Re: [edk2] [PATCH v2 1/5] OvfmPkg/XenHypercallLib: add missing GCC_ASM_EXPORT to XenHypercall2

On 17 December 2015 at 18:05, Jordan Justen wrote: > On 2015-12-17 00:14:04, Ard Biesheuvel wrote: >> (adding Jordan) >> >> On 16 December 2015 at 14:45, Ard Biesheuvel >> wrote: >> > GCC_ASM_EXPORT() not only exports a symbol as a function,

[edk2] [PATCH v2 1/5] OvfmPkg/XenHypercallLib: add missing GCC_ASM_EXPORT to XenHypercall2

GCC_ASM_EXPORT() not only exports a symbol as a function, it also emits a .type , %function directive, which is used by the ARM linker to decide whether to emit interworking branches. So replace the explicit .global with GCC_ASM_EXPORT(), or the code will not be callable from Thumb-2 code.