Re: [edk2] [PATCH v4 0/6] Introduce freed-memory guard feature

2018-10-25 Thread Zeng, Star

On 2018/10/25 15:17, Jian J Wang wrote:

v4 changes:
Updated per comments from Star. Please refer to individual patch
file for details (#2/5/6)


Minor comments to patch 5 and 6, please see the individual feedback.
With them addressed, Reviewed-by: Star Zeng  to 
patch 1, 2, 5 and 6.


And remember to add RB from Laszlo, I think at least you can add RB from 
Laszlo for patch 1, maybe patch 2 about MdeModulePkg change.



Thanks,
Star



Freed-memory guard is a new feauture used to detect UAF (Use-After-Free)
memory issue.

Tests:
a. Feature basic unit/functionality test
b. OVMF regression test

Jian J Wang (6):
   MdeModulePkg: cleanup Heap Guard pool/page type PCD documentation
   MdeModulePkg: introduce UEFI freed-memory guard bit in HeapGuard PCD
   UefiCpuPkg/CpuDxe: consider freed-memory guard in non-stop mode
   UefiCpuPkg/CpuDxe: prevent recursive calling of
 InitializePageTablePool
   MdeModulePkg/Core: prevent re-acquire GCD memory lock
   MdeModulePkg/Core: add freed-memory guard feature

  MdeModulePkg/Core/Dxe/Gcd/Gcd.c   |  87 --
  MdeModulePkg/Core/Dxe/Mem/HeapGuard.c | 409 +-
  MdeModulePkg/Core/Dxe/Mem/HeapGuard.h |  65 +++-
  MdeModulePkg/Core/Dxe/Mem/Page.c  |  42 ++-
  MdeModulePkg/Core/Dxe/Mem/Pool.c  |  23 +-
  MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c |   2 +-
  MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c  |  18 +-
  MdeModulePkg/MdeModulePkg.dec |  20 +-
  MdeModulePkg/MdeModulePkg.uni |  16 +-
  UefiCpuPkg/CpuDxe/CpuDxe.h|   2 +-
  UefiCpuPkg/CpuDxe/CpuPageTable.c  |  23 +-
  11 files changed, 637 insertions(+), 70 deletions(-)



___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


[edk2] [PATCH v4 0/6] Introduce freed-memory guard feature

2018-10-25 Thread Jian J Wang
> v4 changes:
> Updated per comments from Star. Please refer to individual patch
> file for details (#2/5/6)

Freed-memory guard is a new feauture used to detect UAF (Use-After-Free)
memory issue.

Tests:
a. Feature basic unit/functionality test
b. OVMF regression test

Jian J Wang (6):
  MdeModulePkg: cleanup Heap Guard pool/page type PCD documentation
  MdeModulePkg: introduce UEFI freed-memory guard bit in HeapGuard PCD
  UefiCpuPkg/CpuDxe: consider freed-memory guard in non-stop mode
  UefiCpuPkg/CpuDxe: prevent recursive calling of
InitializePageTablePool
  MdeModulePkg/Core: prevent re-acquire GCD memory lock
  MdeModulePkg/Core: add freed-memory guard feature

 MdeModulePkg/Core/Dxe/Gcd/Gcd.c   |  87 --
 MdeModulePkg/Core/Dxe/Mem/HeapGuard.c | 409 +-
 MdeModulePkg/Core/Dxe/Mem/HeapGuard.h |  65 +++-
 MdeModulePkg/Core/Dxe/Mem/Page.c  |  42 ++-
 MdeModulePkg/Core/Dxe/Mem/Pool.c  |  23 +-
 MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c |   2 +-
 MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c  |  18 +-
 MdeModulePkg/MdeModulePkg.dec |  20 +-
 MdeModulePkg/MdeModulePkg.uni |  16 +-
 UefiCpuPkg/CpuDxe/CpuDxe.h|   2 +-
 UefiCpuPkg/CpuDxe/CpuPageTable.c  |  23 +-
 11 files changed, 637 insertions(+), 70 deletions(-)

-- 
2.16.2.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel