Re: [edk2] [Patch] BaseTools: Fix the wrong reference _GetSkuIds() in AutoGen code
Reviewed-by: Jaben Carsey > -Original Message- > From: Zhu, Yonghong > Sent: Monday, September 24, 2018 11:23 PM > To: Gao, Liming ; edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Zhu, Yonghong > > Subject: RE: [Patch] BaseTools: Fix the wrong reference _GetSkuIds() in > AutoGen code > Importance: High > > Reviewed-by: Yonghong Zhu > > Best Regards, > Zhu Yonghong > > > -Original Message- > From: Gao, Liming > Sent: Tuesday, September 25, 2018 9:36 AM > To: edk2-devel@lists.01.org > Cc: Zhu, Yonghong ; Carsey, Jaben > > Subject: [Patch] BaseTools: Fix the wrong reference _GetSkuIds() in > AutoGen code > > DscBuildData has been updated to define SkuIds instead of _GetSkuIds(). > The consumer code should refer to SkuIds. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liming Gao > Cc: Yonghong Zhu > Cc: Jaben Carsey > --- > BaseTools/Source/Python/AutoGen/AutoGen.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py > b/BaseTools/Source/Python/AutoGen/AutoGen.py > index 5271b44..38f1260 100644 > --- a/BaseTools/Source/Python/AutoGen/AutoGen.py > +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py > @@ -1153,7 +1153,7 @@ class PlatformAutoGen(AutoGen): > VpdRegionBase = FdRegion.Offset > break > > -VariableInfo = VariableMgr(self.DscBuildDataObj._GetDefaultStores(), > self.DscBuildDataObj._GetSkuIds()) > +VariableInfo = VariableMgr(self.DscBuildDataObj._GetDefaultStores(), > self.DscBuildDataObj.SkuIds) > VariableInfo.SetVpdRegionMaxSize(VpdRegionSize) > VariableInfo.SetVpdRegionOffset(VpdRegionBase) > Index = 0 > -- > 2.10.0.windows.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch] BaseTools: Fix the wrong reference _GetSkuIds() in AutoGen code
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Tuesday, September 25, 2018 9:36 AM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Carsey, Jaben Subject: [Patch] BaseTools: Fix the wrong reference _GetSkuIds() in AutoGen code DscBuildData has been updated to define SkuIds instead of _GetSkuIds(). The consumer code should refer to SkuIds. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Yonghong Zhu Cc: Jaben Carsey --- BaseTools/Source/Python/AutoGen/AutoGen.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py b/BaseTools/Source/Python/AutoGen/AutoGen.py index 5271b44..38f1260 100644 --- a/BaseTools/Source/Python/AutoGen/AutoGen.py +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py @@ -1153,7 +1153,7 @@ class PlatformAutoGen(AutoGen): VpdRegionBase = FdRegion.Offset break -VariableInfo = VariableMgr(self.DscBuildDataObj._GetDefaultStores(), self.DscBuildDataObj._GetSkuIds()) +VariableInfo = VariableMgr(self.DscBuildDataObj._GetDefaultStores(), self.DscBuildDataObj.SkuIds) VariableInfo.SetVpdRegionMaxSize(VpdRegionSize) VariableInfo.SetVpdRegionOffset(VpdRegionBase) Index = 0 -- 2.10.0.windows.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [Patch] BaseTools: Fix the wrong reference _GetSkuIds() in AutoGen code
DscBuildData has been updated to define SkuIds instead of _GetSkuIds(). The consumer code should refer to SkuIds. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Yonghong Zhu Cc: Jaben Carsey --- BaseTools/Source/Python/AutoGen/AutoGen.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py b/BaseTools/Source/Python/AutoGen/AutoGen.py index 5271b44..38f1260 100644 --- a/BaseTools/Source/Python/AutoGen/AutoGen.py +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py @@ -1153,7 +1153,7 @@ class PlatformAutoGen(AutoGen): VpdRegionBase = FdRegion.Offset break -VariableInfo = VariableMgr(self.DscBuildDataObj._GetDefaultStores(), self.DscBuildDataObj._GetSkuIds()) +VariableInfo = VariableMgr(self.DscBuildDataObj._GetDefaultStores(), self.DscBuildDataObj.SkuIds) VariableInfo.SetVpdRegionMaxSize(VpdRegionSize) VariableInfo.SetVpdRegionOffset(VpdRegionBase) Index = 0 -- 2.10.0.windows.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
