Re: [edk2] [Patch] BaseTools: Optimize string concatenation

2018-12-13 Thread Gao, Liming
o, Liming > Cc: Carsey, Jaben ; edk2-devel@lists.01.org > Subject: Re: [edk2] [Patch] BaseTools: Optimize string concatenation > > Hi Liming, > > Yes, this is fine. > But for future submissions, I would like for this sort of information > to be provided at the time

Re: [edk2] [Patch] BaseTools: Optimize string concatenation

2018-12-13 Thread Leif Lindholm
k2-devel-boun...@lists.01.org] On Behalf Of Leif > >Lindholm > >Sent: Thursday, December 13, 2018 2:37 AM > >To: Feng, Bob C > >Cc: Carsey, Jaben ; edk2-devel@lists.01.org; Gao, > >Liming > >Subject: Re: [edk2] [Patch] BaseTools: Optimize string concate

Re: [edk2] [Patch] BaseTools: Optimize string concatenation

2018-12-12 Thread Leif Lindholm
orms". Regards, Leif > > Thanks, > Bob > > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Monday, December 10, 2018 8:36 PM > To: Feng, Bob C > Cc: edk2-devel@lists.01.org; Carsey, Jaben ; Gao, > Liming > Subject:

Re: [edk2] [Patch] BaseTools: Optimize string concatenation

2018-12-11 Thread Feng, Bob C
, Jaben ; Gao, Liming Subject: Re: [edk2] [Patch] BaseTools: Optimize string concatenation On Mon, Dec 10, 2018 at 12:09:23PM +, Feng, Bob C wrote: > For the "customized deepcopy" and "cache for uni file parser" data, > you can see the AutoGen is not slower

Re: [edk2] [Patch] BaseTools: Optimize string concatenation

2018-12-10 Thread Leif Lindholm
On Mon, Dec 10, 2018 at 12:09:23PM +, Feng, Bob C wrote: > For the "customized deepcopy" and "cache for uni file parser" data, > you can see the AutoGen is not slower. The whole Build Duration is > longer because Make Duration is longer while Make Duration time > depends on the external make,

Re: [edk2] [Patch] BaseTools: Optimize string concatenation

2018-12-10 Thread Feng, Bob C
, 2018 6:48 PM To: Feng, Bob C Cc: edk2-devel@lists.01.org; Carsey, Jaben ; Gao, Liming Subject: Re: [edk2] [Patch] BaseTools: Optimize string concatenation Hi Bob, Thanks. I am a little bit confused by the "customized deepcopy" and "cache for uni file parser" data.

Re: [edk2] [Patch] BaseTools: Optimize string concatenation

2018-12-10 Thread Leif Lindholm
t; Sent: Sunday, November 11, 2018 8:41 AM > To: Leif Lindholm > Cc: Carsey, Jaben ; edk2-devel@lists.01.org; Gao, > Liming > Subject: Re: [edk2] [Patch] BaseTools: Optimize string concatenation > > Hi Leif, > > I use my desktop to do the benchmark. > CPU: Intel(

Re: [edk2] [Patch] BaseTools: Optimize string concatenation

2018-12-04 Thread Feng, Bob C
Lindholm Cc: Carsey, Jaben ; edk2-devel@lists.01.org; Gao, Liming Subject: Re: [edk2] [Patch] BaseTools: Optimize string concatenation Hi Leif, I use my desktop to do the benchmark. CPU: Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz Memory: 16G OS: Win10 I'll add the performance detailed data to BZ

Re: [edk2] [Patch] BaseTools: Optimize string concatenation

2018-11-10 Thread Feng, Bob C
, Bob C Cc: edk2-devel@lists.01.org; Carsey, Jaben ; Gao, Liming Subject: Re: [edk2] [Patch] BaseTools: Optimize string concatenation Hi Bob, On Fri, Nov 09, 2018 at 03:25:04AM +, Feng, Bob C wrote: > Yes. I should show the data. > > My unites scripts is as below. The parame

Re: [edk2] [Patch] BaseTools: Optimize string concatenation

2018-11-09 Thread Kinney, Michael D
improvement in the BZ. Mike > -Original Message- > From: Gao, Liming > Sent: Friday, November 9, 2018 6:17 AM > To: Kinney, Michael D ; > Feng, Bob C ; edk2- > de...@lists.01.org > Cc: Carsey, Jaben > Subject: RE: [edk2] [Patch] BaseTools: Optimize string > concatenatio

Re: [edk2] [Patch] BaseTools: Optimize string concatenation

2018-11-09 Thread Gao, Liming
Cc: Carsey, Jaben ; Gao, Liming > Subject: RE: [edk2] [Patch] BaseTools: Optimize string concatenation > > Bob, > > Is this for edk2/master or for the Python 3 conversion in the > edk2-staging branch? If it is for the edk-staging branch, then > the Subject is not correct. >

Re: [edk2] [Patch] BaseTools: Optimize string concatenation

2018-11-09 Thread Leif Lindholm
> - Done - > Build end time: 10:11:56, Nov.09 2018 > Build total time: 00:00:15 > > > Thanks, > Bob

Re: [edk2] [Patch] BaseTools: Optimize string concatenation

2018-11-08 Thread Feng, Bob C
m: Leif Lindholm [mailto:leif.lindh...@linaro.org] Sent: Friday, November 9, 2018 12:53 AM To: Feng, Bob C Cc: edk2-devel@lists.01.org; Carsey, Jaben ; Gao, Liming Subject: Re: [edk2] [Patch] BaseTools: Optimize string concatenation On Thu, Nov 08, 2018 at 06:16:25PM +0800, BobCF wrot

Re: [edk2] [Patch] BaseTools: Optimize string concatenation

2018-11-08 Thread Leif Lindholm
On Thu, Nov 08, 2018 at 06:16:25PM +0800, BobCF wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=1288 > > This patch is one of build tool performance improvement > series patches. > > This patch is going to use join function instead of > string += string2 statement. > > Current code use

Re: [edk2] [Patch] BaseTools: Optimize string concatenation

2018-11-08 Thread Kinney, Michael D
CF > Sent: Thursday, November 8, 2018 2:16 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Gao, Liming > > Subject: [edk2] [Patch] BaseTools: Optimize string > concatenation > > https://bugzilla.tianocore.org/show_bug.cgi?id=1288 > > This patch is one of buil

Re: [edk2] [Patch] BaseTools: Optimize string concatenation

2018-11-08 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Feng, Bob C > Sent: Thursday, November 08, 2018 2:16 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Carsey, Jaben > > Subject: [Patch] BaseTools: Optimize string concatenation > Importance: High > >

[edk2] [Patch] BaseTools: Optimize string concatenation

2018-11-08 Thread BobCF
https://bugzilla.tianocore.org/show_bug.cgi?id=1288 This patch is one of build tool performance improvement series patches. This patch is going to use join function instead of string += string2 statement. Current code use string += string2 in a loop to combine a string. while creating a string