Re: [edk2] [Patch] NetworkPkg: Check pointer for NULL before use.

2016-04-01 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu Siyuan Sent: Friday, April 1, 2016 12:16 AM To: edk2-devel@lists.01.org Cc: Ye Ting ; Wu Jiaxin Subject: [edk2] [Patch] NetworkPkg: Check pointer for NULL

Re: [edk2] [Patch] NetworkPkg: Check pointer for NULL before use.

2016-04-01 Thread Wu, Jiaxin
Ok, it's good to me. Reviewed-by: Jiaxin Wu mailto:jiaxin...@intel.com>> From: Fu, Siyuan Sent: Friday, April 1, 2016 1:22 PM To: Wu, Jiaxin ; edk2-devel@lists.01.org Cc: Ye, Ting Subject: RE: [Patch] NetworkPkg: Check pointer for NULL before use. Hi, Jiaxin We assume the Uri should never

Re: [edk2] [Patch] NetworkPkg: Check pointer for NULL before use.

2016-04-01 Thread Ye, Ting
Looks good to me. Reviewed-by: Ye Ting mailto:ting...@intel.com>> From: Fu, Siyuan Sent: Friday, April 01, 2016 1:22 PM To: Wu, Jiaxin ; edk2-devel@lists.01.org Cc: Ye, Ting Subject: RE: [Patch] NetworkPkg: Check pointer for NULL before use. Hi, Jiaxin We assume the Uri should never be NULL p

Re: [edk2] [Patch] NetworkPkg: Check pointer for NULL before use.

2016-03-31 Thread Fu, Siyuan
Hi, Jiaxin We assume the Uri should never be NULL pointer returned from the HII interface, so the ASSERT is to help to catch the exception case in DEBUG build, for example, possible HII interface change. In release build the ASSERT will be removed so the if condition will return an error. Siyu

Re: [edk2] [Patch] NetworkPkg: Check pointer for NULL before use.

2016-03-31 Thread Wu, Jiaxin
ASSERT should be removed since it will checked later. > -Original Message- > From: Fu, Siyuan > Sent: Friday, April 1, 2016 1:16 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Wu, Jiaxin > Subject: [Patch] NetworkPkg: Check pointer for NULL before use. > > Cc: Ye Ting > Cc: Wu Jiaxin

[edk2] [Patch] NetworkPkg: Check pointer for NULL before use.

2016-03-31 Thread Fu Siyuan
Cc: Ye Ting Cc: Wu Jiaxin Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan --- NetworkPkg/HttpBootDxe/HttpBootConfig.c | 4 1 file changed, 4 insertions(+) diff --git a/NetworkPkg/HttpBootDxe/HttpBootConfig.c b/NetworkPkg/HttpBootDxe/HttpBootConfig.c index