Two minor comments: 1. please use a new macro to describe the ComId used for BlockSID. 2. It looks the patch 7/7's comment is not very matched with the code. The code always does BlockSid operation no matter if it's in unlock process.
Others look good to me. Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -----Original Message----- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric Dong Sent: Wednesday, May 4, 2016 1:33 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch 0/7] Enhance BlockSid releated logic. Enhance the BlockSid related logic. Eric Dong (7): SecurityPkg TcgStorageOpalLib: Update ComId for Block SID command. MdePkg: Add TCG_BLOCK_SID_FEATURE_DESCRIPTOR definition. SecurityPkg TcgStorageOpalLib: Check BlockSid capability. SecurityPkg OpalPasswordDxe: Change BlockSid position. SecurityPkg OpalPasswordDxe: Check BlockSid capability before send command. SecurityPkg OpalPasswordSmm: Enhance BlockSid Logic. SecurityPkg OpalPasswordSmm: Move BlockSid out of unlock process. MdePkg/Include/IndustryStandard/TcgStorageCore.h | 12 ++++++++++ MdePkg/Include/IndustryStandard/TcgStorageOpal.h | 1 + SecurityPkg/Include/Library/TcgStorageOpalLib.h | 6 +++++ .../Library/TcgStorageOpalLib/TcgStorageOpalCore.c | 8 ++++++- SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalDriver.c | 25 +++++++++----------- SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c | 9 ++++---- .../Tcg/Opal/OpalPasswordDxe/OpalHiiFormValues.h | 1 - .../Tcg/Opal/OpalPasswordDxe/OpalPasswordForm.vfr | 22 +++++++++--------- .../Tcg/Opal/OpalPasswordSmm/OpalPasswordSmm.c | 27 +++++++++++++--------- 9 files changed, 69 insertions(+), 42 deletions(-) -- 2.6.4.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
