Re: [edk2] [Patch 3/3] BaseTools: Update PatchCheck to report error for EFI_D_*

Thanks Jordan, I sent a V2. I update a little on the re.compile to cover the case that EFI_D_* in the middle of the DEBUG string, and may have multiple space between DEBUG and ( character. Best Regards, Zhu Yonghong -Original Message- From: Justen, Jordan L Sent: Tuesday, October 18,

Re: [edk2] [Patch 3/3] BaseTools: Update PatchCheck to report error for EFI_D_*

On 2016-10-17 19:02:57, Zhu, Yonghong wrote: > Hi Jordan, > > We request to report error since the DEBUG_* is our recommend coding > style and EFI_D_ is obsolete. Looking for DEBUG and EFI_D_ since > only look for EFI_D_ may cause some False error be reported. And I > agree that user might put

Re: [edk2] [Patch 3/3] BaseTools: Update PatchCheck to report error for EFI_D_*

On 2016-10-17 01:28:38, Yonghong Zhu wrote: > In EDK2, DEBUG_* is recommended to be used instead of EFI_D_*. For new > code, they should use DEBUG_* macro. > > Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=145 > Remove blank line. I think you meant 143, not 145. Instead of looking for

[edk2] [Patch 3/3] BaseTools: Update PatchCheck to report error for EFI_D_*

In EDK2, DEBUG_* is recommended to be used instead of EFI_D_*. For new code, they should use DEBUG_* macro. Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=145 Cc: Liming Gao Cc: Jordan Justen Contributed-under: TianoCore Contribution