Re: [edk2] [Patch 3/6] MdeModulePkg/UefiPxeBcDxe: Add the clarification compared to UefiPxeBcDxe in NetworkPkg.
On 09/25/18 05:44, Jiaxin Wu wrote: > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1205 > > This patch is to add the driver usage/difference clarification > compared to UefiPxeBcDxe in NetworkPkg. > > Cc: Ye Ting > Cc: Fu Siyuan > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Wu Jiaxin > --- > .../Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf > b/MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf > index b5b9e80710..0fef0058bd 100644 > --- a/MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf > +++ b/MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf > @@ -2,11 +2,20 @@ > # This module produces EFI Preboot Execution Environment (PXE) Base Code > Protocol. > # > # This module produces EFI PXE Base Code Protocol upon EFI MMP Protocl and > IPv4 > # network stack, used to control PXE-compatible devices. It produces EFI > Load File > # Protocol to provide one clean way to otain control from the boot manager > if the > -# boot patch is from the remote device. > +# boot patch is from the remote device. This driver only supports IPv4 > network stack. > +# > +# Notes: > +# 1) This driver can't co-work with the UefiPxeBcDxe driver in NetworkPkg. > +# 2) This driver might have some issues that have been fixed in the > UefiPxeBcDxe > +# driver in NetworkPkg. > +# 3) This driver supports less feature than the UefiPxeBcDxe driver in > NetworkPkg > +# (e.g. IPv6, MTFTP windowsize). > +# 4) UefiPxeBcDxe driver in NetworkPkg is recommanded to use instead of > this one even > +# both of them can be used. > # > # Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved. > # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the BSD > License > # which accompanies this distribution. The full text of the license may be > found at > Same comments as for patch #1. With those addressed: Reviewed-by: Laszlo Ersek Thanks, Laszlo ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [Patch 3/6] MdeModulePkg/UefiPxeBcDxe: Add the clarification compared to UefiPxeBcDxe in NetworkPkg.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1205 This patch is to add the driver usage/difference clarification compared to UefiPxeBcDxe in NetworkPkg. Cc: Ye Ting Cc: Fu Siyuan Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Wu Jiaxin --- .../Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf b/MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf index b5b9e80710..0fef0058bd 100644 --- a/MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf +++ b/MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf @@ -2,11 +2,20 @@ # This module produces EFI Preboot Execution Environment (PXE) Base Code Protocol. # # This module produces EFI PXE Base Code Protocol upon EFI MMP Protocl and IPv4 # network stack, used to control PXE-compatible devices. It produces EFI Load File # Protocol to provide one clean way to otain control from the boot manager if the -# boot patch is from the remote device. +# boot patch is from the remote device. This driver only supports IPv4 network stack. +# +# Notes: +# 1) This driver can't co-work with the UefiPxeBcDxe driver in NetworkPkg. +# 2) This driver might have some issues that have been fixed in the UefiPxeBcDxe +# driver in NetworkPkg. +# 3) This driver supports less feature than the UefiPxeBcDxe driver in NetworkPkg +# (e.g. IPv6, MTFTP windowsize). +# 4) UefiPxeBcDxe driver in NetworkPkg is recommanded to use instead of this one even +# both of them can be used. # # Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved. # This program and the accompanying materials # are licensed and made available under the terms and conditions of the BSD License # which accompanies this distribution. The full text of the license may be found at -- 2.17.1.windows.2 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
