Re: [edk2] [RESEND PATCH v2 2/6] efi_loader: Initial HII database protocols

2019-01-08 Thread Laszlo Ersek
On 01/08/19 16:12, Gao, Liming wrote: > Last, EFI_HII_KEYBOARD_PACKAGE_HDR structure definition doesn't follow UEFI > spec. I remember we ever meet with the compiler issue for below style. GCC49 > may complaint it. I need to double confirm. > typedef struct { > EFI_HII_PACKAGE_HEADER

Re: [edk2] [RESEND PATCH v2 2/6] efi_loader: Initial HII database protocols

2019-01-08 Thread Leif Lindholm
Thanks Liming, this exactly the reply I was hoping for. On Tue, Jan 08, 2019 at 03:12:11PM +, Gao, Liming wrote: > EFI_GUID structure definition follows RFC UUID > https://www.ietf.org/rfc/rfc4122.txt. This RFC has no 64 bit > boundary requirement. I don't know the background why UEFI spec >

Re: [edk2] [RESEND PATCH v2 2/6] efi_loader: Initial HII database protocols

2019-01-08 Thread Gao, Liming
EFI_GUID structure definition follows RFC UUID https://www.ietf.org/rfc/rfc4122.txt. This RFC has no 64 bit boundary requirement. I don't know the background why UEFI spec requires to align on 64-bit boundary. This may be true for early IPF arch. UEFI forum can clarify its purpose. If no

Re: [edk2] [RESEND PATCH v2 2/6] efi_loader: Initial HII database protocols

2019-01-08 Thread Bi, Dandan
edk2-devel@lists.01.org; Alexander > Graf ; Gao, Liming ; u- > b...@lists.denx.de; robdcl...@gmail.com; Kinney, Michael D > ; Zeng, Star > Subject: Re: [edk2] [RESEND PATCH v2 2/6] efi_loader: Initial HII database > protocols > > MdePkg/MdeModulePkg maintainers - any comments?

Re: [edk2] [RESEND PATCH v2 2/6] efi_loader: Initial HII database protocols

2019-01-08 Thread Laszlo Ersek
On 01/08/19 10:51, Leif Lindholm wrote: > MdePkg/MdeModulePkg maintainers - any comments? > > On Tue, Jan 08, 2019 at 01:28:00AM +0100, Laszlo Ersek wrote: >> On 01/07/19 20:22, Leif Lindholm wrote: >>> On Mon, Jan 07, 2019 at 07:29:47PM +0100, Laszlo Ersek wrote: >> The UEFI spec (v2.7)

Re: [edk2] [RESEND PATCH v2 2/6] efi_loader: Initial HII database protocols

2019-01-08 Thread Ard Biesheuvel
On Tue, 8 Jan 2019 at 10:51, Leif Lindholm wrote: > > MdePkg/MdeModulePkg maintainers - any comments? > > On Tue, Jan 08, 2019 at 01:28:00AM +0100, Laszlo Ersek wrote: > > On 01/07/19 20:22, Leif Lindholm wrote: > > > On Mon, Jan 07, 2019 at 07:29:47PM +0100, Laszlo Ersek wrote: > > > > >> The

Re: [edk2] [RESEND PATCH v2 2/6] efi_loader: Initial HII database protocols

2019-01-08 Thread Leif Lindholm
MdePkg/MdeModulePkg maintainers - any comments? On Tue, Jan 08, 2019 at 01:28:00AM +0100, Laszlo Ersek wrote: > On 01/07/19 20:22, Leif Lindholm wrote: > > On Mon, Jan 07, 2019 at 07:29:47PM +0100, Laszlo Ersek wrote: > > >> The UEFI spec (v2.7) explicitly requires EFI_GUID to be 64-bit aligned,

Re: [edk2] [RESEND PATCH v2 2/6] efi_loader: Initial HII database protocols

2019-01-07 Thread Laszlo Ersek
On 01/07/19 20:22, Leif Lindholm wrote: > On Mon, Jan 07, 2019 at 07:29:47PM +0100, Laszlo Ersek wrote: >> The UEFI spec (v2.7) explicitly requires EFI_GUID to be 64-bit aligned, >> unless specified otherwise. See in "Table 5. Common UEFI Data Types": >> >> EFI_GUID -- 128-bit buffer containing

Re: [edk2] [RESEND PATCH v2 2/6] efi_loader: Initial HII database protocols

2019-01-07 Thread Leif Lindholm
On Mon, Jan 07, 2019 at 07:29:47PM +0100, Laszlo Ersek wrote: > On 01/07/19 15:09, Leif Lindholm wrote: > > Apologies for late reply, back from holidays today. > > I'm going to snip a whole lot of context below, since I have no idea > what project this is about, and/or what files in that project

Re: [edk2] [RESEND PATCH v2 2/6] efi_loader: Initial HII database protocols

2019-01-07 Thread Laszlo Ersek
On 01/07/19 15:09, Leif Lindholm wrote: > Apologies for late reply, back from holidays today. > I'm going to snip a whole lot of context below, since I have no idea what project this is about, and/or what files in that project (no diff hunk headers in the context). Judged from the address list,

Re: [edk2] [RESEND PATCH v2 2/6] efi_loader: Initial HII database protocols

2019-01-07 Thread Leif Lindholm
Apologies for late reply, back from holidays today. On Tue, Dec 25, 2018 at 05:30:25PM +0900, AKASHI Takahiro wrote: > > >>> +struct efi_key_descriptor { > > >>> + efi_key key; > > >> > > >> Hello Takahiro, > > >> > > >> with the patch I can start the EFI shell. But I am still trying to