Re: [edk2] [patch] MdeModulePkg: Refine codes of iSCSI driver

2016-08-11 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Zhang, Lubo > Sent: Thursday, August 11, 2016 3:19 PM > To: Dong, Eric > Cc: Ye, Ting; Fu, Siyuan; edk2-devel@lists.01.org > Subject: RE: [edk2] [patch] MdeModulePkg: Refine codes of iSCSI driver > > Hi Er

Re: [edk2] [patch] MdeModulePkg: Refine codes of iSCSI driver

2016-08-11 Thread Zhang, Lubo
Subject: [edk2] [patch] MdeModulePkg: Refine codes of iSCSI driver The RSDT is only used when the bios need to support ACPI 1.0 version. When change PcdAcpiExposedTableVersions to 0x3C, it will not support ACPI 1.0. The default is 0x3E. Contributed-under: TianoCore Contribution Agreement 1.0 Signed

[edk2] [patch] MdeModulePkg: Refine codes of iSCSI driver

2016-08-10 Thread Zhang Lubo
The RSDT is only used when the bios need to support ACPI 1.0 version. When change PcdAcpiExposedTableVersions to 0x3C, it will not support ACPI 1.0. The default is 0x3E. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo Cc: Eric Dong Cc: Ye Ting Cc: Fu Siyuan --

Re: [edk2] [patch] MdeModulePkg: refine codes of iSCSI driver.

2016-04-22 Thread Wu, Jiaxin
016 5:05 PM > >> To: Ye, Ting ; edk2-devel@lists.01.org > >> Cc: Fu, Siyuan ; Wu, Jiaxin > >> > >> Subject: RE: [edk2] [patch] MdeModulePkg: refine codes of iSCSI driver. > >> > >> Thank you for your series comments, will update them while chec

Re: [edk2] [patch] MdeModulePkg: refine codes of iSCSI driver.

2016-04-22 Thread Ard Biesheuvel
016 5:02 PM >> To: Zhang, Lubo ; edk2-devel@lists.01.org >> Cc: Fu, Siyuan ; Wu, Jiaxin >> Subject: RE: [edk2] [patch] MdeModulePkg: refine codes of iSCSI driver. >> >> Same comment for this patch for MdeModulePkg: >> >> Suggest to

Re: [edk2] [patch] MdeModulePkg: refine codes of iSCSI driver.

2016-04-22 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu > -Original Message- > From: Zhang, Lubo > Sent: Tuesday, April 19, 2016 5:05 PM > To: Ye, Ting ; edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Wu, Jiaxin > Subject: RE: [edk2] [patch] MdeModulePkg: refine codes of iSCSI driver. > > T

Re: [edk2] [patch] MdeModulePkg: refine codes of iSCSI driver.

2016-04-19 Thread Zhang, Lubo
@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin Subject: [edk2] [patch] MdeModulePkg: refine codes of iSCSI driver. Add error handling logic in DriverBingingStop function, it may return error status when invoking the UninstallProtocolInterface. Cc: Fu Siyuan Cc: Ye Ting Cc: Wu Jiaxin

Re: [edk2] [patch] MdeModulePkg: refine codes of iSCSI driver.

2016-04-19 Thread Ye, Ting
: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin Subject: [edk2] [patch] MdeModulePkg: refine codes of iSCSI driver. Add error handling logic in DriverBingingStop function, it may return error status when invoking the UninstallProtocolInterface. Cc: Fu Siyuan Cc: Ye Ting Cc: Wu Jiaxin Contributed-under

Re: [edk2] [patch] MdeModulePkg: refine codes of iSCSI driver.

2016-04-18 Thread Fu, Siyuan
k2] [patch] MdeModulePkg: refine codes of iSCSI driver. > > Add error handling logic in DriverBingingStop function, > it may return error status when invoking the > UninstallProtocolInterface. > > Cc: Fu Siyuan > Cc: Ye Ting > Cc: Wu Jiaxin > Contributed-under: TianoCor

[edk2] [patch] MdeModulePkg: refine codes of iSCSI driver.

2016-04-18 Thread Zhang Lubo
Add error handling logic in DriverBingingStop function, it may return error status when invoking the UninstallProtocolInterface. Cc: Fu Siyuan Cc: Ye Ting Cc: Wu Jiaxin Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo --- .../Universal/Network/IScsiDxe/IScsiDr