Re: [edk2] [patch] MdeModulePkg:Fix a bug that HttpLib can not parse Ipv6 address correctly.

2015-11-08 Thread Wu, Jiaxin
The patch looks good to me. Reviewed-by: Wu Jiaxin -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang Lubo Sent: Friday, November 6, 2015 4:12 PM To: edk2-devel@lists.01.org Cc: Ye, Ting; Fu, Siyuan; Wu, Jiaxin; Gary

[edk2] [patch] MdeModulePkg:Fix a bug that HttpLib can not parse Ipv6 address correctly.

2015-11-06 Thread Zhang Lubo
v2: *Add a Url Parse state machine to indicate the host is ipv6 expressed url and can parse the ipv6 address correctly. Cc: Fu Siyuan Cc: Ye Ting CC: Wu Jiaxin CC: Gary Ching-Pang Lin Contributed-under: TianoCore

Re: [edk2] [patch] MdeModulePkg:Fix a bug that HttpLib can not parse Ipv6 address correctly.

2015-11-06 Thread Gary Ching-Pang Lin
On Fri, Nov 06, 2015 at 04:11:45PM +0800, Zhang Lubo wrote: > v2: > *Add a Url Parse state machine to indicate the host is ipv6 expressed url and > can parse > the ipv6 address correctly. > This patch works for me. The IPv6 address was extracted from my url. Tested-by: Gary Ching-Pang Lin

Re: [edk2] [patch] MdeModulePkg:Fix a bug that HttpLib can not parse Ipv6 address correctly.

2015-11-05 Thread Zhang, Lubo
Yes , you are right, I will make some changes. Thanks -Original Message- From: Fu, Siyuan Sent: Friday, November 06, 2015 10:02 AM To: Zhang, Lubo; edk2-devel@lists.01.org Cc: Ye, Ting; Wu, Jiaxin; Gary Ching-Pang Lin Subject: RE: [patch] MdeModulePkg:Fix a bug that HttpLib can not

[edk2] [patch] MdeModulePkg:Fix a bug that HttpLib can not parse Ipv6 address correctly.

2015-11-05 Thread Zhang Lubo
When parsing the authority component of the input URL, it can not distinguish the ":" is the flag that indicates the port or the separator between the ipv6 address. Cc: Fu Siyuan Cc: Ye Ting CC: Wu Jiaxin CC: Gary Ching-Pang Lin

Re: [edk2] [patch] MdeModulePkg:Fix a bug that HttpLib can not parse Ipv6 address correctly.

2015-11-05 Thread Fu, Siyuan
Hi, Lubo The patch pass "IsBracket" by value so it will always be FALSE, please check it. Siyuan -Original Message- From: Zhang, Lubo Sent: Friday, November 6, 2015 9:31 AM To: edk2-devel@lists.01.org Cc: Fu, Siyuan ; Ye, Ting ; Wu, Jiaxin