: [edk2] [patch] NetworkPkg: Refine codes of Http boot driver.
Hi, Samer
I think in PXE this issue was solved by the
EFI_PXE_BASE_CODE_CALLBACK_PROTOCOL, which allows the platform owner to provide
an callback implementation which will take precedence over the default
implementation in PXE driver
Fu, Siyuan
Sent: Friday, May 20, 2016 10:04 AM
To: El-Haj-Mahmoud, Samer ; Zhang, Lubo
; edk2-devel@lists.01.org
Cc: Ye, Ting ; Wu, Jiaxin
Subject: RE: [edk2] [patch] NetworkPkg: Refine codes of Http boot driver.
Hi, Samer
I think in PXE this issue was solved by the
EFI_PXE_BASE_CODE_CALLBAC
; edk2-devel@lists.01.org
> Cc: Ye, Ting ; Fu, Siyuan ; Wu,
> Jiaxin
> Subject: RE: [edk2] [patch] NetworkPkg: Refine codes of Http boot driver.
>
> Thanks Zhang.
>
> I know this makes sense (and does help during lengthy download), and I also
> know that PXE does somethin
Thanks Siyuan, I will improve the codes.
lubo
From: Fu, Siyuan
Sent: Friday, May 20, 2016 9:19 AM
To: Zhang, Lubo ; edk2-devel@lists.01.org
Cc: Ye, Ting ; Wu, Jiaxin
Subject: RE: [patch] NetworkPkg: Refine codes of Http boot driver.
And I think the "percentage" is what you actually means by the
And I think the "percentage" is what you actually means by the name "Ratio".
From: Fu, Siyuan
Sent: Friday, May 20, 2016 9:17 AM
To: Zhang, Lubo ; edk2-devel@lists.01.org
Cc: Ye, Ting ; Wu, Jiaxin
Subject: RE: [patch] NetworkPkg: Refine codes of Http boot driver.
Hi, Lubo
1. The (ReceivedSize *
Hi, Lubo
1. The (ReceivedSize * 100) may lead to a integer overflow, especially in a
32bit system.
2. You could use %[wide]d to control the width of the print, to avoid the if
condition "Ratio>10"
Best Regards
Siyuan
> -Original Message-
> From: Zhang, Lubo
> Sent: Thursday, May 19, 20
below.
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang
Lubo
Sent: Wednesday, May 18, 2016 10:53 PM
To: edk2-devel@lists.01.org
Cc: Ye Ting ; Fu Siyuan ; Wu Jiaxin
Subject: [edk2] [patch] NetworkPkg: Refine codes of Http boot driver.
When
Reviewed-by: Ye Ting
-Original Message-
From: Zhang, Lubo
Sent: Thursday, May 19, 2016 11:53 AM
To: edk2-devel@lists.01.org
Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin
Subject: [patch] NetworkPkg: Refine codes of Http boot driver.
When downloading a big image as ram disk iso,we can print
When downloading a big image as ram disk iso,we can
print the progress message on screen to enhance the
user experience.
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Wu Jiaxin
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
---
NetworkPkg/HttpBootDxe/HttpBootClient.c | 29
When http error status returned or Succeed to download
a RamDisk image but without RamDisk driver, we need to
display the error message to screen for a appropriate time
to let users know what happens.
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Wu Jiaxin
Contributed-under: TianoCore Contribution Agreement 1.
10 matches
Mail list logo
