Re: [edk2] Community Discussion: General Code and Commit message standards

2018-10-19 Thread Jeremiah Cox
loses #123" -Original Message- From: edk2-devel On Behalf Of Kinney, Michael D Sent: Thursday, October 18, 2018 4:01 PM To: stephano ; Andrew Fish ; Kinney, Michael D Cc: Carsey, Jaben ; edk2-devel@lists.01.org Subject: Re: [edk2] Community Discussion: General Code and Commit message

Re: [edk2] Community Discussion: General Code and Commit message standards

2018-10-18 Thread Kinney, Michael D
> To: Andrew Fish > Cc: Carsey, Jaben ; edk2- > de...@lists.01.org > Subject: Re: [edk2] Community Discussion: General Code > and Commit message standards > > On 10/18/2018 6:11 PM, Andrew Fish wrote:> What I've done > in the past on > a branch based github PR flow is h

Re: [edk2] Community Discussion: General Code and Commit message standards

2018-10-18 Thread stephano
On 10/18/2018 6:11 PM, Andrew Fish wrote:> What I've done in the past on a branch based github PR flow is have a naming convention for the branch. For example eng/PR--. Then we have a git hook that looks at the branch name and if it sees a Bugzilla number it inserts the Bugzilla reference in

Re: [edk2] Community Discussion: General Code and Commit message standards

2018-10-18 Thread Andrew Fish
> On Oct 18, 2018, at 9:43 AM, stephano wrote: > > On 10/18/2018 4:49 PM, Andrew Fish wrote: >>> On Oct 18, 2018, at 7:22 AM, Carsey, Jaben wrote: >>> >>> I would like to know when a patch fixes a BZ. Subject/body I have less >>> strong opinion about. >>> >> +1 >> Thanks, >> Andrew Fish >

Re: [edk2] Community Discussion: General Code and Commit message standards

2018-10-18 Thread stephano
On 10/18/2018 4:49 PM, Andrew Fish wrote: On Oct 18, 2018, at 7:22 AM, Carsey, Jaben wrote: I would like to know when a patch fixes a BZ. Subject/body I have less strong opinion about. +1 Thanks, Andrew Fish This is always a point of contention with mailing list style patch-workflows

Re: [edk2] Community Discussion: General Code and Commit message standards

2018-10-18 Thread Andrew Fish
...@lists.01.org] On Behalf Of >> stephano >> Sent: Thursday, October 18, 2018 2:13 AM >> To: edk2-devel@lists.01.org >> Subject: [edk2] Community Discussion: General Code and Commit message >> standards >> >> This discussion was tabled as it will probably be its

Re: [edk2] Community Discussion: General Code and Commit message standards

2018-10-18 Thread Carsey, Jaben
gt; Subject: [edk2] Community Discussion: General Code and Commit message > standards > > This discussion was tabled as it will probably be its own meeting rather > than part of our general discussions this month. > > Recently on the list Laszlo and Star agreed that we shoul

[edk2] Community Discussion: General Code and Commit message standards

2018-10-18 Thread stephano
This discussion was tabled as it will probably be its own meeting rather than part of our general discussions this month. Recently on the list Laszlo and Star agreed that we should be adding the CVE to the subject of any patch that fixes a CVE. I will be documenting this in the wiki as well