Sure.
Thanks,
-Chema
---------- Forwarded message ----------
From: Gao, Liming <liming....@intel.com>
Date: Wed, Dec 27, 2017 at 5:48 PM
Subject: FW: [tianocore/edk2] BaseTools: Barf on unknown HOST_ARCH in
C Makefile (#122)
To: "che...@gmail.com" <che...@gmail.com>
Could you send patch to edk2-devel@lists.01.org?
From: chemag [mailto:notificati...@github.com]
Sent: Thursday, December 28, 2017 9:26 AM
To: tianocore/edk2 <e...@noreply.github.com>
Cc: Subscribed <subscri...@noreply.github.com>
Subject: [tianocore/edk2] BaseTools: Barf on unknown HOST_ARCH in C
Makefile (#122)
I was getting HOST_ARCH set using the linux arch name ("x86_64"), which
is different from the MS one ("X64").
It is not clear anyway we can proceed without valid build variables
(ARCH_INCLUDE, BIN_PATH, LIB_PATH, SYS_BIN_PATH, and
SYS_LIB_PATH).
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Chema Gonzalez che...@gmail.com
________________________________
You can view, comment on, or merge this pull request online at:
https://github.com/tianocore/edk2/pull/122
Commit Summary
BaseTools: Barf on unknown HOST_ARCH in C Makefile
File Changes
M BaseTools/Source/C/Makefiles/ms.common (6)
Patch Links:
https://github.com/tianocore/edk2/pull/122.patch
https://github.com/tianocore/edk2/pull/122.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
From b0657ee033daad00c996c561857d4b3aad1f47cf Mon Sep 17 00:00:00 2001
From: Chema Gonzalez <che...@fb.com>
Date: Wed, 27 Dec 2017 16:23:56 -0800
Subject: [PATCH] BaseTools: Barf on unknown HOST_ARCH in C Makefile
I was getting `HOST_ARCH` set using the linux arch name ("x86_64"), which
is different from the MS one ("X64").
It is not clear anyway we can proceed without valid build variables
(`ARCH_INCLUDE`, `BIN_PATH`, `LIB_PATH`, `SYS_BIN_PATH`, and
`SYS_LIB_PATH`).
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Chema Gonzalez <che...@gmail.com>
---
BaseTools/Source/C/Makefiles/ms.common | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/BaseTools/Source/C/Makefiles/ms.common b/BaseTools/Source/C/Makefiles/ms.common
index a6bfea5..06399df 100644
--- a/BaseTools/Source/C/Makefiles/ms.common
+++ b/BaseTools/Source/C/Makefiles/ms.common
@@ -42,14 +42,16 @@ BIN_PATH = $(BASE_TOOLS_PATH)\Bin\Win32
LIB_PATH = $(BASE_TOOLS_PATH)\Lib\Win32
SYS_BIN_PATH = $(EDK_TOOLS_PATH)\Bin\Win32
SYS_LIB_PATH = $(EDK_TOOLS_PATH)\Lib\Win32
-!ENDIF
-!IF "$(HOST_ARCH)"=="X64"
+!ELSEIF "$(HOST_ARCH)"=="X64"
ARCH_INCLUDE = $(SOURCE_PATH)\Include\X64
BIN_PATH = $(BASE_TOOLS_PATH)\Bin\Win64
LIB_PATH = $(BASE_TOOLS_PATH)\Lib\Win64
SYS_BIN_PATH = $(EDK_TOOLS_PATH)\Bin\Win64
SYS_LIB_PATH = $(EDK_TOOLS_PATH)\Lib\Win64
+
+!ELSE
+!ERROR "Unknown HOST_ARCH variable"
!ENDIF
CC = cl.exe
--
2.7.4
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
