Re: [edk2] Instance of library class [ArmMmuLib] is not found

2016-07-22 Thread Ard Biesheuvel
On 21 July 2016 at 15:20, Haojian Zhuang  wrote:
[...]
>
>
> I think that we also need to append ArmMmuLib in
> ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf. Since ArmConfigureMmu() is
> used in MemoryInitPeim.
>

It is only used by MemoryInitPeiLib, which is used by MemoryInitPeim,
and I already added it to MemoryInitPeiLib.inf.

If you are having build problems due to this, it may be caused by the
fact that you are including MemoryInitPeiLib.c directly in
MemoryInitPeim.inf. This was fixed upstream in patch

d94a48c71a67 ArmPlatformPkg: do not fulfil MemoryInitPeiLib dependency
directly via .c file

Thanks,
Ard.
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


Re: [edk2] Instance of library class [ArmMmuLib] is not found

2016-07-21 Thread Haojian Zhuang

On 2016/7/21 19:27, Ard Biesheuvel wrote:

On 20 July 2016 at 07:44, Michael Zimmermann  wrote:

Hi,

since commit '5db1cce ArmPkg ArmVirtPkg MdeModulePkg: switch to separate
ArmMmuLib' you need to add ArmMmuLib to your platform's dsc file:

ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf


Indeed. But in this particular case, the reporter is building
ArmPkg.dsc from the upstream, and so one would expect the series that
introduces ArmMmuLib to keep ArmPkg.dsc in sync as well.

My bad.

This should do the trick

diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc
index df5be6e..f4ca3e1 100644
--- a/ArmPkg/ArmPkg.dsc
+++ b/ArmPkg/ArmPkg.dsc
@@ -38,6 +38,7 @@
RELEASE_*_*_CC_FLAGS  = -DMDEPKG_NDEBUG

  [LibraryClasses.common]
+  ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf

CacheMaintenanceLib|ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib.inf
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


I think that we also need to append ArmMmuLib in 
ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf. Since ArmConfigureMmu() 
is used in MemoryInitPeim.



Best Regards

Haojian

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


Re: [edk2] Instance of library class [ArmMmuLib] is not found

2016-07-21 Thread Haojian Zhuang

On 2016/7/21 19:27, Ard Biesheuvel wrote:

On 20 July 2016 at 07:44, Michael Zimmermann  wrote:

Hi,

since commit '5db1cce ArmPkg ArmVirtPkg MdeModulePkg: switch to separate
ArmMmuLib' you need to add ArmMmuLib to your platform's dsc file:

ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf


Indeed. But in this particular case, the reporter is building
ArmPkg.dsc from the upstream, and so one would expect the series that
introduces ArmMmuLib to keep ArmPkg.dsc in sync as well.

My bad.

This should do the trick

diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc
index df5be6e..f4ca3e1 100644
--- a/ArmPkg/ArmPkg.dsc
+++ b/ArmPkg/ArmPkg.dsc
@@ -38,6 +38,7 @@
RELEASE_*_*_CC_FLAGS  = -DMDEPKG_NDEBUG

  [LibraryClasses.common]
+  ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf

CacheMaintenanceLib|ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib.inf
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


I think that we also need to append ArmMmuLib in 
ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf. Since ArmConfigureMmu() 
is used in MemoryInitPeim.



Best Regards

Haojian

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


Re: [edk2] Instance of library class [ArmMmuLib] is not found

2016-07-21 Thread Ard Biesheuvel
On 20 July 2016 at 07:44, Michael Zimmermann  wrote:
> Hi,
>
> since commit '5db1cce ArmPkg ArmVirtPkg MdeModulePkg: switch to separate
> ArmMmuLib' you need to add ArmMmuLib to your platform's dsc file:
>
> ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
>

Indeed. But in this particular case, the reporter is building
ArmPkg.dsc from the upstream, and so one would expect the series that
introduces ArmMmuLib to keep ArmPkg.dsc in sync as well.

My bad.

This should do the trick

diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc
index df5be6e..f4ca3e1 100644
--- a/ArmPkg/ArmPkg.dsc
+++ b/ArmPkg/ArmPkg.dsc
@@ -38,6 +38,7 @@
   RELEASE_*_*_CC_FLAGS  = -DMDEPKG_NDEBUG

 [LibraryClasses.common]
+  ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
   BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
   BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
   
CacheMaintenanceLib|ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib.inf
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


[edk2] Instance of library class [ArmMmuLib] is not found

2016-07-19 Thread jl
Hey there, 
what is wrong with this build --verbose:

Build environment: Linux-4.1.12-gentoo-x86_64-
AMD_A10-7700K_Radeon_R7,_10_Compute_Cores_4C+6G-with-gentoo-2.2
Build start time: 20:36:36, Jul.19 2016

WORKSPACE= /home/xxx/devel/firmware/edk2
ECP_SOURCE   = /home/xxx/devel/firmware/edk2/EdkCompatibilityPkg
EDK_SOURCE   = /home/xxx/devel/firmware/edk2/EdkCompatibilityPkg
EFI_SOURCE   = /home/xxx/devel/firmware/edk2/EdkCompatibilityPkg
EDK_TOOLS_PATH   = /home/xxx/devel/firmware/edk2/BaseTools/

Initialize build database started ...

Initialize table DataModel started ...
Initialize build database ... DONE!


Architecture(s)  = AARCH64
Build target = RELEASE
Toolchain= GCC49

Active Platform  = /home/xxx/devel/firmware/edk2/ArmPkg/ArmPkg.dsc

FLASH_DEFINITION = 

Processing meta-data .Found forced library for arch=AARCH64
ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf 
[NULL1]
Found forced library for arch=AARCH64
MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf [NULL2]

Library instances of module [/home/xxx/devel/firmware/edk2/ArmPkg/Drivers/
CpuDxe/CpuDxe.inf] [AARCH64]:
ArmLib : /home/xxx/devel/firmware/edk2/ArmPkg/Library/ArmLib/
AArch64/AArch64Lib.inf


build.py...
/home/xxx/devel/firmware/edk2/ArmPkg/ArmPkg.dsc(...): error 4000: Instance 
of library class [ArmMmuLib] is not found
in [/home/xxx/devel/firmware/edk2/ArmPkg/Drivers/CpuDxe/CpuDxe.inf] 
[AARCH64]
consumed by module [/home/xxx/devel/firmware/edk2/ArmPkg/Drivers/
CpuDxe/CpuDxe.inf]
 

- Failed -
Build end time: 20:36:38, Jul.19 2016
Build total time: 00:00:02


___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel