Re: [edk2] Library refinement: OptionRomPkg/BltLib

2015-08-13 Thread Jordan Justen
Did you get a chance to review the commit message on caebd915 / r11520? On 2015-08-09 20:09:54, Ni, Ruiyu wrote: Jordan and Laszlo, I reviewed the OptionRomPkg/BltLib again and would like to discuss with you about the potential API refinement. I attached two versions of the

Re: [edk2] Library refinement: OptionRomPkg/BltLib

2015-08-10 Thread Ni, Ruiyu
Laszlo, The reason I wanted to use the four APIs instead of only one BltLibGopBlt is if user just wants to fill video, he can supply less parameters. I am glad you have no concern to the refine proposal. Jordan, Any thought? Thanks, Ray -Original Message- From: Laszlo Ersek

Re: [edk2] Library refinement: OptionRomPkg/BltLib

2015-08-10 Thread Ni, Ruiyu
To: Justen, Jordan L jordan.l.jus...@intel.com; Laszlo Ersek ler...@redhat.com Cc: edk2-devel@lists.01.org Subject: [edk2] Library refinement: OptionRomPkg/BltLib Jordan and Laszlo, I reviewed the OptionRomPkg/BltLib again and would like to discuss with you about the potential API refinement. I

[edk2] Library refinement: OptionRomPkg/BltLib

2015-08-09 Thread Ni, Ruiyu
Jordan and Laszlo, I reviewed the OptionRomPkg/BltLib again and would like to discuss with you about the potential API refinement. I attached two versions of the refined BltLib.h. The common part of the two versions is: 1. BltLibGetSizes() is removed. Because the size information is