Re: [edk2] Missing PI definitions?

[Andrew Fish via edk2-devel]

Liming,

Sorry I guess I was confusing this with EFI_RESOURCE_ATTRIBUTE_TESTED. 

I'll a little confused that it is implementation given it is passed into 
gDS->AddMemorySpace() the PI Spec defines the values of Capabilities to be 
defined in the UEFI Spec. as the GetMemoryMap() attributes. It is not clear 
that the implementation actually owns these bits? Almost feels like we should 
update the PI spec to include these #defines. 

I seem to remember we have been using these bits for a long time.

Thanks,

Andrew Fish

> On Dec 4, 2018, at 4:19 PM, Gao, Liming  wrote:
> 
> Andrew:
>  UEFI spec doesn't define them. They are the implement related definitions. 
> They are not required to be exposed to OS. We can add one header file in 
> MdeModulePkg to share them between DxeCore and MemoryTest driver. Besides, 
> ECP package will be retired. There is no change for it. 
> 
> #define EFI_MEMORY_PRESENT  0x0100ULL
> #define EFI_MEMORY_INITIALIZED  0x0200ULL
> #define EFI_MEMORY_TESTED   0x0400ULL
> 
> Thanks
> Liming
>> -Original Message-
>> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org 
>> ] On Behalf Of
>> Andrew Fish

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] Missing PI definitions?

[Gao, Liming]

Andrew:
  UEFI spec doesn't define them. They are the implement related definitions. 
They are not required to be exposed to OS. We can add one header file in 
MdeModulePkg to share them between DxeCore and MemoryTest driver. Besides, ECP 
package will be retired. There is no change for it. 

#define EFI_MEMORY_PRESENT  0x0100ULL
#define EFI_MEMORY_INITIALIZED  0x0200ULL
#define EFI_MEMORY_TESTED   0x0400ULL

Thanks
Liming
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>Andrew Fish
>Sent: Wednesday, December 05, 2018 12:01 AM
>To: edk2-devel 
>Subject: [edk2] Missing PI definitions?
>
>Anyone remember why these defines are not in a common header in the
>MdePkg?
>
>/Volumes/Case/UDK2018(vUDK2018)>git grep MEMORY_PRESENT -- *.h
>EdkCompatibilityPkg/Foundation/Include/TianoTypes.h:31:#define
>EFI_MEMORY_PRESENT  0x0100
>MdeModulePkg/Core/Dxe/DxeMain.h:101:#define EFI_MEMORY_PRESENT
>0x0100ULL
>MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/LightMem
>oryTest.h:42:#define EFI_MEMORY_PRESENT  0x0100ULL
>MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryT
>est.h:33:#define EFI_MEMORY_PRESENT  0x0100ULL
>/Volumes/Case/UDK2018(vUDK2018)>git grep EFI_MEMORY_INITIALIZED --
>*.h
>EdkCompatibilityPkg/Foundation/Include/TianoTypes.h:32:#define
>EFI_MEMORY_INITIALIZED  0x0200
>MdeModulePkg/Core/Dxe/DxeMain.h:102:#define
>EFI_MEMORY_INITIALIZED  0x0200ULL
>MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/LightMem
>oryTest.h:43:#define EFI_MEMORY_INITIALIZED  0x0200ULL
>MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryT
>est.h:34:#define EFI_MEMORY_INITIALIZED  0x0200ULL
>/Volumes/Case/UDK2018(vUDK2018)>git grep EFI_MEMORY_TESTED -- *.h
>EdkCompatibilityPkg/Foundation/Include/TianoTypes.h:33:#define
>EFI_MEMORY_TESTED   0x0400
>MdeModulePkg/Core/Dxe/DxeMain.h:103:#define EFI_MEMORY_TESTED
>0x0400ULL
>MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/LightMem
>oryTest.h:44:#define EFI_MEMORY_TESTED   0x0400ULL
>MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryT
>est.h:35:#define EFI_MEMORY_TESTED   0x0400ULL
>
>
>Thanks,
>
>Andrew Fish
>___
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] Missing PI definitions?

[Andrew Fish]

Anyone remember why these defines are not in a common header in the MdePkg?

/Volumes/Case/UDK2018(vUDK2018)>git grep MEMORY_PRESENT -- *.h
EdkCompatibilityPkg/Foundation/Include/TianoTypes.h:31:#define 
EFI_MEMORY_PRESENT  0x0100
MdeModulePkg/Core/Dxe/DxeMain.h:101:#define EFI_MEMORY_PRESENT  
0x0100ULL
MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/LightMemoryTest.h:42:#define
 EFI_MEMORY_PRESENT  0x0100ULL
MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTest.h:33:#define 
EFI_MEMORY_PRESENT  0x0100ULL
/Volumes/Case/UDK2018(vUDK2018)>git grep EFI_MEMORY_INITIALIZED -- *.h
EdkCompatibilityPkg/Foundation/Include/TianoTypes.h:32:#define 
EFI_MEMORY_INITIALIZED  0x0200
MdeModulePkg/Core/Dxe/DxeMain.h:102:#define EFI_MEMORY_INITIALIZED  
0x0200ULL
MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/LightMemoryTest.h:43:#define
 EFI_MEMORY_INITIALIZED  0x0200ULL
MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTest.h:34:#define 
EFI_MEMORY_INITIALIZED  0x0200ULL
/Volumes/Case/UDK2018(vUDK2018)>git grep EFI_MEMORY_TESTED -- *.h
EdkCompatibilityPkg/Foundation/Include/TianoTypes.h:33:#define 
EFI_MEMORY_TESTED   0x0400
MdeModulePkg/Core/Dxe/DxeMain.h:103:#define EFI_MEMORY_TESTED   
0x0400ULL
MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/LightMemoryTest.h:44:#define
 EFI_MEMORY_TESTED   0x0400ULL
MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTest.h:35:#define 
EFI_MEMORY_TESTED   0x0400ULL


Thanks,

Andrew Fish
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel