Hi Samer
I think this ASM patch is OK. Add GCC patch.
Reviewed by: Jiewen Yao jiewen@intel.com
Thank you
Yao Jiewen
From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hp.com]
Sent: Tuesday, August 26, 2014 1:33 AM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [PATCH]
Chen Jordan,
I encountered on exception as blew on Ubuntu12.04 (on virtual machine by
Virtual Box, VT-x enabled) with GCC46. Log is attached. Do you have any idea
on it?
$ qemu-system-i386 -smp 4 -serial file:ovmf.log
Could not access KVM kernel module: No such file or directory
failed to
On Fri, 2014-09-19 at 07:07 +, Fan, Jeff wrote:
Chen Jordan,
I encountered on exception as blew on Ubuntu12.04 (on virtual machine by
Virtual Box, VT-x enabled) with GCC46. Log is attached. Do you have any idea
on it?
$ qemu-system-i386 -smp 4 -serial file:ovmf.log
Could not
From: Jordan Justen jordan.l.jus...@intel.com
We'll want to use the structures for AP startup.
Note: It seems previously we were not using '#pragma pack ()' in
CpuGdt.c.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
---
All APs use the same common stack to initialization. after
initialization, APs should switch to the stack of its own.
the sequences are:
1. BSP detects AP count
2. BSP allocates AP stack spaces
3. AP grabs a lock
4. AP SwitchStack
5. AP releases lock
Contributed-under: TianoCore
when Ap graps a lock and call CpuMp.c:ApEntryPointInC,
it should switch to stack of its' own and release the
lock to let others Ap call CpuMp.c:ApEntryPointInC
sequential. and StartCode should be not freed.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chen Fan
From: Jordan Justen jordan.l.jus...@intel.com
TODO: Port to MASM
TODO: Remove unused GNU Assembler
The AP startup code simply jumps into this code with the CpuDxe driver
without setting up a stack for the processor.
Therefore, this code must setup the stack before calling into C code.
This is
This series patchset try to implement Mp Service protocol in UefiCpuPkg,
Jordan had implemented the startup APs code, and I try to add more
initialization code to let all APs work up, this Mp Service protocol's
implementation used EmulatorPkg/MpService for reference.
this patches works on my
BSP should detect the AP COUNT to know the AP presence.
So in AP initialization code, AP increased the COUNT,
and BSP waited 100ms to get the COUNT. then BSP could
allocate stack spaces for the APs.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chen Fan
From: Jordan Justen jordan.l.jus...@intel.com
This routine starts the APs and directs them to run the specified
code.
The specified code is entered without a stack being available.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
---
From: Jordan Justen jordan.l.jus...@intel.com
This sequence should happen:
* CpuMp.c: Allocate a stack for the APs
* ApStartup.c: Send Start IPI to wake APs in 16-bit real mode
* MpAsm.S: AP enters CpuDxe driver code without stack
- AP grabs a lock
- AP sets up stack
- AP calls
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
UefiCpuPkg/CpuDxe/CpuMp.c | 127 +-
UefiCpuPkg/CpuDxe/CpuMp.h | 73 ++
2 files changed, 199 insertions(+), 1
From: Jordan Justen jordan.l.jus...@intel.com
This is the function the AP assembly code will expect to call after
getting a lock and setting up the stack.
Only one AP will enter this routine at a time.
If ApEntryPointInC exits, then the assembly code will loop around to
grab the lock, setup the
by now, SwitchBSP() always return UNSUPPORTED
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
UefiCpuPkg/CpuDxe/CpuMp.c | 47 ++-
UefiCpuPkg/CpuDxe/CpuMp.h | 43
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
UefiCpuPkg/CpuDxe/CpuDxe.inf | 1 +
UefiCpuPkg/CpuDxe/CpuMp.c| 21 +
UefiCpuPkg/CpuDxe/CpuMp.h| 2 ++
3 files changed, 24 insertions(+)
diff --git
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
UefiCpuPkg/CpuDxe/CpuMp.c | 56 ++-
UefiCpuPkg/CpuDxe/CpuMp.h | 35 +
2 files changed, 90 insertions(+), 1
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
UefiCpuPkg/CpuDxe/CpuMp.c | 342 --
UefiCpuPkg/CpuDxe/CpuMp.h | 107 +++
2 files changed, 440 insertions(+), 9 deletions(-)
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
UefiCpuPkg/CpuDxe/CpuMp.c | 64 +++
UefiCpuPkg/CpuDxe/CpuMp.h | 31 +++
2 files changed, 85 insertions(+), 10
Due to the implementation of AcquireSpinLock() is not MP safe,
so we should use AcquireSpinLockOrFail directly instead.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
UefiCpuPkg/CpuDxe/CpuDxe.inf | 1 +
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
UefiCpuPkg/CpuDxe/CpuMp.c | 465 +-
UefiCpuPkg/CpuDxe/CpuMp.h | 161
2 files changed, 625 insertions(+), 1 deletion(-)
Hi Ard,
On 09/18/14 23:33, Ard Biesheuvel wrote:
Users of the LP64 data model should declare SIXTY_FOUR_BIT_LONG,
not SIXTY_FOUR_BIT when building OpenSSL.
Contributed-under: TianoCore Contribution Agreement 1.0
Reviewed-By: Olivier Martin olivier.mar...@arm.com
Reviewed-by: Andrew Fish
BIOSes often have boot-time code which tweaks the static ACPI tables
generated by iasl to reflect the current hardware. For instance, it may
mark missing CPUs as disabled. It's also possible (although a lot of
work) to generate the binary ACPI data (AML) on the fly. I'm not aware
of any
On 19 September 2014 03:38, Laszlo Ersek ler...@redhat.com wrote:
Hi Ard,
On 09/18/14 23:33, Ard Biesheuvel wrote:
Users of the LP64 data model should declare SIXTY_FOUR_BIT_LONG,
not SIXTY_FOUR_BIT when building OpenSSL.
Contributed-under: TianoCore Contribution Agreement 1.0
Reviewed-By:
On 18 September 2014 05:18, Laszlo Ersek ler...@redhat.com wrote:
On 09/18/14 13:44, Andreas Färber wrote:
Hello Laszlo,
Am 18.09.2014 um 10:23 schrieb Laszlo Ersek:
I've been made an offer that I couldn't refuse :) to organize a Birds
of a Feather session concerning OVMF at the KVM Forum
Reviewed-by: Erik Bjorge erik.c.bjo...@intel.com
From: Mcdaniel, Daryl
Sent: Wednesday, September 17, 2014 3:43 PM
To: edk2-devel@lists.sourceforge.net; Bjorge, Erik C; Carsey, Jaben
Subject: [PATCH] StdLib/AppPkg: Replace DevShell with DevMedia
Jaben or Erik: Could you please review the
On Sep 18, 2014, at 10:38 PM, Narinder Dhillon ndhillo...@gmail.com wrote:
Hi All,
In order to add ACPI tables to UEFI, iasl compiler has to be downloaded from
acpica.org.
UEFI build compiles the tables, which makes the configuration static.
Is there any way to change this configuration
On Sep 18, 2014, at 10:21 PM, J. E. nszero...@hotmail.com wrote:
Yep thats the first thing I did, search all of UDK for SHELLENV_GET_ENV using
Agent Ransack which searches binary and unicode as well.
I found nothing except for the EfiShellEnvironment2.h and UefiShellLib.lib
files.
No idea
Il 19/09/2014 16:17, Ard Biesheuvel ha scritto:
(**) Ard's patches for the upstream host kernel (== KVM) have been...
ugh, not sure... applied to a maintainer tree? Ard? :)
Some are in kvm/master, which I think means to should go into the next
3.17-rc, although I haven't seen much
The Intel(R) UEFI Packaging Tool, UPT.exe that is included in the BaseTools
will create DEC and INF files when installing a UEFI Distribution Package (UDP).
Both the INF and DEC files may have sections and content within a section that
is reordered when installing a UDP.
INF Spec Change
When
On 09/19/2014 12:10 PM, Hauch, Larry wrote:
In order to facilitate validation of INF files, we will also like to
create a new tool that can be used for content (not format) validation
of INF and DEC files. This tool would take two files as arguments,
either DEC or INF files, and do an object
On 19 September 2014 10:03, Paolo Bonzini pbonz...@redhat.com wrote:
Il 19/09/2014 16:17, Ard Biesheuvel ha scritto:
(**) Ard's patches for the upstream host kernel (== KVM) have been...
ugh, not sure... applied to a maintainer tree? Ard? :)
Some are in kvm/master, which I think means to
While revisiting problem discussed
http://sourceforge.net/p/edk2/mailman/message/32171128/ I tried to
understand why using EXCLUSIVE as suggested in this thread did not
work. I added print of EFI status code from protocol open and to my
surprise it was 3 (UNSUPPORTED). This happens in this code:
On Sep 19, 2014, at 11:27 AM, Andrei Borzenkov arvidj...@gmail.com wrote:
While revisiting problem discussed
http://sourceforge.net/p/edk2/mailman/message/32171128/ I tried to
understand why using EXCLUSIVE as suggested in this thread did not
work. I added print of EFI status code from
Typo in MdePkg/Include/Library/UefiRuntimeLib.h line 332
... For a ResetType of EfiRestUpdate the data buffer...
'EfiRestUpdate' should be 'EfiResetUpdate'.
--
Bruce
--
Slashdot TV. Video for Nerds. Stuff that
http://tianocore.sourceforge.net/wiki/RoadMap2014SP1
or the same on github
https://github.com/tianocore/tianocore.github.io/wiki/RoadMap2014SP1
thanks,
Laurie
laurie.jarlst...@intel.commailto:laurie.jarlst...@intel.com
EFI / Framework Technical
Marketing Engineering Team
(503) 712-9395
Hi Brian,
Thanks for the recommendation and will include the ability to compare DSC FDF
files as well.
I think adding some verification tools is definitely a great idea and will put
this down on my to-do list.
Everyone else, are their tools that you would like to see - it may take some
time
Dear MdeModulePkg maintainer,
please review my attached patch that removes some unused assigned variables.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin olivier.mar...@arm.com
Best Regards,
Olivier
-- IMPORTANT NOTICE: The contents of this email and any
Dear IntelFrameworkModulePkg maintainer,
please find the attached patch that removes some unused assigned variables.
Some compiler (GCC in this case) raises a warning/error.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin olivier.mar...@arm.com
Regards,
Olivier,
For the removing of the Status variable. Is it better to add a check to see if
the function passed instead of (or in addition to) removing the variable?
-Jaben
-Original Message-
From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: Friday, September 19, 2014 3:57 PM
39 matches
Mail list logo
