Re: [edk2] [PATCH 01/14] OvmfPkg: initialize Q35 platform

2014-09-30 Thread Laszlo Ersek
On 09/30/14 23:42, Jordan Justen wrote: > On 2014-09-30 02:36:59, Laszlo Ersek wrote: >> On 09/30/14 00:17, Jordan Justen wrote: >>> My recommendations would be: >>> >>> OvmfPkg/Include/Library/PciHostBridge.h => >>> OvmfPkg/Include/OvmfPlatforms.h >>> >>> Add DEVIDs to OvmfPkg/Include/OvmfPlatfo

Re: [edk2] SecureBootConfigDxe divergence between OvmfPkg/ and SecurityPkg/VariableAuthenticated/

2014-09-30 Thread Jordan Justen
On Tue, Sep 30, 2014 at 2:43 PM, Laszlo Ersek wrote: > Hi, > > OvmfPkg forked SecureBootConfigDxe from SecurityPkg in SVN r13635. Since > then the original has diverged significantly. Now I'm seeing that > OpenSUSE builds OVMF in a way that the original (which has since > diverged) is included, in

[edk2] SecureBootConfigDxe divergence between OvmfPkg/ and SecurityPkg/VariableAuthenticated/

2014-09-30 Thread Laszlo Ersek
Hi, OvmfPkg forked SecureBootConfigDxe from SecurityPkg in SVN r13635. Since then the original has diverged significantly. Now I'm seeing that OpenSUSE builds OVMF in a way that the original (which has since diverged) is included, instead of the (now obsolete) fork. https://build.opensuse.org/pac

Re: [edk2] [PATCH 01/14] OvmfPkg: initialize Q35 platform

2014-09-30 Thread Jordan Justen
On 2014-09-30 02:36:59, Laszlo Ersek wrote: > On 09/30/14 00:17, Jordan Justen wrote: > > My recommendations would be: > > > > OvmfPkg/Include/Library/PciHostBridge.h => > > OvmfPkg/Include/OvmfPlatforms.h > > > > Add DEVIDs to OvmfPkg/Include/OvmfPlatforms.h. Drop IS_Q35_HOSTBRIDGE, > > PCI_PM

Re: [edk2] [PATCH 01/14] OvmfPkg: initialize Q35 platform

2014-09-30 Thread Gabriel L. Somlo
On Tue, Sep 30, 2014 at 10:16:24PM +0200, Laszlo Ersek wrote: > > "-bios OVMF.fd" works just fine with both. I still haven't figured out > > how to pass a "-v" to OS X via OVMF, so I can see verbose text-mode boot > > messages scroll by for extra clues. Reza, any idea how I'd be able to > > do that

Re: [edk2] [PATCH 01/14] OvmfPkg: initialize Q35 platform

2014-09-30 Thread Laszlo Ersek
On 09/30/14 19:22, Gabriel L. Somlo wrote: > On Mon, Sep 29, 2014 at 01:45:09PM +0200, Laszlo Ersek wrote: >>> bin/qemu-system-x86_64 -enable-kvm -m 2048 -cpu core2duo -smp 4,cores=2 \ >>> -machine q35 -device ide-drive,bus=ide.2,drive=CD \ >>> -drive id=CD,if=none,snapshot=on,file=Fedora-Live-

Re: [edk2] ShellPkg: Update MV. now supports across file system moves.

2014-09-30 Thread Shah, Tapan
Reviewed-by: Tapan Shah mailto:tapands...@hp.com>> From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Monday, September 29, 2014 12:39 PM To: Bjorge, Erik C; Shah, Tapan Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben Subject: ShellPkg: Update MV. now supports across file system moves.

Re: [edk2] ShellPkg: Update SetVar to use existing attributes for updating existing variables

2014-09-30 Thread Shah, Tapan
Reviewed-by: Tapan Shah mailto:tapands...@hp.com>> From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Monday, September 29, 2014 12:38 PM To: Bjorge, Erik C; Shah, Tapan Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben Subject: ShellPkg: Update SetVar to use existing attributes for updat

[edk2] DynamicEx and FeatureFlag

2014-09-30 Thread Tim Lewis
Currently the flag PcdDxeIplSwitchToLongMode is declared as storage type PcdFeatureFlag. But we tried to change it to DynamicEx. Ok, that works great. We changed the .dec file to say [PcdDynamicEx]. No problem. But then we tried to make it selectable by .dsc by making it [PcdFeatureFlag, PcdDy

Re: [edk2] [PATCH 01/14] OvmfPkg: initialize Q35 platform

2014-09-30 Thread Laszlo Ersek
On 09/30/14 18:59, Gabriel L. Somlo wrote: > On Tue, Sep 30, 2014 at 11:52:28AM +0200, Laszlo Ersek wrote: >>> So, my n00b question is why bother with PCDs in the first place, >>> given that their use in AcpiTimerLib (where the bulk of the savings >>> from ditching the IS_Q35 macro is realized) may

Re: [edk2] [PATCH 01/14] OvmfPkg: initialize Q35 platform

2014-09-30 Thread Laszlo Ersek
On 09/30/14 16:16, Brian J. Johnson wrote: > On 09/30/2014 04:36 AM, Laszlo Ersek wrote: >> ... >> - The OvmfPlatformsLib class would have the following *three* instances: >> >>(a) for SEC and PEI_CORE: interrogate the registers all the time. >> >>(b) for PEIM, DXE_CORE, DXE_RUNTIME_DRIVER,

Re: [edk2] [PATCH 01/14] OvmfPkg: initialize Q35 platform

2014-09-30 Thread Gabriel L. Somlo
On Mon, Sep 29, 2014 at 01:45:09PM +0200, Laszlo Ersek wrote: > > bin/qemu-system-x86_64 -enable-kvm -m 2048 -cpu core2duo -smp 4,cores=2 \ > > -machine q35 -device ide-drive,bus=ide.2,drive=CD \ > > -drive id=CD,if=none,snapshot=on,file=Fedora-Live-Desktop-x86_64-20-1.iso > > \ > > -device

Re: [edk2] [PATCH 01/14] OvmfPkg: initialize Q35 platform

2014-09-30 Thread Gabriel L. Somlo
On Tue, Sep 30, 2014 at 11:52:28AM +0200, Laszlo Ersek wrote: > > So, my n00b question is why bother with PCDs in the first place, given > > that their use in AcpiTimerLib (where the bulk of the savings from > > ditching the IS_Q35 macro is realized) may be frowned upon ? > > I agree that PCDs are

Re: [edk2] [PATCH 01/14] OvmfPkg: initialize Q35 platform

2014-09-30 Thread Brian J. Johnson
On 09/30/2014 04:36 AM, Laszlo Ersek wrote: > ... > - The OvmfPlatformsLib class would have the following *three* instances: > >(a) for SEC and PEI_CORE: interrogate the registers all the time. > >(b) for PEIM, DXE_CORE, DXE_RUNTIME_DRIVER, DXE_DRIVER: call >GetFirstGuidHob(). If it

Re: [edk2] Error in ApciS3Save compiled by clang

2014-09-30 Thread Sergey Isakov
This is old clang --- Apple clang version 4.1 (tags/Apple/clang-421.11.66) (based on LLVM 3.1svn) Target: x86_64-apple-darwin11.4.2 Thread model: posix --- Ok, I will do this temp workaround. OvmfPkg, compiled with this clang works, if I exclude S3Save from its body ;) Sergey On 30.09.201

Re: [edk2] Error in ApciS3Save compiled by clang

2014-09-30 Thread Andrew Fish
On Sep 30, 2014, at 5:13 AM, Sergey Isakov wrote: > Hi sirs, > New problem > > Building ... > /Users/sergey/src/edk2/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf > [X64] > /Users/sergey/src/edk2/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c:216:33: > e

[edk2] Error in ApciS3Save compiled by clang

2014-09-30 Thread Sergey Isakov
Hi sirs, New problem Building ... /Users/sergey/src/edk2/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf [X64] /Users/sergey/src/edk2/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c:216:33: error: second argument to 'va_arg' is of promotable type 'UINT16' (aka

Re: [edk2] [PATCH 01/14] OvmfPkg: initialize Q35 platform

2014-09-30 Thread Laszlo Ersek
On 09/30/14 06:30, Gabriel L. Somlo wrote: > On Mon, Sep 29, 2014 at 03:17:23PM -0700, Jordan Justen wrote: >> My recommendations would be: >> >> OvmfPkg/Include/Library/PciHostBridge.h => >> OvmfPkg/Include/OvmfPlatforms.h >> >> Add DEVIDs to OvmfPkg/Include/OvmfPlatforms.h. Drop IS_Q35_HOSTBRID

Re: [edk2] [PATCH 01/14] OvmfPkg: initialize Q35 platform

2014-09-30 Thread Laszlo Ersek
On 09/30/14 00:17, Jordan Justen wrote: > My recommendations would be: > > OvmfPkg/Include/Library/PciHostBridge.h => > OvmfPkg/Include/OvmfPlatforms.h > > Add DEVIDs to OvmfPkg/Include/OvmfPlatforms.h. Drop IS_Q35_HOSTBRIDGE, > PCI_PM_REG. Maybe add Q35_PM_DEVICE=0x1f and PIIX4_PM_DEVICE=1. >

Re: [edk2] Compiler inserting memcpy. Unresolved external symbol memcpy

2014-09-30 Thread J. E.
I see, ok thanks for the info.*puts on pointer hat* From: af...@apple.com Date: Mon, 29 Sep 2014 07:34:00 -0700 To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] Compiler inserting memcpy. Unresolved external symbol memcpy On Sep 29, 2014, at 7:08 AM, J. E. wrote:All good now, th