Re: [edk2] Common, pedantic, bug in embedded C. * (char *)0x00000000 = 1

2013-03-08 Thread Paolo Bonzini
Il 08/03/2013 19:04, Andrew Fish ha scritto: For GCC/clang, it is probably best to add -fno-delete-null-pointer-checks to the command line, because a NULL pointer dereference will not cause abnormal termination in TianoCore. The Linux kernel uses the same option. What we do is is add

Re: [edk2] [PATCH 0/8] OvmfPkg: reset-related changes

2013-02-22 Thread Paolo Bonzini
-- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb Reviewed-by: Paolo Bonzini pbonz...@redhat.com

Re: [edk2] [Qemu-devel] [RFC PATCH] Distinguish between reset types

2013-02-21 Thread Paolo Bonzini
Il 21/02/2013 02:10, Laszlo Ersek ha scritto: OTOH if the keyboard reset gets soft in qemu, then OVMF's hard reset (the above code) will break. Maybe I could cycle between 0xCF9 and 0x64 in ResetCold(), starting with 0xCF9. Yes, that's the right thing to do. Also, in QEMU you're doing:

Re: [edk2] [Qemu-devel] [RFC PATCH] Distinguish between reset types

2013-02-21 Thread Paolo Bonzini
Il 21/02/2013 18:12, David Woodhouse ha scritto: Since - I like kvm, and - I cannot easily change my hardware (which doesn't support UG), and - I prefer to run the RHEL-6 kernel which has old KVM, I depend on David's fix for the PAM registers. Which means your suspend/resume is broken.

Re: [edk2] OvmfPkg reset [was: Distinguish between reset types]

2013-02-21 Thread Paolo Bonzini
Il 21/02/2013 19:24, Laszlo Ersek ha scritto: (1) The reset capability that OVMF exports via ACPI -- I agree that I should be effecting the 0xCF9 thing in the appropriate table. On a second thought, this will require a new build -D flag, or a PCD. I'm not worried about the ACPI 1.0 -- ACPI

Re: [edk2] (PAM stuff) reset doesn't work on OVMF + SeaBIOS CSM

2013-02-18 Thread Paolo Bonzini
Il 18/02/2013 13:53, David Woodhouse ha scritto: diff --git a/hw/piix_pci.c b/hw/piix_pci.c index 6c77e49..6dcf1c5 100644 --- a/hw/piix_pci.c +++ b/hw/piix_pci.c @@ -171,6 +171,23 @@ static int i440fx_load_old(QEMUFile* f, void *opaque, int version_id) return 0; } +static void

Re: [edk2] SeaBIOS as CSM

2013-01-21 Thread Paolo Bonzini
Il 21/01/2013 00:42, David Woodhouse ha scritto: The main issue I have on the OVMF side is that it locks the entire memory region from 0xC-0xF to be read-only, right before invoking the Legacy16Boot method. This upsets SeaBIOS, which puts a stack in the E segment for use during

Re: [edk2] [PATCH 3/4] OvmfPkg: report S3 state in DSDT

2012-12-07 Thread Paolo Bonzini
question: on what OS(es) did you test this? Apart from this, Reviewed-by: Paolo Bonzini pbonz...@redhat.com for the whole series. Paolo -- LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely

Re: [edk2] gcc47 and tools-def.txt

2012-11-15 Thread Paolo Bonzini
Il 14/11/2012 21:19, Jordan Justen ha scritto: On Wed, Nov 14, 2012 at 11:34 AM, Sergey Isakov isakov...@bk.ru wrote: Dear sirs, May be this information must to to BaseTools developers but if we use edk2/Conf/tools-def.txt we should know that GCC47 required one more flag

Re: [edk2] Unaligned I/O ?

2012-11-09 Thread Paolo Bonzini
Il 08/11/2012 23:17, Gerd Hoffmann ha scritto: On 11/08/12 22:23, Jordan Justen wrote: Seems like you're going to need to: * Pull IoRead/Write16 from MdePkg/Library/BaseIoLibIntrinsic into the driver. * Rename to UnalignedIoRead/Write16 and remove the alignment assert * Read the BAR to get

Re: [edk2] [PATCH] OvmfPkg VirtioScsiDxe: Fix build with VS2010

2012-10-29 Thread Paolo Bonzini
Il 28/10/2012 16:30, Laszlo Ersek ha scritto: Is there a UEFI macro for a compiler optimization barrier? If so, use it and forget volatile altogether... Wherever the virtio specification required a memory barrier, I used MemoryFence(). I used volatile wherever I thought it was necessary in

Re: [edk2] OVMF + Windows 2008 r2 sp1

2012-10-18 Thread Paolo Bonzini
Il 18/10/2012 03:38, Laszlo Ersek ha scritto: On 10/17/12 15:11, Laszlo Ersek wrote: I did see a lot of binary stuff written to the serial console. I expected to see textual debug messages, but apparently the /bootdebug /debug flags above allow a remote windbg to attach instead, and it was

Re: [edk2] [PATCH v2 0/4] OvmfPkg: virtio-blk driver

2012-10-08 Thread Paolo Bonzini
Il 08/10/2012 09:42, Jordan Justen ha scritto: I noticed the -drive file=cd.iso,if=virtio doesn't seem to boot the ISO. This does work for seabios. I wonder if this is luck based on the ISO layout, or if seabios detects this. I do wonder if it is treating it as a USB (pendrive) image... Paolo

Re: [edk2] OT: Gmane archives of TianoCore lists

2012-09-10 Thread Paolo Bonzini
Il 09/09/2012 02:01, Lee Fisher ha scritto: FYI, starting in July, someone setup Gmane mirrors for most of the TianoCore lists. Thank you, whoever did this. It would be even better if one of the admins contributed full archives for at least the -devel lists! Paolo

Re: [edk2] QEMU debug port

2012-07-26 Thread Paolo Bonzini
Il 26/07/2012 18:40, Jordan Justen ha scritto: I committed the QEMU debug-port support in r13562. I had two follow up questions. Why don't we use the default port address of 0xe9? I'm following what SeaBIOS does. On Xen, IIRC, 0xe9 is spammed to the hypervisor logs. Shouldn't we add

<    1   2