Re: [edk2] [PATCH] BaseTools/GenFw: Added AArch64 page-relative relocations

2015-07-13 Thread Ard Biesheuvel
On 13 July 2015 at 16:54, Olivier Martin wrote: > Sorry, I am bit slow today... Sorry again to ask clarification but what do > you mean by: " So my position is that the first hunk should be dropped, and > instead, the patch should ensure that these relocations are only encountered > in binaries

Re: [edk2] [PATCH] BaseTools/GenFw: Added AArch64 page-relative relocations

2015-07-13 Thread Olivier Martin
Sorry, I am bit slow today... Sorry again to ask clarification but what do you mean by: " So my position is that the first hunk should be dropped, and instead, the patch should ensure that these relocations are only encountered in binaries that have sufficient section alignment, and error out ot

Re: [edk2] [PATCH] BaseTools/GenFw: Added AArch64 page-relative relocations

2015-07-10 Thread Ard Biesheuvel
On 10 July 2015 at 18:13, Olivier Martin wrote: > > >> -Original Message- >> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >> Sent: 08 July 2015 18:50 >> To: Olivier Martin >> Cc: Leif Lindholm; edk2-devel@lists.sourceforge.net; Harry Liebel >> Subject: Re: [PATCH] BaseTools/GenF

Re: [edk2] [PATCH] BaseTools/GenFw: Added AArch64 page-relative relocations

2015-07-10 Thread Olivier Martin
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: 08 July 2015 18:50 > To: Olivier Martin > Cc: Leif Lindholm; edk2-devel@lists.sourceforge.net; Harry Liebel > Subject: Re: [PATCH] BaseTools/GenFw: Added AArch64 page-relative > relocations > > On 8 Jul

Re: [edk2] [PATCH] BaseTools/GenFw: Added AArch64 page-relative relocations

2015-07-08 Thread Andrew Fish
> On Jul 8, 2015, at 11:18 AM, Ard Biesheuvel wrote: > > Indeed. But unlike ELF, PE/COFF does not allow the header to overlap > with the .text section, so using 4 KB alignment for a XIP modules > .text section always wastes 3.5 KB in the FV. > > Olivier's patch allows code to be generated that

Re: [edk2] [PATCH] BaseTools/GenFw: Added AArch64 page-relative relocations

2015-07-08 Thread Ard Biesheuvel
On 8 July 2015 at 20:01, Andrew Fish wrote: > > On Jul 8, 2015, at 10:49 AM, Ard Biesheuvel > wrote: > > On 8 July 2015 at 16:57, Olivier Martin wrote: > > When EDK2 is built for the small memory model with AArch64 LLVM, > some page-relative relocations (R_AARCH64_ADR_PREL_PG_HI21 and its > R_AA

Re: [edk2] [PATCH] BaseTools/GenFw: Added AArch64 page-relative relocations

2015-07-08 Thread Andrew Fish
> On Jul 8, 2015, at 10:49 AM, Ard Biesheuvel wrote: > > On 8 July 2015 at 16:57, Olivier Martin > wrote: >> When EDK2 is built for the small memory model with AArch64 LLVM, >> some page-relative relocations (R_AARCH64_ADR_PREL_PG_HI21 and its >> R_AARCH64_LDST(16

Re: [edk2] [PATCH] BaseTools/GenFw: Added AArch64 page-relative relocations

2015-07-08 Thread Ard Biesheuvel
On 8 July 2015 at 16:57, Olivier Martin wrote: > When EDK2 is built for the small memory model with AArch64 LLVM, > some page-relative relocations (R_AARCH64_ADR_PREL_PG_HI21 and its > R_AARCH64_LDST(16|32|64|128)_ABS_LO12_NC companions) that were not > supported before by EDK2 BaseTools are now n

[edk2] [PATCH] BaseTools/GenFw: Added AArch64 page-relative relocations

2015-07-08 Thread Olivier Martin
When EDK2 is built for the small memory model with AArch64 LLVM, some page-relative relocations (R_AARCH64_ADR_PREL_PG_HI21 and its R_AARCH64_LDST(16|32|64|128)_ABS_LO12_NC companions) that were not supported before by EDK2 BaseTools are now needed. This change adds support for these relocations i