Re: [edk2] [PATCH] EmbeddedPkg: fix PcdTimerPeriod value

2015-07-14 Thread Leif Lindholm
On Tue, Jul 14, 2015 at 10:05:14AM +0800, Haojian Zhuang wrote: > > > In GRUB, the required timer granularity is only 1ms. If interval of > > > hardware timer interrupt is 10ms in UEFI, GRUB will only get all > > > timer granularity >= 10ms. At least, the timeout of boot menu in > > > GRUB is much

Re: [edk2] [PATCH] EmbeddedPkg: fix PcdTimerPeriod value

2015-07-13 Thread Haojian Zhuang
On Mon, 2015-07-13 at 16:04 +0100, Leif Lindholm wrote: > Thanks Haojian, > > A few comments below. It looks sane to me, but the patches to > individual platforms may need some testing. > > As a note to my future self, I should go through these platforms and > delete the default timer period from

Re: [edk2] [PATCH] EmbeddedPkg: fix PcdTimerPeriod value

2015-07-13 Thread Leif Lindholm
Thanks Haojian, A few comments below. It looks sane to me, but the patches to individual platforms may need some testing. As a note to my future self, I should go through these platforms and delete the default timer period from the platform-specific config files and get it from a central config f

[edk2] [PATCH] EmbeddedPkg: fix PcdTimerPeriod value

2015-07-13 Thread Haojian Zhuang
Fix PcdTimerPeriod from 100,000 to 10,000. Since the unit base of PcdTimerPeriod is 100ns. 100,000 * 100ns = 10ms (interval of hardware timer interrupt) 10,1000 * 100ns = 1ms (interval of hardware timer interrupt) In GRUB, the required timer granularity is only 1ms. If interval of hardware timer