Re: [edk2] clang compilation error

2013-01-11 Thread Nikolai Saoukh
being a 32-bit signed value. > > > > > There are two ways to address this compiler error: > > > > > 1) Disable this compiler warning for this one compiler in tools_def.txt > > > 2) Update the sources to perform an unsigned comparison such as: > &g

Re: [edk2] clang compilation error

2013-01-11 Thread Isakov Sergey
The EDK II implementation attempts to be compatible with both > types of compilers. > > Best regards, > > Mike > > -Original Message- > From: Nikolai Saoukh [mailto:n...@otdel-1.org] > Sent: Friday, January 11, 2013 9:32 AM > To: edk2-devel@lists.sourcef

Re: [edk2] clang compilation error

2013-01-11 Thread Kinney, Michael D
EfiMaxMemoryType && (UINTN)PoolType <= 0x7fff) || > > Best regards, > > > > Mike > > > > From: Sergey Isakov [mailto:isakov...@bk.ru] > Sent: Friday, January 11, 2013 2:15 AM > To: edk2-devel@lists.sourceforge.net > Subject: Re: [edk2]

Re: [edk2] clang compilation error

2013-01-11 Thread Isakov Sergey
gt; Best regards, > > Mike > > From: Sergey Isakov [mailto:isakov...@bk.ru] > Sent: Friday, January 11, 2013 2:15 AM > To: edk2-devel@lists.sourceforge.net > Subject: Re: [edk2] clang compilation error > > Ok, UEFI spec is wrong and as we have to follow them we should ex

Re: [edk2] clang compilation error

2013-01-11 Thread Nikolai Saoukh
pe <= 0x7fff) || > > Best regards, > > > > Mike > > > > From: Sergey Isakov [mailto:isakov...@bk.ru] > Sent: Friday, January 11, 2013 2:15 AM > To: edk2-devel@lists.sourceforge.net > Subject: Re: [edk2] clang compilation error > > > > Ok, U

Re: [edk2] clang compilation error

2013-01-11 Thread Kinney, Michael D
est regards, Mike From: Sergey Isakov [mailto:isakov...@bk.ru] Sent: Friday, January 11, 2013 2:15 AM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] clang compilation error Ok, UEFI spec is wrong and as we have to follow them we should exclude the comparison. 11.01.2013, в 11:58, Tim Le

Re: [edk2] clang compilation error

2013-01-11 Thread Isakov Sergey
I have another proposition. Define new type typedef ENUM INT32; it will conform to UEFI and compatible with C language specification. :) And then as I proposed > #define EfiACPIMemoryNVS 0x0A > and so on. On 11.01.2013, at 11:58, Tim Lewis wrote: > Sergey – > > It is an enum in the UEFI speci

Re: [edk2] clang compilation error

2013-01-11 Thread Sergey Isakov
Ok, UEFI spec is wrong and as we have to follow them we should exclude the comparison. 11.01.2013, в 11:58, Tim Lewis написал(а): > Sergey – > > It is an enum in the UEFI specification. > > Why not just remove the second comparison? Since the enum is an int (for UEFI > cases), if it is more

Re: [edk2] clang compilation error

2013-01-11 Thread Tim Lewis
Sergey - It is an enum in the UEFI specification. Why not just remove the second comparison? Since the enum is an int (for UEFI cases), if it is more than or equal to EfiMaxMemoryType, it must be less than 0x7fff (if it is an int). Otherwise it would be less than 0. Tim From: Sergey Isako