Re: [edk2] [PATCH 1/4] OvmfPkg: introduce virtio-blk driver

2012-09-29 Thread Paolo Bonzini
Il 28/09/2012 12:52, Laszlo Ersek ha scritto: > Normally I like explicit error checking, but: > - Due to the many PCI accesses, VirtioBlkInit() is quite linear, already > pretty long, and not really splittable. I introduced the above macros > partially in order to save repeating the error checking

[edk2] MdeModulePkg EFI_BLOCK_IO2_PROTOCOL.FlushBlocksEx questions?

2012-09-29 Thread Andrew Fish
Dear MdeModulePkg maintainers, I see the Partition driver doing the following in its Stop() function: BlockIo2->FlushBlocksEx (BlockIo2, NULL); I don't see in the UEFI spec where Token being set to NULL is defined? What does Token == NULL mean? In the AtaBusDriver FlushBlocksEx() seems