Hi Elvin,
I've checked Terminal.h, TerminalConIn.c files & they both still contain
"@retval FLASE" typos.
Alexei.
>Date: Tue, 11 Feb 2014 00:17:11 +
>From: "Li, Elvin" mailto:elvin...@intel.com>>
>Subject: Re: [edk2] Bug in TerminalDxe UnicodeFiFoRemoveOneKey() function
>To: "edk2-deve
It is a real issue. And I use 'common' ReportStatusCodeLib implementations - so
you should have the same issue:
ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.inf
ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.i
Martin:
I go through code. But, I don't find which code trig it. Could you highlight
it?
ExitBootServices() REPORT_STATUS_CODE() --> ReportStatusCode() -->
InternalReportStatusCode() --> (*mReportStatusCode) (Type, Value, Instance,
(EFI_GUID *)CallerId, Data);
IntelFrameworkModulePkg Stat
On 02/08/14 00:17, Jordan Justen wrote:
> From: Laszlo Ersek
>
> Such a packaged query function will come in handy in the following
> patches.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Laszlo Ersek
> Reviewed-by: Jordan Justen
> [jordan.l.jus...@intel.com: ch
Thanks Mike for the feedback, I attached the new version.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin
From: Kinney, Michael D [mailto:michael.d.kin...@intel.com]
Sent: 10 February 2014 21:22
To: edk2-devel@lists.sourceforge.net; Tian, Feng
Subjec
They’ll be loaded as UEFI Drivers, so use the ‘drivers’ command the UEFI Shell.
Thanks ... br
---
Brian Richardson -- brian.richard...@intel.com -- Twitter: intel_brian
From: John Davis [mailto:davi...@gmail.com]
Sent: Monday, February 10, 2014 7:55 PM
To: Richardson, Brian; edk2-devel@lists.sour
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen
---
OvmfPkg/Library/LoadLinuxLib/Linux.c| 4 ++--
OvmfPkg/PlatformPei/MemDetect.c | 2 +-
OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c | 3 ++-
OvmfPkg/Virti
The result of 'find . -type f -exec unix2dos {} \;'.
Affects only one file.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Leif Lindholm
---
ArmPkg/Library/ArmLib/AArch64/AArch64Mmu.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/ArmPkg/Li
The result of 'find . -type f -exec unix2dos {} \;'.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Leif Lindholm
---
.../Scripts/uefi-aarch64-bootstrap/LICENSE.TXT | 56 +--
.../Scripts/uefi-aarch64-bootstrap/Makefile| 192 +-
.../Scripts/uefi-aarc
Erik,
Can you review this patch?
ShellPkg: Fix uninitialized Variable error
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey
Shell.c.patch
Description: Shell.c.patch
--
Android apps
Reviewed-by: Erik Bjorge
From: Carsey, Jaben
Sent: Tuesday, February 11, 2014 3:35 PM
To: Bjorge, Erik C
Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben
Subject: ShellPkg: Fix uninitialized Variable error
Erik,
Can you review this patch?
ShellPkg: Fix uninitialized Variable error
Contribu
Erik,
Can you review this patch?
ShellPkg: Fix changing to file system with 2 colons like "fs0::"
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey
mailto:jaben.car...@intel.com>>
Shell.c.patch
Description: Shell.c.patch
--
comments below
On 02/11/14 18:16, Jordan Justen wrote:
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jordan Justen
> ---
> OvmfPkg/Library/LoadLinuxLib/Linux.c| 4 ++--
> OvmfPkg/PlatformPei/MemDetect.c | 2 +-
> OvmfPkg/Qe
Olivier
All but 0006 look good. I believe that 0006 violates the shell specification.
I do not believe that the nesting is optional. I would support changing the
spec to eliminate the red highlight and then we can leave launching a nested
shell as an implementation choice. I agree that this
It looks like this tries to use UnicodeCollation instead of UnicodeCollation2.
Did I read this wrong?
Tim
From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Tuesday, February 11, 2014 3:38 PM
To: Bjorge, Erik C
Cc: edk2-devel@lists.sourceforge.net
Subject: [edk2] ShellPkg: Fix changing to
Reviewed-by: Erik Bjorge
From: Carsey, Jaben
Sent: Tuesday, February 11, 2014 3:38 PM
To: Bjorge, Erik C
Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben
Subject: ShellPkg: Fix changing to file system with 2 colons like "fs0::"
Erik,
Can you review this patch?
ShellPkg: Fix changing to file
Tim,
I don't see anything like that. It changes the "if" block to require that the
last character in the string be a colon, and that the first colon in the string
must be the last character in the string. No Unicode collation at all...
-Jaben
From: Tim Lewis [mailto:tim.le...@insyde.com]
Sen
Sorry, I think it is 15220. It also looks like gUnicodeCollation is already
initialized at this point (from UefiShellCommandLib)
Tim
From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Tuesday, February 11, 2014 3:59 PM
To: edk2-devel@lists.sourceforge.net; Bjorge, Erik C
Subject: Re: [edk
Ah. Yes. I think that implementation would be better to use the
pre-initialized variable from the library. I didn't notice that wasn't done in
the patch that was submitted to me.
-Jaben
From: Tim Lewis [mailto:tim.le...@insyde.com]
Sent: Tuesday, February 11, 2014 4:02 PM
To: edk2-devel@list
r-b with your suggestions adopted?
On Tue, Feb 11, 2014 at 3:42 PM, Laszlo Ersek wrote:
> comments below
>
> On 02/11/14 18:16, Jordan Justen wrote:
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Jordan Justen
>> ---
>> OvmfPkg/Library/LoadLinuxLib/Linux.c
Hello
Can you use the emulator to dump memory associated with roms?
For instance, dmem fff3c9e8 is a region where I believe I have a rom
mapped, but that command will crash the emulator.
--
John F. Davis
6 Kandes Court
Durham, NC 27713
919-888-8358
独树一帜
Erik,
Can you review?
ShellPkg: refactor elimination of non-replaced environment variables
This changes how non-replaced environment variables are found and eliminated
from the command line. This new method makes sure that the found environment
variables are not using escaped characters and th
So, while working on my UEFI OS loader, I managed to brick a couple of
machines. I recovered all but one of them so far (sadly that one is my
personal tablet -- there may yet be a way to save it but I'm holding off on it
until I'm better prepared for the attempt).
I want people to be able to se
This may be a cleaner style for these types of issue. Instead of !!, compare
the result of the integer result against 0.
*MediaPresent = (BOOLEAN) ((LinkStatus & VIRTIO_NET_S_LINK_UP) != 0);
Mike
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Tuesday, February
Hi, Olivier
You need tell me why you need expose this parameter? What's your intention &
use case?
Thanks
Feng
From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: Tuesday, February 11, 2014 22:50
To: edk2-devel@lists.sourceforge.net; Tian, Feng
Subject: RE: [edk2] [PATCH] MdeModulePkg/Di
Hi Feng,
we need this change to run UEFI on a platform that has a limited amount of
system memory. Otherwise, we must change the source files to be able to run
UEFI.
Thanks,
Olivier
From: Tian, Feng [feng.t...@intel.com]
Sent: 12 February 2014 00:59
To: Ol
Get your point. It makes sense. Thanks for explanation.
I found you put the pcd definition at [PcdsFixedAtBuild] section. I would
suggest you put it to [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic,
PcdsDynamicEx] section.
Reviewed-by: Tian, Feng
-Original Message-
From: Olivi
To clean typo issue is check into 15227.
From: Alexei Fedorov [mailto:alexei.fedo...@arm.com]
Sent: Tuesday, February 11, 2014 5:37 PM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] Bug in TerminalDxe UnicodeFiFoRemoveOneKey()
Hi Elvin,
I've checked Terminal.h, TerminalConIn.c files &
Bill,
The User Interface is not defined in EFI, so it is an implementation detail, so
there is not a generic answer to this.
In general there are hot keys to enter setup, and hot keys to clear “CMOS”
which should also clear the EFI Variables on a modern system. You will need to
find the mapp
On Feb 11, 2014, at 4:34 PM, John Davis wrote:
> Hello
>
> Can you use the emulator to dump memory associated with roms?
>
The “emulator” is not a VM. If you want to assume magic addresses and hardware
exist you need to run the OVFM, as it runs in a VM.
The “emulator” is an OS application w
I guess I am confused. I don't have the files handy but I thought the
entire fv would be loaded at the top of memory. I'll post more detail
tomorrow morning.
On Feb 11, 2014 6:06 PM, "Andrew Fish" wrote:
>
> On Feb 11, 2014, at 4:34 PM, John Davis wrote:
>
> > Hello
> >
> > Can you use the emula
Laszlo Ersek [mailto:ler...@redhat.com] wrote:
[...]
]>Dev->BlockIoMedia.LogicalPartition = FALSE;
]> - Dev->BlockIoMedia.ReadOnly = !!(Features & VIRTIO_BLK_F_RO);
]> - Dev->BlockIoMedia.WriteCaching = !!(Features & VIRTIO_BLK_F_FLUSH);
]> + Dev->BlockIoMedia.ReadOnly
On 02/12/14 06:33, Scott Duplichan wrote:
> Laszlo Ersek [mailto:ler...@redhat.com] wrote:
>
> [...]
>
> ]>Dev->BlockIoMedia.LogicalPartition = FALSE;
> ]> - Dev->BlockIoMedia.ReadOnly = !!(Features & VIRTIO_BLK_F_RO);
> ]> - Dev->BlockIoMedia.WriteCaching = !!(Features & VIRTIO
On 02/12/14 01:14, Jordan Justen wrote:
> r-b with your suggestions adopted?
Please ask Mike & Scott to review this one. I'd do more harm than good
right now :/ I should likely hold off reviewing the S3 thing too, for a
few days.
Sorry
Laszlo
34 matches
Mail list logo
