Re: [edk2] investigate features differences between ovmf and seabios with QEMU

On Thu, 2014-02-27 at 12:29 +0100, Laszlo Ersek wrote: > On 02/27/14 11:05, Chen Fan wrote: > > On Wed, 2014-02-26 at 13:31 +0100, Laszlo Ersek wrote: > >> On 02/26/14 09:43, Chen Fan wrote: > > >>> what features will be provided by MP services? the smp feature includes > >>> detect and initializ

[edk2] [PATCH 0/8] OvmfPkg: QemuVideoDxe: cleanups and new BOCHS modes

According to Jordan's advice, I've separated out this series (and addressed his comments of course). Fetch it from . Thanks, Laszlo Laszlo Ersek (8): OvmfPkg: QemuVideoDxe: tidy up error checking/handling in & under Start() OvmfPkg: Qemu

[edk2] [PATCH 2/8] OvmfPkg: QemuVideoDxe: simplify UEFI driver model use in Supported() / Start()

A bus driver is allowed to ignore the actual value of RemainingDevicePath in Supported() and Start(), and to produce all child handles at once. This in effect means the following invariants for QemuVideoDxe: - (RemainingDevicePath == NULL), and - (Private->GopDevicePath != NULL) Simplify Supporte

[edk2] [PATCH 1/8] OvmfPkg: QemuVideoDxe: tidy up error checking/handling in & under Start()

In QemuVideoControllerDriverStart(): - remove redundant zero-initialization of: - Private->Handle (2 locations) - Private->GopDevicePath (when at devpath end) - remove fields used for error handling only: - PciAttributesSaved - tigthen scope of temporaries: - MmioDesc - AcpiDeviceNode

[edk2] [PATCH 3/8] OvmfPkg: QemuVideoDxe: disentangle UEFI driver model use in Stop()

A bus driver needs to pay attention whether its Stop() function is being called on the "main" controller handle (NumberOfChildren == 0) or on the child handles (NumberOfChildren > 0). In QemuVideoDxe, all our resources are associated with the one child handle (and the Private data structure) *exce

[edk2] [PATCH 4/8] OvmfPkg: QemuVideoDxe: plug remaining leaks in Stop()

Contributed-under: TianoCore Contribution Agreement 1.0 Reviewed-by: Jordan Justen Signed-off-by: Laszlo Ersek --- OvmfPkg/QemuVideoDxe/Driver.c | 5 + 1 file changed, 5 insertions(+) diff --git a/OvmfPkg/QemuVideoDxe/Driver.c b/OvmfPkg/QemuVideoDxe/Driver.c index 48a788f..e71af6e 100644 --

[edk2] [PATCH 7/8] OvmfPkg: QemuVideoDxe: filter BOCHS modes vs. available frame buffer size

In the next patch we'll add many new BOCHS modes, some of which require large frame buffers. The size of the QXL VGA compatibility framebuffer can be changed with the -global qxl-vga.vgamem_mb=$NUM_MB QEMU option. If $NUM_MB would exceed 32, then the following two QEMU options are necessary i

[edk2] [PATCH 8/8] OvmfPkg: QemuVideoDxe: add further BOCHS modes

This brings the list of BOCHS video modes to par with the QEMU QXL implementation. Contributed-under: TianoCore Contribution Agreement 1.0 Reviewed-by: Jordan Justen Signed-off-by: Laszlo Ersek --- OvmfPkg/QemuVideoDxe/Initialize.c | 40 --- 1 file changed, 3

[edk2] [PATCH 5/8] OvmfPkg: QemuVideoDxe: eliminate useless Private->HardwareNeedsStarting

Currently, QemuVideoGraphicsOutputQueryMode() reports EFI_NOT_STARTED when this boolean field is set. However, QemuVideoGraphicsOutputQueryMode() is only available to callers after the GOP interface has been installed. That in turn implies that the following partial call tree has succeeded without

[edk2] [PATCH 6/8] OvmfPkg: QemuVideoDxe: clarify QEMU_VIDEO_MODE_DATA.ModeNumber

The field name "ModeNumber" in QEMU_VIDEO_MODE_DATA is misleading -- it is not immediately obvious whether this field carries a client-visible mode number, in the GOP sense, or an internal, card type specific mode index. After checking all references, rename the field to "InternalModeIndex". Also,

[edk2] [PATCH 5/8] OvmfPkg: QemuVideoDxe: eliminate useless Private->HardwareNeedsStarting

Currently, QemuVideoGraphicsOutputQueryMode() reports EFI_NOT_STARTED when this boolean field is set. However, QemuVideoGraphicsOutputQueryMode() is only available to callers after the GOP interface has been installed. That in turn implies that the following partial call tree has succeeded without

[edk2] [PATCH 6/8] OvmfPkg: QemuVideoDxe: clarify QEMU_VIDEO_MODE_DATA.ModeNumber

The field name "ModeNumber" in QEMU_VIDEO_MODE_DATA is misleading -- it is not immediately obvious whether this field carries a client-visible mode number, in the GOP sense, or an internal, card type specific mode index. After checking all references, rename the field to "InternalModeIndex". Also,