[edk2] PCI UEFI Option rom scanning policy

2014-07-13 Thread jabir
Hi, Please help me in understanding the policy of system BIOS for scanning UEFI driver from a PCI option rom image. 1. Does the system BIOS look for UEFI driver image immediately after the legacy OpROM image based on PCIR length field of legacy OpROM image. OR Can there be gap between legacy and U

Re: [edk2] PCI UEFI Option rom scanning policy

2014-07-13 Thread Andrew Fish
On Jul 13, 2014, at 1:15 AM, jabir wrote: > Hi, > > Please help me in understanding the policy of system BIOS for scanning > UEFI driver from a PCI option rom image. > 1. Does the system BIOS look for UEFI driver image immediately after > the legacy OpROM image based on PCIR length field of leg

Re: [edk2] [BUG] Wrong StrLen usage in UnicodeStrToAsciiStr()

2014-07-13 Thread Zeng, Star
Hi Sergey, For "During copy Destination will overwrite Source but without error", I don't think it is permitted by the function as the function header comment has said " If Source and Destination overlap, then ASSERT()". And I still not see "*(Destination++) = (CHAR16) *(Source++)" in UnicodeS

[edk2] "option" statement

2014-07-13 Thread Tim Lewis
The option statement has the following flags: oneofoptionFlagsField ::= Number | "OPTION_DEFAULT" | "OPTION_DEFAULT_MFG" | "INTERACTIVE" | "RESET_REQUIRED" | "DEFAULT" But it is not clear what the "INTERACTIVE" and "RESET_REQUIRED" flags should do. Are they OR'd together and put in the par

Re: [edk2] [BUG] Possible array out of bounds

2014-07-13 Thread Fan, Jeff
Sergey, Thanks your fix. I will help to check-in later. Reviewed-by: Jeff Fan mailto:jeff@intel.com>> Jeff From: Sergey Isakov [mailto:isakov...@bk.ru] Sent: Friday, July 11, 2014 4:42 PM To: edk2-devel@lists.sourceforge.net Subject: [edk2] [BUG] Possible array out of bounds Hi, I checked

Re: [edk2] [edk2-buildtools] [RFC] Proposal to retire edk2-buildtools sub-project

2014-07-13 Thread Kinney, Michael D
Andrew, The concept of pulling the binaries from svn if they are not present is a good option to consider. Maybe edksetup.bat pulls latest version of edk2-toolsbinaries sub-project if binaries are not present. This would require the command line version of svn to be installed and in the path

Re: [edk2] [edk2-buildtools] [RFC] Proposal to retire edk2-buildtools sub-project

2014-07-13 Thread Tian, Hot
Defer the binary pull to build time is incompatible change. There may be cases that we don't have network access when build the code. From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Monday, July 14, 2014 12:42 To: Andrew Fish; edk2-devel@lists.sourceforge.net Cc: edk2-buildtools

Re: [edk2] inconsistent #langdef usage in *.uni files

2014-07-13 Thread Dong, Eric
Lee, Thanks for raise this issue, we will follow update to fix them. Thanks, Eric -Original Message- From: Blibbet [mailto:blib...@gmail.com] Sent: Thursday, July 10, 2014 8:48 AM To: edk2-devel@lists.sourceforge.net Subject: [edk2] inconsistent #langdef usage in *.uni files Hi, The