Re: [edk2] [PATCH v5 6/9] OvmfPkg: AcpiTimerLib: Use global variable during PEI_CORE and PEIM

2014-11-09 Thread Jordan Justen
On 2014-11-08 14:02:00, Gabriel L. Somlo wrote: > Since in OVMF both PEI_CORE and PEIM run from RAM, and thus may > utilize global variables, use the "Base" AcpiTimerLib instance > (instead of BaseRom) to take advantage of the improved efficiency > of storing the timer register IO address in a glob

Re: [edk2] [PATCH v5 7/9] OvmfPkg: AcpiTimerLib: Switch additional stages to PCD-based Dxe instance

2014-11-09 Thread Jordan Justen
On 2014-11-08 14:02:01, Gabriel L. Somlo wrote: > Link DXE_SMM_DRIVER, UEFI_DRIVER, UEFI_APPLICATION, and SMM_CORE against > a valid, non-asserting version of PcdLib, then switch them over to using > the "Dxe" instance of AcpiTimerLib (instead of the "Base" version). > > Contributed-under: TianoCo

Re: [edk2] MdePkg ++ Should we remove redundant Family specifiers from the INF files.

2014-11-09 Thread Kinney, Michael D
Andrew, Yes. I think these types of cleanups are good. Mike From: Andrew Fish [mailto:af...@apple.com] Sent: Friday, November 07, 2014 4:11 PM To: edk2-devel@lists.sourceforge.net Cc: Kinney, Michael D Subject: MdePkg ++ Should we remove redundant Family specifiers from the INF files. Mike,

Re: [edk2] [PATCH v5 2/9] OvmfPkg: PlatformPei: Platform specific ACPI power management setup

2014-11-09 Thread Jordan Justen
On 2014-11-08 14:01:56, Gabriel L. Somlo wrote: > Set up ACPI power management using registers determined based on > the underlying (PIIX4 or Q35/MCH) platform type. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Gabriel Somlo > Reviewed-by: Paolo Bonzini > Reviewed

[edk2] [PATCH v2] Add RETURN_ADDRESS macro into Base.h

2014-11-09 Thread Zeng, Star
Hi Andrew, It is a good point, see the updated patch. BTW: The patch focus on return address function and is not going to add macro for __builtin_frame_address, or other built in functions. Thanks, Star From: Andrew Fish [mailto:af...@apple.com] Sent: Sunday, November 09, 2014 6:06 AM To: edk2-d