It looks good to me, Laszlo
Just a minor comment, How about moving the local variable statement up to the
beginning of the function for better coding style?
If you agree, I will do it at check-in this patch and sign:
Reviewed-by: Feng Tian
Thanks
Feng
-Original Message-
From: Laszlo
Hi Sajeesh,
I need understand your problem at first. Could you please describe your
topology and configuration? How do you configure your VLAN ID?
And what does protocol type 0x8000 stand for? We use 0x0800 Ethernet type for
IPv4 protocol as I known. Is it a typo or a new protocol?
Best Regard
Since there is now a formal definition of EFI_LOAD_OPTION, we can no
longer typedef it as a UINT8*. So update the code to use the common
definition, which is not a pointer type, hence the additional changes
to the C code.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard B
On 05/11/15 09:07, Tian, Feng wrote:
> It looks good to me, Laszlo
>
> Just a minor comment, How about moving the local variable statement up to the
> beginning of the function for better coding style?
>
> If you agree, I will do it at check-in this patch and sign:
>
> Reviewed-by: Feng Tian
Hi All
We tried with our UEFI Option Rom on Platform ASROCK-Z97.
And find if enable the fast boot option in BIOS ,OS boot will hang on the black
screen.
But if use the BIOS embedded UEFI BIOS , OS can be boot up successfully.
On the data stream capture, we just can find BIOS just will stop its op
1. PCD PcdCpuMtrrTableAddress/PcdCpuSyncMtrrToAcpiNvs are not necessary now,
due to there is no one total SMM-capable S3 resume. I think you could add them
(if necessary) after one total SMM-capable S3 resume is verified.
2. The patch introduced two new files with the different BSD license head
It's good.
Reviewed-by: Jeff Fan
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Saturday, May 09, 2015 2:52 AM
To: edk2-devel@lists.sourceforge.net
Cc: Fan, Jeff; Chen Fan; Justen, Jordan L
Subject: [PATCH 11/11] UefiCpuPkg: CpuDxe: provide EFI_MP_SERVICES_PROTOC
It looks good.
Reviewed-by: David Wei
Thanks,
David | SSG BIOS
From: Lu, ShifeiX A
Sent: Monday, May 11, 2015 5:03 PM
To: 'edk2-devel@lists.sourceforge.net'
Cc: Wei, David; He, Tim; Wu, Mike; Guo, Mang; Lu, ShifeiX A
Subject: [edk2][Patch] Vlv2TbltDevicePkg:Fixed SOURCE_DEBUG_ENABLE build error
It's good.
Reviewed-by: Jeff Fan
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Saturday, May 09, 2015 2:52 AM
To: edk2-devel@lists.sourceforge.net
Cc: Fan, Jeff; Chen Fan; Justen, Jordan L
Subject: [PATCH 10/11] UefiCpuPkg: CpuDxe: sync MTRR settings to APs at M
Andreas,
On 05/11/15 02:09, Andrew Fish wrote:
>
>> On May 10, 2015, at 4:20 PM, Andreas Galauner wrote:
>>
>> On 10.05.2015 15:32, Cohen, Eugene wrote:
>>> I apologize since this was probably not the answer you were looking for.
>>
>> No worries, it's kind of what I expected. Hence the question
On 05/08/15 21:31, Gabriel L. Somlo wrote:
> On Fri, May 08, 2015 at 08:51:53PM +0200, Laszlo Ersek wrote:
>> The PMBA_RTE and ACPI_TIMER_OFFSET macros apply equally to both boards,
>> plus they are triplicated between the various AcpiTimerLib instances.
>> Define them centrally in "OvmfPlatforms.h
On 05/11/15 11:04, Fan, Jeff wrote:
> 1. PCD PcdCpuMtrrTableAddress/PcdCpuSyncMtrrToAcpiNvs are not
> necessary now, due to there is no one total SMM-capable S3 resume. I
> think you could add them (if necessary) after one total SMM-capable
> S3 resume is verified.
The problem is that this leads
Hi Ting,
The problem is solved. There was an issue in the driver code. Thanks for
your prompt reply.
Thanks,
Sajeesh.
Message: 2
Date: Mon, 11 May 2015 07:22:03 +
From: "Ye, Ting"
Subject: Re: [edk2] SW VLAN IMPLEMENTATION QUESTION
To: "edk2-devel@lists.sourceforge.net"
Message-ID
> On May 11, 2015, at 2:19 AM, Laszlo Ersek wrote:
>
> Andreas,
>
> On 05/11/15 02:09, Andrew Fish wrote:
>>
>>> On May 10, 2015, at 4:20 PM, Andreas Galauner wrote:
>>>
>>> On 10.05.2015 15:32, Cohen, Eugene wrote:
I apologize since this was probably not the answer you were looking for
> On May 10, 2015, at 8:30 PM, Gao, Liming wrote:
>
> 2) Nasm build rules have been used for the other tool chain and platform.
> And, we also agree to use nasm in EDKII. I don’t think we can drop it now in
> the default configuration.
> 3) I don’t see those flags in build_rule.txt. I am curio
Thanks Ard, Your patch fixes the build but introduces a new issue (pointer
arithmetic). I pushed your change with the correct fix in SVN rev17410.
Thanks again for the fix!
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: 11 May 2015 08:36
To: edk2-devel@li
On 2015-05-08 11:51:50, Laszlo Ersek wrote:
> Move platform specific macros to their own include files. In addition,
> define some new macros for register addresses (both PCI and IO) and
> register values (bits).
How about adding the new definitions is a separate commit? If Split,
both would be Re
On 2015-05-11 03:21:38, Laszlo Ersek wrote:
> On 05/11/15 11:04, Fan, Jeff wrote:
> > 2. The patch introduced two new files with the different BSD license
> > header format from the other files in the same Package. I do not
> > suggest to use the different BSD license header here.
>
> I don't have
On 05/11/15 20:27, Jordan Justen wrote:
> On 2015-05-11 03:21:38, Laszlo Ersek wrote:
>> On 05/11/15 11:04, Fan, Jeff wrote:
>>> 2. The patch introduced two new files with the different BSD license
>>> header format from the other files in the same Package. I do not
>>> suggest to use the different
Hi Feng,
Need some help, as USB->SerialAdapter is not an option, I replaced with a
proper serial port, now I am having issues with Windbg on "DuetpkgIa32.dsc" FV
image?
Looks like I am getting a CPU exception? Not sure what is wrong?
Your help is so much appreciated
Thanks
Sai
Access violati
Liming, Amy,
I'm confused. I didn't even see the original post of the patch to
edk2-devel. Maybe Amy is not subscribed?
I don't think removing a feature (EDK II NASM support), and calling it
'Basetools update for CLAN support' is a good way to proceed.
Maybe just install NASM instead?
There was
On 2015-05-11 02:06:44, Wei, David wrote:
>It looks good.
What looks good? I don't think Shifei is subscribed to edk2-devel
because the original post did not go through.
-Jordan
>Reviewed-by: David Wei
>
>
>
>Thanks,
>
>David | SSG BIOS
>
>
>
>From: Lu, Shifei
Jordan:
For the feature that toolchain families to choose the priority for source
file extensions, the design is finished. We plan to implement it. Once this
feature is supported, I think Amy patch can use this way and not to remove NASM
build support.
BUILDRULEORDER key will be introduced
And the compiler name is clang (part of the LLVM open source project
http://llvm.org), the tools are installed as Xcode (the name of the target).
> On May 11, 2015, at 8:50 PM, Jordan Justen wrote:
>
> Liming, Amy,
>
> I'm confused. I didn't even see the original post of the patch to
> edk2-d
Andrew:
Yes. Those PCD can support Dynamic and DynamicEx. DxeIpl can use them instead
of EFI variable. But, Platform DSC should configure those PCDs as DynamicHii.
This is an impact for the existing platform. To minimize the impact, I suggest
to define those PCDs with all PCD types, and keep D
On 2015-05-11 20:59:40, Chan, Amy wrote:
> Sorry for typo.
> The change is not only for removing a feature (EDK II NASM support),
> we also have other updates.
>From Liming's version of your patch, this appears to be the extent of
the commit message:
===
Basetools update for CLAN support
Contrib
> On May 11, 2015, at 9:17 PM, Jordan Justen wrote:
>
> On 2015-05-11 20:59:40, Chan, Amy wrote:
>> Sorry for typo.
>> The change is not only for removing a feature (EDK II NASM support),
>> we also have other updates.
>
>> From Liming's version of your patch, this appears to be the extent of
>
On 2015-05-11 21:03:14, Gao, Liming wrote:
> Jordan:
> For the feature that toolchain families to choose the priority for
> source file extensions, the design is finished. We plan to
> implement it. Once this feature is supported, I think Amy patch
> can use this way and not to remove NASM
Add ESRT module. It is used to manage ESRT cache repository for
FMP or NonFMP instance
Zhang, Chao B (3):
MdePkg: Add Microsoft UX capsule GUID & layout
MdeModulePkg: Add ESRT management protocol definition
MdeModulePkg: Add ESRT management module.
MdeModulePkg/Include/Protocol/EsrtManage
Add Microsoft UX capsule GUID & layout into IndustryStandard
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chao Zhang
---
MdePkg/Include/IndustryStandard/WindowsUxCapsule.h | 46 ++
MdePkg/MdePkg.dec | 6 +++
2 files
Add ESRT management protocol definition into MdeModulePkg.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chao Zhang
---
MdeModulePkg/Include/Protocol/EsrtManagement.h | 144 +
MdeModulePkg/MdeModulePkg.dec | 20 +++-
MdeModulePkg
It provides a repository to cache ESRT info for FMP or Non-FMP instance.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chao Zhang
---
MdeModulePkg/MdeModulePkg.dsc | 1 +
MdeModulePkg/Universal/EsrtDxe/EsrtDxe.c| 652
> On May 11, 2015, at 9:16 PM, Gao, Liming wrote:
>
> Andrew:
> Yes. Those PCD can support Dynamic and DynamicEx. DxeIpl can use them
> instead of EFI variable. But, Platform DSC should configure those PCDs as
> DynamicHii. This is an impact for the existing platform. To minimize the
> impa
Sai,
What do you do on DuetPkg to enable SourceLevelDebug? We didn't enable and test
such use case. Do you see the connection of Windbg with target?
The exception is not printed by EDKII Duet, it's more like legacy bios.
Thanks
Feng
From: Saiprasad Chavali [mailto:s...@marvell.com]
Sent: Tuesd
When PcdTpmInstanceGuid is configured to other value,
it means other TPM 2.0 device.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao
---
SecurityPkg/SecurityPkg.dec | 1 +
SecurityPkg/SecurityPkg.uni | Bin 35500 -> 35774 bytes
2 files changed, 1 insertion(+)
This change will make DEBUG information be aligned with DEBUG_GCD enabled.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao
Reviewed-by: Star Zeng
---
MdeModulePkg/Core/Dxe/Gcd/Gcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdeModulePk
36 matches
Mail list logo
