Hi, Eric
I glance through your code, looks like SelectInterface() has a bug, in which
You set Request.RequestType = 0x0; but according to USB 2.0 spec 9.4.10, it
should be 0x01 for SET_INTERFACE request.
So which return value did you get for SelectInterface() invocation? It should
be EFI_DEVIC
Hello Larry and all,
Could you help review this patch? Thank you
[Description]
Update error message of installation failure to avoid confusion.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hess Chen mailto:hesheng.c...@intel.com>
>
Best Regards,
Chen, Hess
Intel China
Re-sending, since I realized I'd forgotten the Contributed-Under and
Signed-off-by labels.
The changes can also be seen at
https://github.com/bcran/edk2/blob/724514e9e1512b8e844c9727a1a8428946c4f91c/Vlv2TbltDevicePkg/PlatformSetupDxe/VfrStrings.uni
.
--
Bruce
From 724514e9e1512b8e844c9727a1a
This patch adds the support for PKCS7 Verification Protocol which
was defined in UEFI 2.5.
(NOTE: The VerifySignature interface was not supported in this
version, due to openssl interface limitation)
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qin Long
---
.../P
This patch adds one new API (Pkcs7GetAttachedContent) to support
PKCS7 Verification Protocol defined in UEFI 2.5.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qin Long
---
CryptoPkg/Include/Library/BaseCryptLib.h | 33 ++-
.../Library/BaseCryptLib/Pk/Cryp
This patch adds the support for PKCS7 Verification Protocl defined in
UEFI 2.5.
One new crypto API was added to support the embedded content extraction
in CryptoPkg. And only VerifyBuffer interface in PKCS7 Verificatio Protocol
is supported in this version. Another interface (VerifySignature) will
Reviewed-by: Liming Gao
From: Bi, Dandan
Sent: Tuesday, June 16, 2015 9:17 AM
To: 'edk2-devel@lists.sourceforge.net'; Dong, Eric; Gao, Liming
Subject: [patch] MdeModulePkg:System hangs in setup menu when RTC time rollover
1999 to 2000
Error processing of GetTime function:
If get time fail,the d
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni
Cc: Liming Gao
---
MdePkg/Library/DxeServicesLib/DxeServicesLib.c | 24 +---
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/MdePkg/Library/DxeServicesLib/DxeServicesLib.c
b/MdePk
Reviewed-by: Liming Gao
-Original Message-
From: Ni, Ruiyu
Sent: Wednesday, June 17, 2015 4:52 PM
To: edk2-devel@lists.sourceforge.net
Cc: Ni, Ruiyu; Gao, Liming
Subject: [Patch] MdePkg/DxeServicesLib: Return NULL GetFileBufferByFilePath
reads directory
Contributed-under: TianoCore Con
On 06/17/15 03:10, Peterson, Joe wrote:
> Hello all,
>
> There are a lot of conflicting ideas on how we should lay out our
> EDK2 repo using Git. We have Submodules, Subtrees, using soft links,
> etc. Some of the suggestions won't work for various reasons- ex. repo
> isn't supported on Windows, wh
Jordan,
I'm OK for the patches. Thanks for your contribution.
Reviewed-by: Yingke Liu
Dennis
-Original Message-
From: Justen, Jordan L
Sent: Friday, June 12, 2015 15:11
To: Liu, Yingke D; edk2-devel@lists.sourceforge.net
Subject: Re: [PATCH v4 00/10] Support UTF-8 in .uni string files
Hi, Jiaxin
The patch is ok with me.
Reviewed-by: Fu Siyuan
-Original Message-
From: jiaxinwu [mailto:jiaxin...@intel.com]
Sent: Thursday, June 04, 2015 4:03 PM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [Patch 0/2] *** SUBJECT HERE ***
*** BLURB HERE ***
jiaxinwu (2):
Fix
Scott:
Thanks for this full report. For the first, this failure should exist since
_DEBUG_PRINT is added in DebugLib.h. It exists for several months. No people
reports it. Seemly, there is no users to use the old DDK3790 chain. So, I think
you can remove this test from your validation scope.
What about removing toolchains that are not supported anymore? Like DDK3790?
Or are we waiting for tools_def.txt to reach 10,000 lines (it is only 7212
lines at the moment).
-Original Message-
From: Gao, Liming [mailto:liming@intel.com]
Sent: 17 June 2015 11:04
To: edk2-devel@lists.so
On 17 June 2015 at 11:38, Laszlo Ersek wrote:
> On 06/17/15 03:10, Peterson, Joe wrote:
>> Hello all,
>>
>> There are a lot of conflicting ideas on how we should lay out our
>> EDK2 repo using Git. We have Submodules, Subtrees, using soft links,
>> etc. Some of the suggestions won't work for vario
Tim:
I see your point. We are improving the process to avoid the change impact to
EDKII users, and open discussion on feature and bug fix before the commit. We
will try to avoid the similar case happen again. On PCD database case, it is
designed for internal use by PCD driver. So, we are not a
Hi all,
I want to know when MinnowMax firmware start to boot, where in source
firmware recognize HDMI and where can I find which information
interchange firmware with HDMI and which functions are use.
Best regards,
Anteja
Ard:
Subtree model requires to be kept in sync by automation. And, Subtree Repo is
still not upstream repo. Developer is required to move his change to upstream
repo and push it.
Yes. We can have multiple Repos like you. EDKII, SctPkg, InternalPkgs.
Developer needs to manually combine them
On 17 June 2015 at 14:21, Gao, Liming wrote:
> Ard:
> Subtree model requires to be kept in sync by automation. And, Subtree Repo
> is still not upstream repo. Developer is required to move his change to
> upstream repo and push it.
>
Indeed. Btw you never responded to my question below:
>> F
Ard:
Sorry, I have not tried this way. I assume it works and resolves the patch
generation. Besides, we find subtree Repo history is shown in the root
directory, not each sub package. Submodule shows the history for each package,
but no history in root.
Thanks
Liming
-Original Message---
Good point. I think we can separate tools_def.template to two template files.
One is for old tool chain, another is for current popular tool chain. Default
is current tool chain template. If user really wants to verify old tool chain,
he can use old template. If so, next is to scope which tool c
On 06/17/2015 05:03 AM, Gao, Liming wrote:
> Scott:
>Thanks for this full report. For the first, this failure should
> exist since _DEBUG_PRINT is added in DebugLib.h. It exists for several
> months. No people reports it. Seemly, there is no users to use the old
> DDK3790 chain. So, I think you
What function would you want to implement?
Display (including HDMI display interface) are initialized by Intel GOP
(Graphic OutPut Protocol) driver. It locates at
Vlv2MiscBinariesPkg\GOP\7.2.1011\RELEASE_VS2008x86\X64\IntelGopDriver.efi.
EFI_GRAPHICS_OUTPUT_PROTOCOL protocol, which is produced
Ahah, I knew this hidden link would make some people happy!
Hmm, I think the driver was on one of my old hard disk. I have just tried to
see if I can redo the work again. It took me a couple of hours :-/
Anyway, I sent the patch. It builds with GCC49. But as I said I have not tested
it.
-O
Hi Feng,
You are right. Once I fixed that everything works as expected. Thanks
for taking the time to review my code.
Best Regards,
Eric
> -Original Message-
> From: Tian, Feng [mailto:feng.t...@intel.com]
> Sent: Wednesday, June 17, 2015 12:14 AM
> To: Eric Wittmayer; edk2-devel@l
On 6/16/2015 7:10 PM, Peterson, Joe wrote:
> I know there was a lot of support and several requests to move to git, so I
> would like to understand a little more about why people feel subversion isn't
> working out for us.
If we do stay with subversion, I think we should consider moving away
fr
On Wed, Jun 17, 2015 at 2:38 AM, Laszlo Ersek wrote:
> On 06/17/15 03:10, Peterson, Joe wrote:
>> Hello all,
>>
>> There are a lot of conflicting ideas on how we should lay out our
>> EDK2 repo using Git. We have Submodules, Subtrees, using soft links,
>> etc. Some of the suggestions won't work fo
On 06/17/15 18:21, Olivier Martin wrote:
> Ahah, I knew this hidden link would make some people happy!
>
> Hmm, I think the driver was on one of my old hard disk. I have just
> tried to see if I can redo the work again. It took me a couple of
> hours :-/
Wow, thank you.
> Anyway, I sent the patc
On 6/17/2015 8:52 AM, Brian J. Johnson wrote:
>
> If DDK3790 is dropped, you should add support for another free
> (as-in-beer) Microsoft toolchain, such as the Windows 7 DDK:
> http://www.microsoft.com/en-us/download/details.aspx?id=11800
Is Visual Studio 2013 Community not free enough?
https://
On 06/17/2015 02:08 PM, Bruce Cran wrote:
> On 6/17/2015 8:52 AM, Brian J. Johnson wrote:
>>
>> If DDK3790 is dropped, you should add support for another free
>> (as-in-beer) Microsoft toolchain, such as the Windows 7 DDK:
>> http://www.microsoft.com/en-us/download/details.aspx?id=11800
>
> Is Visu
Hi Olivier,
Where can we have a peek at the patch. Is it already pushed to the public GIT
Regards,
Bhupesh
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, June 18, 2015 12:05 AM
> To: Olivier Martin
> Cc: edk2-devel@lists.sourceforge.net; Gupta Ruch
On 6/17/2015 1:13 PM, Brian J. Johnson wrote:
> No - it's not free for commercial use.
Ah, okay. How about VS 2013 Express?
--
Bruce
--
___
edk2-devel mailing list
edk2-devel@
Thanks for the great feedback -- you made me do more homework than I was
expecting which is not a bad thing.
Since we understand the problem and the fix, I think it's time to get Olivier's
review and approval to move forward.
Thanks,
Eugene
-Original Message-
From: Ard Biesheuvel [mai
> On Jun 17, 2015, at 3:01 PM, Cohen, Eugene wrote:
>
> Thanks for the great feedback -- you made me do more homework than I was
> expecting which is not a bad thing.
>
> Since we understand the problem and the fix, I think it's time to get
> Olivier's review and approval to move forward.
>
Andrew,
This change does not affect the PE/COFF output. The default linker script
(which is being replaced with this patch) put data 64KB beyond the last .text
in ELF but the PE/COFF conversion brought this in closer (it just uses ELF
section alignment values to place the next section). All t
Reviewed-by: lhauch
Cheers,
Larry
From: Chen, Hesheng
Sent: Wednesday, June 17, 2015 12:20 AM
To: Hauch, Larry; edk2-devel@lists.sourceforge.net
Subject: [edk2][Basetool][Upt][patch]Update error message of installation
failure
Hello Larry and all,
Could you help review this patch? Thank you
[
Reviewed-by: lhauch
Cheers,
Larry
From: Chen, Hesheng
Sent: Thursday, June 11, 2015 6:31 PM
To: Hauch, Larry; edk2-devel@lists.sourceforge.net
Subject: [edk2][Basetool][Upt][patch]Update help message of UPT
Hello Larry and all,
Could you help review this patch? Thank you
[Description]
Update h
The SMM Exit Boot Service protocol is to be published by the SMM
Foundation code to associate with EFI_EVENT_GROUP_EXIT_BOOT_SERVICES
to notify SMM driver that system enter exit boot services.
The SMM Legacy Boot protocol is to be published by the SMM
Foundation code to associate with EFI_EVENT_LE
Thank you, Star.
I think it is good design because any SMM drivers can get protocol notify on
what happened in DXE phase, then there is no need to let each individual SMM
driver to register Communication Handler for that.
Will you consider adding ReadyToBoot as well?
I found SMM Variable driver
And also SMM Ready To Boot.
The SMM Exit Boot Service protocol is to be published by the SMM
Foundation code to associate with EFI_EVENT_GROUP_EXIT_BOOT_SERVICES
to notify SMM driver that system enter exit boot services.
The SMM Legacy Boot protocol is to be published by the SMM
Foundation code t
Thanks for your great comments and Reviewed-by.
I have resent the patch V2 with some added commit log queried from your great
comments and Reviewed-by.
Thanks,
Star
-Original Message-
From: Yao, Jiewen
Sent: Thursday, June 18, 2015 10:42 AM
To: Zeng, Star; edk2-devel@lists.sourceforge.n
Thanks for the patch Olivier!
As you said that this patch is not tested, is it taken from some tested
reference? As it’s a huge untested patch :)
Regards,
Shaveta
-Original Message-
From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: Wednesday, June 17, 2015 9:51 PM
To: Laszlo E
On 4 June 2015 at 10:03, jiaxinwu wrote:
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Wu Jiaxin
> Signed-off-by: jiaxinwu
This patch is breaking the GCC build on ARM. Please see below.
Also, the patch in the repository has a different title and some
Reviewed-by's
Thanks. It seems complete now.
I just thought another thing: Should we unregister the event handler, once it
is served?
Thank you
Yao Jiewen
-Original Message-
From: Star Zeng [mailto:star.z...@intel.com]
Sent: Thursday, June 18, 2015 11:16 AM
To: edk2-devel@lists.sourceforge.net
Subje
On 18 June 2015 at 00:01, Cohen, Eugene wrote:
> Thanks for the great feedback -- you made me do more homework than I was
> expecting which is not a bad thing.
>
> Since we understand the problem and the fix, I think it's time to get
> Olivier's review and approval to move forward.
>
I would st
When the file is empty, make FileHandleReadLine in FileHandleLib return
EFI_SUCCESS instead of EFI_BUFFER_TOO_SMALL.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
---
.../Library/UefiFileHandleLib/UefiFileHandleLib.c | 41 ++
1 file chang
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng
---
MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 2 +-
MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCore
Cc: Jiewen Yao
Star Zeng (2):
MdePkg: Enhance the comments in SmmEndOfDxe.h and SmmReadyToLock.h.
MdeModulePkg PiSmmCore: Unregister end of dxe notification in
SmmReadyToLock.
MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 2 +-
MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c | 2 +-
MdePkg/Include
Good point. See the attached V3 patch.
I found PI spec has description for SmmReadyToLockProtocol "This protocol is a
mandatory protocol published by the SMM Foundation code when the system is
preparing to lock SMM. This protocol should be installed immediately after
EFI_END_OF_DXE_EVENT_GROUP_
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng
---
MdePkg/Include/Protocol/SmmEndOfDxe.h| 3 ++-
MdePkg/Include/Protocol/SmmReadyToLock.h | 5 +++--
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/MdePkg/Include/Protocol/SmmEndO
Good. Thanks!
Reviewed by: Yao, Jiewen
-Original Message-
From: Zeng, Star
Sent: Thursday, June 18, 2015 1:41 PM
To: Yao, Jiewen; edk2-devel@lists.sourceforge.net
Subject: RE: [edk2] [PATCH V2] MdeModulePkg PiSmmCore: Introduce SMM Exit Boot
Services and Legacy Boot.
Good point. See th
Looks good.
Reviewed-by: Yao, Jiewen
-Original Message-
From: Zeng, Star
Sent: Thursday, June 18, 2015 1:41 PM
To: edk2-devel@lists.sourceforge.net
Cc: Yao, Jiewen
Subject: [PATCH 2/2] MdeModulePkg PiSmmCore: Unregister end of dxe notification
in SmmReadyToLock.
Cc: Jiewen Yao
Contrib
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: jiaxinwu
---
MdeModulePkg/Library/DxeNetLib/DxeNetLib.c | 199 +++
MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf | 11 +-
2 files changed, 24 insertions(+), 186 deletions(-)
diff --git a/MdeModulePkg
53 matches
Mail list logo
