The BuildOptions in an INF should also follow override rule: If '==' is used,
all other options with '=' are overridden.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yingke Liu
---
BaseTools/Source/Python/AutoGen/AutoGen.py | 14 --
.../Source/Pyt
Reviewed-by: Ruiyu Ni
> -Original Message-
> From: Liming Gao [mailto:liming@intel.com]
> Sent: Tuesday, June 30, 2015 2:12 PM
> To: edk2-devel@lists.sourceforge.net
> Subject: [edk2] [Patch 0/3] Update driver to handle LoadFile device path
>
> UEFI Spec HTTP Boot Device Path, after
I think they are saying A.dsc includes B.dsc, which nestly includes C.dsc.
I vote Andrew’s solution to provide the correct line number. It’s not a complex
problem for tool to resolve.
From: Gao, Liming [mailto:liming@intel.com]
Sent: Wednesday, July 1, 2015 10:34 AM
To: edk2-devel@lists.sourc
On 2015-06-30 02:01:24, Star Zeng wrote:
> AuthVariableLib and TpmMeasurementLib library classes are now linked with
> MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf
> to optionally support secure variables.
>
> For Nt32Pkg,
> link AuthVariableLib and DxeTpmMeasurementLib in Sec
Ok, miss understanding.
"
> Nt32Pkg: Link AuthVariableLib for following merged variable driver
> deploy.
> OvmfPkg: Link AuthVariableLib for following merged variable driver
> deploy.
For these two, do you think the commit message could be improved similar to my
EmulatorPkg suggestio
1. When Property->Attributes == 0, don't check input Attributes.
2. Enhance comments to be indent aligned and debug message
to be aligned with other messages.
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng
---
.../Universal/Variable/RuntimeDxe/Va
Looks good.
Reviewed-by: Yao, Jiewen
-Original Message-
From: Zeng, Star
Sent: Wednesday, July 01, 2015 3:31 PM
To: edk2-devel@lists.sourceforge.net
Cc: Yao, Jiewen
Subject: [PATCH] MdeModulePkg Variable: Minor enhancement to VarCheck
1. When Property->Attributes == 0, don't check inpu
Unsafe string functions are replaced with safe ones.
Safe string functions will assert if DestMax is not greater than
StrnLenS(Source, DestMax). Therefore, additional assert for checking the
size of source and destination buffers can be removed.
Contributed-under: TianoCore Contribution Agreement
On 2015-07-01 00:26:26, Zeng, Star wrote:
> Ok, miss understanding.
>
> "
> > Nt32Pkg: Link AuthVariableLib for following merged variable driver
> > deploy.
> > OvmfPkg: Link AuthVariableLib for following merged variable driver
> > deploy.
> For these two, do you think the commit mess
On 30 June 2015 at 13:02, Gao, Liming wrote:
> Reviewed-by: Liming Gao
>
Hello Dennis,
Thanks for merging this.
Next time, could you please keep the subject line as well?
> Subject: [PATCH] BaseTools: fix a syntax error in 4 KB aligned GNU ld linker
> script
You have used this instead:
> T
On 30 June 2015 at 06:12, Roy Franz wrote:
> Replace the 38 identical Contributions.txt in subdirectories with a single
> copy at the top level.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Roy Franz
I agree that the duplication seems wasteful, but how is this sup
On 30 June 2015 at 06:12, Roy Franz wrote:
> Add a description of how to describe the authorship of a patch that
> is submitted by someone other than the original author.
> Add mention of git format-patch options for generating
> more useful patch names in diffstat.
>
> Contributed-under: TianoCor
Hi Ard,
Thanks for the comments, I have updated the log message.
Thanks,
Dennis
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Wednesday, July 01, 2015 16:12
To: Liu, Yingke D
Cc: edk2-devel@lists.sourceforge.net; Justen, Jordan L; Gao, Liming
Subject:
Laszlo,
Thanks for reminder. The missing code was checked in @17791.
Thanks,
Guo
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Friday, June 26, 2015 8:22 PM
To: Dong, Guo
Cc: edk2-devel list; Gerd Hoffmann (GMail address)
Subject: SVN r17714 broke the Coreboot
@Olivier: do you have any comments on this patch?
On 29 June 2015 at 23:22, Cohen, Eugene wrote:
> Reviewed-by: Eugene Cohen
>
> Thanks.
>
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Monday, June 29, 2015 12:37 PM
> To: edk2-devel@lists.sourcef
Hello,
I tried with IOCTL, but problem was I couldn't open driver file with
CreateFile method because I couldn't find path ( something like this
.\\PCI#VEN_8086&DEV_0F0E&SUBSYS_72708086&REV_0C#3&11583659&0&F5#{badc33d6-be37-4372-b90e-bbf2d986b0eb}
). For UART I have iaiouart.sys driver and
Reviewed-by: Tapan Shah mailto:tapands...@hp.com>>
From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Tuesday, June 30, 2015 4:35 PM
To: Qiu, Shumin; Shah, Tapan
Cc: edk2-devel@lists.sourceforge.net; El-Haj-Mahmoud, Samer; Carsey, Jaben
Subject: RE: [Patch] ShellPkg: fix string to number co
Reviewed-by: Tapan Shah <>
-Original Message-
From: Qiu Shumin [mailto:shumin@intel.com]
Sent: Tuesday, June 30, 2015 9:24 PM
To: edk2-devel@lists.sourceforge.net
Cc: jeff@intel.com; jaben.car...@intel.com; Shah, Tapan
Subject: [PATCH] ShellPkg: Refine the code logic of StrnCatGro
Oliver,
Can you please help review this ?
-Original Message-
From: El-Haj-Mahmoud, Samer
Sent: Sunday, June 28, 2015 11:42 AM
To: edk2-devel@lists.sourceforge.net
Cc: olivier.mar...@arm.com
Subject: RE: [PATCH] ArmPlatformPkg: Allow PcdFirmwareVersionString to be a
dynamic PCD
PcdFir
Reviewed-By: Olivier Martin
-Original Message-
From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hp.com]
Sent: 01 July 2015 15:26
To: edk2-devel@lists.sourceforge.net
Cc: Olivier Martin
Subject: RE: [PATCH] ArmPlatformPkg: Allow PcdFirmwareVersionString to be a
dynamic PCD
Oliver
I am guessing your question is to make the USB XHCI controller memory mapped
device instead of relying on the PCI IO protocol.
There were some discussions on the EDK2 mailing-list few years ago about
disconnecting the USB Host controller DXE driver from PCI IO driver.
The UEFI spec does not mand
Version3 update mainly include comments from reviewer:
Recover renamed and removed string tokens in uni file.
Update ifconfig help info by using the standard shell output message.
Remove redundant string tokens for ifconfig compared to version2.
Remove redundant parameter in private data structure
Hi Tapan,
Thank you for your comments, I have updated patch according below and other
reviewers comments.
For the copyright, I have confirm that HP's copyright should be kept, I have
recovered it and just update Intel copyright year.
Best Regards!
Jiaxin
-Original Message-
From: edk2-de
Jiaxin,
Can you send out an updated patch file for review?
Thanks,
Tapan
-Original Message-
From: Wu, Jiaxin [mailto:jiaxin...@intel.com]
Sent: Wednesday, July 01, 2015 10:55 AM
To: Shah, Tapan; edk2-devel@lists.sourceforge.net
Subject: RE: Re: [Patch] ShellPkg: Update ShellPkg ping/i
On Wed, Jul 1, 2015 at 1:20 AM, Ard Biesheuvel
wrote:
> On 30 June 2015 at 06:12, Roy Franz wrote:
>> Replace the 38 identical Contributions.txt in subdirectories with a single
>> copy at the top level.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Roy Franz
>
>
On Wed, Jul 1, 2015 at 1:22 AM, Ard Biesheuvel
wrote:
> On 30 June 2015 at 06:12, Roy Franz wrote:
>> Add a description of how to describe the authorship of a patch that
>> is submitted by someone other than the original author.
>> Add mention of git format-patch options for generating
>> more us
> On Jun 30, 2015, at 7:34 PM, Gao, Liming wrote:
>
> This case? I think it is supported. We have similar cases that can work.
>
> !include A.dsc
> !include B.dsc
>
>
I hit a case where this failed. But only if no parseable data was between the
!include statements. Maybe it has been fixe
I still see this case as well Andrew. I have a fix in my local repo. I will try
to submit a patch.
From: Andrew Fish [mailto:af...@apple.com]
Sent: Wednesday, July 01, 2015 12:55 PM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] Question on DSC double includes
On Jun 30, 2015, at 7:34
Ting,
What is the reason for wanting the registration moved from the IP driver's
entry point to DriverBindingStart()? The EfiIpSec2Protocol is installed in the
IpSecDxe driver's entry point, so why wait until DriverBinding to register? The
IP driver's notify function will get called anytime the
SourceLevelDebugPkg maintainers,
I noticed what looks like a regression in the SecPeiDebugAgentLib.
InitializeDebugAgent() calls SaveAndSetDebugTimerInterrupt() before a
normal return, but it is not called when execution continues via
InitializeDebugAgentPhase2(), as in the DEBUG_AGENT_INIT_PRE
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Shah, Tapan [mailto:tapands...@hp.com]
> Sent: Wednesday, July 01, 2015 7:22 AM
> To: Qiu, Shumin; edk2-devel@lists.sourceforge.net
> Cc: Fan, Jeff; Carsey, Jaben
> Subject: RE: [PATCH] ShellPkg: Refine the code logic of StrnCatGrow.
One question below.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Hao Wu [mailto:hao.a...@intel.com]
> Sent: Wednesday, July 01, 2015 1:00 AM
> To: edk2-devel@lists.sourceforge.net
> Subject: [edk2] [PATCH] FatPkg EnhancedFatDxe: Use safe string functions
>
> Unsafe string func
Reviewed-by: Jaben Carsey
> -Original Message-
> From: jiaxinwu [mailto:jiaxin...@intel.com]
> Sent: Wednesday, July 01, 2015 8:45 AM
> To: edk2-devel@lists.sourceforge.net
> Subject: [edk2] [Patch] Update ShellPkg ping/ifconfig library.
> Importance: High
>
> Version3 update mainly incl
On 07/01/2015 11:04 AM, El-Haj-Mahmoud, Samer wrote:
> Some feedback :
>
> We need to add ARM support as well, in addition to x64/IA32:
Besides client-side checks, is there any info for the HTTP server? Some
instructions on what the HTTP server requirements are, and how to
configure the server wou
In the future, can you use git bash with 'git send-email *.patch' so
all the emails in your patch series will be sent as a single email
thread?
The TortoiseGit GUI can't do this correctly. I think that you'll also
find that 'git send-email *.patch' is faster.
Thanks,
-Jordan
On 2015-06-25 00:47
On 2015-07-01 01:34:56, Liu, Yingke D wrote:
> Hi Ard,
>
> Thanks for the comments, I have updated the log message.
For future reference, I think you should not bother to update the log
message. It is a bad practice, and the git archive will not see the
updated log message anyhow. It should also
Hi Tapan,
I have already sent out the patch to edk2-devel.
Thanks.
Jiaxin
-Original Message-
From: Shah, Tapan [mailto:tapands...@hp.com]
Sent: Thursday, July 2, 2015 1:00 AM
To: Wu, Jiaxin; edk2-devel@lists.sourceforge.net
Subject: RE: Re: [Patch] ShellPkg: Update ShellPkg ping/ifconfig
Jordan:
Agree. We will follow this rule, apply the patch and push it without any
modification.
gcc-4k is added for new UEFI2.5 Properties Table. When enable this feature,
gcc-4k script will be required for RUNTIME driver. It can be configured in
[BuildOptions] of DSC file for RUNTIME drive
On 2015-07-01 17:41:11, Gao, Liming wrote:
> Jordan:
> Agree. We will follow this rule, apply the patch and push it
> without any modification.
My point is that if there is a mistake, we should not bother to update
the log message to fix that mistake. Hopefully we can just be more
careful with
Jiaxin, I think he meant to ask for the attachment .patch file.
>-Original Message-
>From: Wu, Jiaxin [mailto:jiaxin...@intel.com]
>Sent: Wednesday, July 01, 2015 5:42 PM
>To: Shah, Tapan; edk2-devel@lists.sourceforge.net
>Subject: Re: [edk2] [Patch] ShellPkg: Update ShellPkg ping/ifconfi
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Samer El-Haj-Mahmoud
---
BaseTools/Source/Python/GenFds/FdfParser.py | 9 +
1 file changed, 9 insertions(+)
diff --git a/BaseTools/Source/Python/GenFds/FdfParser.py
b/BaseTools/Source/Python/GenFds/FdfParser.py
index
Jaben, attachment .patch and UNI files have been sent to Tapan.
Thanks.
-Original Message-
From: edk2-devel-requ...@lists.sourceforge.net
[mailto:edk2-devel-requ...@lists.sourceforge.net]
Sent: Thursday, July 2, 2015 9:02 AM
To: edk2-devel@lists.sourceforge.net
Subject: edk2-devel Diges
This feature is complete. But, there is no example now. So, I plan to add the
example in OVMF to show how to enable it.
-Original Message-
From: Justen, Jordan L
Sent: Thursday, July 2, 2015 8:54 AM
To: Gao, Liming; Liu, Yingke D; Ard Biesheuvel
Cc: edk2-devel@lists.sourceforge.net
Subj
Reviewed-by: Liming Gao
-Original Message-
From: Yingke Liu [mailto:yingke.d@intel.com]
Sent: Wednesday, July 1, 2015 3:02 PM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [Patch] BaseTools: Fixed BuildOptions bug.
The BuildOptions in an INF should also follow override rule:
Hi Samer,
I think you are right. Previously I think we normally keep driver's entry point
simple and add more logic to driver binding start(). I agree that this is a
case we'd better put into driver's entry point to avoid each NIC to check
whether IPsec protocol available redundantly.
Best Reg
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng
---
MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
b/MdeModulePkg
Reviewed by: Yao, Jiewen
-Original Message-
From: Zeng, Star
Sent: Thursday, July 02, 2015 9:43 AM
To: edk2-devel@lists.sourceforge.net
Cc: Yao, Jiewen
Subject: [PATCH] MdeModulePkg: Fix EBC build failure.
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-of
Thanks Ting
I will submit ver 2 that uses EfiCreateProtocolNotifyEvent()
-Original Message-
From: Ye, Ting [ting...@intel.com]
Received: Wednesday, 01 Jul 2015, 8:42PM
To: edk2-devel@lists.sourceforge.net [edk2-devel@lists.sourceforge.net]
Subject: Re: [edk2] [PATCH] NetworkPkg: Locate
+ edk2 list and authors of the patch
Regards,
Bhupesh
> -Original Message-
> From: boot-architecture [mailto:boot-architecture-
> boun...@lists.linaro.org] On Behalf Of Meenakshi Aggarwal
> Sent: Wednesday, July 01, 2015 6:29 PM
> To: boot-architect...@lists.linaro.org
> Subject: Ext2/Ex
Johnson,
Thanks your fix. I verified it in SourceLevelDebugPkg, it works well.
Could you re-send the patch after refined the commit log format to add
TianoCore Contribution Agreement and Signed-off-by section?
Thanks!
Jeff
-Original Message-
From: Brian J. Johnson [mailto:bjohn...@sgi
Hi Samer,
Thanks for your patch, after take a look at the issue, I found another bug in
FDF parser. Following patch fixed both issues:
If there are two continuous !include lines, the second !include is ignored.
Also if the last line in !include file is not ends with '\r' or '\n', a '\n'
should
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng
---
MdeModulePkg/MdeModulePkg.dec | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
index a067384..18e519c 100644
--- a/
On 2 July 2015 at 02:54, Jordan Justen wrote:
> On 2015-07-01 17:41:11, Gao, Liming wrote:
>> Jordan:
>> Agree. We will follow this rule, apply the patch and push it
>> without any modification.
>
> My point is that if there is a mistake, we should not bother to update
> the log message to fix
Reviewed-by: Star Zeng
-Original Message-
From: Liming Gao [mailto:liming@intel.com]
Sent: Tuesday, June 30, 2015 2:12 PM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [Patch] MdeModulePkg: Merge GCD range before convert it to EFI
memory
GCD Range is byte address. EFI memory
Ard:
Good to know --script option can be appended and work fine.
Thanks
Liming
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Thursday, July 02, 2015 1:05 PM
To: Justen, Jordan L
Cc: Gao, Liming; Liu, Yingke D; edk2-devel@lists.sourceforge.net
Subject:
Reviewed-by: Liming Gao
-Original Message-
From: Zeng, Star
Sent: Thursday, July 02, 2015 11:26 AM
To: edk2-devel@lists.sourceforge.net
Cc: Gao, Liming
Subject: [PATCH] MdeModulePkg: Correct AuthVaribleLib to AuthVariableLib in
LibraryClass path
Cc: Liming Gao
Contributed-under: Tiano
Thanks Yingke,
If your patch fixes both issues then that is great! Let's go with your patch.
Reviewed-by: Samer El-Haj-Mahmoud
Thanks,
Samer
-Original Message-
From: Liu, Yingke D [yingke.d@intel.com]
Received: Wednesday, 01 Jul 2015, 11:21PM
To: El-Haj-Mahmoud, Samer [samer.e
Hi Ronathan,
I have below comments:
1. I add below build option in the inf to pass build:
[BuildOptions]
# Override MSFT build option to remove /Oi and /GL
MSFT:DEBUG_*_IA32_CC_FLAGS == /nologo /c /WX /GS- /W4 /Gs32768 /D UNICODE
/O1b2 /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /Gm
MSFT:R
On 2015-07-01 22:35:12, Gao, Liming wrote:
> Ard:
> Good to know --script option can be appended and work fine.
So, --script will be specified twice to ld. This seems like a very
fragile implementation of a new UEFI feature.
Is this the long term plan?
Do Visual Studio based builds do somethi
On 2 July 2015 at 08:08, Jordan Justen wrote:
> On 2015-07-01 22:35:12, Gao, Liming wrote:
>> Ard:
>> Good to know --script option can be appended and work fine.
>
> So, --script will be specified twice to ld. This seems like a very
> fragile implementation of a new UEFI feature.
>
> Is this the
Jordan:
On VS tool chain, we override /ALIGN option to configure 4K alignment for
runtime driver.
[BuildOptions.X64.EDKII.DXE_RUNTIME_DRIVER]
MSFT:*_*_*_DLINK_FLAGS = /ALIGN:4096
Thanks
Liming
-Original Message-
From: Justen, Jordan L
Sent: Thursday, July 02, 2015 2:08 PM
To: Gao,
Sent from my iPhone
> On Jul 1, 2015, at 11:08 PM, Jordan Justen wrote:
>
>> On 2015-07-01 22:35:12, Gao, Liming wrote:
>> Ard:
>> Good to know --script option can be appended and work fine.
>
> So, --script will be specified twice to ld. This seems like a very
> fragile implementation of a
On 2 July 2015 at 08:22, Andrew Fish wrote:
>
>
> Sent from my iPhone
>
>> On Jul 1, 2015, at 11:08 PM, Jordan Justen wrote:
>>
>>> On 2015-07-01 22:35:12, Gao, Liming wrote:
>>> Ard:
>>> Good to know --script option can be appended and work fine.
>>
>> So, --script will be specified twice to ld
On Wed, Jul 01, 2015 at 10:23:44AM +0800, Qiu Shumin wrote:
> In order to indicate the catena length use StrnCatS instead of StrCatS to
> generate Destination string, and update the DestMax of Destination string.
>
I just found the latest OVMF crashed when loading the shell, and this patch
works
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
Reviewed-by: Jiewen Yao
---
MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c| 2 +-
.../PropertiesTableAttributesDxe/PropertiesTableAttributesDxe.c | 2 ++
2 files changed, 3 inserti
On 2 July 2015 at 08:38, Ard Biesheuvel wrote:
> Liming, Jordan, Jiewen.
>
> I appeared to have screwed up something performing the push
>
> Could you please rewind SVN to r17801 ?
>
Apologies for sounding a bit panicky, but it would be useful if those
commits could be removed before the sync to
66 matches
Mail list logo
