[edk2] [Patch 5/6] MdePkg: Add two PcdApi for Patch VOID* PCD set operation.

2015-08-18 Thread Liming Gao
Two new APIs LibPatchPcdSetPtrAndSize() and LibPatchPcdSetPtrAndSizeS() are added to catch the size of the updated VOID* PCD value buffer, then PcdGetSize() API can return the actual size. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao liming@intel.com ---

Re: [edk2] [PATCH v2 00/16] unify GCC command line options

2015-08-18 Thread Ard Biesheuvel
On 17 August 2015 at 21:16, David Woodhouse dw...@infradead.org wrote: See http://www.infradead.org/rpr.html X-SRS-Rewrite: SMTP reverse-path rewritten from dw...@infradead.org by twosheds.infradead.org See http://www.infradead.org/rpr.html On 2015-08-17 11:25:41, David Woodhouse wrote:

[edk2] [Patch 3/6] BaseTools: Update SetPcdPtr in AutoGen Code

2015-08-18 Thread Liming Gao
For patchable PCD, map SetPcdPtr() to LibPatchPcdSetPtrAndSize(), then the size of the updated VOID* value can be cached. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao liming@intel.com --- BaseTools/Source/Python/AutoGen/GenC.py | 8 1 file

[edk2] [Patch 6/6] SecurityPkg: Use PcdGetSize to get the size of VOID* PCD value.

2015-08-18 Thread Liming Gao
PcdLib introduces generic API to get the size of VOID* PCD value. Update Pei and Dxe RsaGuidedLib to use generic PCD API instead of GetEx API. This change can remove PCD type limitation in these two libraries. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao

[edk2] [Patch 0/6] Add generic PcdGetSize() API

2015-08-18 Thread Liming Gao
PcdLib LibPcdGetSize() and LibPcdGetExSize() are type specific API. New generic PcdGetSize() API will be added to reterieve the size of PCD value. Like PcdGetValue(), it supports all PCD types and all PCD data types. BaseTools generates PCD size macros in AutoGen code. MdePkg PcdLib adds

[edk2] [Patch 1/6] BaseTools: Generate macro for the size of PCD value

2015-08-18 Thread Liming Gao
PcdLib introduces new APIs to get the size of PCD value. BaseTools generates those macros in AutoGen code. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Bob Feng bob.c.f...@intel.com --- BaseTools/Source/Python/AutoGen/GenC.py | 70 ++--- 1

[edk2] [Patch 2/6] BaseTools: Fix AutoGen issue for Patchable VOID* PCD.

2015-08-18 Thread Liming Gao
Patchable VOID* PCD set operation should map LibPatchPcdSetPtr() and LibPatchPcdSetPtrS() API. This has been done when PCD is used in driver, but not done when PCD is used in library. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao liming@intel.com ---

Re: [edk2] [PATCH 1/3] ArmPlatformPkg: PL061: fix accessing GPIO DATA

2015-08-18 Thread Haojian Zhuang
On Tue, 2015-08-18 at 10:45 +0200, Ard Biesheuvel wrote: On 18 August 2015 at 10:39, Haojian Zhuang haojian.zhu...@linaro.org wrote: // All bits low except one bit high, restricted to 8 bits // (i.e. ensures zeros above 8bits) But '' is wrong at here. It'll only return 1 or 0 as the

[edk2] EFI_FILE_PROTOCOL Read my files on local disk

2015-08-18 Thread zaman khan
Hello, I am trying to read a file on the local disk from an UEFI app (that I'm executing using NT32). I am new to the programming of it. Could some one please point me in the right direction. Thanks. ___ edk2-devel mailing list edk2-devel@lists.01.org

Re: [edk2] [PATCH v2 00/16] unify GCC command line options

2015-08-18 Thread Ard Biesheuvel
On 17 August 2015 at 20:53, Jordan Justen jordan.l.jus...@intel.com wrote: On 2015-08-17 11:25:56, Ard Biesheuvel wrote: On 17 August 2015 at 20:22, Jordan Justen jordan.l.jus...@intel.com wrote: Can't you use an elf-based GCC4.9 with the GCC49 toolchain instead? I'm not sure it makes

[edk2] [PATCH v3 0/3] support multiple PL061 gpio controllers

2015-08-18 Thread Haojian Zhuang
*** BLURB HERE *** Changelog: v3: * Remove GPIO_PIN_MASK_HIGH_8BIT() and GPIO_PIN_MASK_LOW_8BIT(). * Avoid to use MmioAnd8() on updating GPIO DATA register, since PL061 could access each bit by specified register offset. * Add PLATFORM_GPIO_CONTROLLER structure in embedded

[edk2] [Basetool][ECC][patch]Remove the checkpoint for STATIC modifer

2015-08-18 Thread Chen, Hesheng
Hello Yang and all, Could you help review this patch? Thank you [Description] 1. Remove the checkpoint for STATIC modifier Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hess Chen hesheng.c...@intel.commailto:hesheng.c...@intel.com Best Regards, Chen, Hess

Re: [edk2] [PATCH 13/15] ArmVirtPkg: Link separated VarCheckUefiLib NULL class library instance

2015-08-18 Thread Ard Biesheuvel
On 17 August 2015 at 10:24, Star Zeng star.z...@intel.com wrote: Cc: Laszlo Ersek ler...@redhat.com Cc: Ard Biesheuvel ard.biesheu...@linaro.org Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng star.z...@intel.com Reviewed-by: Ard Biesheuvel

Re: [edk2] [PATCH 14/15] ArmPlatformPkg: Link separated VarCheckUefiLib NULL class library instance

2015-08-18 Thread Ard Biesheuvel
On 17 August 2015 at 10:24, Star Zeng star.z...@intel.com wrote: Cc: Leif Lindholm leif.lindh...@linaro.org Cc: Ard Biesheuvel ard.biesheu...@linaro.org Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng star.z...@intel.com Reviewed-by: Ard Biesheuvel

Re: [edk2] [PATCH 0/3] unify FVP Base and Foundation model support

2015-08-18 Thread Leif Lindholm
On Tue, Aug 18, 2015 at 01:15:54PM +0200, Ard Biesheuvel wrote: On 12 August 2015 at 08:45, Ard Biesheuvel ard.biesheu...@linaro.org wrote: Instead of omitting some drivers that are known to break the Foundation model when ARM_FOUNDATION_FVP is defined, fix those drivers so that they simply

Re: [edk2] [PATCH 3/3] ArmPlatformPkg: PL061: support multiple controller

2015-08-18 Thread Ard Biesheuvel
On 18 August 2015 at 14:30, Haojian Zhuang haojian.zhu...@linaro.org wrote: On Tue, 2015-08-18 at 11:43 +0200, Ard Biesheuvel wrote: On 18 August 2015 at 11:31, Haojian Zhuang haojian.zhu...@linaro.org wrote: On Tue, 2015-08-18 at 11:22 +0200, Ard Biesheuvel wrote: On 18 August 2015 at

Re: [edk2] [PATCH 07/15] ArmPlatformPkg: Add VarCheckLib library mapping

2015-08-18 Thread Ard Biesheuvel
On 17 August 2015 at 10:24, Star Zeng star.z...@intel.com wrote: Since Variable driver has been updated to consume the separated VarCheckLib. Cc: Leif Lindholm leif.lindh...@linaro.org Cc: Ard Biesheuvel ard.biesheu...@linaro.org Contributed-under: TianoCore Contribution Agreement 1.0

Re: [edk2] [PATCH 06/15] ArmVirtPkg: Add VarCheckLib library mapping

2015-08-18 Thread Ard Biesheuvel
On 17 August 2015 at 10:24, Star Zeng star.z...@intel.com wrote: Since Variable driver has been updated to consume the separated VarCheckLib. Cc: Laszlo Ersek ler...@redhat.com Cc: Ard Biesheuvel ard.biesheu...@linaro.org Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by:

Re: [edk2] [PATCH 0/5] secure boot support for ARM FVP

2015-08-18 Thread Ard Biesheuvel
On 8 August 2015 at 14:00, Ard Biesheuvel ard.biesheu...@linaro.org wrote: This series adds support for using the Intel BDS with ArmVExpress-FVP, and for building it with UEFI Secure Boot enabled. Note that the former is a prerequisite of the latter, since the ARM BDS has no GUI for enrolling

Re: [edk2] [PATCH 0/3] unify FVP Base and Foundation model support

2015-08-18 Thread Ard Biesheuvel
On 18 August 2015 at 14:12, Leif Lindholm leif.lindh...@linaro.org wrote: On Tue, Aug 18, 2015 at 01:15:54PM +0200, Ard Biesheuvel wrote: On 12 August 2015 at 08:45, Ard Biesheuvel ard.biesheu...@linaro.org wrote: Instead of omitting some drivers that are known to break the Foundation model

Re: [edk2] [PATCH 0/3] unify FVP Base and Foundation model support

2015-08-18 Thread Ard Biesheuvel
On 12 August 2015 at 08:45, Ard Biesheuvel ard.biesheu...@linaro.org wrote: Instead of omitting some drivers that are known to break the Foundation model when ARM_FOUNDATION_FVP is defined, fix those drivers so that they simply fail to load without interfering with the boot. This way, we can

Re: [edk2] [PATCH 0/2] AARCH64 tiny code model support

2015-08-18 Thread Ard Biesheuvel
On 10 August 2015 at 12:27, Ard Biesheuvel ard.biesheu...@linaro.org wrote: The AARCH64 GCC builds use the GCC large code model by default, simply because it is the code model that requires the least amount of hacking to produce code that supports the PE/COFF conversion applied by Tianocore.

Re: [edk2] [PATCH v2 00/16] unify GCC command line options

2015-08-18 Thread Bruce Cran
On 8/18/2015 10:26 AM, Ard Biesheuvel wrote: Ultimately, it would be useful to have a subset of platforms/toolchains that need to pass before a patch is accepted, but I am aware that we are still far away from anything like that. For internal use, I have set up some infrastructure that we can

Re: [edk2] [PATCH v2 00/16] unify GCC command line options

2015-08-18 Thread Ard Biesheuvel
On 18 August 2015 at 19:35, David Woodhouse dw...@infradead.org wrote: On Tue, 2015-08-18 at 17:52 +0200, Ard Biesheuvel wrote: On 18 August 2015 at 17:19, Jordan Justen jordan.l.jus...@intel.com wrote: Last time I checked, GCC44 ~ GCC49 all produced images roughly in the same ball park

[edk2] [Patch 1/2] Allocate temp buffer to avoid potential change user input string buffer.

2015-08-18 Thread Eric Dong
Current logic will directly change user input string buffer which may cause ASSERT if user input string buffer is a constant string buffer. Now update logic to allocate a temp buffer to let code to update at run-time. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric

[edk2] [Patch 0/2] Enhance the keyword handler protocol to do more validation and error handling.

2015-08-18 Thread Eric Dong
Current code not do the enough validation and error handling, so some case may casued this sytem hang or assert, these patches enhanced it. Eric Dong (2): Allocate temp buffer to avoid potential change user input string buffer. Do valid check for the input namespace field.

[edk2] [Patch 2/2] Do valid check for the input namespace field.

2015-08-18 Thread Eric Dong
Current logic don't do the validation for the input namespace, if user input an invalid namespace, system will assert. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong eric.d...@intel.com --- .../Universal/HiiDatabaseDxe/ConfigKeywordHandler.c | 20

[edk2] [PATCH 3/3] ArmPlatformPkg: PL061: support multiple controller

2015-08-18 Thread Haojian Zhuang
Support multiple PL061 controllers. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang haojian.zhu...@linaro.org --- ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c| 107 ++--- .../Drivers/PL061GpioDxe/PL061GpioDxe.inf | 3 +-

[edk2] [PATCH 2/3] EmbeddedPkg: enhance for multiple gpio controllers

2015-08-18 Thread Haojian Zhuang
EmbeddedGpio only supports one gpio controller in one platform. Now create PLATFORM_GPIO_CONTROLLER to support multiple gpio controllers in one platform. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang haojian.zhu...@linaro.org ---

Re: [edk2] [PATCH 3/3] ArmPlatformPkg: PL061: support multiple controller

2015-08-18 Thread Ard Biesheuvel
On 18 August 2015 at 11:04, Haojian Zhuang haojian.zhu...@linaro.org wrote: Support multiple PL061 controllers. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang haojian.zhu...@linaro.org --- ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c| 107

Re: [edk2] [PATCH 3/3] ArmPlatformPkg: PL061: support multiple controller

2015-08-18 Thread Ard Biesheuvel
On 18 August 2015 at 11:31, Haojian Zhuang haojian.zhu...@linaro.org wrote: On Tue, 2015-08-18 at 11:22 +0200, Ard Biesheuvel wrote: On 18 August 2015 at 11:04, Haojian Zhuang haojian.zhu...@linaro.org wrote: Support multiple PL061 controllers. Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH v2 02/16] BaseTools/GenFv: use PE/COFF virtual section size if raw size is larger

2015-08-18 Thread Gao, Liming
I agree this change. Reviewed-by: Liming Gao liming@intel.com -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Monday, August 17, 2015 10:25 PM To: edk2-devel@lists.01.org; Liu, Yingke D Cc: Gao, Liming; Justen, Jordan L; wp...@windriver.com;

Re: [edk2] [PATCH] MdeModulePkg: Add PlatformVarCleanupLib library

2015-08-18 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com -Original Message- From: Zeng, Star Sent: Tuesday, August 18, 2015 8:29 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen Subject: [PATCH] MdeModulePkg: Add PlatformVarCleanupLib library Cc: Jiewen Yao jiewen@intel.com Contributed-under: TianoCore

Re: [edk2] [PATCH] MdeModulePkg: Add VarCheckPcdLib NULL class library

2015-08-18 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com -Original Message- From: Zeng, Star Sent: Tuesday, August 18, 2015 8:29 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen Subject: [PATCH] MdeModulePkg: Add VarCheckPcdLib NULL class library The check will be based on PcdVarCheck binary that generated by

Re: [edk2] [PATCH] MdeModulePkg: Add VarCheckHiiLib NULL class library

2015-08-18 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com -Original Message- From: Zeng, Star Sent: Tuesday, August 18, 2015 8:29 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen Subject: [PATCH] MdeModulePkg: Add VarCheckHiiLib NULL class library The check will be based on VarCheckHiiBin that generated from FV

Re: [edk2] [PATCH 08/15] Vlv2TbltDevicePkg: Add VarCheckLib library mapping

2015-08-18 Thread He, Tim
Reviewed-by: Tim He tim...@intel.com -Original Message- From: Zeng, Star Sent: Monday, August 17, 2015 4:24 PM To: edk2-devel@lists.01.org Cc: Wei, David; He, Tim Subject: [PATCH 08/15] Vlv2TbltDevicePkg: Add VarCheckLib library mapping Since Variable driver has been updated to consume

[edk2] [PATCH] BaseTools: Add support for nested !include in FDF and DSC files Also added code to detect include loops and enhanced error reporting for included files

2015-08-18 Thread Sheng, Cecil (HPS SW)
(The previous mail got rejected by the mail list so I have to resent again.) Hi, Sorry for the delayed update. Please review the attachment for changes to support nested include in DSC and FDF files. The performance impact in previous patch has been addressed. Sincerely, Cecil Sheng ISS

Re: [edk2] [patch] MdeModulePkg/Xhci: make all timeout values be consistent with comments.

2015-08-18 Thread Tian, Feng
Ok, the commit log would be updated to reflect this change. Thanks Feng -Original Message- From: Zeng, Star Sent: Wednesday, August 19, 2015 09:19 To: Tian, Feng Cc: edk2-devel@lists.01.org Subject: RE: [patch] MdeModulePkg/Xhci: make all timeout values be consistent with comments. In

Re: [edk2] [PATCH v2 00/16] unify GCC command line options

2015-08-18 Thread Laszlo Ersek
On 08/18/15 22:04, Paolo Bonzini wrote: On 18/08/2015 08:52, Ard Biesheuvel wrote: Personally, I would not mind deprecating GCC44, but the biggest question I would have is what toolchains do the latest UDK releases claim to support. We also have the issue that every time I ask about

Re: [edk2] [PATCH v2 00/16] unify GCC command line options

2015-08-18 Thread Paolo Bonzini
On 18/08/2015 08:52, Ard Biesheuvel wrote: Personally, I would not mind deprecating GCC44, but the biggest question I would have is what toolchains do the latest UDK releases claim to support. We also have the issue that every time I ask about deprecating a toolchain, Larry looks at

[edk2] [Patch] NetworkPkg: Fix DHCP TransmitReceive EFI_NO_MAPPING return in DnsDxe

2015-08-18 Thread Jiaxin Wu
If the default station address is not available, TransmitReceive function will return EFI_NO_MAPPING. DNS driver should handle this case. This issue is caused by the r18201 fix. Cc: Ye Ting ting...@intel.com Cc: Zhang Lubo lubo.zh...@intel.com Contributed-under: TianoCore Contribution Agreement

[edk2] [PATCH v2] NetworkPkg: Fix DHCP TransmitReceive EFI_NO_MAPPING return in DnsDxe

2015-08-18 Thread Jiaxin Wu
v2: * Add Timeout check, if time out, return EFI_DEVICE_ERROR. If the default station address is not available, TransmitReceive function will return EFI_NO_MAPPING. DNS driver should handle this case. This issue is caused by the r18201 fix. Cc: Ye Ting ting...@intel.com Cc: Zhang Lubo

Re: [edk2] [PATCH 0/3] unify FVP Base and Foundation model support

2015-08-18 Thread Leif Lindholm
On Tue, Aug 18, 2015 at 02:14:53PM +0200, Ard Biesheuvel wrote: On 18 August 2015 at 14:12, Leif Lindholm leif.lindh...@linaro.org wrote: On Tue, Aug 18, 2015 at 01:15:54PM +0200, Ard Biesheuvel wrote: On 12 August 2015 at 08:45, Ard Biesheuvel ard.biesheu...@linaro.org wrote: Instead

[edk2] [PATCH v2 0/3] unify FVP Base and Foundation model support

2015-08-18 Thread Ard Biesheuvel
Instead of omitting some drivers that are known to break the Foundation model when ARM_FOUNDATION_FVP is defined, fix those drivers so that they simply fail to load without interfering with the boot. Changes since v1: - Print a diagnostic at EFI_D_WARN level that we are about to access the

Re: [edk2] [PATCH 0/3] unify FVP Base and Foundation model support

2015-08-18 Thread Ard Biesheuvel
On 18 August 2015 at 15:50, Leif Lindholm leif.lindh...@linaro.org wrote: On Tue, Aug 18, 2015 at 02:14:53PM +0200, Ard Biesheuvel wrote: On 18 August 2015 at 14:12, Leif Lindholm leif.lindh...@linaro.org wrote: On Tue, Aug 18, 2015 at 01:15:54PM +0200, Ard Biesheuvel wrote: On 12 August

[edk2] [PATCH v2 1/3] ArmPlatformPkg/PL180MciDxe: check PrimeCell ID before initializing

2015-08-18 Thread Ard Biesheuvel
To deal gracefully with the absence of the PL180 hardware on the Foundation model, check the PrimeCell ID before proceeding with the installation. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ard.biesheu...@linaro.org Reviewed-by: Leif Lindholm

[edk2] [PATCH v2 3/3] ArmPlatformPkg/FVP: unify support for Foundation and Base models

2015-08-18 Thread Ard Biesheuvel
Now that the PL180 and PL111 drivers know how to behave when executed on the Foundation model that does not emulate the hardware, we can remove the ARM_FOUNDATION_FVP ifdefs and produce a single build that runs on both the Foundation model and the Base model. Contributed-under: TianoCore

[edk2] [PATCH v2 2/3] ArmPlatformPkg/LcdGraphicsOutputDxe: check PrimeCell ID before initializing

2015-08-18 Thread Ard Biesheuvel
To deal gracefully with the absence of the PL111 hardware on the Foundation model, check the PrimeCell ID before proceeding with the installation. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ard.biesheu...@linaro.org Reviewed-by: Leif Lindholm

Re: [edk2] [PATCH v2 00/16] unify GCC command line options

2015-08-18 Thread Ard Biesheuvel
On 18 August 2015 at 22:03, Ard Biesheuvel ard.biesheu...@linaro.org wrote: On 18 August 2015 at 19:35, David Woodhouse dw...@infradead.org wrote: On Tue, 2015-08-18 at 17:52 +0200, Ard Biesheuvel wrote: On 18 August 2015 at 17:19, Jordan Justen jordan.l.jus...@intel.com wrote: Last time I

[edk2] [PATCH] CorebootModulePkg: Prevent erasure of coreboot header before use

2015-08-18 Thread Scott Duplichan
Remove EFI_RESOURCE_ATTRIBUTE_TESTED when reporting lower 640KB memory so that the coreboot header is not erased before being processed by CbParseMemoryInfo. This change is needed for compatibility with SVN revision 18146. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by:

Re: [edk2] [PATCH v2 00/16] unify GCC command line options

2015-08-18 Thread Ard Biesheuvel
On 18 August 2015 at 17:19, Jordan Justen jordan.l.jus...@intel.com wrote: On 2015-08-18 03:57:51, Ard Biesheuvel wrote: On 17 August 2015 at 20:53, Jordan Justen jordan.l.jus...@intel.com wrote: On 2015-08-17 11:25:56, Ard Biesheuvel wrote: MinGW generates PE/COFF not ELF, so much of the

Re: [edk2] [PATCH v2 00/16] unify GCC command line options

2015-08-18 Thread Jordan Justen
On 2015-08-18 03:57:51, Ard Biesheuvel wrote: On 17 August 2015 at 20:53, Jordan Justen jordan.l.jus...@intel.com wrote: On 2015-08-17 11:25:56, Ard Biesheuvel wrote: MinGW generates PE/COFF not ELF, so much of the linker command line is different, and it really deserves a toolchain of its

Re: [edk2] [PATCH v2 00/16] unify GCC command line options

2015-08-18 Thread Jordan Justen
On 2015-08-18 04:01:36, Ard Biesheuvel wrote: On 17 August 2015 at 21:16, David Woodhouse dw...@infradead.org wrote: On 2015-08-17 11:25:41, David Woodhouse wrote: On Mon, 2015-08-17 at 11:22 -0700, Jordan Justen wrote: Can't you use an elf-based GCC4.9 with the GCC49 toolchain instead?