Re: [edk2] [PATCH v5 2/6] OvmfPkg/PciHostBridgeLib: Init PCI aperture to 0

2018-03-05 Thread Guo Heyi
On Fri, Mar 02, 2018 at 11:19:31AM +0100, Laszlo Ersek wrote: > On 03/01/18 11:48, Guo Heyi wrote: > > On Thu, Mar 01, 2018 at 11:17:30AM +0100, Laszlo Ersek wrote: > >> On 03/01/18 07:57, Heyi Guo wrote: > > >>> diff --git a/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c > >>>

Re: [edk2] [PATCH v2] UefiCpuPkg/MpInitLib: put mReservedApLoopFunc in executable memory

2018-03-05 Thread Laszlo Ersek
On 03/03/18 10:03, Jian J Wang wrote: >> v2 changes: >> a. Reserve memory of mReservedApLoopFunc and mReservedTopOfApStack >>separately to avoid making mReservedTopOfApStack executable. > > if PcdDxeNxMemoryProtectionPolicy is enabled for EfiReservedMemoryType > of memory, #PF will be

Re: [edk2] How to handle pflash backed OVMF FW upgrade and live migration best?

2018-03-05 Thread Laszlo Ersek
On 03/02/18 13:53, Dr. David Alan Gilbert wrote: > * Laszlo Ersek (ler...@redhat.com) wrote: >> CC Dave >> To give you the simplest example, binaries (and varstores) corresponding >> to FD_SIZE_2MB and FD_SIZE_4MB are incompatible. If a domain is >> originally defined on top of an FD_SIZE_2MB

Re: [edk2] [PATCH 00/20] OvmfPkg: SEV: decrypt the initial SMRAM save state map for SMBASE relocation

2018-03-05 Thread Laszlo Ersek
On 03/02/18 14:17, Brijesh Singh wrote: > > > On 3/2/18 5:53 AM, Laszlo Ersek wrote: >> On 03/02/18 02:16, Brijesh Singh wrote: >>> >>> On 3/1/18 6:03 PM, Laszlo Ersek wrote: I also tried to test the series with SEV guests (again with Brijesh's v2 2/2 patch applied on top).

Re: [edk2] OVMF package : Question about Qemu/Xen support

2018-03-05 Thread Laszlo Ersek
On 03/05/18 06:49, Tiger Liu(BJ-RD) wrote: > Hi, experts: > I have a question about Ovmf. > > Must Ovmf be run with qemu tool? > Or It could be run with Xen without needed qemu software. > > It seems Xen began to support uefi boot from 4.4 version. - From the Xen wiki:

[edk2] 答复: OVMF package : Question about Qemu/Xen support

2018-03-05 Thread Tiger Liu(BJ-RD)
Hi, Laszlo: Got it! Thanks a lot! Best wishes, -邮件原件- 发件人: Laszlo Ersek [mailto:ler...@redhat.com] 发送时间: 2018年3月5日 17:15 收件人: Tiger Liu(BJ-RD) 抄送: 'edk2-devel@lists.01.org' ; Anthony Perard ; Julien Grall

[edk2] [PATCH] IntelSiliconPkg VTdPmrPei: Add PcdVTdPeiDmaBufferSize(S3)

2018-03-05 Thread Star Zeng
Add PcdVTdPeiDmaBufferSize(S3) to replace the hard coded value TOTAL_DMA_BUFFER_SIZE and TOTAL_DMA_BUFFER_SIZE_S3 in IntelVTdPmrPei. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng ---

Re: [edk2] [PATCH 3/7] HACK: HobLib: workaround infinite loop

2018-03-05 Thread Marc-André Lureau
Hi On Fri, Feb 23, 2018 at 8:45 PM, Andrew Fish wrote: > > >> On Feb 23, 2018, at 5:23 AM, marcandre.lur...@redhat.com wrote: >> >> From: Marc-André Lureau >> >> Without this hack, GetNextHob() loops infinitely with the next patch. >> I don't

Re: [edk2] [Patch V2] DEC spec: Add flexible PCD value format into spec

2018-03-05 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Zhu, Yonghong >Sent: Wednesday, February 07, 2018 8:36 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming ; Kinney, Michael D >; Shaw, Kevin W

Re: [edk2] [Patch V2] Expression spec: update format to support flexible Pcd format

2018-03-05 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Zhu, Yonghong >Sent: Wednesday, February 07, 2018 8:36 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming ; Kinney, Michael D >; Shaw, Kevin W

Re: [edk2] [Patch V2] Build spec: Add flexible PCD value format into spec

2018-03-05 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Zhu, Yonghong >Sent: Wednesday, February 07, 2018 8:36 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming ; Kinney, Michael D >; Shaw, Kevin W

Re: [edk2] [Patch V2] INF spec: Add flexible PCD value format into spec

2018-03-05 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Zhu, Yonghong >Sent: Wednesday, February 07, 2018 8:36 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming ; Kinney, Michael D >; Shaw, Kevin W

Re: [edk2] [PATCH 00/20] OvmfPkg: SEV: decrypt the initial SMRAM save state map for SMBASE relocation

2018-03-05 Thread Brijesh Singh
Hi Laszlo, On 03/05/2018 08:00 AM, Laszlo Ersek wrote: On 03/02/18 14:17, Brijesh Singh wrote: On 3/2/18 5:53 AM, Laszlo Ersek wrote: Do you have (maybe updated) instructions for setting up the SEV host? What are the latest bits that are expected to work together? For host kernel: -

Re: [edk2] [PATCH 00/20] OvmfPkg: SEV: decrypt the initial SMRAM save state map for SMBASE relocation

2018-03-05 Thread Brijesh Singh
One more comment. On 03/05/2018 08:44 AM, Brijesh Singh wrote: >> \    -device scsi-hd,bus=scsi0.0,channel=0,scsi-id=0,lun=0,drive=drive-scsi0-0-0-0,id=scsi0-0-0-0,bootindex=1 \    -netdev tap,fd=26,id=hostnet0,vhost=on,vhostfd=28 \    -device

Re: [edk2] [PATCH 00/20] OvmfPkg: SEV: decrypt the initial SMRAM save state map for SMBASE relocation

2018-03-05 Thread Laszlo Ersek
On 03/02/18 14:17, Brijesh Singh wrote: > On 3/2/18 5:53 AM, Laszlo Ersek wrote: >> Do you have (maybe updated) instructions for setting up the SEV host? >> What are the latest bits that are expected to work together? > For host kernel: > - use recent kvm/master > - make sure following kernel

Re: [edk2] [PATCH 0/3] BaseTools: let the C-language build utils compile with gcc-8

2018-03-05 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Saturday, March 03, 2018 2:09 AM >To: edk2-devel-01 >Cc: Ard Biesheuvel ; Cole Robinson >;

Re: [edk2] [Patch V3] DSC spec: Add flexible PCD value format into spec

2018-03-05 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Monday, February 26, 2018 4:05 PM >To: edk2-devel@lists.01.org >Cc: Kinney, Michael D ; Shaw, Kevin W

[edk2] [PATCH v1] MdePkg: SMMUv3 updates for IORT table definitions

2018-03-05 Thread Sami Mujawar
Updated the IORT SMMUv3 Node structure and flags to match the IO Remapping Table, Platform Design Document, Revision C dated 15 MAY 2017. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sami Mujawar Signed-off-by: Evan Lloyd ---

[edk2] [PATCH] IntelSiliconPkg VTdPmrPei: Return SUCCESS when Mapping == NULL in Unmap

2018-03-05 Thread Star Zeng
NULL is returned to Mapping when Operation is BusMasterCommonBuffer or EdkiiIoMmuOperationBusMasterCommonBuffer64 in PeiIoMmuMap(). So Mapping == NULL is valid when calling PeiIoMmuUnmap(). 940dbd071e9f01717236af236740aa0da716805f wrongly changed EFI_SUCCESS to EFI_INVALID_PARAMETER when Mapping

Re: [edk2] [PATCH v1] MdePkg: SMMUv3 updates for IORT table definitions

2018-03-05 Thread Ard Biesheuvel
On 5 March 2018 at 14:53, Sami Mujawar wrote: > Updated the IORT SMMUv3 Node structure and flags to match the > IO Remapping Table, Platform Design Document, Revision C dated > 15 MAY 2017. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Sami

Re: [edk2] [PATCH] ShellPkg/ConsoleLogger: Fix a typo in UpdateDisplayFromHistory()

2018-03-05 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Wu, Hao A > Sent: Friday, March 02, 2018 7:05 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Carsey, Jaben > ; Ni, Ruiyu > Subject: [PATCH]

Re: [edk2] [PATCH edk2-platforms v2 06/18] ARM/VExpressPkg: Add and update debug ASSERTS

2018-03-05 Thread Evan Lloyd
In that case, would you be happy to take Girish's patches with the ASSERTs done your (our) way? Leif can fulminate about it when he gets back, if he really feels that strongly. I suspect, though, that Leif is capable of being reasonable if pressed (and offered beer at Plugfest). Regards, Evan

Re: [edk2] [PATCH 5/7] ovmf: link with Tcg2Dxe module

2018-03-05 Thread Marc-André Lureau
Hi On Mon, Feb 26, 2018 at 10:50 AM, Laszlo Ersek wrote: > On 02/23/18 14:23, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau >> >> This module measures and log the boot environment. It also produces >> the Tcg2 protocol, which

Re: [edk2] [PATCH 3/7] HACK: HobLib: workaround infinite loop

2018-03-05 Thread Laszlo Ersek
On 03/05/18 15:05, Marc-André Lureau wrote: > Hi > > On Fri, Feb 23, 2018 at 8:45 PM, Andrew Fish wrote: >> >> >>> On Feb 23, 2018, at 5:23 AM, marcandre.lur...@redhat.com wrote: >>> >>> From: Marc-André Lureau >>> >>> Without this hack, GetNextHob()

Re: [edk2] [PATCH 5/7] ovmf: link with Tcg2Dxe module

2018-03-05 Thread Laszlo Ersek
On 03/05/18 16:45, Marc-André Lureau wrote: > Hi > > On Mon, Feb 26, 2018 at 10:50 AM, Laszlo Ersek wrote: >> On 02/23/18 14:23, marcandre.lur...@redhat.com wrote: >>> + SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf { >>> + >>> + >>>

Re: [edk2] [PATCH 0/3] BaseTools: let the C-language build utils compile with gcc-8

2018-03-05 Thread Laszlo Ersek
On 03/05/18 15:13, Gao, Liming wrote: > Reviewed-by: Liming Gao Thank you, Liming; I pushed the series as commit range 20203d3f98d6..9de306701312. Laszlo >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Saturday, March 03, 2018 2:09

Re: [edk2] [PATCH] IntelSiliconPkg VTdPmrPei: Add PcdVTdPeiDmaBufferSize(S3)

2018-03-05 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Monday, March 5, 2018 10:17 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen > Subject: [PATCH] IntelSiliconPkg VTdPmrPei: Add

Re: [edk2] [PATCH] IntelSiliconPkg VTdPmrPei: Return SUCCESS when Mapping == NULL in Unmap

2018-03-05 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Monday, March 5, 2018 9:34 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen > Subject: [PATCH] IntelSiliconPkg VTdPmrPei: Return SUCCESS when

Re: [edk2] [PATCH 3/7] HACK: HobLib: workaround infinite loop

2018-03-05 Thread Andrew Fish
> On Mar 5, 2018, at 10:22 AM, Laszlo Ersek wrote: > > On 03/05/18 15:05, Marc-André Lureau wrote: >> Hi >> >> On Fri, Feb 23, 2018 at 8:45 PM, Andrew Fish wrote: >>> >>> On Feb 23, 2018, at 5:23 AM, marcandre.lur...@redhat.com wrote:

Re: [edk2] [PATCH 00/20] OvmfPkg: SEV: decrypt the initial SMRAM save state map for SMBASE relocation

2018-03-05 Thread Laszlo Ersek
On 03/05/18 15:44, Brijesh Singh wrote: > On 03/05/2018 08:00 AM, Laszlo Ersek wrote: >> QEMU exits with the following error for me: >> >> 2018-03-05T13:40:12.478835Z qemu-system-x86_64: sev_ram_block_added: >> failed to register region (0x7f3df3e0+0x2) >> 2018-03-05T13:40:12.489183Z

Re: [edk2] [PATCH v5 4/6] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

2018-03-05 Thread Guo Heyi
Hi Ray, Any comments for v5? Regards, Heyi On Thu, Mar 01, 2018 at 02:57:22PM +0800, Heyi Guo wrote: > PCI address translation is necessary for some non-x86 platforms. On > such platforms, address value (denoted as "device address" or "address > in PCI view") set to PCI BAR registers in

[edk2] [Patch] EmbeddedPkg: Correct the way of handling sections with a large size

2018-03-05 Thread Ge Song
Correct the way of handling EFI_SECTION_GUID_DEFINED type sections with a large size Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ge Song ---

Re: [edk2] [PATCH 3/7] HACK: HobLib: workaround infinite loop

2018-03-05 Thread Brian J. Johnson
On 03/05/2018 12:22 PM, Laszlo Ersek wrote: PEIMs generally "execute in place" (XIP), i.e. they run from flash, not RAM. In this status they use "temporary RAM" (e.g. CPU caches configured like RAM) for stack & heap; whatever HOBs they produce are stored in "temp RAM" as well. Then one of the

Re: [edk2] [PATCH 3/7] HACK: HobLib: workaround infinite loop

2018-03-05 Thread Gao, Liming
Laszlo: I also suggest to check the generated ProcessLibraryConstructorList () function. It is in the driver build output AutoGen.c code. You can check what library function be called in this function. Then, further add debug message in the library function. I suspect some function does the

[edk2] [PATCH 0/2] Fix bug in CompatibleRangeTest

2018-03-05 Thread Ruiyu Ni
Ruiyu Ni (2): MdeModulePkg/NullMemoryTest: Change prototype of ConvertToTestedMemory MdeModulePkg/NullMemoryTest: Fix bug in CompatibleRangeTest .../MemoryTest/NullMemoryTestDxe/NullMemoryTest.c | 82 +- 1 file changed, 65 insertions(+), 17 deletions(-) --

[edk2] [PATCH 2/2] MdeModulePkg/NullMemoryTest: Fix bug in CompatibleRangeTest

2018-03-05 Thread Ruiyu Ni
CompatibleRangeTest() contains two bugs: 1. It doesn't reject the memory above 16MB 2. it cannot handle the case when the partial or whole range of requested memory is already tested. The patch fixes the two bugs. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni

[edk2] [PATCH 1/2] MdeModulePkg/NullMemoryTest: Change prototype of ConvertToTestedMemory

2018-03-05 Thread Ruiyu Ni
The patch should not impact the functionality. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Liming Gao --- .../MemoryTest/NullMemoryTestDxe/NullMemoryTest.c | 37 ++ 1 file changed, 24

Re: [edk2] [PATCH v4 0/2] quirks handling for SDHCI controllers

2018-03-05 Thread Meenakshi Aggarwal
Hi, I am using Mmc Driver implemented in " EmbeddedPkg/Universal/MmcDxe/" for my SD/MMC controller and my controller is not on PCI bus. I am a bit confused if i should move to SD implementation available in 'MdeModulePkg\Bus\Pci\SdMmcPciHcDxe". Please suggest. Thanks, Meenakshi >