Re: [edk2] how do I use RamDiskDxe?

2018-03-06 Thread Rick Warner
On 02/13/18 19:48, Wu, Hao A wrote: >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Rick >> Warner >> Sent: Wednesday, February 14, 2018 12:33 AM >> To: Wu, Hao A; Andrew Fish >> Cc: edk2-devel@lists.01.org >> Subject: Re: [edk2] how do I use

[edk2] [PATCH 1/1] RFC: SecurityPkg: only clear HashInterface informations

2018-03-06 Thread marcandre . lureau
From: Marc-André Lureau The ZeroMem() call goes beyond the HashInterfaceHob structure, causing HOB list corruption. Instead, just clear the HashInterface fields, as I suppose was originally intended. Cc: Jiewen Yao Cc: Chao Zhang

Re: [edk2] [PATCH 1/1] RFC: SecurityPkg: only clear HashInterface informations

2018-03-06 Thread Zeng, Star
Reviewed-by: Star Zeng Thanks, Star -Original Message- From: marcandre.lur...@redhat.com [mailto:marcandre.lur...@redhat.com] Sent: Wednesday, March 7, 2018 4:27 AM To: edk2-devel@lists.01.org Cc: Marc-André Lureau ; Yao, Jiewen

Re: [edk2] [PATCH 1/1] RFC: SecurityPkg: only clear HashInterface informations

2018-03-06 Thread Yao, Jiewen
Excellent. Thanks to catch that. Reviewed-by: jiewen@intel.com > -Original Message- > From: marcandre.lur...@redhat.com [mailto:marcandre.lur...@redhat.com] > Sent: Wednesday, March 7, 2018 4:27 AM > To: edk2-devel@lists.01.org > Cc: Marc-André Lureau ;

Re: [edk2] [PATCH v2 0/2] Resolve feature conflict between NX and Stack guard

2018-03-06 Thread Ni, Ruiyu
On 3/6/2018 9:33 PM, Hao Wu wrote: V2 changes: A. Use Hoblib APIs to get the base of stack from Hob. B. Remove unnecessary local variable used in function InitializeDxeNxMemoryProtectionPolicy(). V1 history: If enabled, NX memory protection feature will mark some types of active memory as

Re: [edk2] [PATCH v2 0/2] Resolve feature conflict between NX and Stack guard

2018-03-06 Thread Yao, Jiewen
I think the original patch is fine. StackBase is already checked by using ASSERT before. > +ASSERT ((StackBase & EFI_PAGE_MASK) == 0); MemMap entry must be page aligned. No additional check is required here. Thank you Yao Jiewen > -Original Message- > From: Wang, Jian J >

[edk2] [PATCH 2/4] NonDiscoverableDeviceRegistrationLib: Added Virtio support

2018-03-06 Thread Daniil Egranov
Added Virtio non-discoverable device case. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Daniil Egranov --- .../NonDiscoverableDeviceRegistrationLib.c | 3 +++ .../NonDiscoverableDeviceRegistrationLib.inf

[edk2] [PATCH 1/4] MdeModulePkg: Added new Virtio non-discoverable type and GUID

2018-03-06 Thread Daniil Egranov
Added Virtio type and GUID to the list of supported non-discoverable devices. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Daniil Egranov --- MdeModulePkg/Include/Guid/NonDiscoverableDevice.h | 3 +++

Re: [edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: limit recursive call depth

2018-03-06 Thread Guo Heyi
Hi Ray, Sorry to disturb, but I didn't find the patch committed. Could you help to do that? Thanks, Heyi On Thu, Mar 01, 2018 at 12:46:32PM +0800, Ni, Ruiyu wrote: > On 3/1/2018 10:39 AM, Heyi Guo wrote: > >Function BmRepairAllControllers may recursively call itself if some > >driver health

Re: [edk2] [PATCH 0/2] Fix bug in CompatibleRangeTest

2018-03-06 Thread Kinney, Michael D
Reviewed-by: Michael D Kinney > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of Ruiyu Ni > Sent: Monday, March 5, 2018 7:40 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH 0/2] Fix bug in >

Re: [edk2] [PATCH v5 4/6] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

2018-03-06 Thread Ni, Ruiyu
On 3/6/2018 10:44 AM, Guo Heyi wrote: Hi Ray, Any comments for v5? Heyi, Some backward compatibility concerns were received from internal production teams. Current change will cause silent failure on old platforms because TranslationOffset might be random if uninitialized. I will solve the

[edk2] [PATCH 4/4] VirtioPciDeviceDxe: Added non-discoverable Virtio support

2018-03-06 Thread Daniil Egranov
The VirtioPciDeviceDxe was extended to support a non-discoverable MMIO Virtio case. The Virtio spec defines both PCI and MMIO device types with the set of registers that are not the same between these two types of devices. All PCI registers have corresponding MMIO registers but the number of

[edk2] [PATCH 3/4] NonDiscoverablePciDeviceDxe: Added MMIO Virtio support

2018-03-06 Thread Daniil Egranov
Added PCI IO to MMIO translation for Virtio case into the PCI IO protocol functions. Added Virtio device type into the PCI IO protocol initialization procedure. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Daniil Egranov ---

[edk2] [PATCH 0/4] Virtio non-discoverable devices

2018-03-06 Thread Daniil Egranov
This is an attempt to add MMIO Virtio devices into the non-discoverable device registration procedure and allow Virtio PCI drivers to recognize and program such devices correctly. The main issue is that the set of MMIO registers is different from PCI, plus the width of similar registers are not

[edk2] [PATCH] MdeModulePkg/Core: fix too many available pages between BS_Data

2018-03-06 Thread Jian J Wang
The root cause is an unnecessary check to Size parameter in function AdjustMemoryS(). It will cause one standalone free page (happen to have Guard page around) in the free memory list cannot be allocated, even if the requested memory size is less than a page. // // At least one more page

Re: [edk2] [PATCH v2 0/2] Resolve feature conflict between NX and Stack guard

2018-03-06 Thread Wang, Jian J
Thanks for fixing the issue. For this patch series: Reviewed-by: Jian J Wang > -Original Message- > From: Wu, Hao A > Sent: Tuesday, March 06, 2018 9:33 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Wang, Jian J ; >

[edk2] [patch] MdeModulePkg/DriverSampleDxe: Refine the sample case for UNION type

2018-03-06 Thread Dandan Bi
The example of UNION storage is not good, now update it. Cc: Eric Dong Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/DriverSampleDxe/NVDataStruc.h | 6

Re: [edk2] [PATCH v2 0/2] Resolve feature conflict between NX and Stack guard

2018-03-06 Thread Ni, Ruiyu
On 3/7/2018 12:28 PM, Wu, Hao A wrote: Hi Ray, Below are the answers to your feedbacks: -Original Message- From: Yao, Jiewen Sent: Wednesday, March 07, 2018 12:14 PM To: Wang, Jian J; Ni, Ruiyu; Wu, Hao A; edk2-devel@lists.01.org Cc: Zeng, Star; Dong, Eric Subject: RE: [PATCH v2 0/2]

Re: [edk2] [PATCH 6/7] SecurityPkg OpalPasswordSupportLib: Remove it

2018-03-06 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Tuesday, March 6, 2018 10:28 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen ; > Dong, Eric ; Zhang, Chao B

Re: [edk2] [PATCH 7/7] SecurityPkg OpalPasswordExtraInfoVariable.h: Remove it

2018-03-06 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Tuesday, March 6, 2018 10:28 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen ; > Dong, Eric ; Zhang, Chao B

[edk2] [PATCH 2/3] Hisilicon: disable GICv3 legacy mode

2018-03-06 Thread Heyi Guo
From: gongchengya Hi1616 GIC does not fully support GICv2 legacy mode, and SBSA watchdog interrupts 400 and 496 cannot be signaled to CPU, so we switch to pure GICv3 mode. For other Hisilicon platforms, we suppose they don't need V2 legacy mode either if they have

Re: [edk2] [patch] MdeModulePkg/DriverSampleDxe: Refine the sample case for UNION type

2018-03-06 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Bi, Dandan > Sent: Wednesday, March 7, 2018 11:06 AM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Gao, Liming > Subject: [patch] MdeModulePkg/DriverSampleDxe: Refine

[edk2] [PATCH 1/3] Hisilicon/D0x: Set ACPI GTDT always-on flag

2018-03-06 Thread Heyi Guo
From: Jason Zhang Timer is always working on Hisilicon D0x, even system enters WFI/WFE, and there is no other low power status, so we set "always-on" flag in ACPI GTDT. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jason Zhang

[edk2] [PATCH 3/3] Hisilicon/D05: Support SBSA watchdog

2018-03-06 Thread Heyi Guo
From: Chenhui Sun Add description of SBSA watchdogs to ACPI GTDT on D05. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chenhui Sun Signed-off-by: Heyi Guo Cc: Ard Biesheuvel

Re: [edk2] [PATCH v2 0/2] Resolve feature conflict between NX and Stack guard

2018-03-06 Thread Wang, Jian J
Regards, Jian > -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, March 07, 2018 11:17 AM > To: Wu, Hao A ; edk2-devel@lists.01.org > Cc: Wang, Jian J ; Zeng, Star ; > Dong, Eric ; Yao, Jiewen

Re: [edk2] [PATCH v5 4/6] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

2018-03-06 Thread Guo Heyi
Thanks. Please let me know if any further changes are needed. Regards, Heyi On Wed, Mar 07, 2018 at 12:30:59PM +0800, Ni, Ruiyu wrote: > On 3/6/2018 10:44 AM, Guo Heyi wrote: > >Hi Ray, > > > >Any comments for v5? > > Heyi, > Some backward compatibility concerns were received from internal

Re: [edk2] [PATCH 1/1] RFC: SecurityPkg: only clear HashInterface informations

2018-03-06 Thread Zhang, Chao B
Reviewed-by: Chao Zhang -Original Message- From: marcandre.lur...@redhat.com [mailto:marcandre.lur...@redhat.com] Sent: Wednesday, March 7, 2018 4:27 AM To: edk2-devel@lists.01.org Cc: Marc-André Lureau ; Yao, Jiewen

[edk2] [PATCH 1/2] Hisilicon/D0x: fix tftp command init failure

2018-03-06 Thread Heyi Guo
We need to set PcdShellLibAutoInitialize to FALSE for TftpDynamicCommand, or else we will get initialization failure when loading TftpDynamicCommand module, for EFI Shell has not been started at this moment. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Heyi Guo

[edk2] [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default

2018-03-06 Thread Heyi Guo
Since D0x platforms always have network enabled, we would like to enable tftp command by default so that we can download something in EFI Shell. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Heyi Guo Cc: Ard Biesheuvel Cc:

Re: [edk2] [PATCH 0/2] Fix bug in CompatibleRangeTest

2018-03-06 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Kinney, Michael D >Sent: Wednesday, March 07, 2018 12:09 PM >To: Ni, Ruiyu ; edk2-devel@lists.01.org; Kinney, Michael >D

Re: [edk2] [PATCH 3/7] SecurityPkg TcgStorageCoreLib: Make it be base type really

2018-03-06 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Tuesday, March 6, 2018 10:28 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen ; > Dong, Eric ; Zhang, Chao B

Re: [edk2] [PATCH v2 0/2] Resolve feature conflict between NX and Stack guard

2018-03-06 Thread Wu, Hao A
Hi Ray, Below are the answers to your feedbacks: > -Original Message- > From: Yao, Jiewen > Sent: Wednesday, March 07, 2018 12:14 PM > To: Wang, Jian J; Ni, Ruiyu; Wu, Hao A; edk2-devel@lists.01.org > Cc: Zeng, Star; Dong, Eric > Subject: RE: [PATCH v2 0/2] Resolve feature conflict

[edk2] [patch] SecurityPkg/SmmTcg2PhysicalPresenceLib: Fix coding style issue

2018-03-06 Thread Dandan Bi
Boolean values do not need to use explicit comparisons to TRUE or FALSE. Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- .../Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c | 2

[edk2] [patch] UefiCpuPkg/CpuCommonFeaturesLib: Fix coding style issue

2018-03-06 Thread Dandan Bi
Boolean values do not need to use explicit comparisons to TRUE or FALSE. Cc: Eric Dong Cc: Laszlo Ersek Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi ---

Re: [edk2] [patch] UefiCpuPkg/CpuCommonFeaturesLib: Fix coding style issue

2018-03-06 Thread Ni, Ruiyu
On 3/7/2018 1:53 PM, Dandan Bi wrote: Boolean values do not need to use explicit comparisons to TRUE or FALSE. Cc: Eric Dong Cc: Laszlo Ersek Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan

Re: [edk2] [PATCH 1/7] MdeModulePkg LockBoxLib: Support LOCK_BOX_ATTRIBUTE_RESTORE_IN_S3_ONLY

2018-03-06 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star > Zeng > Sent: Tuesday, March 6, 2018 10:28 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Zeng, Star >

Re: [edk2] [PATCH 0/3] BaseTools: let the C-language build utils compile with gcc-8

2018-03-06 Thread Gao, Liming
Laszlo: We just find this change causes XCODE5 build failure, because XCODE compiler doesn't know these two options. So, could you provide the patch to remove the change in BUILD_CFLAGS for MAC? ifeq ($(DARWIN),Darwin) # assume clang or clang compatible flags on OS X BUILD_CFLAGS = else

Re: [edk2] [PATCH 2/7] SecurityPkg TcgStorageOpalLib: Make it be base type really

2018-03-06 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Tuesday, March 6, 2018 10:28 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen ; > Dong, Eric ; Zhang, Chao B

Re: [edk2] [PATCH] MdeModulePkg/Core: fix too many available pages between BS_Data

2018-03-06 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Wang, Jian J > Sent: Wednesday, March 7, 2018 12:41 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Dong, Eric ; Yao, > Jiewen > Subject: [PATCH]

Re: [edk2] [patch] SecurityPkg/SmmTcg2PhysicalPresenceLib: Fix coding style issue

2018-03-06 Thread Zhang, Chao B
Reviewed-by: Chao Zhang -Original Message- From: Bi, Dandan Sent: Wednesday, March 7, 2018 1:54 PM To: edk2-devel@lists.01.org Cc: Zhang, Chao B Subject: [patch] SecurityPkg/SmmTcg2PhysicalPresenceLib: Fix coding style issue Boolean

Re: [edk2] [PATCH v4 0/2] quirks handling for SDHCI controllers

2018-03-06 Thread Ard Biesheuvel
On 6 March 2018 at 05:14, Meenakshi Aggarwal wrote: > Hi, > > I am using Mmc Driver implemented in " EmbeddedPkg/Universal/MmcDxe/" for my > SD/MMC controller and my controller is not on PCI bus. > > I am a bit confused if i should move to SD implementation available

Re: [edk2] [PATCH edk2-platforms v2 06/18] ARM/VExpressPkg: Add and update debug ASSERTS

2018-03-06 Thread Ard Biesheuvel
On 5 March 2018 at 15:08, Evan Lloyd wrote: > In that case, would you be happy to take Girish's patches with the ASSERTs > done your (our) way? > Leif can fulminate about it when he gets back, if he really feels that > strongly. Why? Because it is almost the end of the

[edk2] [PATCH 0/7] OpalPassword: New solution without SMM device code

2018-03-06 Thread Star Zeng
The patch series is also at https://github.com/lzeng14/edk2 OpalPasswordNew branch. After IOMMU is enabled in S3, original solution with SMM device code (OpalPasswordSmm) to unlock OPAL device for S3 will not work as the DMA operation will be aborted without granted DMA buffer. Instead, this

[edk2] [PATCH 1/7] MdeModulePkg LockBoxLib: Support LOCK_BOX_ATTRIBUTE_RESTORE_IN_S3_ONLY

2018-03-06 Thread Star Zeng
With this flag, the LockBox can be restored in S3 resume only. The LockBox can not be restored after SmmReadyToLock in normal boot and after EndOfS3Resume in S3 resume. It can not be set together with LOCK_BOX_ATTRIBUTE_RESTORE_IN_PLACE. Cc: Jiewen Yao Contributed-under:

Re: [edk2] [PATCH] ArmPkg/TimerDxe: Always perform an EOI, even for spurious interrupts

2018-03-06 Thread Laszlo Ersek
On 03/06/18 14:24, Ard Biesheuvel wrote: > From: Marc Zyngier > > The generic timer driver only EOIs the timer interrupt if > the ISTATUS bit is set. This is completely fine if you pretend > that spurious interrupts do not exist. But as a matter of fact, > they do, and the

[edk2] [PATCH 2/7] SecurityPkg TcgStorageOpalLib: Make it be base type really

2018-03-06 Thread Star Zeng
Cc: Jiewen Yao Cc: Eric Dong Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalLib.inf | 8 ++-- 1

[edk2] [PATCH 3/7] SecurityPkg TcgStorageCoreLib: Make it be base type really

2018-03-06 Thread Star Zeng
Cc: Jiewen Yao Cc: Eric Dong Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCoreLib.inf | 4 ++-- 1 file

[edk2] [PATCH 6/7] SecurityPkg OpalPasswordSupportLib: Remove it

2018-03-06 Thread Star Zeng
Remove OpalPasswordSupportLib as it is not been used anymore. Cc: Jiewen Yao Cc: Eric Dong Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng ---

[edk2] [PATCH 7/7] SecurityPkg OpalPasswordExtraInfoVariable.h: Remove it

2018-03-06 Thread Star Zeng
Remove OpalPasswordExtraInfoVariable.h as it is not been used anymore. Cc: Jiewen Yao Cc: Eric Dong Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng ---

[edk2] How load Duet Floppy.IMG File in Bochs or Quemu?

2018-03-06 Thread David Moheban
Hi, My Duet floppy image that i compiled with Gcc 5 gets stuck when I try to run it in Bochs or Qemu as it does not get any further than 'Welcome to Efi World'. Is that normal or are there specific setting needed in the Bochs config to get it emulated? Thank you Sent from my iPhone

[edk2] [PATCH v1] Platform/ARM/VExpressPkg: Fix RSDT pointer in RSDP

2018-03-06 Thread Sami Mujawar
According to the SBBR Specification (ARM DEN 0044B), Section 4.2.1.1 "Within the RSDP, the RsdtAddress field must be null (zero) and the XsdtAddresss MUST be a valid, non-null, 64-bit value." The PcdAcpiExposedTableVersions is used to indicate the ACPI versions that are supported. The

Re: [edk2] [PATCH] ArmPkg/TimerDxe: Always perform an EOI, even for spurious interrupts

2018-03-06 Thread Marc Zyngier
On 06/03/18 14:25, Laszlo Ersek wrote: > On 03/06/18 14:24, Ard Biesheuvel wrote: >> From: Marc Zyngier >> >> The generic timer driver only EOIs the timer interrupt if >> the ISTATUS bit is set. This is completely fine if you pretend >> that spurious interrupts do not exist.

Re: [edk2] [PATCH] ArmPkg/TimerDxe: Always perform an EOI, even for spurious interrupts

2018-03-06 Thread Ard Biesheuvel
On 6 March 2018 at 14:25, Laszlo Ersek wrote: > On 03/06/18 14:24, Ard Biesheuvel wrote: >> From: Marc Zyngier >> >> The generic timer driver only EOIs the timer interrupt if >> the ISTATUS bit is set. This is completely fine if you pretend >> that

Re: [edk2] [PATCH 3/7] HACK: HobLib: workaround infinite loop

2018-03-06 Thread Laszlo Ersek
On 03/06/18 01:45, Brian J. Johnson wrote: > On 03/05/2018 12:22 PM, Laszlo Ersek wrote: >> PEIMs generally "execute in place" (XIP), i.e. they run from flash, not >> RAM. In this status they use "temporary RAM" (e.g. CPU caches configured >> like RAM) for stack & heap; whatever HOBs they produce

Re: [edk2] [PATCH 2/2] MdeModulePkg/Core: Fix feature conflict between NX and Stack guard

2018-03-06 Thread Wu, Hao A
Got it, I will send out a V2 of the series according to the comments. Best Regards, Hao Wu > -Original Message- > From: Yao, Jiewen > Sent: Tuesday, March 06, 2018 9:11 PM > To: Yao, Jiewen; Zeng, Star; Wu, Hao A; edk2-devel@lists.01.org > Cc: Ni, Ruiyu; Dong, Eric > Subject: RE: [PATCH

Re: [edk2] [PATCH 2/2] MdeModulePkg/Core: Fix feature conflict between NX and Stack guard

2018-03-06 Thread Yao, Jiewen
BTW: I don't think "StackBaseFound" is really needed. We can use ASSERT (StackBase != 0); directly. :-) Thank you Yao Jiewen > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yao, > Jiewen > Sent: Tuesday, March 6, 2018 9:05 PM > To: Zeng,

Re: [edk2] [PATCH 2/2] MdeModulePkg/Core: Fix feature conflict between NX and Stack guard

2018-03-06 Thread Zeng, Star
A quick minor comment. GetHobList() could be used instead of EfiGetSystemConfigurationTable (, ). Thanks, Star -Original Message- From: Wu, Hao A Sent: Tuesday, March 6, 2018 8:11 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Wang, Jian J ;

[edk2] [PATCH] ArmPkg/TimerDxe: Always perform an EOI, even for spurious interrupts

2018-03-06 Thread Ard Biesheuvel
From: Marc Zyngier The generic timer driver only EOIs the timer interrupt if the ISTATUS bit is set. This is completely fine if you pretend that spurious interrupts do not exist. But as a matter of fact, they do, and the first one will leave the interrupt activated at the

[edk2] [PATCH 2/2] MdeModulePkg/Core: Fix feature conflict between NX and Stack guard

2018-03-06 Thread Hao Wu
If enabled, NX memory protection feature will mark some types of active memory as NX (non-executable), which includes the first page of the stack. This will overwrite the attributes of the first page of the stack if the stack guard feature is also enabled. The solution is to override the

[edk2] [PATCH 0/2] Resolve feature conflict between NX and Stack guard

2018-03-06 Thread Hao Wu
If enabled, NX memory protection feature will mark some types of active memory as NX (non-executable), which includes the first page of the stack. This will overwrite the attributes of the first page of the stack if the stack guard feature is also enabled. The series will override the attributes

[edk2] [PATCH 1/2] MdeModulePkg/Core: Refine handling NULL detection in NX setting

2018-03-06 Thread Hao Wu
The commit rewrites the logic in function InitializeDxeNxMemoryProtectionPolicy() for handling the first page (page 0) when NULL pointer detection feature is enabled. Instead of skip setting the page 0, the codes will now override the attribute setting of page 0 by adding the 'EFI_MEMORY_RP'

Re: [edk2] [PATCH 00/20] OvmfPkg: SEV: decrypt the initial SMRAM save state map for SMBASE relocation

2018-03-06 Thread Laszlo Ersek
On 03/02/18 16:21, Brijesh Singh wrote: > > > On 03/01/2018 06:03 PM, Laszlo Ersek wrote: > ... > >> >> I regression-tested my usual non-SEV guests (with Brijesh's v2 2/2 patch >> applied on top, from the above-referenced series), which covers i440fx >> (no SMM, X64), q35 (SMM, IA32 and

Re: [edk2] [PATCH 1/2] MdeModulePkg/Core: Refine handling NULL detection in NX setting

2018-03-06 Thread Yao, Jiewen
reviewed-by: jiewen@intel.com > -Original Message- > From: Wu, Hao A > Sent: Tuesday, March 6, 2018 8:11 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Wang, Jian J ; > Zeng, Star ; Dong, Eric ;

Re: [edk2] [PATCH 2/2] MdeModulePkg/Core: Fix feature conflict between NX and Stack guard

2018-03-06 Thread Yao, Jiewen
Agree. With this update, reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Tuesday, March 6, 2018 8:16 PM > To: Wu, Hao A ; edk2-devel@lists.01.org > Cc: Wang, Jian J ; Dong, Eric ; > Yao,

Re: [edk2] [PATCH 1/5] MdePkg/SPI: Change function definitions to match their descriptions.

2018-03-06 Thread Marvin Häuser
Hey Dandan, Thanks for your reply. I issued updates for the current headers because I saw activity in edk2-platforms to implement these incomplete protocols and because I haven't heard back for discussed changes in the specification for some time. Sure I could help submitting the ECR, however

Re: [edk2] [PATCH v4 0/2] quirks handling for SDHCI controllers

2018-03-06 Thread Meenakshi Aggarwal
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, March 06, 2018 4:41 PM > To: Meenakshi Aggarwal > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH v4 0/2] quirks handling for SDHCI controllers > > On 6

[edk2] [PATCH v2 2/2] MdeModulePkg/Core: Fix feature conflict between NX and Stack guard

2018-03-06 Thread Hao Wu
If enabled, NX memory protection feature will mark some types of active memory as NX (non-executable), which includes the first page of the stack. This will overwrite the attributes of the first page of the stack if the stack guard feature is also enabled. The solution is to override the

[edk2] [PATCH v2 0/2] Resolve feature conflict between NX and Stack guard

2018-03-06 Thread Hao Wu
V2 changes: A. Use Hoblib APIs to get the base of stack from Hob. B. Remove unnecessary local variable used in function InitializeDxeNxMemoryProtectionPolicy(). V1 history: If enabled, NX memory protection feature will mark some types of active memory as NX (non-executable), which includes

[edk2] [PATCH v2 1/2] MdeModulePkg/Core: Refine handling NULL detection in NX setting

2018-03-06 Thread Hao Wu
The commit rewrites the logic in function InitializeDxeNxMemoryProtectionPolicy() for handling the first page (page 0) when NULL pointer detection feature is enabled. Instead of skip setting the page 0, the codes will now override the attribute setting of page 0 by adding the 'EFI_MEMORY_RP'

Re: [edk2] [PATCH v2 2/2] MdeModulePkg/Core: Fix feature conflict between NX and Stack guard

2018-03-06 Thread Yao, Jiewen
Both patches are reviewed-by: jiewen@intel.com > -Original Message- > From: Wu, Hao A > Sent: Tuesday, March 6, 2018 9:33 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Wang, Jian J ; > Zeng, Star ; Dong, Eric