From: Jaben
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/GenFds/FfsInfStatement.py | 21
From: Jaben
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/Workspace/DscBuildData.py | 2 --
1 file
group of patches for refactoring BaseTools. removing unused functions,
variables, and parameters. make functions statis where apropriate.
Jaben (9):
BaseTools: remove unused local variable.
BaseTools: change DscBuildData functions without need for self to
staticmethod
BaseTools:
From: Jaben
prepend functiosn with @staticmethod
change calls to use class name, not self
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
From: Jaben
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/Workspace/DscBuildData.py | 11 +--
From: Jaben
make functions that doesn't use self into @staticmethod
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
On Fri, Apr 13, 2018 at 07:24:06PM +, Kinney, Michael D wrote:
> Hi Leif,
>
> I think we need to look at the names. I see a mix of
> "Be" and "Swap". We should pick one and use it
> consistently.
This was what I meant by the comments:
---
This modified version introduces a single BeIoLib
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/CommonDataClass/ModuleClass.py | 485
On 04/12/18 12:03, Long, Qin wrote:
>
> Ah, "it's wrong here" means "the existence of "--remote" in original
> suggested command is wrong".
> "It's important" looks also make sense to address the "update" goal. I can
> update that, if old message will cause confusion.
With the commit message
On 04/12/18 05:08, Long Qin wrote:
> (https://bugzilla.tianocore.org/show_bug.cgi?id=927)
>
> (V2 Update:
> Removing the wrong "--remote" option from git submodule update
> command in this commit message. Thanks Leszlo's clarification
> to correct this)
(1) "Laszlo", not "Leszlo" :)
From: Jaben
__GetInfStatement() does not use the dict parameter, so remove it
from the API and from all callers.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben
From: Jaben
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/build/build.py | 4 +---
1 file changed, 1
From: Jaben
change default parameter value to None since the parameter isn't used.
remove temporary dictionary and just do the reaplce call.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution
From: Jaben
3 functions were never called:
_dumpPcdInfo
__STRING2OCTList
__UNICODE2OCTList
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/CommonDataClass/PackageClass.py | 127
Hi Leif,
I think we need to look at the names. I see a mix of
"Be" and "Swap". We should pick one and use it
consistently.
Mike
> -Original Message-
> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> Sent: Friday, April 13, 2018 10:42 AM
> To: edk2-devel@lists.01.org
> Cc:
When performing MMIO to a destination of the opposite endianness to the
executing processor, this library provides automatic byte order reversal
on inputs and outputs.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Leif Lindholm
---
Udit, many
Cc: Andrew Fish
Cc: Laszlo Ersek
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Leif Lindholm
---
Maintainers.txt | 1 +
1 file changed, 1 insertion(+)
diff
Leif,
I am curious why a Swap class/instances is not sufficient.
Currently EDK II follows the UEFI/PI specs, which for
all supported CPU architectures use little endian ABI.
The BaseIoLib follows the endianness of the CPU. If
UEFI/PI added a CPU that was big endian, I would expect
BaseIoLib
Mva address calculation should use the left-shifted current
section index instead of the left-shifted table base address.
Using the table base address here has the side-effect of potentially
causing an access violation depending on the base address value.
Cc: Leif Lindholm
On 13 April 2018 at 04:05, Guo Heyi wrote:
> Hi Ard,
>
> Any comments?
>
Apologies for the delay. I have been travelling and am behind on email.
> Anyway we can modify the code if you insist on using an intermediate CPU IO
> address space.
>
I have not made up my mind yet,
Hi Star,
On 04/13/18 07:15, Zeng, Star wrote:
> Generally, I am ok with the change.
> But, what is the case for the change?
> If the new "if condition" is TRUE, the ASSERT above it will happen, so the
> new "if condition" is for RELEASE build case?
> And if the code passes Support() check, then
d69d9227d046211265de1fab5580c50a65944614 caused system firmware update
failure. It is because FindMatchingFmpHandles() is expected to return
handles matched, but the function returns all handles found.
This patch is to fix the issue.
This patch also assigns mSystemFmpPrivate->Handle for "case 1:"
Thanks Laszlo.
If the commit log is updated to reference the BZ link or even add more detailed
information.
Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Friday, April 13, 2018 5:00 PM
To: Zeng, Star
On 04/11/18 12:42, Laszlo Ersek wrote:
> Repo: https://github.com/lersek/edk2.git
> Branch: tls_ciphers_v2
>
> This is version 2 of the series posted earlier at
>
> 20180403145149.8925-1-lersek@redhat.com">http://mid.mail-archive.com/20180403145149.8925-1-lersek@redhat.com
>
25 matches
Mail list logo