Re: [edk2] [PATCH 0/2] Capsule: Fix typo 'Press' to 'Process'

2018-07-11 Thread Yao, Jiewen
Series reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Tuesday, July 10, 2018 6:23 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Kinney, Michael D > ; Yao, Jiewen ; Shao, > Ming > Subject: [PATCH 0/2] Capsule: Fix typo 'Press' to 'Process' > > Cc:

Re: [edk2] [PATCH 06/37] CorebootModulePkg: Removing ipf from edk2.

2018-07-11 Thread You, Benjamin
Reviewed-by: Benjamin You > -Original Message- > From: Chen, Chen A > Sent: Wednesday, June 13, 2018 11:43 AM > To: edk2-devel@lists.01.org > Cc: Chen, Chen A ; Ma, Maurice > ; Agyeman, Prince ; You, > Benjamin ; Kinney, Michael D > > Subject: [PATCH 06/37] CorebootModulePkg: Removing

Re: [edk2] [PATCH] Platform/ARM: Correct LevelID in PLPI packages of DSDT

2018-07-11 Thread Ard Biesheuvel
On 10 July 2018 at 13:55, Evan Lloyd wrote: > Reviewed-by: Evan Lloyd > >> -Original Message- >> From: AlexeiFedorov >> Sent: 04 July 2018 14:05 >> To: edk2-devel@lists.01.org >> Cc: Arvind Chauhan ; Thomas Abraham >> ; ard.biesheu...@linaro.org; >> leif.lindh...@linaro.org; Matteo

Re: [edk2] [PATCH] MdeModulePkg CapsuleApp: Fix NestedCapsuleHeader->Flags assigned wrong

2018-07-11 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Tuesday, July 10, 2018 6:24 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Kinney, Michael D > ; Yao, Jiewen ; Shao, > Ming > Subject: [PATCH] MdeModulePkg CapsuleApp: Fix NestedCapsuleHeader->Flags >

Re: [edk2] [PATCH 07/37] CorebootPayloadPkg: Removing ipf from edk2.

2018-07-11 Thread You, Benjamin
Reviewed-by: Benjamin You > -Original Message- > From: Chen, Chen A > Sent: Wednesday, June 13, 2018 11:44 AM > To: edk2-devel@lists.01.org > Cc: Chen, Chen A ; Ma, Maurice > ; Agyeman, Prince ; You, > Benjamin ; Kinney, Michael D > > Subject: [PATCH 07/37] CorebootPayloadPkg: Removing

Re: [edk2] [PATCH 0/3] CapsuleApp: Some enhancements

2018-07-11 Thread Yao, Jiewen
Series reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Wednesday, July 11, 2018 11:51 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Kinney, Michael D > ; Yao, Jiewen ; Zhu, > Yonghong > Subject: [PATCH 0/3] CapsuleApp: Some enhancements > > Cc:

Re: [edk2] question about armclang support

2018-07-11 Thread Ard Biesheuvel
(+ Leif) On 10 July 2018 at 15:14, Laszlo Ersek wrote: > Hello Sau Kae, > > On 07/10/18 11:14, Tan, Sau Kae wrote: >> Hi All, >> >> May I know is armclang already supported in EDK2? >> Or only armcc is supported currently? >> Thanks. > > Looking at "BaseTools/Conf/tools_def.template", the

[edk2] [Patch 2/3] UefiCpuPkg/MpInitLib: Use BSP uCode for APs if possible.

2018-07-11 Thread Eric Dong
Search uCode costs much time, if AP has same processor type with BSP, AP can use BSP saved uCode info to get better performance. This change enables this solution. Cc: Laszlo Ersek Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong ---

[edk2] [Patch 0/3] Optimize load uCode performance

2018-07-11 Thread Eric Dong
Use below three rules to optimize load uCode performance: 1. Let BSP relocate uCode from flash to memory for better performance. 2. BSP caches the CPU ID and address of uCode so AP doesn’t need to look for the uCode again if the CPU ID is same as BSP’s. 3. Only apply uCode in one thread of a

[edk2] [Patch 1/3] UefiCpuPkg/MpInitLib: Relocate uCode to memory to save time.

2018-07-11 Thread Eric Dong
Read uCode from memory has better performance than from flash. But it needs extra effort to let BSP copy uCode from flash to memory. Also BSP already enable cache in SEC phase, so it use less time to relocate uCode from flash to memory. After verification, if system has more than one processor, it

Re: [edk2] 答复: [Patch] UefiCpuPkg/MpInitLib: Optimize get processor number performance.

2018-07-11 Thread Yao, Jiewen
Hi I believe using stack pointer is not a robust way if the stack guard feature is not enabled. Stack pointer may overflow. Can we use GDT? Each AP has its own GDT. Thank you Yao Jiewen > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dong,

[edk2] [Patch 3/3] UefiCpuPkg/MpInitLib: Load uCode once for one core.

2018-07-11 Thread Eric Dong
SDM requires one core only needs to load uCode once. Also load uCode once can save some time. This change enables this solution. Cc: Laszlo Ersek Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpuPkg/Library/MpInitLib/Microcode.c | 9

Re: [edk2] [PATCH v2] SecurityPkg: Fix assert when setting key from eMMC/SD/USB

2018-07-11 Thread Ard Biesheuvel
On 11 July 2018 at 14:05, Laszlo Ersek wrote: > Hi Roman, > > On 07/11/18 00:51, rba...@gmail.com wrote: >> From: Roman Bacik >> >> When secure boot is enabled, if one loads keys from a FAT formatted >> eMMC/SD/USB when trying to provision PK/KEK/DB keys via the menu, >> an assert in StrLen()

Re: [edk2] [PATCH v4 6/9] ArmPkg/PlatformBDS: Implement PlatformBootManagerUnableToBoot

2018-07-11 Thread Ard Biesheuvel
On 4 July 2018 at 03:50, Ruiyu Ni wrote: > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni > Cc: Leif Lindholm > Cc: Ard Biesheuvel Acked-by: Ard Biesheuvel > --- > ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 18 +- > 1 file

Re: [edk2] [PATCH edk2-platforms v2 1/6] Hisilicon/D0x: Fix invoke SetMemorySpaceAttributes error bug

2018-07-11 Thread Ard Biesheuvel
On 4 July 2018 at 09:51, Ming Huang wrote: > The edk2 commit bacfd6e let CpuDxe running latter. > CpuDxe is needed by gDS->SetMemorySpaceAttributes, and > gDS->SetMemorySpaceAttributes is invoked by some drivers. > > This issue can solve by adding Depex on gEfiCpuArchProtocolGuid > to

Re: [edk2] 答复: [Patch] UefiCpuPkg/MpInitLib: Optimize get processor number performance.

2018-07-11 Thread Laszlo Ersek
On 07/11/18 13:31, Dong, Eric wrote: > Hi Jiewen, > > I checked the code, found in the AP function (ApWakeupFunction), it updated > the GDT value with the saved GDT value from BSP. So I think we can't use GDT > in this case. Right? > > // > // Sync BSP's Control registers to APs >

Re: [edk2] [PATCH v2] SecurityPkg: Fix assert when setting key from eMMC/SD/USB

2018-07-11 Thread Carsey, Jaben
> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Wednesday, July 11, 2018 5:16 AM > To: rba...@gmail.com; edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Vladimir Olovyannikov > ; Justen, Jordan L > ; Gao, Liming ; Carsey, >

Re: [edk2] [PATCH v2] SecurityPkg: Fix assert when setting key from eMMC/SD/USB

2018-07-11 Thread Laszlo Ersek
On 07/11/18 19:10, Carsey, Jaben wrote: > >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> Laszlo Ersek >> Sent: Wednesday, July 11, 2018 5:16 AM >> To: rba...@gmail.com; edk2-devel@lists.01.org >> Cc: Ni, Ruiyu ; Vladimir Olovyannikov >>

Re: [edk2] [PATCH v2] SecurityPkg: Fix assert when setting key from eMMC/SD/USB

2018-07-11 Thread Laszlo Ersek
Hi Roman, On 07/11/18 00:51, rba...@gmail.com wrote: > From: Roman Bacik > > When secure boot is enabled, if one loads keys from a FAT formatted > eMMC/SD/USB when trying to provision PK/KEK/DB keys via the menu, > an assert in StrLen() occurs. > This is because the filename starts on odd

[edk2] reg: PXE Boot Enhancement

2018-07-11 Thread Sivaraman Nainar
Hello All, During PXE boot if the operation fails to connect the PXE server, system waits for the user's manual Key input to abort the operation and proceed further. It would be nice to have an option to set timeout before starting PXE boot so that if there's any issue with the PXE boot

Re: [edk2] [PATCH v2] SecurityPkg: Fix assert when setting key from eMMC/SD/USB

2018-07-11 Thread Laszlo Ersek
On 07/11/18 14:05, Laszlo Ersek wrote: > - The OpenFileByDevicePath() function is duplicated in the following > modules: "NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c", and > "MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskFileExplorer.c". With the > implication that the alignment issue you

[edk2] OVMF dynamic NVRAM size discovering

2018-07-11 Thread Denis Plotnikov
Hello! I'd like to ask whether it's a good idea or not to make the omfv discover the variable image size in the runtime. We have a setting in our product to use separate pflash images for OVMF code and variables parts in QEMU/KVM based virtual machines. Currently, we use a 2M code image but

Re: [edk2] 答复: [Patch] UefiCpuPkg/MpInitLib: Optimize get processor number performance.

2018-07-11 Thread Dong, Eric
Hi Jiewen, I checked the code, found in the AP function (ApWakeupFunction), it updated the GDT value with the saved GDT value from BSP. So I think we can't use GDT in this case. Right? // // Sync BSP's Control registers to APs // RestoreVolatileRegisters

Re: [edk2] [PATCH v2] SecurityPkg: Fix assert when setting key from eMMC/SD/USB

2018-07-11 Thread Roman Bacik
Signed-off-by: Roman Bacik On Tue, Jul 10, 2018 at 3:51 PM, wrote: > From: Roman Bacik > > When secure boot is enabled, if one loads keys from a FAT formatted > eMMC/SD/USB when trying to provision PK/KEK/DB keys via the menu, > an assert in StrLen() occurs. > This is because the filename

Re: [edk2] OVMF dynamic NVRAM size discovering

2018-07-11 Thread Laszlo Ersek
On 07/11/18 15:01, Denis Plotnikov wrote: > Hello! > > I'd like to ask whether it's a good idea or not to make the omfv > discover the variable image size in the runtime. Not a good idea. > We have a setting in our product to use separate pflash images for OVMF > code and variables parts in

Re: [edk2] [Patch 0/3] Optimize load uCode performance

2018-07-11 Thread Laszlo Ersek
Hi Eric, On 07/11/18 13:07, Eric Dong wrote: > Use below three rules to optimize load uCode performance: > 1. Let BSP relocate uCode from flash to memory for better performance. > 2. BSP caches the CPU ID and address of uCode so AP doesn’t need to look >for the uCode again if the CPU ID is

Re: [edk2] [PATCH v2] SecurityPkg: Fix assert when setting key from eMMC/SD/USB

2018-07-11 Thread Roman Bacik
Hi Laszlo, Thank you very much for your review and help. I would prefer the option 2b. Thanks, Roman On Wed, Jul 11, 2018 at 5:05 AM, Laszlo Ersek wrote: > Hi Roman, > > On 07/11/18 00:51, rba...@gmail.com wrote: > > From: Roman Bacik > > > > When secure boot is enabled, if one loads keys

Re: [edk2] [PATCH v2] SecurityPkg: Fix assert when setting key from eMMC/SD/USB

2018-07-11 Thread Laszlo Ersek
On 07/11/18 17:44, Roman Bacik wrote: > Hi Laszlo, > > Thank you very much for your review and help. I would prefer the option 2b. Great, thanks! Let's wait for the SecurityPkg maintainers then, to give their R-b's for your patch. Chao Zhang, Jiewen, can you please comment? >From my side,

[edk2] Reg: Intel Rangley Support in EDK

2018-07-11 Thread Dhanasekar Jaganathan
Hi, I have booted Intel Rangley / MohonPeak platform in coreboot with Intel FSP. I am unable to install UEFI OS in coreboot (sometime). EDK bios will install both UEFI and Legacy OS. Does Open EDK supports Intel Rangley platform?. Is code base available for Intel Rangely platform? Thanks,

Re: [edk2] 答复: [Patch] UefiCpuPkg/MpInitLib: Optimize get processor number performance.

2018-07-11 Thread Dong, Eric
Hi Laszlo, > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, July 11, 2018 11:12 PM > To: Dong, Eric ; Yao, Jiewen ; > Fan Jeff ; edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: Re: [edk2] 答复: [Patch] UefiCpuPkg/MpInitLib: Optimize get > processor

[edk2] [Patch][edk2-platforms/devel-IntelAtomProcessorE3900] Change BIOS version

2018-07-11 Thread Guo, Mang
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Guo Mang --- Platform/BroxtonPlatformPkg/BiosId.env | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/BroxtonPlatformPkg/BiosId.env b/Platform/BroxtonPlatformPkg/BiosId.env index ff1aa87..b9cb0fd

[edk2] [Patch] ShellPkg/TftpDynamicCommand: Fix the potential assertion and memory leak issue.

2018-07-11 Thread Jiaxin Wu
From: Jiaxin Wu This patch is to fix the issue reported from https://bugzilla.tianocore.org/show_bug.cgi?id=925. DataSize variable was not assigned the value if ShellOpenFileByName returns error. In the such a case, it should not be used to FreePages. Instead, DataSize can be used to record

Re: [edk2] [PATCH 07/14] BaseTools: Use absolute import in BPDG

2018-07-11 Thread Gary Lin
On Thu, Jul 12, 2018 at 12:52:32AM +, Zhu, Yonghong wrote: > Hi Gary, > > I got below error: > > Traceback (most recent call last): > File "C:\TCWork\Edk2\BaseTools\Source\Python\BPDG\BPDG.py", line 34, in > > from . import StringTable as st > ValueError: Attempted relative import in

Re: [edk2] [Patch] ShellPkg/TftpDynamicCommand: Fix the potential assertion and memory leak issue.

2018-07-11 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: Wu, Jiaxin > Sent: Thursday, July 12, 2018 8:44 AM > To: edk2-devel@lists.01.org > Cc: Wu, Jiaxin ; Ye, Ting ; Fu, > Siyuan ; Carsey, Jaben > Subject: [Patch] ShellPkg/TftpDynamicCommand: Fix the potential assertion > and memory

Re: [edk2] [PATCH] BaseTool: Fixed the incorrect cache key.

2018-07-11 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Feng, Bob C > Sent: Wednesday, July 11, 2018 12:19 AM > To: edk2-devel@lists.01.org > Cc: Feng, Bob C ; Gao, Liming > Subject: [PATCH] BaseTool: Fixed the incorrect cache key. > > From: "bob.c.f...@intel.com" > > This patch is to

Re: [edk2] [PATCH 07/14] BaseTools: Use absolute import in BPDG

2018-07-11 Thread Zhu, Yonghong
Hi Gary, I got below error: Traceback (most recent call last): File "C:\TCWork\Edk2\BaseTools\Source\Python\BPDG\BPDG.py", line 34, in from . import StringTable as st ValueError: Attempted relative import in non-package Best Regards, Zhu Yonghong -Original Message- From: Gary

[edk2] Organization of github.com/IntelFsp/FSP

2018-07-11 Thread Desimone, Nathaniel L
Hi All, Recently a discussion came up on the coreboot mailing list regarding the organization of the github.com/IntelFsp/FSP repository. Currently the repository is organized with each platform on its own branch. This organization makes it difficult to set up a git submodule that pulls the

Re: [edk2] [PATCH v2] SecurityPkg: Fix assert when setting key from eMMC/SD/USB

2018-07-11 Thread Laszlo Ersek
On 07/11/18 18:06, Laszlo Ersek wrote: > On 07/11/18 17:44, Roman Bacik wrote: >> Hi Laszlo, >> >> Thank you very much for your review and help. I would prefer the option 2b. > > Great, thanks! Let's wait for the SecurityPkg maintainers then, to give > their R-b's for your patch. Chao Zhang,