From: Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=996
Issue:
In current code logic, when a key is pressed, it will search
the whole NotifyList to find whether a notification has been
registered with the keystroke. if yes, it will en-queue the
key for notification execution
From: Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=996
Issue:
In current code logic, when a key is pressed, it will search
the whole NotifyList to find whether a notification has been
registered with the keystroke. if yes, it will en-queue the
key for notification execution
From: Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=996
Issue:
In current code logic, when a key is pressed, it will search
the whole NotifyList to find whether a notification has been
registered with the keystroke. if yes, it will en-queue the
key for notification execution
This change is wrong introduced by e21e355e2ca7fefb15b4df7078f995d3fb9c2b89
It is not required. So, revert it.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao
Cc: Jiewen Yao
---
UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm | 9 ++---
1 file changed, 2
Today's implementation does an exact device path match to check
whether the device path of a console is in ConIn/ConOut/ErrOut.
But that doesn't work for the USB keyboard.
Because when a platform have multiple USB port, ConIn needs to
carry all device paths corresponding to each port.
Even worse,
Today's InterlockedIncrement()/InterlockedDecrement() guarantees to
perform atomic increment/decrement but doesn't guarantee the return
value equals to the new value.
The patch fixes the behavior to use "XADD" instruction to guarantee
the return value equals to the new value.
Contributed-under:
Hi
Can we use XSUB for decrement?
Thank you
Yao Jiewen
> -Original Message-
> From: Ni, Ruiyu
> Sent: Monday, September 10, 2018 6:06 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Gao, Liming
> ; Kinney, Michael D
> Subject: [PATCH] MdePkg/SynchronizationLib: fix
(1) Update EDK2 TianoCore logo to the latest.
(2) Extend logo showing period to the late stage of BDS.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: David Wei
CC: Mike Wu
CC: Mang Guo
---
.../AuroraGlacier/BoardInitPostMem/BoardInit.c | 2 +-
Hi Team,
Thank it’s got worked on dp -t 0.
> On 07-Sep-2018, at 9:27 PM, prabin ca wrote:
>
> Hi
>
> Yes it is included in same module (both event handler and function handler),
> and I’m not perf_start and perf_end only two times (one is by event handler
> and one is by normal function
Ray,
Why are we removing the use of intrinsics from
MSFT builds? We should keep those for more efficient
code generation if the intrinsic has the correct
behavior.
Thanks,
Mike
> -Original Message-
> From: Ni, Ruiyu
> Sent: Monday, September 10, 2018 3:06 AM
> To:
I didn’t find such instruction in SDM.
发自我的 iPhone
> 在 2018年9月10日，下午7:37，Yao, Jiewen 写道：
>
> Hi
> Can we use XSUB for decrement?
>
> Thank you
> Yao Jiewen
>
>> -Original Message-
>> From: Ni, Ruiyu
>> Sent: Monday, September 10, 2018 6:06 PM
>> To: edk2-devel@lists.01.org
>> Cc:
You are right. My mistake.
> -Original Message-
> From: Ni, Ruiyu
> Sent: Monday, September 10, 2018 10:59 PM
> To: Yao, Jiewen
> Cc: edk2-devel@lists.01.org; Gao, Liming ; Kinney,
> Michael D
> Subject: Re: [PATCH] MdePkg/SynchronizationLib: fix
> Interlocked[De|In]crement return value
Update the WorkspaceAutoGen class to use caching decorators and remove
the no longer needed private variables.
Cc: Liming Gao
Cc: Yonghong Zhu
Cc: Bob Feng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/AutoGen/AutoGen.py | 69
update the classes for the following:
1) use decorators for property
2) use decorators for caching property and caching function
- this allows for objects to reduce in size as they get used
3) remove unused variables and properties
4) use tuple instead of custom class when apropriate
5) remove
1) use decorators
2) also change some private functions to public when all callers are
external
3) change external callers to use functions instead of directly
accessing private data.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben
use decorators and auto cache those that were cached manually
remove properties never used
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/Common/Misc.py | 90 +---
1 file changed,
use Common.caching and auto cache properties and functions of InfBuildData
Cc: Liming Gao
Cc: Yonghong Zhu
Cc: Bob Feng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/Workspace/InfBuildData.py | 840 +---
1 file
use function decorators
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/AutoGen/GenMake.py | 20
1 file changed, 8 insertions(+), 12 deletions(-)
diff --git
use decorators for property and automatic caching
remove circular dependency between some APIs
Cc: Liming Gao
Cc: Yonghong Zhu
Cc: Bob Feng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/AutoGen/AutoGen.py | 587
currently created for 3 different purposes and saved once.
this makes it created once and saved and then referenced.
Cc: Liming Gao
Cc: Yonghong Zhu
Cc: Bob Feng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/AutoGen/AutoGen.py
FlexibleFieldName was never used not set.
DefinitionPosition (file and line number) are recalculated
and never used outside the function. remove the saving of the
data.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
1) use namedtuple instead of custom class when apropriate
2) rename collections.OrderedDict to OrderedDict since we import it already
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
remove uncalled functions
remove extra blank lines
remove commented out code
Cc: Yonghong Zhu
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/GenFds/FdfParser.py | 56
1 file changed, 56
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Zeng, Star
> Sent: Tuesday, September 11, 2018 10:04 AM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Ni, Ruiyu ; Wang,
> Jian J ; Wang, Fei1
> Subject: [PATCH] MdeModulePkg XhciDxe: Set HSEE Bit if SERR# Enable Bit is
>
From: zhijufan
The case is user use 0x1} as a hex value for Pcd, it directly cause
tool report traceback info. This patch add more error info.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan
---
When the HSEE in the USBCMD bit is a ‘1’ and the HSE bit in the USBSTS
register is a ‘1’, the xHC shall assert out-of-band error signaling to
the host and assert the SERR# pin.
To prevent masking any potential issues with SERR, this patch is to set
USBCMD Host System Error Enable(HSEE) Bit if
The reason I didn't remove the GCC version is because Liming told me that there
is a XCODE issue which prevents using NASM for library.
Thanks/Ray
> -Original Message-
> From: Ni, Ruiyu
> Sent: Tuesday, September 11, 2018 10:25 AM
> To: Kinney, Michael D ; edk2-
> de...@lists.01.org
>
The NASM does the exactly same as the MSFT intrinsic.
I'd like to remove them because I was almost lost in so many versions of
Interlocked[De|In]crement.
I'd like to merge them to one version.
Thanks/Ray
> -Original Message-
> From: Kinney, Michael D
> Sent: Tuesday, September 11, 2018
BZ#: https://bugzilla.tianocore.org/show_bug.cgi?id=1166
Cc: Dandan Bi
Cc: Hao A Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jian J Wang
---
UefiCpuPkg/CpuMpPei/CpuPaging.c | 23 ---
1 file changed, 16 insertions(+), 7 deletions(-)
diff --git
BZ#: https://bugzilla.tianocore.org/show_bug.cgi?id=1116
Since the stack memory is allocated as EfiBootServicesData, its NX protection
can be covered by BIT4 of PcdDxeNxMemoryProtectionPolicy. To avoid confusing
in setting related PCDs, PcdSetNxForStack will be expired. Instead, If BIT4
of
BZ#: https://bugzilla.tianocore.org/show_bug.cgi?id=1116
Since PcdSetNxForStack is expired, remove related config code.
PcdDxeNxMemoryProtectionPolicy cannot be used as dynamic PCD.
There's no need to add it in code to replace PcdSetNxForStack.
Cc: Laszlo Ersek
Cc: Star Zeng
Cc: Jordan Justen
BZ#: https://bugzilla.tianocore.org/show_bug.cgi?id=1116
Since PcdSetNxForStack is expired, remove all references. The default
setting of PcdDxeNxMemoryProtectionPolicy has covered PcdSetNxForStack.
Cc: Laszlo Ersek
Cc: Star Zeng
Cc: Ard Biesheuvel
Cc: Ruiyu Ni
Cc: Jiewen Yao
BZ#: https://bugzilla.tianocore.org/show_bug.cgi?id=1116
Since the stack memory is allocated as EfiBootServicesData, its NX protection
can be covered by BIT4 of PcdDxeNxMemoryProtectionPolicy. To avoid confusing
in setting related PCDs, PcdSetNxForStack will be expired. Instead, If BIT4
of
BZ#: https://bugzilla.tianocore.org/show_bug.cgi?id=1116
Since PcdSetNxForStack is expired, remove related references in dsc file.
Cc: Laszlo Ersek
Cc: Star Zeng
Cc: Jordan Justen
Cc: Ard Biesheuvel
Cc: Ruiyu Ni
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.1
BZ#: https://bugzilla.tianocore.org/show_bug.cgi?id=1116
Since the stack memory is allocated as EfiBootServicesData, its NX protection
can be covered by BIT4 of PcdDxeNxMemoryProtectionPolicy. To avoid confusing
in setting related PCDs, PcdSetNxForStack will be expired. Set BIT4 of
Thanks to simply the PCD usage.
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org]
> Sent: Tuesday, September 11, 2018 1:17 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH 0/5] expire the use of PcdSetNxForStack
>
36 matches
Mail list logo
