Re: [edk2] [Patch] BaseTools GenFw: Fix XCODE5 build issue

2019-01-14 Thread Laszlo Ersek
On 01/14/19 14:52, Liming Gao wrote: > Remove extraneous parentheses around the comparison to silence this warning. Can you please quote the warning message in the commit message? It's unclear what warning the commit message refers to. (No need to repost just for this.) Thanks Laszlo > This

[edk2] [patch v2] MdePkg/BasePeCoffLib: Add more check for relocation data

2019-01-14 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1426 V2: (1) Add NULL pointer check for the input parameters (2) Add check for the "Adjust" value before applying fix ups. In function PeCoffLoaderRelocateImageForRuntime, it doesn't do much check when do relocation. For API level

[edk2] [PATCH V2 15/15] MdeModulePkg: Remove EmuVariableRuntimeDxe

2019-01-14 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 Merge EmuVariable and Real variable driver. The real variable driver has been updated to support emulated variable NV mode. This patch removes EmuVariableRuntimeDxe after platforms are migrated to use the merged variable driver. Cc: Jian J

[edk2] [PATCH V2 13/15] QuarkMin: Use merged variable driver for emulated NV mode

2019-01-14 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 Merge EmuVariable and Real variable driver. The real variable driver has been updated to support emulated variable NV mode and the EmuVariableRuntimeDxe will be removed later, so use merged variable driver for emulated NV mode. Cc: Michael

[edk2] [PATCH V2 14/15] CorebootPayloadPkg: Use merged variable driver for emulated NV mode

2019-01-14 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 Merge EmuVariable and Real variable driver. The real variable driver has been updated to support emulated variable NV mode and the EmuVariableRuntimeDxe will be removed later, so use merged variable driver for emulated NV mode. Cc: Maurice

[edk2] [PATCH V2 12/15] BeagleBoardPkg: Use merged variable driver for emulated NV mode

2019-01-14 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 Merge EmuVariable and Real variable driver. The real variable driver has been updated to support emulated variable NV mode and the EmuVariableRuntimeDxe will be removed later, so use merged variable driver for emulated NV mode. Cc: Leif

[edk2] [PATCH edk2-platforms 4/8] Silicon/SynQuacerMemoryInitPeiLib: don't map memory above MAX_ALLOC_ADDRESS

2019-01-14 Thread Ard Biesheuvel
When encountering memory that is above the threshold of what we can map, don't add it to the virtual memory table. This table is only used by the early MMU code that creates the 1:1 mapping, and since it cannot be mapped in the first place, there is no point. Contributed-under: TianoCore

[edk2] [PATCH edk2-platforms 5/8] Silicon/SynQuacerMemoryInitPeiLib: fix 32-bit build

2019-01-14 Thread Ard Biesheuvel
Add a missing intermediate UINTN case to fix the 32-bit build. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Silicon/Socionext/SynQuacer/Library/SynQuacerMemoryInitPeiLib/SynQuacerMemoryInitPeiLib.c | 2 +- 1 file changed, 1 insertion(+), 1

[edk2] [PATCH edk2-platforms 0/8] Silicon/SynQuacer: add support for 32-bit mode

2019-01-14 Thread Ard Biesheuvel
This series fixes various issues that prevent the SynQuacer/DeveloperBox platform from being built or executed in 32-bit mode. Ard Biesheuvel (8): Silicon/SynQuacer/NetsecDxe: fix 32-bit build Silicon/SynQuacer/OpteeRngDxe: fix 32-bit build Silicon/SynQuacerPciHostBridgeLib: fix MMIO32-only

[edk2] [PATCH edk2-platforms 6/8] Silicon/SynQuacer/Stage2Tables: fix 32-bit build

2019-01-14 Thread Ard Biesheuvel
The static stage2 page tables don't contain any code, but we are relying on the linker to resolve the references to the next level tables, so we can only use native word size quantities. So add a CPP macro to emit the same quantity in different ways. Contributed-under: TianoCore Contribution

[edk2] [PATCH edk2-platforms 8/8] Platform/Socionext/DeveloperBox: add resolution for ArmSoftFloatLib

2019-01-14 Thread Ard Biesheuvel
OpensslLib depends on ArmSoftFloatLib when built for 32-bit ARM, so add the required resolution for it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 3 +++ 1 file changed, 3 insertions(+) diff --git

[edk2] [PATCH edk2-platforms 3/8] Silicon/SynQuacerPciHostBridgeLib: fix MMIO32-only configuration

2019-01-14 Thread Ard Biesheuvel
When running on 32-bit ARM, we cannot decode the MMIO64 region, and so we don't set the EFI_PCI_HOST_BRIDGE_MEM64_DECODE flag in this case. However, with that flag cleared, it is no longer permitted to include a definition for the placement of the MMIO64 region either, so remove those as well if

[edk2] [PATCH edk2-platforms 2/8] Silicon/SynQuacer/OpteeRngDxe: fix 32-bit build

2019-01-14 Thread Ard Biesheuvel
Replace a UINT64 cast of a virtual address with a UINTN cast so that this driver can be built for 32-bit ARM as well. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Silicon/Socionext/SynQuacer/Drivers/OpteeRngDxe/OpteeRng.c | 2 +- 1 file changed, 1

[edk2] [PATCH edk2-platforms 7/8] Platform/Socionext/DeveloperBox: disable EbcDxe for ARM builds

2019-01-14 Thread Ard Biesheuvel
EBC and 32-bit ARM are fundamentally incompatible, so only enable it on AArch64 builds. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 4 +++- Platform/Socionext/DeveloperBox/DeveloperBox.fdf | 2 ++ 2

[edk2] [PATCH edk2-platforms 1/8] Silicon/SynQuacer/NetsecDxe: fix 32-bit build

2019-01-14 Thread Ard Biesheuvel
Tweak the definition of pfdep_cpu_addr_t and add some intermediate UINTN casts so that the NETSEC driver builds cleanly in 32-bit mode. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.c

Re: [edk2] [PATCH] IntelSiliconPkg\Include\IndustryStandard: Update IGD_OPREGION_MBOX3 Structure

2019-01-14 Thread Yao, Jiewen
Hi According to https://01.org/sites/default/files/documentation/skl_opregion_rev0p5.pdf, there is no the new field. Would you please give a new link for the latest spec to make sure code/doc match ? Thank you Yao Jiewen > -Original Message- > From: edk2-devel

Re: [edk2] [PATCH v2] BaseTools/tools_def GCC5: disable LTO for ASLC invocations

2019-01-14 Thread Ard Biesheuvel
On Mon, 14 Jan 2019 at 15:10, Gao, Liming wrote: > > Reviewed-by: Liming Gao > Pushed as 17f5fd9291e0..e695e44545b4 Thanks all > > -Original Message- > > From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com] > > Sent: Monday, January 14, 2019 10:09 PM > > To: Ard Biesheuvel ; Gao,

Re: [edk2] [edk2-announce] Community Meeting Minutes

2019-01-14 Thread stephano
On 1/12/2019 7:59 PM, Rebecca Cran wrote: I wonder if we might want to have a separate mailing list for reviews? I find it a bit overwhelming having both patches and more general discussions on the same list, since I only check it every few days. My original thought was to add

Re: [edk2] [PATCH 08/12] ArmVirtXen: Use merged variable driver for emulated NV mode

2019-01-14 Thread Zeng, Star
Hi Laszlo, On 2019/1/14 19:40, Laszlo Ersek wrote: On 01/13/19 16:37, Star Zeng wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 Merge EmuVariable and Real variable driver. The real variable driver has been updated to support emulated variable NV mode and the

Re: [edk2] [PATCH 3/5] ArmPkg/ArmMmuLib AARCH64: implement support for EFI_MEMORY_RP permissions

2019-01-14 Thread Ard Biesheuvel
On Mon, 14 Jan 2019 at 15:29, Leif Lindholm wrote: > > On Mon, Jan 07, 2019 at 08:15:02AM +0100, Ard Biesheuvel wrote: > > Wire up the access flag (AF) page table attribute to the EFI_MEMORY_RP > > permission attribute, so that attempts to read from such a region will > > trigger an access flag

Re: [edk2] [PATCH 3/5] ArmPkg/ArmMmuLib AARCH64: implement support for EFI_MEMORY_RP permissions

2019-01-14 Thread Leif Lindholm
On Mon, Jan 14, 2019 at 03:59:08PM +0100, Ard Biesheuvel wrote: > On Mon, 14 Jan 2019 at 15:29, Leif Lindholm wrote: > > > > On Mon, Jan 07, 2019 at 08:15:02AM +0100, Ard Biesheuvel wrote: > > > Wire up the access flag (AF) page table attribute to the EFI_MEMORY_RP > > > permission attribute, so

[edk2] [PATCH V2 01/15] MdeModulePkg Variable: Add some missing changes for 9b18845

2019-01-14 Thread Star Zeng
To improve performance 9b18845a4b4cd1d2cf004cbc1cadf8a93ccb37ea changed the code which read from physical MMIO address to read from memory cache, but it missed some places that could be updated at the same away for performance optimization. The patch updates these places as supplementary. I

[edk2] [PATCH V2 04/15] MdeModulePkg Variable: Abstract VariableWriteServiceInitializeDxe/Smm

2019-01-14 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 Merge EmuVariable and Real variable driver. Abstract VariableWriteServiceInitializeDxe/Smm from FtwNotificationEvent/SmmFtwNotificationEvent, then VariableWriteServiceInitializeDxe/Smm could be not aware the NV storage is real or emulated.

[edk2] [PATCH V2 03/15] MdeModulePkg Variable: Not get NV PCD in VariableWriteServiceInitialize

2019-01-14 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 Merge EmuVariable and Real variable driver. Add macro NV_STORAGE_VARIABLE_BASE. Not get NV PCD in VariableWriteServiceInitialize, but in FtwNotificationEvent/SmmFtwNotificationEvent, then VariableWriteServiceInitialize could be not aware

[edk2] [PATCH V2 07/15] MdeModulePkg Variable: type case VolatileBase to UINTN directly

2019-01-14 Thread Star Zeng
Simplify ((UINTN) ((UINT8 *) VolatileBase + VolatileBase->Size)) to ((UINTN) VolatileBase + VolatileBase->Size) This patch prepares for adding emulated variable NV mode support in VariableRuntimeDxe. Cc: Jian J Wang Cc: Hao Wu Cc: Laszlo Ersek Contributed-under: TianoCore Contribution

[edk2] [PATCH V2 06/15] MdeModulePkg Variable: Remove CacheOffset in UpdateVariable()

2019-01-14 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 Merge EmuVariable and Real variable driver. CacheOffset could be removed in UpdateVariable() after // // update the memory copy of Flash region. // CopyMem ( (UINT8 *)mNvVariableCache + CacheOffset, (UINT8 *)NextVariable, VarSize );

[edk2] [PATCH V2 08/15] MdeModulePkg Variable: Add emulated variable NV mode support

2019-01-14 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 Merge EmuVariable and Real variable driver. Add emulated variable NV mode support in real variable driver. Platform can configure PcdEmuVariableNvModeEnable statically (build time) or dynamically (boot time) to support emulated variable NV

[edk2] [PATCH V2 11/15] ArmVirtXen: Link VarCheckUefiLib NULL class library instance

2019-01-14 Thread Star Zeng
This patch is not related to REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 Merge EmuVariable and Real variable driver. It just makes ArmVirtXen be aligned with ArmVirtQemuXXX to link VarCheckUefiLib NULL class library instance. Suggested-by: Laszlo Ersek Cc: Laszlo Ersek Cc: Ard

[edk2] [PATCH V2 10/15] ArmVirtXen: Use merged variable driver for emulated NV mode

2019-01-14 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 Merge EmuVariable and Real variable driver. The real variable driver has been updated to support emulated variable NV mode and the EmuVariableRuntimeDxe will be removed later, so use merged variable driver for emulated NV mode. Cc: Laszlo

[edk2] [PATCH V2 00/15] Merge EmuVariable and Real variable driver

2019-01-14 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 Purpose: 1. Add emulated variable NV mode support in MdeModulePkg\Universal\Variable\RuntimeDxe. Platform can configure PCD statically (build time) or dynamically (boot time) to support emulated variable NV mode. 2. Remove

[edk2] [PATCH V2 02/15] MdeModulePkg Variable: Abstract InitRealNonVolatileVariableStore

2019-01-14 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 Merge EmuVariable and Real variable driver. Abstract InitRealNonVolatileVariableStore from InitNonVolatileVariableStore. This patch prepares for adding emulated variable NV mode support in VariableRuntimeDxe. Cc: Jian J Wang Cc: Hao Wu

[edk2] [PATCH V2 09/15] MdeModulePkg VariablePei: Don't check BOOT_IN_RECOVERY_MODE

2019-01-14 Thread Star Zeng
Don't check BOOT_IN_RECOVERY_MODE, but check PcdEmuVariableNvModeEnable which platform can configure flexibly. Cc: Jian J Wang Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- MdeModulePkg/Universal/Variable/Pei/Variable.c | 8 +---

[edk2] [PATCH V2 05/15] MdeModulePkg: Add PcdEmuVariableNvModeEnable in dec

2019-01-14 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 Merge EmuVariable and Real variable driver. Add PcdEmuVariableNvModeEnable (support both static and dynamic) to indicate if Variable driver will enable emulated variable NV mode. This patch prepares for adding emulated variable NV mode

Re: [edk2] [edk2-platforms] [PATCH v7 2/2] Platform/ARM: Add Readme.md

2019-01-14 Thread Nariman Poushin
On Fri, Jan 11, 2019 at 05:42:43PM +, Leif Lindholm wrote: > On Wed, Dec 19, 2018 at 06:01:46PM +, Nariman Poushin wrote: > > This covers the bulk of the information originally present in > > https://github.com/tianocore/tianocore.github.io/wiki/ArmPlatformPkg-AArch64 > > regarding

Re: [edk2] [PATCH] IntelSiliconPkg\Include\IndustryStandard: Update IGD_OPREGION_MBOX3 Structure

2019-01-14 Thread Chaganty, Rangasai V
Please add the spec revision in the comment that introduced this change. Also if the spec has provided any additional details or rationale, please add the summary to justify this change. Thanks, Sai -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf

Re: [edk2] [PATCH 3/5] ArmPkg/ArmMmuLib AARCH64: implement support for EFI_MEMORY_RP permissions

2019-01-14 Thread Leif Lindholm
On Mon, Jan 07, 2019 at 08:15:02AM +0100, Ard Biesheuvel wrote: > Wire up the access flag (AF) page table attribute to the EFI_MEMORY_RP > permission attribute, so that attempts to read from such a region will > trigger an access flag fault. > > Note that this is a stronger notion than just read

Re: [edk2] [Patch] BaseTools GenFw: Fix XCODE5 build issue

2019-01-14 Thread Gao, Liming
Got it. I will update the commit message with the warning message "equality comparison with extraneous parentheses". Thanks Liming > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, January 14, 2019 10:36 PM > To: Gao, Liming ; edk2-devel@lists.01.org >

Re: [edk2] [PATCH v2 02/17] OvmfPkg: add MmServicesTableLib resolution

2019-01-14 Thread Laszlo Ersek
On 01/14/19 14:27, Ard Biesheuvel wrote: > The SMM based FTW and variable drivers are going to depend on > MmServicesTableLib after a subsequent patch, so add a resolution > for it to various OvmfPkg .dsc files. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard

Re: [edk2] [PATCH v2 02/17] OvmfPkg: add MmServicesTableLib resolution

2019-01-14 Thread Ard Biesheuvel
On Mon, 14 Jan 2019 at 17:40, Laszlo Ersek wrote: > > On 01/14/19 14:27, Ard Biesheuvel wrote: > > The SMM based FTW and variable drivers are going to depend on > > MmServicesTableLib after a subsequent patch, so add a resolution > > for it to various OvmfPkg .dsc files. > > > >

Re: [edk2] [Patch] BaseTools: Remove EDK_SOURCE keyword

2019-01-14 Thread Laszlo Ersek
On 01/14/19 15:03, Feng, Bob C wrote: > Sure. Since ECC and UPT are two standalone tools, I'll send another patch for > them. That sounds like a good idea to me, but shouldn't we then split this patch as well? Namely, the first two hunks apply to GenFds. So, for those, I would suggest a common

Re: [edk2] [PATCH 06/12] MdeModulePkg Variable: Add emulated variable NV mode support

2019-01-14 Thread Zeng, Star
Hi Laszlo, Yes, agree with the suggestions. Two patches have been separated from this patch in V2 patch series at https://lists.01.org/pipermail/edk2-devel/2019-January/035015.html. Thanks, Star On 2019/1/14 18:57, Laszlo Ersek wrote: Hi Star, On 01/13/19 16:37, Star Zeng wrote: REF:

Re: [edk2] [PATCH] ArmPkg/ArmGicV3Dxe: use correct value for ARM_GICD_IROUTER

2019-01-14 Thread Ard Biesheuvel
On Mon, 14 Jan 2019 at 12:24, Leif Lindholm wrote: > > On Fri, Dec 21, 2018 at 04:08:48PM +0100, Ard Biesheuvel wrote: > > Use the correct value for ARM_GICD_IROUTER as per the GIC spec, > > and fix the code that relies on the value being skewed by 32 x 8 > > bytes. > > > > Contributed-under:

Re: [edk2] [PATCH 0/6] implement standalone MM versions of the variable runtime drivers

2019-01-14 Thread Gao, Liming
Ard: Got it. I will update our internal platform dsc to include new MmServicesTableLib library. Besides, will you send the patch to update platform DSC files in edk2-platforms? If yes, please update DSCs in https://github.com/tianocore/edk2-platforms/tree/devel-MinPlatform. They both

[edk2] [PATCH edk2-platforms] Platform/Intel/MinPlatformPkg: add MmServicesTableLib resolution

2019-01-14 Thread Ard Biesheuvel
Ensure that the platform will still build when we move the upstream FTW and variable SMM runtime drivers to use the new MmServiceTableLib library class. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel ---

Re: [edk2] [PATCH 1/5] ArmPkg/ArmMmuLib AARCH64: fix out of bounds access

2019-01-14 Thread Ard Biesheuvel
On Mon, 14 Jan 2019 at 13:00, Leif Lindholm wrote: > > On Mon, Jan 07, 2019 at 08:15:00AM +0100, Ard Biesheuvel wrote: > > Take care not to dereference BlockEntry if it may be pointing past > > the end of the page table we are manipulating. It is only a read, > > and thus harmless, but HeapGuard

Re: [edk2] [PATCH] IntelFsp2Pkg: Add FspmArchConfigPpi to support Dispatch mode

2019-01-14 Thread Desimone, Nathaniel L
Hi Star, There are three fields in FSPM_ARCH_UPD that are not in FSPM_ARCH_CONFIG_PPI: 1. StackBase 2. StackSize 3. BootMode For #1 and #2, there is no need for a second stack and second HOB list when FSP is running in dispatch mode, so these entries are not needed. For #3, there is already a

Re: [edk2] [PATCH] ArmPkg/ArmMmuLib ARM: disregard high memory when setting permissions

2019-01-14 Thread Ard Biesheuvel
On Mon, 14 Jan 2019 at 12:43, Leif Lindholm wrote: > > On Mon, Jan 07, 2019 at 07:56:49AM +0100, Ard Biesheuvel wrote: > > Ignore calls to ArmSetMemoryAttributes () when the region described > > is outside of the 32-bit addressable range. This memory is not > > mapped in the first place, and the

Re: [edk2] [PATCH edk2-platforms 6/8] Silicon/SynQuacer/Stage2Tables: fix 32-bit build

2019-01-14 Thread Ard Biesheuvel
On Mon, 14 Jan 2019 at 18:02, Ard Biesheuvel wrote: > > The static stage2 page tables don't contain any code, but we are > relying on the linker to resolve the references to the next level > tables, so we can only use native word size quantities. So add a > CPP macro to emit the same quantity in

Re: [edk2] [PATCH v2 04/11] MdePkg/Include: Add StandaloneMmServicesTableLib library

2019-01-14 Thread Ard Biesheuvel
On Sun, 13 Jan 2019 at 13:42, Cohen, Eugene wrote: > > I saw this thread earlier this week and wanted to chime in. > > > > Also, there are some other pieces missing (which I mentioned in one of > > > the other threads but I suppose you may not have caught up yet): > > > EndOfDxe (as well as some

Re: [edk2] [platforms: PATCH v2 05/12] Marvell/Armada80x0Db: Extend board description library with GPIO

2019-01-14 Thread Leif Lindholm
On Thu, Jan 10, 2019 at 02:44:32AM +0100, Marcin Wojtas wrote: > This patch implements ArmadaBoarDescLib library for > Armada80x0Db comunity board and introduces ArmadaBoardGpioGet > routine with per-board GPIO expander description. > > Contributed-under: TianoCore Contribution Agreement 1.1 >

Re: [edk2] [platforms: PATCH v2 10/12] Marvell/Drivers: MvPca95xxDxe: Introduce GPIO expander driver

2019-01-14 Thread Leif Lindholm
On Thu, Jan 10, 2019 at 02:44:37AM +0100, Marcin Wojtas wrote: > Marvell Armada 7k/8k-based platforms may use Pca95xx to extend > amount of the GPIO pins. > > This patch introduces support for them. The new driver implements > a generic EMBEDDED_GPIO protocol. > > In order to ease description of

Re: [edk2] [platforms: PATCH v2 02/12] Marvell/Library: ArmadaBoardDescLib: Add GPIO information

2019-01-14 Thread Leif Lindholm
On Thu, Jan 10, 2019 at 02:44:29AM +0100, Marcin Wojtas wrote: > This patch extends library with GPIO devices per-board > description. Both embedded SoC controllers and > I2C IO expanders are supported. Add a helper routine > for obtaining information about the latter. > > Contributed-under:

Re: [edk2] [platforms: PATCH v2 03/12] SolidRun/Armada80x0McBin: Extend board description library with GPIO

2019-01-14 Thread Leif Lindholm
On Thu, Jan 10, 2019 at 02:44:30AM +0100, Marcin Wojtas wrote: > This patch implements ArmadaBoarDescLib library for > Armada80x0McBin comunity board and introduces ArmadaBoardGpioGet > routine with per-board GPIO expander description. > > Contributed-under: TianoCore Contribution Agreement 1.1 >

Re: [edk2] [PATCH edk2-platforms 3/3] Silicon/SynQuacer: add support for DEBUG output on second UART

2019-01-14 Thread Ard Biesheuvel
On Sat, 12 Jan 2019 at 19:25, Mark Kettenis wrote: > > > Date: Fri, 11 Jan 2019 17:58:44 + > > From: Leif Lindholm > > > > On Wed, Dec 26, 2018 at 02:25:30PM +0100, Ard Biesheuvel wrote: > > > On headless server systems where the PL011 serial port is the primary > > > console, having DEBUG

Re: [edk2] [platforms: PATCH v2 07/12] Marvell/Protocol: Introduce GPIO helper header

2019-01-14 Thread Leif Lindholm
On Thu, Jan 10, 2019 at 02:44:34AM +0100, Marcin Wojtas wrote: > From: jinghua > > This patch introduces a helper header that can be used by > multiple EMBEDDED_GPIO protocol producers (e.g. platform > driver or GPIO expanders). The drives are differentiated by > MV_GPIO_DRIVER_TYPE field of

Re: [edk2] [platforms: PATCH v2 08/12] Marvell/Drivers: MvGpioDxe: Introduce platform GPIO driver

2019-01-14 Thread Leif Lindholm
On Thu, Jan 10, 2019 at 02:44:35AM +0100, Marcin Wojtas wrote: > Marvell Armada 7k/8k SoCs comprise integrated GPIO controllers, > one in AP806 and two in each south bridge hardware blocks. > > This patch introduces support for them. The new driver implements > a generic EMBEDDED_GPIO protocol. >

Re: [edk2] [PATCH V2 12/15] BeagleBoardPkg: Use merged variable driver for emulated NV mode

2019-01-14 Thread Leif Lindholm
Hi Star, This set looks like a good cleanup. This patch also need an added resolution for SynchronizationLib. (MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf should be fine.) The same modification will also be needed in edk2-platforms for Platform/Hisilicon/HiKey and HiKey960.

Re: [edk2] [platforms: PATCH v2 04/12] Marvell/Armada70x0Db: Extend board description library with GPIO

2019-01-14 Thread Leif Lindholm
On Thu, Jan 10, 2019 at 02:44:31AM +0100, Marcin Wojtas wrote: > This patch implements ArmadaBoarDescLib library for > Armada70x0Db comunity board and introduces ArmadaBoardGpioGet > routine with per-board GPIO expander description. > > Contributed-under: TianoCore Contribution Agreement 1.1 >

Re: [edk2] [platforms: PATCH v2 06/12] Marvell/Drivers: MvBoardDesc: Extend protocol with GPIO support

2019-01-14 Thread Leif Lindholm
On Thu, Jan 10, 2019 at 02:44:33AM +0100, Marcin Wojtas wrote: > Introduce new callback that can provide information > about GPIO SoC controllers, as well as on-board > I2C IO expanders. According ArmadaSoCDescLib > ArmadaBoardDescLib routines are used for > obtaining required data. > >

Re: [edk2] [platforms: PATCH v2 12/12] Marvell/Armada7k8k: Introduce NonDiscoverable device init routines

2019-01-14 Thread Leif Lindholm
On Thu, Jan 10, 2019 at 02:44:39AM +0100, Marcin Wojtas wrote: > To abstract the initialization required for non-discoverable devices, > which is often platform specific (e.g. enable GPIO-driven power supply), > introduce a NonDiscoverableInitLib for use by the NonDiscoverable code, > for which

Re: [edk2] [platforms: PATCH v2 01/12] Marvell/Library: ArmadaSoCDescLib: Add GPIO information

2019-01-14 Thread Leif Lindholm
On Thu, Jan 10, 2019 at 02:44:28AM +0100, Marcin Wojtas wrote: > This patch introduces new library callback (ArmadaSoCGpioGet ()), > which dynamically allocates and fills EmbeddedGpio's > GPIO_CONTROLLER structure with the SoC description of GPIO controllers. > > Because the library header is

[edk2] [PATCH v1 0/2] Fix the possible NULL pointer dereference issue.

2019-01-14 Thread Jiaxin Wu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1456 For the NET_LIST_FOR_EACH & NET_LIST_FOR_EACH_SAFE, "Entry" should be checked whether it's NULL or not instead of using the pointer directly. Besides, NET_LIST_FOR_EACH_SAFE is defined to iterate through the double linked list in

[edk2] [PATCH v1 1/2] MdeModulePkg/NetLib.h: Fix the possible NULL pointer dereference issue.

2019-01-14 Thread Jiaxin Wu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1456 For the NET_LIST_FOR_EACH & NET_LIST_FOR_EACH_SAFE, "Entry" should be checked whether it's NULL or not instead of using the pointer directly. Cc: Wu Hao A Cc: Gao Liming Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore

[edk2] [PATCH v1 2/2] MdeModulePkg/Dhcp4Dxe: Use NET_LIST_FOR_EACH instead of NET_LIST_FOR_EACH_SAFE.

2019-01-14 Thread Jiaxin Wu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1456 NET_LIST_FOR_EACH_SAFE is defined to iterate through the double linked list in delete-safe way. It's unnecessary to use this macro if list entries won't be deleted. Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH] MinPlatformPkg: Support TCO base locked by FSP

2019-01-14 Thread Chiu, Chasel
+ Michael to review this too. Thanks! Chasel > -Original Message- > From: Chiu, Chasel > Sent: Tuesday, January 15, 2019 12:07 PM > To: edk2-devel@lists.01.org > Cc: Desimone, Nathaniel L ; Zeng, Star > ; Chiu, Chasel > Subject: [PATCH] MinPlatformPkg: Support TCO base locked by FSP

Re: [edk2] [PATCH v1 0/2] Remove unused global variables in

2019-01-14 Thread Wu, Jiaxin
Series Reviewed-by: Jiaxin Wu Thanks, jiaxin > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Songpeng Li > Sent: Monday, January 14, 2019 5:25 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH v1 0/2] Remove unused global variables

Re: [edk2] [Patch] BaseTools GenFw: Fix XCODE5 build issue

2019-01-14 Thread Feng, Bob C
Reviewed-by: Feng Bob C -Original Message- From: Gao, Liming Sent: Monday, January 14, 2019 9:52 PM To: edk2-devel@lists.01.org Cc: Feng, Bob C Subject: [Patch] BaseTools GenFw: Fix XCODE5 build issue Remove extraneous parentheses around the comparison to silence this warning. This

Re: [edk2] [PATCH V2 12/15] BeagleBoardPkg: Use merged variable driver for emulated NV mode

2019-01-14 Thread Zeng, Star
On 2019/1/15 6:11, Leif Lindholm wrote: Hi Star, This set looks like a good cleanup. Thanks. This patch also need an added resolution for SynchronizationLib. (MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf should be fine.) Oh, yes. I assumed it has been there, but it is

[edk2] EmulatorPkg build issue with macOS mojave and Xcode 10

2019-01-14 Thread 唐佳诚
Hi Dear EmulatorPkg Maintainer: I'm a newbie at this, There are some issue when building EmulatorPkg. Any inspiration or help will appreciated!OS macOS mojave with Xcode 10 command line tool and installed macOS_SDK_headers_for_macOS_10.14.pkgDownload edk2-UDK2018.zipInitializing workspace>

[edk2] [PATCH] MinPlatformPkg: Support TCO base locked by FSP

2019-01-14 Thread Chasel, Chiu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1457 Per security recommendation TCO Base should be initialized and locked by FSP and MinPlatform should support both TCO Base locked and not locked scenarios. Cc: Nate DeSimone Cc: Star Zeng Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH V2 05/15] MdeModulePkg: Add PcdEmuVariableNvModeEnable in dec

2019-01-14 Thread Wang, Jian J
Hi Star, > -Original Message- > From: Zeng, Star > Sent: Monday, January 14, 2019 11:20 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Wang, Jian J ; > Wu, Hao A > Subject: [PATCH V2 05/15] MdeModulePkg: Add PcdEmuVariableNvModeEnable > in dec > > REF:

[edk2] EmulatorPkg build issue with macOS mojave and Xcode 10

2019-01-14 Thread 唐佳诚
Hi Dear EmulatorPkg Maintainer: I'm a newbie at this, I am sorry for the wrong format of the previous mail. There are some issue when building EmulatorPkg. Any inspiration or help will appreciated! OS Environment: macOS mojave with Xcode 10 command line tool and installed

Re: [edk2] [PATCH V2 03/15] MdeModulePkg Variable: Not get NV PCD in VariableWriteServiceInitialize

2019-01-14 Thread Wu, Hao A
Hi Star, One minor comment below. > -Original Message- > From: Zeng, Star > Sent: Monday, January 14, 2019 11:20 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star; Wang, Jian J; Wu, Hao A > Subject: [PATCH V2 03/15] MdeModulePkg Variable: Not get NV PCD in >

Re: [edk2] [PATCH V2 05/15] MdeModulePkg: Add PcdEmuVariableNvModeEnable in dec

2019-01-14 Thread Wu, Hao A
Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: Zeng, Star > Sent: Monday, January 14, 2019 11:20 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star; Wang, Jian J; Wu, Hao A > Subject: [PATCH V2 05/15] MdeModulePkg: Add > PcdEmuVariableNvModeEnable in dec > > REF:

Re: [edk2] [PATCH V2 07/15] MdeModulePkg Variable: type case VolatileBase to UINTN directly

2019-01-14 Thread Wu, Hao A
Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: Zeng, Star > Sent: Monday, January 14, 2019 11:20 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star; Wang, Jian J; Wu, Hao A; Laszlo Ersek > Subject: [PATCH V2 07/15] MdeModulePkg Variable: type case VolatileBase >

Re: [edk2] [PATCH V2 01/15] MdeModulePkg Variable: Add some missing changes for 9b18845

2019-01-14 Thread Wu, Hao A
Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Star Zeng > Sent: Monday, January 14, 2019 11:20 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A; Zeng, Star > Subject: [edk2] [PATCH V2 01/15]

Re: [edk2] [PATCH V2 02/15] MdeModulePkg Variable: Abstract InitRealNonVolatileVariableStore

2019-01-14 Thread Wu, Hao A
Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: Zeng, Star > Sent: Monday, January 14, 2019 11:20 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star; Wang, Jian J; Wu, Hao A > Subject: [PATCH V2 02/15] MdeModulePkg Variable: Abstract >

Re: [edk2] [PATCH V2 04/15] MdeModulePkg Variable: Abstract VariableWriteServiceInitializeDxe/Smm

2019-01-14 Thread Wu, Hao A
Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: Zeng, Star > Sent: Monday, January 14, 2019 11:20 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star; Wang, Jian J; Wu, Hao A > Subject: [PATCH V2 04/15] MdeModulePkg Variable: Abstract >

Re: [edk2] [PATCH V2 03/15] MdeModulePkg Variable: Not get NV PCD in VariableWriteServiceInitialize

2019-01-14 Thread Wang, Jian J
Hi Star, One comment below. > -Original Message- > From: Zeng, Star > Sent: Monday, January 14, 2019 11:20 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Wang, Jian J ; > Wu, Hao A > Subject: [PATCH V2 03/15] MdeModulePkg Variable: Not get NV PCD in > VariableWriteServiceInitialize

Re: [edk2] [PATCH V2 06/15] MdeModulePkg Variable: Remove CacheOffset in UpdateVariable()

2019-01-14 Thread Wu, Hao A
Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: Zeng, Star > Sent: Monday, January 14, 2019 11:20 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star; Wang, Jian J; Wu, Hao A; Laszlo Ersek > Subject: [PATCH V2 06/15] MdeModulePkg Variable: Remove CacheOffset in >

Re: [edk2] [edk2-test][RFC] Integrating SBBR tests into SCT - A design proposal

2019-01-14 Thread Jin, Eric
Hi Sakar, Thank for the clarification. Now, I understand that the SBBR wants to add/modify in existing edk2-test/uefi-sct. In your description, '-s' is not suitable for sbbr purpose. The fundamental point to be discussed is that edk2-test/uefi-sct is UEFI Self Compliance Test and should keep

Re: [edk2] [patch v2] MdePkg/BasePeCoffLib: Add more check for relocation data

2019-01-14 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Bi, Dandan >Sent: Monday, January 14, 2019 11:02 PM >To: edk2-devel@lists.01.org >Cc: Kinney, Michael D ; Gao, Liming > >Subject: [patch v2] MdePkg/BasePeCoffLib: Add more check for relocation >data > >REF:

Re: [edk2] [PATCH v3] IntelFsp2Pkg: Add FspmArchConfigPpi to support Dispatch mode

2019-01-14 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Chiu, Chasel Sent: Tuesday, January 15, 2019 2:03 PM To: edk2-devel@lists.01.org Cc: Desimone, Nathaniel L ; Zeng, Star ; Chiu, Chasel Subject: [PATCH v3] IntelFsp2Pkg: Add FspmArchConfigPpi to support Dispatch mode REF:

Re: [edk2] [platforms: PATCH v2 06/12] Marvell/Drivers: MvBoardDesc: Extend protocol with GPIO support

2019-01-14 Thread Marcin Wojtas
Hi Leif, pon., 14 sty 2019 o 23:58 Leif Lindholm napisał(a): > > On Thu, Jan 10, 2019 at 02:44:33AM +0100, Marcin Wojtas wrote: > > Introduce new callback that can provide information > > about GPIO SoC controllers, as well as on-board > > I2C IO expanders. According ArmadaSoCDescLib > >

Re: [edk2] [platforms: PATCH v2 07/12] Marvell/Protocol: Introduce GPIO helper header

2019-01-14 Thread Marcin Wojtas
Hi Leif, wt., 15 sty 2019 o 00:12 Leif Lindholm napisał(a): > > On Thu, Jan 10, 2019 at 02:44:34AM +0100, Marcin Wojtas wrote: > > From: jinghua > > > > This patch introduces a helper header that can be used by > > multiple EMBEDDED_GPIO protocol producers (e.g. platform > > driver or GPIO

Re: [edk2] [PATCH V2 08/15] MdeModulePkg Variable: Add emulated variable NV mode support

2019-01-14 Thread Zeng, Star
On 2019/1/15 14:01, Wang, Jian J wrote: Hi Star, Just two minor comments below. -Original Message- From: Zeng, Star Sent: Monday, January 14, 2019 11:20 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Wang, Jian J ; Wu, Hao A ; Kinney, Michael D ; Gao, Liming ; Ni, Ray ; Laszlo Ersek

Re: [edk2] [platforms: PATCH v2 08/12] Marvell/Drivers: MvGpioDxe: Introduce platform GPIO driver

2019-01-14 Thread Marcin Wojtas
Hi Leif, wt., 15 sty 2019 o 00:32 Leif Lindholm napisał(a): > > On Thu, Jan 10, 2019 at 02:44:35AM +0100, Marcin Wojtas wrote: > > Marvell Armada 7k/8k SoCs comprise integrated GPIO controllers, > > one in AP806 and two in each south bridge hardware blocks. > > > > This patch introduces support

[edk2] [PATCH] BaseTools:Build fail when PCD use in the [DEPEX] section of INF files

2019-01-14 Thread Fan, ZhijuX
https://vthsd.intel.com/hsd/tiano/tracker/default.aspx?tracker_id=223983 1. Define one fixedatbuild PCD in dec: [PcdsFixedAtBuild] gUefiOvmfPkgTokenSpaceGuid.test1| {0x01, 0x02}|VOID*|0x3c 2. Define this PCD point to a depex GUID in dsc: MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf {

Re: [edk2] [platforms: PATCH v2 04/12] Marvell/Armada70x0Db: Extend board description library with GPIO

2019-01-14 Thread Marcin Wojtas
Hi Leif, pon., 14 sty 2019 o 23:41 Leif Lindholm napisał(a): > > On Thu, Jan 10, 2019 at 02:44:31AM +0100, Marcin Wojtas wrote: > > This patch implements ArmadaBoarDescLib library for > > Armada70x0Db comunity board and introduces ArmadaBoardGpioGet > > routine with per-board GPIO expander

Re: [edk2] [PATCH V2 05/15] MdeModulePkg: Add PcdEmuVariableNvModeEnable in dec

2019-01-14 Thread Zeng, Star
On 2019/1/15 13:05, Wang, Jian J wrote: Hi Star, -Original Message- From: Zeng, Star Sent: Monday, January 14, 2019 11:20 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Wang, Jian J ; Wu, Hao A Subject: [PATCH V2 05/15] MdeModulePkg: Add PcdEmuVariableNvModeEnable in dec REF:

Re: [edk2] [PATCH V2 03/15] MdeModulePkg Variable: Not get NV PCD in VariableWriteServiceInitialize

2019-01-14 Thread Zeng, Star
On 2019/1/15 13:48, Wu, Hao A wrote: Hi Star, One minor comment below. -Original Message- From: Zeng, Star Sent: Monday, January 14, 2019 11:20 PM To: edk2-devel@lists.01.org Cc: Zeng, Star; Wang, Jian J; Wu, Hao A Subject: [PATCH V2 03/15] MdeModulePkg Variable: Not get NV PCD in

Re: [edk2] [PATCH V2 08/15] MdeModulePkg Variable: Add emulated variable NV mode support

2019-01-14 Thread Wang, Jian J
Hi Star, Just two minor comments below. > -Original Message- > From: Zeng, Star > Sent: Monday, January 14, 2019 11:20 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Wang, Jian J ; > Wu, Hao A ; Kinney, Michael D > ; Gao, Liming ; Ni, Ray > ; Laszlo Ersek ; Ard Biesheuvel > >

[edk2] [PATCH v3] IntelFsp2Pkg: Add FspmArchConfigPpi to support Dispatch mode

2019-01-14 Thread Chasel, Chiu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1381 In Dispatch mode FSP may consume PPI directly so creating FSPM_ARCH_CONFIG_PPI to align with FSPM_ARCH_UPD. Also Keeps new structure size 8 bytes alignment as other structures. Test: Verified on internal platform to boot with this PPI

Re: [edk2] [PATCH v2] ShellPkg/TftpDynamicCommand: Change file writing method in tftp

2019-01-14 Thread Li, Songpeng
Hi Laszlo, Thank you for the comments. For your questions below: > Before the patch, the shell would write the entire file in "one go". > > In this particular case, I'm not interested in the memory allocation > size, but the transfer block size that the shell would ultimately use > with

Re: [edk2] [PATCH 0/6] implement standalone MM versions of the variable runtime drivers

2019-01-14 Thread Ard Biesheuvel
On Mon, 14 Jan 2019 at 03:55, Gao, Liming wrote: > > Ard: > I don't find the function issue in this patch. I have no other comments for > the change in MdePkg. Reviewed-by: Liming Gao . For > this patch set, if you push the change, please push the patches in MdePkg > first, and tell me the

Re: [edk2] [edk2-announce] Community Meeting Minutes

2019-01-14 Thread Laszlo Ersek
On 01/13/19 04:59, Rebecca Cran wrote: > On Friday, 11 January 2019 12:26:30 MST stephano wrote: > >> Patch Review System Evaluation >> -- >> After evaluating Github, Gitlab, and Phabricator, we will be remaining >> with the mailing list for now. Github did prove a

[edk2] [PATCH v1 2/2] NetworkPkg/Dhcp6Dxe: Remove an unused global variable.

2019-01-14 Thread Songpeng Li
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1413 The global variable mAllDhcpServersAddress has never been used, this patch is to clean it. Cc: Jiaxin Wu Cc: Siyuan Fu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Songpeng Li ---

[edk2] [PATCH v1 1/2] NetworkPkg/IScsiDxe: Remove unused global variables.

2019-01-14 Thread Songpeng Li
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1413 Global variables mIScsiDeviceListUpdated and mNumberOfIScsiDevices have never been used, this patch is to clean them. Cc: Jiaxin Wu Cc: Siyuan Fu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Songpeng Li ---

[edk2] [PATCH v1 0/2] Remove unused global variables in

2019-01-14 Thread Songpeng Li
Uefi-aware compiler found some redundant definitions in the NetworkPkg. We need to clean them. Songpeng Li (2): NetworkPkg/IScsiDxe: Remove unused global variables. NetworkPkg/Dhcp6Dxe: Remove an unused global variable. NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c | 2 --

[edk2] [PATCH] IntelSiliconPkg\Include\IndustryStandard: Update IGD_OPREGION_MBOX3 Structure

2019-01-14 Thread Digant H Solanki
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1454 Based on latest IGD OpRegion Spec, IGD_OPREGION_MBOX3 needs to be updated with two new members : Physical Address of Raw VBT Data (RVDA) and Size of Raw VBT Data (RVDS) Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

  1   2   >