Re: [edk2] [Patch edk2 Wiki] Add three features for edk2-stable201903

2019-02-13 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Liming Gao > Sent: Wednesday, February 13, 2019 12:24 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch edk2 Wiki] Add three features for edk2-stable201903

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/PeiMain: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-13 Thread Wang, Jian J
Reviewed-by: Jian J Wang > -Original Message- > From: Chiu, Chasel > Sent: Wednesday, February 13, 2019 5:47 PM > To: edk2-devel@lists.01.org > Cc: Wang, Jian J ; Wu, Hao A ; > Ni, Ray ; Zeng, Star ; Gao, Liming > ; Chiu, Chasel > Subject: [PATCH v2 2/3] MdeModulePkg/PeiMain: Support

[edk2] [PATCH v2 0/3] Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-13 Thread Chasel, Chiu
PI spec 1.7 section 6.3.9 has defined a PPI to support the scenario that PEI Foundation not in BFV. EFI_PEI_CORE_FV_LOCATION_PPI reports the FV which contains PEI Foundation and should be passed by SEC as part of PPI list. Otherwise PEI Foundation shall assume that it resides in BFV. Patch1: Add

[edk2] [PATCH v2 2/3] MdeModulePkg/PeiMain: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-13 Thread Chasel, Chiu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1524 When shadowing PeiCore the EFI_PEI_CORE_FV_LOCATION_PPI should be checked to see if PeiCore not in BFV, otherwise just shadowing PeiCore from BFV. Test: Verified on internal platform and booting successfully. Cc: Jian J Wang Cc: Hao Wu

[edk2] [PATCH v2 3/3] UefiCpuPkg/SecCore: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-13 Thread Chasel, Chiu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1524 EFI_PEI_CORE_FV_LOCATION_PPI may be passed by platform when PeiCore not in BFV so SecCore has to search PeiCore either from the FV location provided by EFI_PEI_CORE_FV_LOCATION_PPI or from BFV. Test: Verified on internal platform and

[edk2] [PATCH v2 1/3] MdePkg: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-13 Thread Chasel, Chiu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1524 Add EFI_PEI_CORE_FV_LOCATION_PPI definition basing on PI spec 1.7, Section 6.3.9. This PPI can support the secnario that PEI Foundation not in BFV. Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement

Re: [edk2] [PATCH edk2-platforms v1 09/16] Hisilicon/D06: Add PCI_OSC_SUPPORT

2019-02-13 Thread Leif Lindholm
On Wed, Feb 13, 2019 at 10:59:17AM +0800, Ming Huang wrote: > On 2/12/2019 2:51 AM, Leif Lindholm wrote: > > On Fri, Feb 01, 2019 at 09:34:29PM +0800, Ming Huang wrote: > >> Add PCI_OSC_SUPPORT for remaining host bridges to remove fail > >> output in kernel: > >> [ 103.478893] acpi PNP0A08:01:

Re: [edk2] [PATCH 1/3] MdePkg: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-13 Thread Zeng, Star
On 2019/2/12 21:19, Chasel, Chiu wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1524 Add EFI_PEI_CORE_FV_LOCATION_PPI definition basing on PI spec 1.7, Section 6.3.9. This PPI can support the secnario that PEI Foundation not in BFV. Cc: Michael D Kinney Cc: Liming Gao

Re: [edk2] [PATCH 2/3] MdeModulePkg/PeiMain: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-13 Thread Zeng, Star
With this addressed, Reviewed-by: Star Zeng . -Original Message- From: Chiu, Chasel Sent: Wednesday, February 13, 2019 11:59 AM To: Wang, Jian J ; edk2-devel@lists.01.org Cc: Wu, Hao A ; Ni, Ray ; Zeng, Star ; Gao, Liming Subject: RE: [PATCH 2/3] MdeModulePkg/PeiMain: Support

[edk2] nonzero LUN on USB Bulk Only Transfer fails with QEMU+edk2

2019-02-13 Thread Laszlo Ersek
Hi, using QEMU, when I specify a nonzero LUN for the hard disk that sits on the "SCSI bus" that embodies the USB Bulk Only Transfer device, then UsbMassStorageDxe fails to recognize the hard disk. (1) Consider the following QEMU command line snippet: -drive

Re: [edk2] [PATCH edk2-platforms v1 01/16] Hisilicon/D0x: Remove SerdesLib

2019-02-13 Thread Leif Lindholm
On Wed, Feb 13, 2019 at 02:36:11PM +0800, Ming Huang wrote: > > Should it not then also delete #include from > > Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06.c, > > Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.c and > >

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/PeiMain: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-13 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Chiu, Chasel Sent: Wednesday, February 13, 2019 5:47 PM To: edk2-devel@lists.01.org Cc: Wang, Jian J ; Wu, Hao A ; Ni, Ray ; Zeng, Star ; Gao, Liming ; Chiu, Chasel Subject: [PATCH v2 2/3] MdeModulePkg/PeiMain: Support

Re: [edk2] [PATCH v2 1/3] MdePkg: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-13 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chasel, Chiu Sent: Wednesday, February 13, 2019 5:47 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D ; Gao, Liming Subject: [edk2] [PATCH v2 1/3] MdePkg: Support

Re: [edk2] [PATCH edk2-platforms v1 01/16] Hisilicon/D0x: Remove SerdesLib

2019-02-13 Thread Ming Huang
On 2/13/2019 5:42 PM, Leif Lindholm wrote: > On Wed, Feb 13, 2019 at 02:36:11PM +0800, Ming Huang wrote: >>> Should it not then also delete #include from >>> Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06.c, >>> Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.c and >>>

Re: [edk2] [PATCH edk2-non-osi v2 1/1] Platform/Socionext: uprev TF-A binary

2019-02-13 Thread Ard Biesheuvel
On Tue, 12 Feb 2019 at 14:19, Sumit Garg wrote: > > Update TF-A to upstream v2.0 release + synquacer-spm changes > (Commit: e86e202c2e4e). > Also update OP-TEE to upstream v3.4.0 release (Commit: 406c609bbf08). > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Sumit

Re: [edk2] [PATCH edk2-non-osi v1 5/7] Hisilicon/D06: Use new flash layout

2019-02-13 Thread Ming Huang
On 2/12/2019 11:26 PM, Leif Lindholm wrote: > On Fri, Feb 01, 2019 at 10:25:05PM +0800, Ming Huang wrote: >> In new flash layout, BIOS fd change from offset 1M to 8M in 16M >> spi flash. > > I think I covered all of the layout questions in the corresponding > edk2-platforms patch. > >>

Re: [edk2] [PATCH v2] NetworkPkg/Ip6Dxe: Clean the invalid IPv6 configuration during driver start.

2019-02-13 Thread Wu, Jiaxin
Hi Siyuan, Both of them should be fine to clear the invalid configuration data. In my opinion, since the error returned from SetData(), we will treat it as invalid except the asynchronous process (EFI_NOT_READY). That's already have been checked in the if condition. Thanks, Jiaxin >

Re: [edk2] [PATCH 3/3] MdeModulePkg/SmmS3SaveStateDxe: Change function parameter types

2019-02-13 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Shenglei Zhang >Sent: Wednesday, February 13, 2019 2:52 PM >To: edk2-devel@lists.01.org >Cc: Wu, Hao A ; Zeng, Star >Subject: [edk2] [PATCH 3/3]

Re: [edk2] [PATCH 2/3] MdeModulePkg/S3SaveStateDxe: Change function parameter types

2019-02-13 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Shenglei Zhang >Sent: Wednesday, February 13, 2019 2:52 PM >To: edk2-devel@lists.01.org >Cc: Wu, Hao A ; Zeng, Star >Subject: [edk2] [PATCH 2/3]

Re: [edk2] [PATCH 1/3] MdePkg: Change structure parameter types

2019-02-13 Thread Gao, Liming
The change is good. Please update header comments to describe the change in PI 1.7. With this change, Reviewed-by: Liming Gao >-Original Message- >From: Zhang, Shenglei >Sent: Wednesday, February 13, 2019 2:52 PM >To: edk2-devel@lists.01.org >Cc: Kinney, Michael D ; Gao, Liming >

[edk2] [PATCH] ShellPkg/Application/Shell: add array index check for shell delay option

2019-02-13 Thread Zhichao Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1528 Shell delay option without parameters do not check the index of shell parameter argv. Add index check to avoid invalid pointer references. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhichao Gao Cc: Liming Gao

Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function

2019-02-13 Thread Gao, Liming
Bob: So, this is OS issue. I prefer to update wiki page to describe how to resolve it. Thanks Liming >-Original Message- >From: Feng, Bob C >Sent: Thursday, February 14, 2019 10:51 AM >To: Laszlo Ersek ; Gao, Liming ; >Bi, Dandan ; Carsey, Jaben >Cc: edk2-devel@lists.01.org >Subject:

Re: [edk2] [Patch 3/3] UefiCpuPkg/RegisterCpuFeaturesLib: Simplify PcdCpuFeaturesSupport.

2019-02-13 Thread Dong, Eric
Hi Laszlo, > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, February 13, 2019 11:01 AM > To: Dong, Eric ; edk2-devel@lists.01.org > Cc: Ni, Ray > Subject: Re: [Patch 3/3] UefiCpuPkg/RegisterCpuFeaturesLib: Simplify > PcdCpuFeaturesSupport. > > On

Re: [edk2] [Patch 2/3] UefiCpuPkg/RegisterCpuFeaturesLib: Optimize PCD PcdCpuFeaturesUserConfiguration.

2019-02-13 Thread Dong, Eric
Hi Laszlo, > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, February 13, 2019 10:44 AM > To: Dong, Eric ; edk2-devel@lists.01.org > Cc: Ni, Ray > Subject: Re: [Patch 2/3] UefiCpuPkg/RegisterCpuFeaturesLib: Optimize PCD >

Re: [edk2] [patch V2] MdeModulePkg/ReportStatusCodeLib: Avoid using AllocatePool if possible

2019-02-13 Thread Bi, Dandan
This patch is also available at https://github.com/dandanbi/edk2/commit/e5c432b2d5083c0bbadbf773d460a9c22d36b267 Thanks, Dandan > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Dandan Bi > Sent: Thursday, February 14, 2019 10:39 AM > To:

[edk2] [PATCH] MdePkg/BaseLib: Change a variable type in a bitwise operation

2019-02-13 Thread Shenglei Zhang
Change the type of variable Chr from CHAR8 to UINT32 in a bitwise operation, to make the two variables in the operation have the same size. https://bugzilla.tianocore.org/show_bug.cgi?id=1527 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] [PATCH] SecurityPkg/OpalPassword: Update strings on Opal Setup page

2019-02-13 Thread Dong, Eric
Hi Maggie, Thanks for your contribution. Reviewed-by: Eric Dong Pushed: SHA-1: 315873959ec3e0a44168efdf4c03fe6160121cdb Thanks, Eric > -Original Message- > From: Chu, Maggie > Sent: Wednesday, February 13, 2019 2:56 PM > To: edk2-devel@lists.01.org > Cc: Zhang, Chao B ; Yao, Jiewen

Re: [edk2] [PATCH v2 1/3] MdePkg: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-13 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Zeng, Star >Sent: Wednesday, February 13, 2019 5:50 PM >To: Chiu, Chasel ; edk2-devel@lists.01.org >Cc: Kinney, Michael D ; Gao, Liming >; Zeng, Star >Subject: RE: [edk2] [PATCH v2 1/3] MdePkg: Support >EFI_PEI_CORE_FV_LOCATION_PPI >

Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function

2019-02-13 Thread Feng, Bob C
Hi Laszlo, Liming, Jaben and Dandan, I found this is a Ubuntu18 bug. Refer to https://bugs.launchpad.net/ubuntu/+source/fdroidserver/+bug/1762183 And Ubuntu fixed this bug via a Ubuntu18.04.1 update package which was published on 2018-08-09. Refer to

Re: [edk2] [edk2-announce] February Community Meeting

2019-02-13 Thread stephano
On 1/31/2019 8:49 AM, stephano wrote: We will be holding our February Community Meeting on the *2nd* Thursday of February to accommodate holiday schedules. Details are posted here: Sorry for the last minute notice here, but I'm going to move the APAC meeting for February from Thursday night

Re: [edk2] nonzero LUN on USB Bulk Only Transfer fails with QEMU+edk2

2019-02-13 Thread Laszlo Ersek
On 02/13/19 18:00, Philippe Mathieu-Daudé wrote: > On 2/13/19 9:37 AM, Laszlo Ersek wrote: >> >> using QEMU, when I specify a nonzero LUN for the hard disk that sits on >> the "SCSI bus" that embodies the USB Bulk Only Transfer device, then >> UsbMassStorageDxe fails to recognize the hard disk. >>

Re: [edk2] [PATCH v3 00/10] Remove unused tool chain configuration

2019-02-13 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Zhang, Shenglei >Sent: Wednesday, February 13, 2019 9:43 AM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >; Zhu, Yonghong ; Ni, Ray >; Justen, Jordan L ; Laszlo >Ersek ; Ard Biesheuvel ; >Anthony Perard ; Julien Grall >

[edk2] [patch V2] MdeModulePkg/ReportStatusCodeLib: Avoid using AllocatePool if possible

2019-02-13 Thread Dandan Bi
From: Max Knutsen REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1114 V2: simplify the code logic. update if (!mHaveExitedBootServices && (StatusCodeData != (EFI_STATUS_CODE_DATA *) StatusCodeBuffer)) { gBS->FreePool (StatusCodeData); } to if (StatusCodeData != (EFI_STATUS_CODE_DATA

Re: [edk2] OVMF and TCP4, HTTP protocols

2019-02-13 Thread Rebecca Cran via edk2-devel
On 2/12/19 10:44 PM, Laszlo Ersek wrote: In your case, I think it should suffice to call ConnectController() with Recursive=FALSE, on the controller that already has SNP. The HttpServiceBinding, Tcp6ServiceBinding and TCPv4ServiceBinding protocols seem to be installed on the same handle. (The

Re: [edk2] [PATCH] SecurityPkg/OpalPassword: Add NULL pointer check before using it

2019-02-13 Thread Dong, Eric
Hi Maggie, Thanks for your contribution. Reviewed-by: Eric Dong Pushed: d72d8561fbe03a64e01c2ad57a93777de4b9ae2f Thanks, Eric > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Maggie Chu > Sent: Friday, February 1, 2019 6:44 PM > To:

Re: [edk2] nonzero LUN on USB Bulk Only Transfer fails with QEMU+edk2

2019-02-13 Thread Philippe Mathieu-Daudé
Hi Laszlo, On 2/13/19 9:37 AM, Laszlo Ersek wrote: > Hi, > > using QEMU, when I specify a nonzero LUN for the hard disk that sits on > the "SCSI bus" that embodies the USB Bulk Only Transfer device, then > UsbMassStorageDxe fails to recognize the hard disk. > > (1) Consider the following QEMU