[edk2] [PATCH v5 04/13] MdeModulePkg: Add GUID for LockBox to save storage dev to init in S3

2019-02-14 Thread Hao Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 This commit will add the GUID definitions for LockBox which is used to save a list of storage devices that need to get initialized during the S3 resume. The content of the LockBox will be a DevicePath structure that contains zero or more

[edk2] [PATCH v5 06/13] MdeModulePkg/NvmExpressPei: Add logic to produce SSC PPI

2019-02-14 Thread Hao Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 For the NvmExpressPei driver, this commit will add codes to produce the Storage Security Command PPI if the underlying NVM Express controller supports the Security Send and Security Receive commands. Cc: Jian J Wang Cc: Ray Ni Cc: Eric

[edk2] [PATCH v5 01/13] MdeModulePkg: Add definitions for ATA AHCI host controller PPI

2019-02-14 Thread Hao Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 This commit will add the definitions for ATA AHCI host controller PPI. The purpose of the PPI in to provide: * MMIO base address * Controller identification information (DevicePath) for ATA host controllers working under AHCI mode. Cc:

[edk2] [PATCH v5 02/13] MdeModulePkg: Add definitions for EDKII PEI ATA PassThru PPI

2019-02-14 Thread Hao Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 This commit will add the definitions for EDKII PEI ATA PassThru PPI. This PPI will provide services that allow ATA commands to be sent to ATA devices attached to an ATA controller in the PEI phase. More specifically, the PPI will provide

[edk2] [PATCH v5 05/13] MdeModulePkg/NvmExpressPei: Avoid updating the module-level variable

2019-02-14 Thread Hao Wu
This commit is out of the scope for BZ-1409. The commit will remove the call of RegisterForShadow() at the entry point of the driver. By doing so, the driver is now possible to be executed without being re-loaded into permanent memory. Thus, this commit will update the NvmExpressPei driver to

[edk2] [PATCH v5 00/13] Split the S3 PEI phase HW init codes from Opal driver

2019-02-14 Thread Hao Wu
The series is also available at: https://github.com/hwu25/edk2/tree/opal_remodel_v5 V5 changes: For patch 11, as suggested by Star: * Refine the UpdateLockBox() API description comment to be more precise; * Ensure the parameter for macro 'EFI_SIZE_TO_PAGES' is of type 'UINTN'; Since the changes

[edk2] [PATCH v5 03/13] MdeModulePkg: Add definitions for Storage Security Command PPI

2019-02-14 Thread Hao Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 This commit will add the definitions for Storage Security Command (SSC) PPI. This PPI will be be used to abstract mass storage devices to allow code running in the PEI phase to send security protocol commands to mass storage devices without

Re: [edk2] [PATCH v4 09/13] MdeModulePkg/SmmLockBoxLib: Use 'DEBUG_' prefix instead of 'EFI_D_'

2019-02-14 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Wu, Hao A Sent: Monday, February 11, 2019 3:58 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Wang, Jian J ; Zeng, Star Subject: [PATCH v4 09/13] MdeModulePkg/SmmLockBoxLib: Use 'DEBUG_' prefix instead of 'EFI_D_' This commit is out of

[edk2] [PATCH v5 10/13] MdeModulePkg/SmmLockBox(PEI): Remove an ASSERT in RestoreLockBox()

2019-02-14 Thread Hao Wu
This commit is out of the scope for BZ-1409. It is a refinement for the PEI library instance within SmmLockBoxLib. For the below ASSERT statement within function RestoreLockBox(): Status = SmmCommunicationPpi->Communicate ( SmmCommunicationPpi,

[edk2] [PATCH v5 12/13] OvmfPkg/LockBoxLib: Update the comments for API UpdateLockBox()

2019-02-14 Thread Hao Wu
The previous commit: MdeModulePkg/SmmLockBoxLib: Support LockBox enlarge in UpdateLockBox() adds the support to enlarge a LockBox when using the LockBoxLib API UpdateLockBox(). This commit is to sync the API description comment of UpdateLockBox() with its counterparts in MdeModulePkg.

[edk2] [PATCH v5 09/13] MdeModulePkg/SmmLockBoxLib: Use 'DEBUG_' prefix instead of 'EFI_D_'

2019-02-14 Thread Hao Wu
This commit is out of the scope for BZ-1409. It is a coding style refinement for the SmmLockBoxLib. More specifically, the commit will remove all the debug message display level macros starting with 'EFI_D_' and replace them with macros starting with 'DEBUG_'. Cc: Jian J Wang Contributed-under:

[edk2] [PATCH v5 07/13] MdeModulePkg/NvmExpressPei: Consume S3StorageDeviceInitList LockBox

2019-02-14 Thread Hao Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 For the NvmExpressPei driver, this commit will update the driver to consume the S3StorageDeviceInitList LockBox in S3 phase. The purpose is to perform an on-demand (partial) NVM Express device enumeration/initialization to benefit the S3

[edk2] [PATCH v5 11/13] MdeModulePkg/SmmLockBoxLib: Support LockBox enlarge in UpdateLockBox()

2019-02-14 Thread Hao Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 This commit will add the support to enlarge a LockBox when using the LockBoxLib API UpdateLockBox(). Please note that the new support will ONLY work for LockBox with attribute LOCK_BOX_ATTRIBUTE_RESTORE_IN_S3_ONLY set. The functional

Re: [edk2] [PATCH v4 11/13] MdeModulePkg/SmmLockBoxLib: Support LockBox enlarge in UpdateLockBox()

2019-02-14 Thread Zeng, Star
Some minor comments. With them addressed, Reviewed-by: Star Zeng . On 2019/2/11 15:57, Hao Wu wrote: REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 This commit will add the support to enlarge a LockBox when using the LockBoxLib API UpdateLockBox(). Please note that the new support

Re: [edk2] [PATCH v4 10/13] MdeModulePkg/SmmLockBox(PEI): Remove an ASSERT in RestoreLockBox()

2019-02-14 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Wu, Hao A Sent: Monday, February 11, 2019 3:58 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Wang, Jian J ; Zeng, Star Subject: [PATCH v4 10/13] MdeModulePkg/SmmLockBox(PEI): Remove an ASSERT in RestoreLockBox() This commit is out of

Re: [edk2] [PATCH v2 3/3] UefiCpuPkg/SecCore: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-14 Thread Chiu, Chasel
> -Original Message- > From: Ni, Ray > Sent: Thursday, February 14, 2019 4:25 PM > To: Chiu, Chasel ; edk2-devel@lists.01.org > Cc: Dong, Eric ; Laszlo Ersek > Subject: RE: [PATCH v2 3/3] UefiCpuPkg/SecCore: Support > EFI_PEI_CORE_FV_LOCATION_PPI > > > > > -Original Message-

Re: [edk2] [PATCH 2/3] MdeModulePkg/PeiMain: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-14 Thread Chiu, Chasel
> -Original Message- > From: Ni, Ray > Sent: Thursday, February 14, 2019 4:20 PM > To: Chiu, Chasel ; edk2-devel@lists.01.org > Cc: Wang, Jian J ; Wu, Hao A ; > Zeng, Star ; Gao, Liming > Subject: RE: [PATCH 2/3] MdeModulePkg/PeiMain: Support > EFI_PEI_CORE_FV_LOCATION_PPI > > Sorry,

Re: [edk2] [PATCH v2 3/3] UefiCpuPkg/SecCore: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-14 Thread Ni, Ray
> -Original Message- > From: Chiu, Chasel > Sent: Wednesday, February 13, 2019 5:47 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Ni, Ray ; Laszlo > Ersek ; Chiu, Chasel > Subject: [PATCH v2 3/3] UefiCpuPkg/SecCore: Support > EFI_PEI_CORE_FV_LOCATION_PPI > > REF:

Re: [edk2] [Patch 3/3] UefiCpuPkg/RegisterCpuFeaturesLib: Simplify PcdCpuFeaturesSupport.

2019-02-14 Thread Ni, Ray
Reviewed-by: Ray Ni On 2/13/2019 10:04 AM, Eric Dong wrote: PcdCpuFeaturesSupport used to specify the platform policy about what CPU features this platform supports. This value is decide by platform owner, not by hardware. After this change, this PCD will be used in IsCpuFeatureSupported

Re: [edk2] [Patch 0/3] Simplify CPU Features solution.

2019-02-14 Thread Ni, Ray
Eric, Please update the copyright year to 2019 for every file you changed. > -Original Message- > From: Dong, Eric > Sent: Wednesday, February 13, 2019 10:04 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ray ; Laszlo Ersek > Subject: [Patch 0/3] Simplify CPU Features solution. > > Changes

Re: [edk2] [PATCH 2/3] MdeModulePkg/PeiMain: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-14 Thread Ni, Ray
Sorry, please ignore my other review mail and just check this mail. 3 minor comments below. > -Original Message- > From: Chiu, Chasel > Sent: Tuesday, February 12, 2019 9:20 PM > To: edk2-devel@lists.01.org > Cc: Wang, Jian J ; Wu, Hao A ; > Ni, Ray ; Zeng, Star ; Gao, Liming > ; Chiu,

Re: [edk2] [PATCH 2/3] MdeModulePkg/PeiMain: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-14 Thread Ni, Ray
1. please move the #include adjacent to other #include 2. Can you explain why > -Original Message- > From: Chiu, Chasel > Sent: Tuesday, February 12, 2019 9:20 PM > To: edk2-devel@lists.01.org > Cc: Wang, Jian J ; Wu, Hao A ; > Ni, Ray ; Zeng, Star ; Gao, Liming > ; Chiu, Chasel >

Re: [edk2] [Patch 2/3] UefiCpuPkg/RegisterCpuFeaturesLib: Optimize PCD PcdCpuFeaturesUserConfiguration.

2019-02-14 Thread Ni, Ray
> -Original Message- > From: Dong, Eric > Sent: Wednesday, February 13, 2019 10:04 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ray ; Laszlo Ersek > Subject: [Patch 2/3] UefiCpuPkg/RegisterCpuFeaturesLib: Optimize PCD > PcdCpuFeaturesUserConfiguration. > > In current implementation,

[edk2] [PATCH] BaseTools:Function application error

2019-02-14 Thread Fan, ZhijuX
Error due to incorrect function parameters and attributes FileWrite() The first argument it needs is a list, not a file This patch abandons this function and saves the file independently Cc: Bob Feng Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhiju.Fan

Re: [edk2] [PATCH edk2-platforms v1 01/16] Hisilicon/D0x: Remove SerdesLib

2019-02-14 Thread Ming Huang
On 2/13/2019 5:42 PM, Leif Lindholm wrote: > On Wed, Feb 13, 2019 at 02:36:11PM +0800, Ming Huang wrote: >>> Should it not then also delete #include from >>> Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06.c, >>> Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.c and >>>

[edk2] [PATCH v3 1/3] MdePkg: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-14 Thread Chasel, Chiu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1524 Add EFI_PEI_CORE_FV_LOCATION_PPI definition basing on PI spec 1.7, Section 6.3.9. This PPI can support the secnario that PEI Foundation not in BFV. Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement

[edk2] [PATCH v3 3/3] UefiCpuPkg/SecCore: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-14 Thread Chasel, Chiu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1524 EFI_PEI_CORE_FV_LOCATION_PPI may be passed by platform when PeiCore not in BFV so SecCore has to search PeiCore either from the FV location provided by EFI_PEI_CORE_FV_LOCATION_PPI or from BFV. Test: Verified on internal platform and

[edk2] [PATCH v3 0/3] Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-14 Thread Chasel, Chiu
PI spec 1.7 section 6.3.9 has defined a PPI to support the scenario that PEI Foundation not in BFV. EFI_PEI_CORE_FV_LOCATION_PPI reports the FV which contains PEI Foundation and should be passed by SEC as part of PPI list. Otherwise PEI Foundation shall assume that it resides in BFV. Patch1: Add

Re: [edk2] [PATCH 1/3] MdePkg: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-14 Thread Ni, Ray
Chasel, I don't think the below forward definition is needed. typedef struct _EFI_PEI_CORE_FV_LOCATION_PPI EFI_PEI_CORE_FV_LOCATION_PPI; It is needed when the PPI contains methods and the methods requires This pointer as the first parameter. > -Original Message- > From: edk2-devel On

[edk2] [PATCH v3 2/3] MdeModulePkg/PeiMain: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-14 Thread Chasel, Chiu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1524 When shadowing PeiCore the EFI_PEI_CORE_FV_LOCATION_PPI should be checked to see if PeiCore not in BFV, otherwise just shadowing PeiCore from BFV. Test: Verified on internal platform and booting successfully. Cc: Jian J Wang Cc: Hao Wu

Re: [edk2] [PATCH v3 1/3] MdePkg: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-14 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Chasel, Chiu > Sent: Thursday, February 14, 2019 6:59 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > > Subject: [edk2] [PATCH v3 1/3] MdePkg:

Re: [edk2] [Patch 1/3] BaseTools: Fixed a build report issue.

2019-02-14 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Feng, Bob C > Sent: Monday, February 4, 2019 2:48 PM > To: edk2-devel@lists.01.org > Cc: Feng, Bob C ; Gao, Liming > Subject: [Patch 1/3] BaseTools: Fixed a build report issue. > > Generate report fail when -Y EXECUTION_ORDER in

Re: [edk2] [Patch] BaseTools: Fix the build report issue about Structure PCD

2019-02-14 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Feng, Bob C > Sent: Friday, February 1, 2019 5:01 PM > To: edk2-devel@lists.01.org > Cc: Feng, Bob C ; Gao, Liming > Subject: [Patch] BaseTools: Fix the build report issue about Structure PCD > >

Re: [edk2] [PATCH v3 2/3] MdeModulePkg/PeiMain: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-14 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Chiu, Chasel > Sent: Thursday, February 14, 2019 6:59 PM > To: edk2-devel@lists.01.org > Cc: Wang, Jian J ; Wu, Hao A ; > Ni, Ray ; Zeng, Star ; Gao, Liming > ; Chiu, Chasel > Subject: [PATCH v3 2/3] MdeModulePkg/PeiMain: Support >

Re: [edk2] [Patch] BaseTools: Correct the error message for UPT

2019-02-14 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Feng, Bob C > Sent: Saturday, February 2, 2019 9:36 AM > To: edk2-devel@lists.01.org > Cc: Chen, Hess ; Gao, Liming > Subject: [Patch] BaseTools: Correct the error message for UPT > > This patch is going to correct the error message

Re: [edk2] [PATCH v3 3/3] UefiCpuPkg/SecCore: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-14 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Chasel, Chiu > Sent: Thursday, February 14, 2019 6:59 PM > To: edk2-devel@lists.01.org > Cc: Laszlo Ersek ; Dong, Eric > Subject: [edk2] [PATCH v3 3/3] UefiCpuPkg/SecCore:

Re: [edk2] [Patch 2/3] BaseTools: Fixed an issue about StructurePcd

2019-02-14 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Feng, > Bob C > Sent: Monday, February 4, 2019 2:48 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [Patch 2/3] BaseTools: Fixed an issue about

Re: [edk2] [Patch 3/3] BaseTools: Fix a bug about PcdArray

2019-02-14 Thread Gao, Liming
Bob: Could you give more message on this issue? > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Feng, > Bob C > Sent: Monday, February 4, 2019 2:48 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [Patch 3/3] BaseTools:

Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function

2019-02-14 Thread Laszlo Ersek
Hi Bob, On 02/14/19 03:51, Feng, Bob C wrote: > Hi Laszlo, Liming, Jaben and Dandan, > > I found this is a Ubuntu18 bug. Refer to > https://bugs.launchpad.net/ubuntu/+source/fdroidserver/+bug/1762183 That Ubuntu bug is *related*, but it's not a bug that matters for us. The bug above is about

Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function

2019-02-14 Thread Laszlo Ersek
On 02/14/19 04:23, Gao, Liming wrote: > Bob: > So, this is OS issue. I prefer to update wiki page to describe how to > resolve it. Great idea. I think this is probably the affected section:

Re: [edk2] [Patch] BaseTools: Correct the PcdDatabase Info in AutoGen

2019-02-14 Thread Gao, Liming
Zhiju: 1. Please make sure struct PEI_PCD_DATABASE_INIT in AutoGen.h to match gPEIPcdDbInit in AutoGen.c. 2. Please make sure struct DXE_PCD_DATABASE_INIT in AutoGen.h to match gDXEPcdDbinit in AutoGen.c 3. gDXEPcdDbinit in AutoGen.c a. Keep origin style of /* LocalTokenNumberTable */ and /*

Re: [edk2] [PATCH] BaseTools:Function application error

2019-02-14 Thread Carsey, Jaben
I am really confused by this patch and how it ever worked. I see that you remove the import for sdict. But I see that sdict is used in other places in that file. I also cant find a class definition for sdict anywhere (certainly not in Common/Misc). So maybe refactor and remove all the other

Re: [edk2] [PATCH v5 edk2-platforms 00/22] Platform/RaspberryPi: Add Raspberry Pi 3 support

2019-02-14 Thread Leif Lindholm
On Tue, Feb 05, 2019 at 04:25:15PM +, Pete Batard wrote: > Changes for v5: > > * Raspberry/Pi3 -> RaspberryPi/RPi3 > * Remove VirtualRealTimeClockLib as well as BUILD_EPOCH macro (use the > upcoming > EmbeddedPkg Virtual RTC from EDK2 instead) > * Use $(PLATFORM_NAME) where possible in

Re: [edk2] Issues with EDK-II-Debugging wiki page, and how to submit a pull request for wiki pages

2019-02-14 Thread Laszlo Ersek
On 02/14/19 18:39, Rebecca Cran via edk2-devel wrote: > I noticed a couple of issues with the page > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Debugging - > 'SNI' should be 'SNP', and the |PcdDebugPrintErrorLevel is missing some > entries. > | > > > How do I fork the wiki repo

Re: [edk2] [PATCH v5 edk2-platforms 22/22] Platform/RaspberryPi/RPi3: Add platform readme's

2019-02-14 Thread Leif Lindholm
On Tue, Feb 05, 2019 at 04:25:37PM +, Pete Batard wrote: > Documentation is split between general plaform data and OS testing > and installation details. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Pete Batard Reviewed-by: Leif Lindholm > --- >

Re: [edk2] [edk2-announce] Community Meeting Minutes

2019-02-14 Thread Jeremiah Cox via edk2-devel
Hi Ard, My apologies as no insult was intended. The suggestion is that, similar to today, folks encountering difficulties with our systems could reach out to the TianoCore discussion venue (our mailing list or groups.io), and our friendly community members (we have many) will surely assist

[edk2] Issues with EDK-II-Debugging wiki page, and how to submit a pull request for wiki pages

2019-02-14 Thread Rebecca Cran via edk2-devel
I noticed a couple of issues with the page https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Debugging - 'SNI' should be 'SNP', and the |PcdDebugPrintErrorLevel is missing some entries. | How do I fork the wiki repo to make a pull request? On each page there's a "Clone this wiki

Re: [edk2] [edk2-announce] Community Meeting Minutes

2019-02-14 Thread Rebecca Cran via edk2-devel
As a casual contributor, for me the biggest complaint I have is how busy the mailing list gets. I don't think a new 'announce' list is what's needed, perhaps a 'reviews' or 'discussion' list to split out discussions (from anyone) from day-to-day patches? Also, I'd be anxious about jumping to a

Re: [edk2] [edk2-announce] Community Meeting Minutes

2019-02-14 Thread Kinney, Michael D
Rebecca, You can review the groups.io features. I think what you want is available. Stephano has also setup an edk2 area in groups.io for community member to try out. https://groups.io/static/help#features There are a number of CI services that are integrated with GitHub.

[edk2] FW: [PATCH] BaseTools:Function application error

2019-02-14 Thread Fan, ZhijuX
The sdict() was originally defined as common/Misc.py and UPT/library/Misc.py. However, the sdict() defined previously in common/Misc.py has been removed. It is not as good as the OrderedDict() when running in Python3. Any question, please let me know. Thanks. Best Regards Fan Zhiju

Re: [edk2] [PATCH v3 2/3] MdeModulePkg/PeiMain: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-14 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Chiu, Chasel Sent: Thursday, February 14, 2019 6:59 PM To: edk2-devel@lists.01.org Cc: Wang, Jian J ; Wu, Hao A ; Ni, Ray ; Zeng, Star ; Gao, Liming ; Chiu, Chasel Subject: [PATCH v3 2/3] MdeModulePkg/PeiMain: Support

Re: [edk2] [PATCH v3 1/3] MdePkg: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-14 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chasel, Chiu Sent: Thursday, February 14, 2019 6:59 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D ; Gao, Liming Subject: [edk2] [PATCH v3 1/3] MdePkg: Support

[edk2] [PATCH v1 1/1] SecurityPkg/HddPassword: Add Security feature set support for ATA dev

2019-02-14 Thread Hao Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1529 This commit will add the 'Security feature set' support for ATA devices. According to the AT Attachment 8 - ATA/ATAPI Command Set (ATA8-ACS) specification, the Security feature set is an optional feature. In summary, the feature is a

[edk2] [PATCH v1 0/1] Add Security feature set support for ATA devices

2019-02-14 Thread Hao Wu
This patch actually depends on a series that is currently under review: https://www.mail-archive.com/edk2-devel@lists.01.org/msg51142.html One can get this patch together with the above-mentioned series at: https://github.com/hwu25/edk2/tree/hddpassword_v1 Uni-tests performed for the patch: *

[edk2] [PATCH v1] MdeModulePkg/UfsBlockIoPei: Correct use of 'DeviceIndex' in BlkIO PPI

2019-02-14 Thread Hao Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1474 Within UfsBlockIoPei, the current implementation of the Block IO(2) services: UfsBlockIoPeimGetMediaInfo UfsBlockIoPeimReadBlocks UfsBlockIoPeimGetMediaInfo2 UfsBlockIoPeimReadBlocks2 does not handle the input parameter 'DeviceIndex'

Re: [edk2] [edk2-announce] Community Meeting Minutes

2019-02-14 Thread Rebecca Cran via edk2-devel
On 2/14/19 3:13 PM, Kinney, Michael D wrote: You can review the groups.io features. I think what you want is available. Stephano has also setup an edk2 area in groups.io for community member to try out. https://groups.io/static/help#features There are a number of CI services that are

Re: [edk2] [PATCH v3 3/3] UefiCpuPkg/SecCore: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-14 Thread Zeng, Star
// // Perform platform specific initialization before entering PeiCore. // This comment block should be also moved together with SecPlatformMain() calling, right? Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chasel,

Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function

2019-02-14 Thread Feng, Bob C
Hi Laszlo, Thanks for you detailed clarification. This patch will not be pushed to edk2 master and Ubuntu user need to install python3-distutils package via "sudo apt-get install python3-distutils" to resolve this issue. Thanks, Bob -Original Message- From: Laszlo Ersek

[edk2] [PATCH] BaseTools:BaseTools supports to the driver combination.

2019-02-14 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1520 To save the image size without the compression, more than one drivers can be combined into single one. When more than one drivers are combined, their depex will be AND together. Below is the example to combine BootManagerPolicyDxe into

Re: [edk2] [PATCH 1/1] EmbeddedPkg/Library: Add VirtualRealTimeClockLib

2019-02-14 Thread Pete Batard
Hi Leif, On 2019-02-12 19:14, Leif Lindholm wrote: On Mon, Feb 04, 2019 at 12:47:36PM +, Pete Batard wrote: This is designed to be used on platforms where a a real RTC is not available and relies on an RtcEpochSeconds variable having been set or, if that is not the case, falls back to

Re: [edk2] [PATCH 1/1] EmbeddedPkg/Library: Add VirtualRealTimeClockLib

2019-02-14 Thread Pete Batard
Hi Philippe, Thanks fort reviewing this patch, and apologies for the late reply. On 2019-02-05 20:57, Philippe Mathieu-Daudé wrote: Hi Pete, On 2/4/19 1:47 PM, Pete Batard wrote: This is designed to be used on platforms where a a real RTC is not available and relies on an RtcEpochSeconds