Re: [edk2] Question about memory reservation from PrePi to DXE

2015-08-08 Thread Andrew Fish
between PEI and DXE is a HOB (Hand Off Block). If you really need to punch holes in the memory map, then you can use resource descriptors. Thanks, Andrew Fish From what I can see of the code in Gcd.c, this won't work, as CoreInitializeMemoryServices() will not consider the allocation HOBs

Re: [edk2] efi acpidump port

2015-07-29 Thread Andrew Fish
' rule.Context: 'acpidump.inf'Disallowed due to Ticket Number: '0ab4-55b9-3aff-0008' See your system administrator for further information. Copyright 1999-2011 McAfee, Inc.All Rights Reserved.http://www.mcafee.com Thanks for working on this. Thanks, Andrew Fish -Original Message

Re: [edk2] efi acpidump port

2015-07-29 Thread Andrew Fish
] On Behalf Of Smith, Jonathan D Sent: Wednesday, July 29, 2015 1:37 PM To: 'Andrew Fish'; 'edk2-devel@lists.01.org mailto:edk2-devel@lists.01.org' Subject: Re: [edk2] efi acpidump port Hi all, Let me know if the attachments to this message do not show up. I’ve elaborated the build metadata

Re: [edk2] BaseTools features: multiple workspaces

2015-08-03 Thread Andrew Fish
WORKSPACE_MULTIPLE=“”${WORKSPACE}/edk2/;${WORKSPACE}/Vendor/Intel/;${WORKSPACE}/Vendor/OurCode/ The two lists are also the simplest form for the user. Tim’s request to set the WORKSPACE_MULTIPLE from the DSC also is a good example that the lists really are separate. Thanks, Andrew Fish -Jordan

Re: [edk2] [PATCH v2 1/2] ArmPkg/ArmGicLibArchLib: common check for GICv3

2015-07-31 Thread Andrew Fish
On Jul 31, 2015, at 9:37 AM, Ryan Harkin ryan.har...@linaro.org wrote: On 31 July 2015 at 17:16, Andrew Fish af...@apple.com wrote: On Jul 31, 2015, at 7:49 AM, Ryan Harkin ryan.har...@linaro.org wrote: Make Arm and Aarch64 both use the same code, conditionally compiled, to check

Re: [edk2] [PATCH v2 1/2] ArmPkg/ArmGicLibArchLib: common check for GICv3

2015-07-31 Thread Andrew Fish
/PeCoffLoaderEx.c Thanks, Andrew Fish RETURN_STATUS EFIAPI @@ -31,7 +47,7 @@ ArmGicArchLibInitialize ( // feature is implemented on the CPU. This is also convenient as our GICv3 // driver requires SRE. If only Memory mapped access is available we try to // drive the GIC as a v2

Re: [edk2] more code sharing joy between OvmfPkg and ArmVirtPkg, re SMBIOS

2015-07-30 Thread Andrew Fish
code with the libraries listed in the [LibraryClasses] section of your INF. Thanks, Andrew Fish ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] BaseTools features: multiple workspaces

2015-08-05 Thread Andrew Fish
) It overrides WORKSPACE_MULTIPLE - prevents side effects from env breaking build. 2) It appends to $WORKSPACE_MULTIPLE, so env overrides DSC 3) it pre-pends to $WORKSPACE_MULTIPLE, so DSC overrides env. Thanks, Andrew Fish One interesting issue is the selection of a path separator

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

2015-08-05 Thread Andrew Fish
, and it looks like the code gets copied to BootServices, and the AP startup code in ACPI NVS memory? Thanks, Andrew Fish I presume the starup code for the APs resides in an area that happens to be marked non-executable (if this feature enabled), and that causes a fatal fault or some

Re: [edk2] BaseTools features: multiple workspaces

2015-08-05 Thread Andrew Fish
: EDK_SOURCE=$WORKSPACE/EdkCompatibilityPkgEcp Vlv2TbltDevicePkg/bld_vlv.sh:224:cp -f $BUILD_PATH/FV/VLV.fd $WORKSPACE/$BIOS_Name ... Thanks, Andrew Fish I think you originally suggested just using WORKSPACE, but maybe now have changed your mind. I know Tim had some big concerns

Re: [edk2] BaseTools features: multiple workspaces

2015-08-05 Thread Andrew Fish
On Aug 5, 2015, at 12:40 PM, Jordan Justen jordan.l.jus...@intel.com wrote: On 2015-08-05 12:19:47, Andrew Fish wrote: On Aug 5, 2015, at 12:09 PM, Jordan Justen jordan.l.jus...@intel.com wrote: On 2015-08-05 07:06:46, Gao, Liming wrote: Thanks for your all comments. Most people

Re: [edk2] BaseTools features: multiple workspaces

2015-08-05 Thread Andrew Fish
for the args of the build command. Thanks, Andrew Fish -Jordan ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists

Re: [edk2] BaseTools features: multiple workspaces

2015-08-05 Thread Andrew Fish
On Aug 5, 2015, at 2:36 PM, Jordan Justen jordan.l.jus...@intel.com wrote: On 2015-08-05 12:51:47, Andrew Fish wrote: On Aug 5, 2015, at 12:40 PM, Jordan Justen jordan.l.jus...@intel.com wrote: Unless we do something about most of those references then WORKSPACE will have

Re: [edk2] today's US CERT UEFI advisory

2015-07-30 Thread Andrew Fish
to cross reference this info. I’m going to ping some UEFI Forum folks about this. Thanks, Andrew Fish PS. If folks want to brush up on edk2/UEFI security related topics, there has been a lot of security related presentations at UEFI Plugfests that are archived here: http://www.uefi.org

Re: [edk2] GetFirstGuidHob availability across phases

2015-08-14 Thread Andrew Fish
(DXE+). When I use 'GetFirstGuidHob (gLKApiAddrGuid);' it just returns NULL. Is there a way to make this Hob persistent across all phases? What Phase are you talking about? Most of EFI goes away when the OS calls gBS-ExitBootServices(). Thanks, Andrew Fish

Re: [edk2] Question about memory reservation from PrePi to DXE

2015-08-10 Thread Andrew Fish
On Aug 8, 2015, at 2:59 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Sat, 2015-08-08 at 08:56 -0700, Andrew Fish wrote: If you really need to punch holes in the memory map, then you can use resource descriptors. Yes, I do need to punch holes in there, Laszlo

Re: [edk2] Question about memory reservation from PrePi to DXE

2015-08-10 Thread Andrew Fish
On Aug 10, 2015, at 1:51 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Mon, 2015-08-10 at 20:14 +0200, Laszlo Ersek wrote: On 08/10/15 18:46, Andrew Fish wrote: Essentially, I am on a platform/architecture which feeds a flat device-tree to EDK and I need to honor

Re: [edk2] Question about memory reservation from PrePi to DXE

2015-08-10 Thread Andrew Fish
. https://github.com/tianocore/edk2/blob/master/Maintainers.txt https://github.com/tianocore/edk2/blob/master/Maintainers.txt But it does feel like the assumption in the DXE Core is not implied by the PI Specifications. Thanks, Andrew Fish Cheers, Ben

Re: [edk2] Status of porting acpidump to edk2 ?

2015-08-10 Thread Andrew Fish
...@intel.com posted a Windows port to the mailing list. Thanks, Andrew Fish Thanks, Shubha Shubha D. ramanishubharam...@gmail.com shubharam...@yahoo.com ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2

Re: [edk2] BaseTools features: multiple workspaces

2015-08-05 Thread Andrew Fish
On Aug 5, 2015, at 2:46 PM, Jordan Justen jordan.l.jus...@intel.com wrote: On 2015-08-05 13:21:37, Andrew Fish wrote: On Aug 5, 2015, at 12:16 PM, Jordan Justen jordan.l.jus...@intel.com wrote: On 2015-08-05 07:06:46, Gao, Liming wrote: Tim gave another idea to define multiple source

Re: [edk2] Enable optimization for gcc x64 builds

2015-07-24 Thread Andrew Fish
my_printf (void *my_object, const char *my_format, ...) __attribute__ ((format (printf, 2, 3))); It might be possible to add a format attribute to a function that could check the calling conventions, but the optimizations may happen too late to help? Thanks, Andrew Fish -- dwmw2 -- David

Re: [edk2] Simple text protocol- Help

2015-07-21 Thread Andrew Fish
On Jul 21, 2015, at 6:59 PM, Saiprasad Chavali s...@marvell.com wrote: Comments Inline From: Andrew Fish [mailto:af...@apple.com mailto:af...@apple.com] Sent: Tuesday, July 21, 2015 6:49 PM To: Saiprasad Chavali Cc: edk2-de...@ml01.01.org mailto:edk2-de...@ml01.01.org Subject: Re

[edk2] [Patch] ShellPkg: Fix bad TimeZone (TZ) conversion.

2015-07-17 Thread Andrew Fish
+, NTFS, ext3, etc store time in UTC. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Andrew Fish af...@apple.com --- ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib

Re: [edk2] [RFC PATCH 0/8] small C model and LLVM/clang support for AARCH64

2015-07-17 Thread Andrew Fish
), and not PEI (4K alignment)? Is there some feature requiring 4K alignment in PEI? Thanks, Andrew Fish Thanks, Eugene -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Friday, July 17, 2015 6:22 AM To: edk2-devel

Re: [edk2] [MdeModulePkg] PeiMain PeiCore does not compile with Xcode 6.3.2

2015-10-23 Thread Andrew Fish
> On Oct 23, 2015, at 12:53 AM, Zeng, Star <star.z...@intel.com> wrote: > > On 2015/10/22 23:54, Andrew Fish wrote: >> /Users/andrewfish/work/src/edk2/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c:682:28: >> error: for loop has empty body [-Werror,-Wempty-body]

Re: [edk2] style question/Omap3530Gpio

2015-10-21 Thread Andrew Fish
e/master/PcAtChipsetPkg/Include, there is an Include/Register/ but no IndustryStandard dir. The generic answer is the package really owns defining the public include structure. The important point is being really clear on what is public and what is private. The EDK was really bad about

Re: [edk2] [MdeModulePkg] PeiMain PeiCore does not compile with Xcode 6.3.2

2015-10-26 Thread Andrew Fish
> On Oct 25, 2015, at 6:04 PM, Zeng, Star <star.z...@intel.com> wrote: > > On 2015/10/23 22:11, Andrew Fish wrote: >> >>> On Oct 23, 2015, at 12:53 AM, Zeng, Star <star.z...@intel.com> wrote: >>> >>> On 2015/10/22 23:54, Andrew Fish wrote:

Re: [edk2] [Patch 1/2] UefiCpuPkg/CpuDxe: Fix one dead lock issue in StartupThisAP()

2015-10-28 Thread Andrew Fish
to CpuStateReady -- this will prevent the AP > from changing the state from Idle to Sleep. > > Such state transitions should be atomic in general. > > (2) The last sentence of the commit message should be: > > The fix is to *hold* the lock till BSP finished setting the semaphore.

[edk2] [BaseTools] I see main Python thread of build doing acquire thread.lock 87% of a single threaded build.

2015-10-23 Thread Andrew Fish
1010.0000.5150.000 Misc.py:1104(__contains__) Also is findall being called too much? Thanks, Andrew Fish PS This is how I turned on cProfile ~/work/src/edk2(master)>git diff BaseTools/BinWrappers/PosixLike/build diff --git a/BaseTools/BinWrappers/PosixLike/build b/BaseTools/BinWr

[edk2] [MdeModulePkg] MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf will not compile with Xcode 6.3.2

2015-10-21 Thread Andrew Fish
1.0 Reviewed-by: Andrew Fish <af...@apple.com> Thanks, Andrew Fish ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [MdeModulePkg] MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf will not compile with Xcode 6.3.2

2015-10-22 Thread Andrew Fish
> On Oct 21, 2015, at 6:34 PM, Zeng, Star <star.z...@intel.com> wrote: > > On 2015/10/22 7:02, Andrew Fish wrote: >> "/usr/bin/clang" -target x86_64-pc-win32-macho -c -g -Os -Wall -Werror >> -Wextra -include AutoGen.h -funsigned-char -fno-ms-extensions

[edk2] [MdeModulePkg] PeiMain PeiCore does not compile with Xcode 6.3.2

2015-10-22 Thread Andrew Fish
Temp Heap : BaseAddress=0x%p Length=0x%X\n", Private->HobList.Raw, (UINT32)((UINTN) Private->HobList.HandoffInformationTable->EfiFreeMemoryBottom - (UINTN) Private->HobList.Raw))); Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Andrew Fish <af

[edk2] [MdeModulePkg] RegularExpressionDxe does not link with Xcode 6.3.2

2015-10-22 Thread Andrew Fish
-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Andrew Fish <af...@apple.com <mailto:af...@apple.com>> Thanks, Andrew Fish ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] MdeModulePkg: Fix Xcode 6.3.2/clang compilation issues.

2015-11-10 Thread Andrew Fish
de-warnings-fix.patch 0003-MdeModulePkg-Variable-add-mising-VA_COPY.patch I attached again here: Thanks, Andrew Fish > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Andrew > Fish > Sent: Tuesday, November 10, 2015 3:18 PM > To: edk2-devel > Cc: Tian,

Re: [edk2] MdeModulePkg: Fix Xcode 6.3.2/clang compilation issues.

2015-11-10 Thread Andrew Fish
> On Nov 10, 2015, at 7:04 AM, Andrew Fish <af...@apple.com> wrote: > > >> On Nov 10, 2015, at 12:06 AM, Gao, Liming <liming@intel.com> wrote: >> >> Andrew: >> The patch is missing. >> > > Liming, > > My sent mail shows

Re: [edk2] MdeModulePkg: Fix Xcode 6.3.2/clang compilation issues.

2015-11-10 Thread Andrew Fish
> On Nov 10, 2015, at 7:04 AM, Andrew Fish <af...@apple.com> wrote: > > >> On Nov 10, 2015, at 12:06 AM, Gao, Liming <liming@intel.com> wrote: >> >> Andrew: >> The patch is missing. >> > > Liming, > > My sent mail shows

Re: [edk2] MdeModulePkg: Fix Xcode 6.3.2/clang compilation issues.

2015-11-10 Thread Andrew Fish
> On Nov 10, 2015, at 7:04 AM, Andrew Fish <af...@apple.com> wrote: > >> >> On Nov 10, 2015, at 12:06 AM, Gao, Liming <liming@intel.com >> <mailto:liming@intel.com>> wrote: >> >> Andrew: >> The patch is missing. >> >

[edk2] MdePkg: Enable Xcode build of BaseLib without

2015-11-09 Thread Andrew Fish
Please review. To build with Xcode without installing NASM I had to make the following change. ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] ShellPkg: Network commands (ifconfig/ping) broken

2015-11-11 Thread Andrew Fish
k the UEFI revision and "do the correct thing". So I think the objection >is the shell was written to strictly conform to the latest UEFI specification, >when it could have been made backward compatible with a range of UEFI >specification versions. Thanks, Andrew Fish

Re: [edk2] EFI GOP with manual vsync trigger

2015-11-12 Thread Andrew Fish
lt;= TPL of your event from making forward progress. gBS->Stall() does not yield, it is no different than running code. So there is only one context, you can print it out any time you want. Thanks, Andrew Fish PS When folks yell at us for not having threads in EFI we point them at:

Re: [edk2] EFI GOP with manual vsync trigger

2015-11-12 Thread Andrew Fish
ld output directory and see what code it maps to. The X86 version of all this lives: https://github.com/tianocore/edk2/blob/master/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c Thanks, Andrew Fish > On Thu, Nov 12, 2015 at 7:39 PM, Andrew Fish <af...@apple.com> wrote:

Re: [edk2] EFI GOP with manual vsync trigger

2015-11-12 Thread Andrew Fish
> On Nov 12, 2015, at 3:22 AM, Andrew Fish <af...@apple.com> wrote: > > >> On Nov 12, 2015, at 12:49 AM, Michael Zimmermann <sigmaepsilo...@gmail.com> >> wrote: >> >> Stall was just an example, I can also use DEBUG. My timer interval i

Re: [edk2] EFI GOP with manual vsync trigger

2015-11-12 Thread Andrew Fish
sed to implement the timer tick. Every thing else is an event that runs in the main EFI context. https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Core/Dxe/Event/Tpl.c#L126 Thanks, Andrew Fish > On Thu, Nov 12, 2015 at 9:27 AM, Andrew Fish <af...@apple.com> wrote: > >>

Re: [edk2] Alter OVMF/UEFI iSCSI settings outside of the OVMF UI

2015-11-13 Thread Andrew Fish
tianocore/edk2/tree/master/MdeModulePkg/Universal/Variable/RuntimeDxe Thanks, Andrew Fish > Thanks for your help! > > Kind regards, > > Pascal van Dam > > > ___ > edk2

Re: [edk2] EFI GOP with manual vsync trigger

2015-11-16 Thread Andrew Fish
t;> Is it one of the edk2 timer libs? If so which one? > > Nope it's my own, platform specific one(my device hasn't been merged to the > official sources yet). > Most of the other TimerLib implementations use a free running counter. Thanks, Andrew Fish > Michael > > >

Re: [edk2] EFI GOP with manual vsync trigger

2015-11-12 Thread Andrew Fish
> On Nov 12, 2015, at 3:28 AM, Andrew Fish <af...@apple.com> wrote: > >> >> On Nov 12, 2015, at 3:22 AM, Andrew Fish <af...@apple.com> wrote: >> >> >>> On Nov 12, 2015, at 12:49 AM, Michael Zimmermann <sigmaepsilo...@gmail.com> >

Re: [edk2] EFI GOP with manual vsync trigger

2015-11-12 Thread Andrew Fish
at Emptor Assume it is your event and figure out if you are doing something slow at an elevated TPL, calling a service at too hight a TPL., or have TPL related deadlock based on the TPL restrictions. Thanks, Andrew Fish PS Sorry if this is more detail than you needed, but I figured other folks

Re: [edk2] MdePkg: Enable Xcode build of BaseLib without

2015-11-10 Thread Andrew Fish
thon/Common/DataType.py:435:TAB_TOD_DEFINES_BUILDRULEORDER = 'BUILDRULEORDER' I realize now that my previous test may have been flawed since I had NASM installed. Thanks, Andrew Fish > -Jordan > > On 2015-11-10 18:30:39, Gao, Liming wrote: >> This patch is committed at r18766. >&g

Re: [edk2] C Coding Standards Specification disappeared

2015-11-05 Thread Andrew Fish
and stay on a given official UDK 201* release for some time. Thus global formatting changes make diffing more challenging. Thanks, Andrew Fish > On Nov 5, 2015, at 10:26 AM, Kinney, Michael D <michael.d.kin...@intel.com> > wrote: > > Laszlo, > > I agree cast opera

Re: [edk2] [PATCH 6/6] OvmfPkg/PlatformPei: Set PcdCpuMaxLogicalProcessorNumber using QEMU fw_cfg

2015-11-03 Thread Andrew Fish
e local apic state in that case. > I've seen the SMI IPI in code, but I think it is mostly used to deal with the case that the processor is sitting in an INIT and the broadcast SMI was ignored. Thanks, Andrew Fish >> Actually, I was *de*prioritizing it because things _more or less_ wor

Re: [edk2] [PATCH 08/10] ArmCacheMaintenanceLib: disallow whole D-cache maintenance operations

2015-11-04 Thread Andrew Fish
, changing system mappings, and for ARM DMA. So it would be good to make the common cases clear. For example the Cache Operations in the MdePkg started out as the set of operations you need to do generically for an x86 or Itanium processor. Thanks, Andrew Fish > Thanks, > Mark. > ___

Re: [edk2] [MdeModulePkg] MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf will not compile with Xcode 6.3.2

2015-11-06 Thread Andrew Fish
> On Nov 6, 2015, at 1:51 AM, Zeng, Star <star.z...@intel.com> wrote: > > On 2015/10/23 14:04, Andrew Fish wrote: >> >>> On Oct 22, 2015, at 10:10 PM, Zeng, Star <star.z...@intel.com> wrote: >>> >>> On 2015/10/22 23:29, Andrew Fish wrot

Re: [edk2] I don't understand AllocatePages

2015-11-06 Thread Andrew Fish
assed to the OS are page aligned to make it easier for the OS to map. Thanks, Andrew Fish > Thanks, > Shubha > Shubha D. ramanishubharam...@gmail.com > shubharam...@yahoo.com > ___ > edk2-devel mailing list > ed

Re: [edk2] [PATCH v3 44/52] OvmfPkg: QemuFlashFvbServicesRuntimeDxe: no dual addressing needed

2015-10-18 Thread Andrew Fish
to a function is a pointer to a data structure (called PLABLE) that contains a register value, and the function pointer. Thanks, Andrew Fish > I've always seen it done this way, but likely this has been due to a > lot of "copy the old version and modify." > > -Jorda

Re: [edk2] [EDK II] implementing EFI_SMART_CARD_EDGE_PROTOCOL.GetData

2015-10-15 Thread Andrew Fish
age/Include/Guid/NewGuid.h and update MyPackage/MyPackage.dec, assuming MyPackage is the name of the package you own, and NewGuid is the name of the GUID you defined. Thanks, Andrew Fish > > > Best Regards, > > Nilesh > > ___

Re: [edk2] Is it possible to 'resume' and event?

2015-10-07 Thread Andrew Fish
vent to not take too much time. You will need to chop up the work in the event, or make the main code process an event loop. https://web.stanford.edu/~ouster/cgi-bin/papers/threads.pdf <https://web.stanford.edu/~ouster/cgi-bin/papers/threads.pdf> Thanks, Andrew Fish > > Than

Re: [edk2] [PATCH 7/7] UefiCpuPkg: Add missing UefiCpuPkgTokenSpace include

2015-10-08 Thread Andrew Fish
for explaining me the PcdGetEx__() family of functions at the > same time :) I've been wondering about both them, and how one could > resolve token name collisions between different token spaces. > Apparently, with the Ex family (but it remains unnecessary in practice). > It is only ne

Re: [edk2] [grub PATCH] efinet: disable MNP background polling

2015-10-15 Thread Andrew Fish
tack (iPXE) trying to make it as common as possible in all its various ports does not seem like an unreasonable goal, but you might not end up with the ideal implementation for each environment. Thanks, Andrew Fish > Laszlo > >> For information, the MNP driver in UEFI net

[edk2] MdePkg include definition issue in UefiPxe.h?

2015-10-19 Thread Andrew Fish
/UefiPxe.h#L320 #define PXE_OPFLAGS_STATION_ADDRESS_READ 0x #define PXE_OPFLAGS_STATION_ADDRESS_WRITE 0x #define PXE_OPFLAGS_STATION_ADDRESS_RESET 0x0001 Thanks, Andrew Fish ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org

Re: [edk2] Is the edk2 FV INF format documented?

2015-10-20 Thread Andrew Fish
it's not too much trouble could someone who knows the GenFv tool please > consider documenting this? > Might as well add the *.Fv.map files to the list of please document too. I know I have debugger scripts that parse these files. Thanks, Andrew Fish > Thanks, > > Eugene >

Re: [edk2] How do you compile EDK2 git repo on Windows ?

2015-10-17 Thread Andrew Fish
of edk2 source. git is > a much nicer way to get the latest edk2 updates. > $ source edksetup.sh > $ make -C "$EDK_TOOLS_PATH” > make is a GNU command so would have to have GCC installed to have make. Thanks, Andrew Fish > Shubha D. ramanishubharam...@gmail.com > shubha

Re: [edk2] [PATCH] MdeModulePkg PiDxeS3BootScriptLib: Use PcdSet64S to instead of PcdSet64

2015-10-08 Thread Andrew Fish
ew: PcdDynamic means you use the PCD PPI/Protocol with the build generated Token PcdDynamicEx means you use the PCD PPI/Protocol with the fixed Token and EFI_GUID from the .DEC. The DSC file also has a knob that controls how dynamic PCDs are stored. So PcdsDynamicHii is a PcdDynamic form, but the drive

Re: [edk2] apple efi

2015-10-13 Thread Andrew Fish
the earlier Simple Text Input Protocol > (not extended) and therefore can't detect the shift states and toggle states > of the key input. > (hence not detect ALT, CTRL etc, or OPTION.) > > so how does apple detect if OPTION is pressed to know to bring up Startup > Manager? Ext

Re: [edk2] [PATCH v2 11/41] OvmfPkg: implement EFI_SMM_CONTROL2_PROTOCOL with a DXE_RUNTIME_DRIVER

2015-10-13 Thread Andrew Fish
t; machine-wide rendezvous when it isn't necessary. Which is kind of scary since it takes a single CPU away from the OS, and the SMM code and OS would be running at the same time. Thanks, Andrew Fish > BIOS implementations may be lagging behind. > >> >> Second, if writing to i

Re: [edk2] It seems something wrong inGraphicsConsoleControllerDriverStart() when user defined resolution is notsupported

2015-11-17 Thread Andrew Fish
> On Nov 17, 2015, at 5:31 PM, winddy <winddy_zh...@foxmail.com> wrote: > > Hi RuiYu, > patch file is attached. I don't see the attachment. I've had trouble attaching patches to the mailing list too? Thanks, Andrew Fish > Thanks. > > >

Re: [edk2] EFI GOP with manual vsync trigger

2015-11-14 Thread Andrew Fish
tions of the > timerLib because they're not thread safe. > Is it one of the edk2 timer libs? If so which one? Thanks, Andrew Fish > The reason is that a hw counter gets reset and started for this and if this > happens from an interrupt(UART uses delay functions) while the thread mod

Re: [edk2] PCI and non-1:1 mapping of MMIO space

2015-08-25 Thread Andrew Fish
driver expectations and doesn't require changing the APIs. It will require some churn inside PciBusDxe to make it cope with the offsets but that's less of a problem as the overall APIs to drivers are unaffected and thus it's just a matter of me doing it :) Thanks, Andrew Fish Cheers

Re: [edk2] PCI and non-1:1 mapping of MMIO space

2015-08-25 Thread Andrew Fish
the PCI Root Bridge IO protocol could return the Address Translation Offset”, and the PCI Bus driver could save that per Bar and then return that value in the ACPI Address Space Descriptor. Maybe Ben could look into that a propose a patch if it works. Thanks, Andrew Fish Thanks Feng

Re: [edk2] USB hot swap support

2015-08-27 Thread Andrew Fish
hanging on to some protocol that “goes away”. I think I posted an example library, SafeProtocolOpenLib, to the mailing list a while back with an example of how to make BlockIo safe. Thanks, Andrew Fish This is the patch I saw on the mailing list, it should give you and idea on how to make

Re: [edk2] Duplicate GUID

2015-08-27 Thread Andrew Fish
, Andrew Fish MdePkg\MdePkg.dec ## Include/Protocol/SimpleFileSystem.h gEfiSimpleFileSystemProtocolGuid = { 0x964E5B22, 0x6459, 0x11D2, { 0x8E, 0x39, 0x00, 0xA0, 0xC9, 0x69, 0x72, 0x3B }} -Baranee ___ edk2-devel mailing list edk2-devel@lists

Re: [edk2] install a PPI with a NULL Ppi value?

2015-08-27 Thread Andrew Fish
On Aug 27, 2015, at 3:30 PM, Tim Lewis tim.le...@insyde.com wrote: That looks like it is setting up for a dependency expression. Check your .infs to see if anyone uses it in their [depex] section. Or a PeiServicesNotifyPpi() callback. Thanks, Andrew Fish Tim -Original Message

Re: [edk2] Why would a UEFI APP come out as a *.lib when you designed it as an *.efi ?

2015-09-04 Thread Andrew Fish
ompiled. The find link is done on a list of libs so it is the App and all the dependent libraries. Thanks, Andrew Fish > Thanks, > Shubha Shubha D. ramanishubharam...@gmail.com > shubharam...@yahoo.com > ___ > edk2-devel mailing list

Re: [edk2] GetTime - TimeZone

2015-09-03 Thread Andrew Fish
eZone, and Daylight come from values set via SetTime(). I would posit if the RTC stores the TimeZone and Daylight information, then it makes sense to return that info. Thanks, Andrew Fish > ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c > implementation may ne

Re: [edk2] Adding Non-Spec Protocol

2015-09-02 Thread Andrew Fish
ition, and potentially a driver that produces it? Or extend the partition driver to produce it. How it gets merged would be up to the MdeModulePkg maintainer. Thanks, Andrew Fish > Michael > ___ > edk2-devel mailing list > edk2-devel@lists

Re: [edk2] BDS automatically boot \

2015-09-04 Thread Andrew Fish
> On Sep 4, 2015, at 2:11 PM, Tim Lewis <tim.le...@insyde.com> wrote: > > Other than setting BootNext? > Or the other bits of UEFI Chapter 3 Boot Manager. Thanks, Andrew Fish > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On

Re: [edk2] PCI and non-1:1 mapping of MMIO space

2015-08-25 Thread Andrew Fish
Thanks, Andrew Fish On Aug 25, 2015, at 2:18 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Tue, 2015-08-25 at 06:47 -0700, Andrew Fish wrote: Sadly it doesn't seem like the UEFI spec caters well to that non -1:1 mapping (which is quite common outside of the x86

Re: [edk2] PCI and non-1:1 mapping of MMIO space

2015-08-25 Thread Andrew Fish
Thanks, Andrew Fish On Aug 25, 2015, at 2:43 PM, Benjamin Herrenschmidt b...@au1.ibm.com wrote: On Wed, 2015-08-26 at 07:18 +1000, Benjamin Herrenschmidt wrote: I think you have it backwards. The UEFI spec abstracts PCI properly, and drivers are implemented incorrectly

Re: [edk2] PCI and non-1:1 mapping of MMIO space

2015-08-25 Thread Andrew Fish
driver passes in a BarIndex and Offset into the PCI I/O Protocol services. The PCI bus driver is responsible for managing the PCI controller’s BARs. Thanks, Andrew Fish Cheers, Ben. ___ edk2-devel mailing list edk2-devel@lists.01.org https

Re: [edk2] Why I get assert in PCD\Dxe\Service.c

2015-09-09 Thread Andrew Fish
build. If you have other modules they need to use the Ex form that uses a GUID and fixed token number. The build generated tokens only exist to save space when all the code is compiled together. Thanks, Andrew Fish > > > > __

Re: [edk2] [PATCH 1/3] ArmPlatformPkg/MemoryInitPeim: handle memory above 4 GB on 32-bit ARM

2015-09-09 Thread Andrew Fish
you won't be able to run 32-bit UEFI if RAM starts > above 4 GB anyway, so changing it to UINT64 seemed wrong to me. > We have traditionally use EFI_PHYSICAL_ADDRESS for things that can be a system address. On x86 PEI can be 32-bit and DXE 64-bit. Not to mention 32-bit x86 su

Re: [edk2] PCI and non-1:1 mapping of MMIO space (Doubt o PCI Root bridge IOMap and IoAllocateBuffer)

2015-09-12 Thread Andrew Fish
ed equally by the processor and the DMA bus master. • Call Unmap(). • Call FreeBuffer(). Map() lets you know both CPU and PCI address of the memory, in case they are different. You should search the edk2 tree for producers of the PCI Root bridge protocol, there are reference ARM pl

Re: [edk2] PCI and non-1:1 mapping of MMIO space (Doubt o PCI Root bridge IOMap and IoAllocateBuffer)

2015-09-12 Thread Andrew Fish
for doing DMA. On x86 normal memory just works, for ARM you needed an uncached buffer, and you have to do some cache management to maintain coherency. Thanks, Andrew Fish > Thanks and Regards, > Shaveta > > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@list

Re: [edk2] [Qemu-devel] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-10 Thread Andrew Fish
it. > > Thanks for the pointers > This history of issues is why we should remove the binary FAT driver from the common repo, so we accommodate the realities of all the down stream partners. Thanks, Andrew Fish PS Nice to see the FOSS and traditional PC folks l

Re: [edk2] Question on OvmfPkgX64.fdf

2015-09-11 Thread Andrew Fish
scanning to pre-order the list prior to processing it. I only mention this as the complexity of the fix may impact how long it takes to get fixed. Thanks, Andrew Fish > Thanks! > Parker > ___ > edk2-devel mailing list > edk2-devel

Re: [edk2] Proposal to let standalone UEFI shell application carry help inside .EFI instead of in .MAN file

2015-09-14 Thread Andrew Fish
ROTOCOL_GUID installed > Check all strings in the HII packages to find a string which follows spec > defined help format > If the string exists: > Display the help > Else: > Show "no Help" > > Any comments, concerns? > Would this feature require updating the

Re: [edk2] Proposal to let standalone UEFI shell application carry help inside .EFI instead of in .MAN file

2015-09-15 Thread Andrew Fish
you just want to write (or port) a simple application I think you are right that passing the entire command line to the application on MAN failure makes the most sense. Thanks, Andrew Fish >> -Original Message- >> From: Carsey, Jaben [mailto:jaben.car...@intel.com >>

Re: [edk2] Listing files in a directory

2015-09-15 Thread Andrew Fish
t > to get a list of all child nodes. > Michael, This is an example. https://github.com/tianocore/edk2/blob/master/EmbeddedPkg/Ebl/Dir.c <https://github.com/tianocore/edk2/blob/master/EmbeddedPkg/Ebl/Dir.c> I was going to point to the Shell, but it uses internal libraries to do the

Re: [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-09 Thread Andrew Fish
guess it is some kind of civil disobedience. it does not mater what license you strap on the code the the device makers still have to “pay the man”. Thanks, Andrew Fish PS As I stated before I’m fine removing all the binaries from the main repo, as you don’t really want binaries in yo

Re: [edk2] Application abort event for EFI_ABORTED

2015-09-11 Thread Andrew Fish
he shell does this off the top of my head, but you could grep for SCAN_ESC. Thanks, Andrew Fish > Example: > A loop script or a application is proceeding... > Then user press ESC key, and it will be aborted as an EFI_ABORTED status. > > For this feature, does someone can

Re: [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-09 Thread Andrew Fish
o the solution is to keep everything in the tree working on master. We should fix the edk2 process, and place a process in place to communicate pending non backward compatible changes in the edk2 to down stream consumers. Don’t forget a lot (majority) of edk2 based products that ship today live in

Re: [edk2] [PATCH 3/3] ArmVirtPkg: set max physical address width to 40 bits

2015-09-09 Thread Andrew Fish
ted? There could be some assumptions, like the memory > 4GB is passed up to the DXE Core untested, or added later. This seems like an area that could be documented better in the PI specification. Maybe the MdeModulePkg maintainer would have some insight into the assumptions in the DXE Core impleme

Re: [edk2] Proposal to let standalone UEFI shell application carry help inside .EFI instead of in .MAN file

2015-09-23 Thread Andrew Fish
e interoperability. Thanks, Andrew Fish > Thanks, > Ray > > -Original Message- > From: Rothman, Michael A > Sent: Wednesday, September 16, 2015 9:20 AM > To: Ni, Ruiyu <ruiyu...@intel.com <mailto:ruiyu...@intel.com>> > Cc: Carsey, Jaben <jaben.car...@i

Re: [edk2] BaseTools build warnings

2015-09-25 Thread Andrew Fish
> On Sep 25, 2015, at 9:37 AM, Heyi Guo <heyi@linaro.org> wrote: > > Hi Liming, > > Below is my gcc information: > Are you getting warnings, but no failures? I seem to remember the C++ throws off errors for some compilers, but does not fail the tools build. Than

Re: [edk2] [PATCH] MdePkg: remove fixup from ARM MOVW/MOVT relocations

2015-09-25 Thread Andrew Fish
ttern from the IPF. Thanks, Andrew Fish > On 23 September 2015 at 21:31, Ard Biesheuvel <ard.biesheu...@linaro.org > <mailto:ard.biesheu...@linaro.org>> wrote: >> The base relocation type EFI_IMAGE_REL_BASED_ARM_MOV32T patches an >> absolute address into the immediate fie

Re: [edk2] gEfiTcp4ProtocolGuid not found when running application on motherboard

2015-09-23 Thread Andrew Fish
ork environment requires TLS features, EFI_TLS_SERVICE_BINDING_PROTOCOL,EFI_TLS_PROTOCOL and EFI_TLS_CONFIGURATION_PROTOCOL are required. If the network environment requires VLAN features, EFI_VLAN_CONFIG_PROTOCOL is required. Thanks, Andrew Fish > David > > __

Re: [edk2] asm/S assembler files

2015-12-02 Thread Andrew Fish
"=d" (HighData) // %1 : "c" (Index) // %2 ); return (((UINT64)HighData) << 32) | LowData; } Not sure why the Vlv2TbltDevicePkg needed to add that assembly code? I would also point out that the inline assembly will optimize better as the compiler

Re: [edk2] asm/S assembler files

2015-12-02 Thread Andrew Fish
s part of the bitcode, so when the native code generation happens it is very easy for the compiler to optimize. Thanks, Andrew Fish ~/work/Compiler>cat bit.c #define IN typedef unsigned int UINT32; typedef unsigned long long UINT64; UINT64 AsmReadMsr64 ( IN UINT32

Re: [edk2] OvmfPkg: ASSERT hit when booting in QEMU with PcdShadowPeimOnS3Boot and PcdShadowPeimOnBoot set to FALSE

2015-11-30 Thread Andrew Fish
t; The strange thing about this is the failure is loading the DXE Core from the DXE IPL, so all of PEI has already run and been dispatched? #2 0x00822f0e in PeiLoadImageLoadImage at /home/miki/vcs/git/edk2/MdeModulePkg/Core/Pei/Image/Image.c:603 #3 0x00823326 in PeiLoadImageLoadIm

Re: [edk2] EDK2 and VS2015

2015-12-02 Thread Andrew Fish
You can try applying that patch. You will need to remove your Conf/boots_def.txt file to get the BaseTools/Conf/tools_def.template file copied over by the edksetup script. Thanks, Andrew Fish > ___ > edk2-devel mailing list > edk2-devel@lists

Re: [edk2] [PATCH v2 1/3] BaseTools RVCT: use scatter file to implement minimum section alignment

2015-12-01 Thread Andrew Fish
ch-O we ended up linking the image with the offset of the PE/COFF (0x240) so the tool that converts to PE/COFF does not have to apply relocations. Thanks, Andrew Fish > Reviewed-by: Eugene Cohen <eug...@hp.com> > > Eugene > >> -Original Message- >> From:

  1   2   3   4   5   6   7   >