Re: [edk2] [Patch] MdeModulePkg: Update UiApp to handle terminal type TtyTerm

2015-08-19 Thread Dong, Eric
Reviewed-by: Eric Dong eric.d...@intel.com -Original Message- From: Ni, Ruiyu Sent: Wednesday, August 19, 2015 5:35 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Dong, Eric Subject: [Patch] MdeModulePkg: Update UiApp to handle terminal type TtyTerm Contributed-under: TianoCore

Re: [edk2] [patch] MdeModulePkg:Refine the code in HiiDatabaseDxe

2015-08-23 Thread Dong, Eric
Reviewed-by: Eric Dong eric.d...@intel.com -Original Message- From: Bi, Dandan Sent: Monday, August 24, 2015 1:28 PM To: Dong, Eric; Qiu, Shumin; edk2-devel@lists.01.org Subject: [patch] MdeModulePkg:Refine the code in HiiDatabaseDxe Check the local variable 'NameSpace' before use

Re: [edk2] [PATCH v2] MdeModulePkg:Full support F10 hot key in UiApp.

2015-08-19 Thread Dong, Eric
Reviewed-by: Eric Dong eric.d...@intel.com -Original Message- From: Bi, Dandan Sent: Wednesday, August 19, 2015 7:59 PM To: Dong, Eric; Gao, Liming; edk2-devel@lists.01.org Subject: [PATCH v2] MdeModulePkg:Full support F10 hot key in UiApp. In current UiApp/Boot Maintenance manager

Re: [edk2] [patch 2/2] MdeModulePkg:Refine the code comments in UiApp

2015-08-03 Thread Dong, Eric
Reviewed-by: Eric Dong eric.d...@intel.com -Original Message- From: Bi, Dandan Sent: Tuesday, August 04, 2015 12:51 PM To: Dong, Eric; Qiu, Shumin; edk2-devel@lists.01.org Subject: [patch 2/2] MdeModulePkg:Refine the code comments in UiApp Contributed-under: TianoCore Contribution

Re: [edk2] [patch] MdeModulePkg:Fix the issue that refresh the question fail in DriverSample

2015-08-03 Thread Dong, Eric
Reviewed-by: Eric Dong eric.d...@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Tuesday, August 04, 2015 1:16 PM To: Dong, Eric; Gao, Liming; edk2-devel@lists.01.org Subject: [edk2] [patch] MdeModulePkg:Fix the issue

Re: [edk2] [Patch 2/2] Update copyright info, use BDS license.

2015-07-30 Thread Dong, Eric
- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Daryl McDaniel Sent: Friday, July 31, 2015 2:32 AM To: 'Ard Biesheuvel'; Dong, Eric Cc: Ni, Ruiyu; edk2-devel@lists.01.org; Gao, Liming Subject: Re: [edk2] [Patch 2/2] Update copyright info, use BDS license. The copyright

Re: [edk2] [Patch] MdeModulePkg: Enhance PciBusDxe to handle high 32bit of MEM64 BAR returns 0

2015-07-29 Thread Dong, Eric
Reviewed-by: Eric Dong eric.d...@intel.com -Original Message- From: Ni, Ruiyu Sent: Thursday, July 30, 2015 11:11 AM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Dong, Eric Subject: [Patch] MdeModulePkg: Enhance PciBusDxe to handle high 32bit of MEM64 BAR returns 0 According to the PCI

Re: [edk2] [Patch] MdeModulePkg: Make boot option description unique

2015-07-23 Thread Dong, Eric
Reviewed-by: Eric Dong eric.d...@intel.com -Original Message- From: Ni, Ruiyu Sent: Thursday, July 23, 2015 5:15 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Dong, Eric Subject: [Patch] MdeModulePkg: Make boot option description unique When there are multiple network boot options

Re: [edk2] Configuration Menu

2015-10-22 Thread Dong, Eric
Hi Foster, Do you use goto opcode to create "System Setup" menu? Can you help to attach the source code for your menu? I think it must be some error in the goto opcode caused this issue. Thanks, Eric -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On

Re: [edk2] [Patch V2 5/5] Nt32Pkg: Use LogoLib for LOGO and progress bar drawing.

2015-11-11 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Ni, Ruiyu Sent: Monday, November 09, 2015 1:24 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Dong, Eric Subject: [Patch V2 5/5] Nt32Pkg: Use LogoLib for LOGO and progress bar drawing. Contributed-under: Tia

Re: [edk2] [Patch V3 2/2] MdeModulePkg FileExplorerDxe: Create file explorer Protocol.

2015-11-10 Thread Dong, Eric
Yes, will update when check in the code. -Original Message- From: af...@apple.com [mailto:af...@apple.com] Sent: Wednesday, November 11, 2015 1:41 PM To: Dong, Eric Cc: edk2-devel@lists.01.org; cecil.sh...@hpe.com; samer.el-haj-mahm...@hpe.com; Gao, Liming Subject: Re: [edk2] [Patch V3

Re: [edk2] [Patch 1/2] BaseTools VfrCompiler: In order to keep consistent, add an optional "; " for condition op-code.

2015-10-14 Thread Dong, Eric
Leif, Got it, I will update the format to follow the BaseTools/Contributions.txt. Thanks for your comments. Thanks, Eric -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Leif Lindholm Sent: Wednesday, October 14, 2015 10:32 PM To: Dong, Eric Cc

Re: [edk2] [PATCH] MdeModulePkg: Remove unused variables from both UefiBootManagerLib and BdsDxe to fix GCC build.

2015-08-27 Thread Dong, Eric
Checked in code at r18350 -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dong, Eric Sent: Friday, August 28, 2015 12:54 PM To: Wang, Sunny (HPS SW); edk2-devel@lists.01.org Cc: El-Haj-Mahmoud, Samer; Shifflett, Joseph Subject: Re: [edk2] [PATCH

Re: [edk2] [PATCH] MdeModulePkg: Remove unused variables from both UefiBootManagerLib and BdsDxe to fix GCC build.

2015-08-27 Thread Dong, Eric
Reviewed-by: Eric Dong eric.d...@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wang, Sunny (HPS SW) Sent: Friday, August 28, 2015 12:40 PM To: edk2-devel@lists.01.org Cc: El-Haj-Mahmoud, Samer; Shifflett, Joseph Subject: [edk2]

Re: [edk2] [patch] CryptoPkg: Replace string wrapper functions with safe string functions

2015-09-01 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Long, Qin Sent: Tuesday, September 01, 2015 4:55 PM To: Ye, Ting; Dong, Eric Cc: edk2-devel@lists.01.org Subject: [patch] CryptoPkg: Replace string wrapper functions with safe string functions EDKII core s

Re: [edk2] [patch] MdeModulePkg:Refine the code comments in RegularExpressionDxe.

2015-09-13 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Bi, Dandan Sent: Friday, September 11, 2015 2:29 PM To: Dong, Eric; Qiu, Shumin; edk2-devel@lists.01.org Subject: [patch] MdeModulePkg:Refine the code comments in RegularExpressionDxe. Contributed-under: Tia

Re: [edk2] [patch] MdeModulePkg:Fix the bug the incorrect change of StrCpyS function

2015-09-16 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Bi, Dandan Sent: Wednesday, September 16, 2015 5:14 PM To: Dong, Eric; Qiu, Shumin; edk2-devel@lists.01.org Subject: [patch] MdeModulePkg:Fix the bug the incorrect change of StrCpyS function The p

Re: [edk2] HII ConfigRouting Assert - Why?

2015-12-07 Thread Dong, Eric
Eugene, It looks like the code has an assumption that when receive such a ConfigRequest string, it must has one varstore which will generate this ConfigRequest, also has an config access protocol to process this varstore. Can you give some info when this case will raise? Why the original

Re: [edk2] [Patch] DxeTpmMeasureBootLib: Change global variable name to avoid name conflict.

2015-12-16 Thread Dong, Eric
Add more description for it: GCC49 has enhance the global variable name conflict check. If different module share the same global name, it will report link error. This patch fixed one case reported for DxeTpmMeasureBootLib and DxeImageVerificationLib. -Original Message- From:

Re: [edk2] [PATCH] MdeModulePkg: Improved SetupBrowser handling to failed GOTO callback.

2015-12-14 Thread Dong, Eric
Hi Cecil, Why not also use mCurrentFormSetGuid and mCurrentHiiHandle for the guid and HiiHandle info? Thanks, Eric -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Cecil Sheng Sent: Monday, December 14, 2015 1:38 PM To: edk2-devel@lists.01.org

[edk2] [Patch] MdeModulePkg: Change file format which the existed folder has mixed file format

2015-12-15 Thread Dong, Eric
Convert the file format from Unix format to DOS for the folder which has mixed file format. The git codebase in my local already convert to the dos format auto, so I send a svn format patch instead. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong

Re: [edk2] [PATCH] MdeModulePkg: Convert HiiDatabaseDxe ConfigRouting ASSERT to return an error

2015-12-10 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> Checked in code at r19219 Thanks, Eric -Original Message- From: Cohen, Eugene [mailto:eug...@hp.com] Sent: Friday, December 04, 2015 9:33 PM To: edk2-devel@lists.01.org; Dong, Eric; Gao, Liming Subject: [PATCH] MdeModulePkg: C

Re: [edk2] [Patch] MdeModulePkg: DeleteLoadOptionVariable() removes Boot####

2016-01-07 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Ni, Ruiyu Sent: Thursday, January 07, 2016 6:15 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Dong, Eric Subject: [Patch] MdeModulePkg: DeleteLoadOptionVariable() removes Boot

Re: [edk2] [patch] MdeModulePkg:Make HII configuration settings available to OS runtime

2015-12-22 Thread Dong, Eric
[mailto:aaron@congatec.com] Sent: Wednesday, December 23, 2015 2:27 AM To: Dong, Eric Cc: Bi, Dandan; edk2-devel@lists.01.org; edk2-devel; Gao, Liming; El-Haj-Mahmoud, Samer Subject: Re: [edk2] [patch] MdeModulePkg:Make HII configuration settings available to OS runtime I have a question about

Re: [edk2] [Patch 3/8] MdeModulePkg: Add the missing library uni files of UI instances

2015-12-23 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Wednesday, December 23, 2015 5:57 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch 3/8] MdeModulePkg: Add the missing library uni

Re: [edk2] [patch] MdeModulePkg:Make HII configuration settings available to OS runtime

2015-12-21 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Monday, December 21, 2015 4:45 PM To: edk2-devel@lists.01.org Cc: Dong, Eric; Gao, Liming Subject: [edk2] [patch] MdeModulePkg:Ma

Re: [edk2] [patch] MdeModulePkg:Make HII configuration settings available to OS runtime

2015-12-21 Thread Dong, Eric
Yes, all the Hii database data will be export. Also the ConfigResp string for all HII drivers. -Original Message- From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hpe.com] Sent: Tuesday, December 22, 2015 9:25 AM To: Dong, Eric; Bi, Dandan; edk2-devel@lists.01.org Cc: Gao

Re: [edk2] [Patch] MdeModulePkg/BootManagerMenu: Fix bug that boots to undesired option

2015-12-24 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Thursday, December 24, 2015 3:50 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Dong, Eric Subject: [edk2] [Patch] MdeMod

Re: [edk2] [patch] MdeModulePkg:Update Boot Manager form when enter it.

2015-12-17 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Bi, Dandan Sent: Thursday, December 17, 2015 5:52 PM To: edk2-devel@lists.01.org Cc: Gao, Liming; Dong, Eric Subject: [patch] MdeModulePkg:Update Boot Manager form when enter it. Currently BootM

Re: [edk2] [patch] MdeModulePkg:Refine the comments in INF files

2015-11-25 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Bi, Dandan Sent: Wednesday, November 25, 2015 4:55 PM To: edk2-devel@lists.01.org Cc: Gao, Liming; Dong, Eric Subject: [patch] MdeModulePkg:Refine the comments in INF files Add comments in IN

Re: [edk2] [Patch] MdeModulePkg/BDS: Do not pass unnecessary option to boot option

2015-11-24 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Ni, Ruiyu Sent: Tuesday, November 24, 2015 3:22 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Dong, Eric Subject: [Patch] MdeModulePkg/BDS: Do not pass unnecessary option to boot option BDS puts a special GUID i

Re: [edk2] [patch] MdeModulePkg:Correct the file name in UiApp.inf

2015-11-24 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Bi, Dandan Sent: Wednesday, November 25, 2015 12:43 PM To: edk2-devel@lists.01.org Cc: Gao, Liming; Dong, Eric Subject: [patch] MdeModulePkg:Correct the file name in UiApp.inf Cc: Liming Gao <liming@inte

Re: [edk2] [patch 1/8] MdeModulePkg:Rename BootMaintenanceManagerLib to BootMaintenanceManagerUiLib

2016-01-12 Thread Dong, Eric
nal Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Dandan Bi > Sent: Tuesday, January 12, 2016 1:52 AM > To: edk2-devel@lists.01.org > Cc: Dong, Eric <eric.d...@intel.com>; Gao, Liming <liming@intel.com> > Subject: [edk2

Re: [edk2] [Patch v2] UefiCpuPkg/MtrrLib: Fixed bug if length is less than Fixed-MTRR range

2016-06-06 Thread Dong, Eric
Reviewed_by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Fan, Jeff > Sent: Monday, June 06, 2016 2:00 PM > To: edk2-de...@ml01.01.org > Cc: Dong, Eric; Tian, Feng; Kinney, Michael D > Subject: [Patch v2] UefiCpuPkg/MtrrLib: Fixed bug if length is

Re: [edk2] [patch] MdeModulePkg/Database: Fix incorrect calculation of baseline in FontPackage

2016-06-12 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Wednesday, June 08, 2016 3:39 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming; Dong, Eric > Subject: [patch] MdeModulePkg/Database: Fix incorrect calculation of ba

Re: [edk2] [patch] MdeModulePkg/UiApp: Fix the incorrect use of the HiiHandle

2016-06-12 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Monday, June 13, 2016 9:42 AM > To: edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: [patch] MdeModulePkg/UiApp: Fix the incorrect use of the HiiHandle > > In cu

Re: [edk2] [PATCH 0/5] Get SIO data from SIO interface

2016-06-12 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu > Ni > Sent: Sunday, June 12, 2016 5:24 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH 0/5] Get SIO data from SIO interface > >

Re: [edk2] [PATCH] MdeModulePkg/Bds: Do not boot to UI again when BootNext points to UI

2016-06-22 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, June 22, 2016 3:26 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric; Chan, Amy > Subject: [PATCH] MdeModulePkg/Bds: Do not boot to UI again when BootNext >

Re: [edk2] [PATCH V2] SecurityPkg: SecureBootConfigDxe: Move Secure Boot string update location

2016-01-14 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Zhang, Chao B Sent: Thursday, January 14, 2016 4:43 PM To: edk2-de...@ml01.01.org Cc: Dong, Eric; Fu, Siyuan; Zhang, Chao B Subject: [PATCH V2] SecurityPkg: SecureBootConfigDxe: Move Secure Boot string update lo

Re: [edk2] [patch] MdeModulePkg: Make HII configuration settings available to OS runtime

2016-02-22 Thread Dong, Eric
Hi Brian, Thanks for your comments, we need internal discussion for your raised issues, will reply later this week. Thanks, Eric > -Original Message- > From: Brian J. Johnson [mailto:bjohn...@sgi.com] > Sent: Friday, February 19, 2016 5:18 AM > To: Andrew Fish; Dong, Eric

[edk2] FW: [PATCH] MdeModulePkg/HiiDatabaseDxe: Fix a variable is uninitialized.

2016-02-22 Thread Dong, Eric
Reviewed-by: Eric Dong Feng & Star, Can you help to check in this patch? Thanks, Eric -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Cinnamon Shia Sent: Monday, February 22, 2016 10:53 AM To: edk2-devel@lists.01.org

Re: [edk2] [patch] MdeModulePkg: Make HII configuration settings available to OS runtime

2016-02-22 Thread Dong, Eric
form with a large amount of > HII data. On this platform, we end up disabling the largest but least > used setup screens when running on the simulator, simply to avoid the > time overhead of processing the HII data. This saves many minutes of > execution time. > > >>>

Re: [edk2] [patch 0/2] Refine function comments in Keyword Handler Protocol

2016-02-15 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Monday, February 15, 2016 2:56 PM To: edk2-devel@lists.01.org Cc: Dong, Eric; Gao, Liming Subject: [edk2] [patch 0/2] Refine fu

Re: [edk2] [patch 0/2] Add new HII action type EFI_BROWSER_ACTION_SUBMITTED

2016-02-17 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan > Bi > Sent: Tuesday, February 16, 2016 7:55 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric; Gao, Liming > Subj

Re: [edk2] [patch] MdeModulePkg: Make HII configuration settings available to OS runtime

2016-02-17 Thread Dong, Eric
a PCD to control it. Thanks, Eric > -Original Message- > From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hpe.com] > Sent: Wednesday, February 17, 2016 2:14 AM > To: Andrew Fish; Brian J. Johnson > Cc: Bi, Dandan; edk2-devel@lists.01.org; Dong, Eric; Gao, Liming >

Re: [edk2] [patch] MdeModulePkg: Make HII configuration settings available to OS runtime

2016-02-17 Thread Dong, Eric
Correct one error in former mail, the extra data size cost is the runtime memory cost instead of bios flash data cost. Thanks, Eric > -Original Message- > From: Dong, Eric > Sent: Thursday, February 18, 2016 10:51 AM > To: El-Haj-Mahmoud, Samer; Andrew Fish; Brian J. John

Re: [edk2] [patch] MdeModulePkg: Refine the code in BootMaintenanceManagerUiLib

2016-02-18 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Wednesday, February 17, 2016 6:15 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming; Dong, Eric > Subject: [patch] MdeModulePkg: Refine the code in BootMaintenance

Re: [edk2] [patch] MdeModulePkg: Add ASSERT to make sure pointers are not NULL

2016-03-01 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan > Bi > Sent: Tuesday, March 01, 2016 10:52 AM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin; Dong, Eric

Re: [edk2] [patch] MdeModulePkg: FileExplorerLib: Modify the EFI_FILE_EXPLORE_FORMSET_GUID

2016-03-01 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan > Bi > Sent: Tuesday, March 01, 2016 2:58 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric; Gao, Liming

Re: [edk2] [MdeModulePkg] Do we support redefinition of typedefs?

2016-03-15 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Andrew > Fish > Sent: Wednesday, March 16, 2016 2:06 AM > To: edk2-devel > Subject: [edk2] [MdeModulePkg] Do we support redefinition of typedefs? >

Re: [edk2] [PATCH] MdeModulePkg: Fixed incorrect Regular expression protocol MatchString return value.

2016-03-15 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Sheng, > Cecil (HPS SW) > Sent: Tuesday, March 15, 2016 10:39 AM > To: edk2-devel@lists.01.org > Cc: Tian, Feng; Zeng, Star > Subject: Re: [edk2]

Re: [edk2] [patch] MdeModulePkg: Refine the UI code

2016-03-14 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Monday, March 14, 2016 3:24 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming; Dong, Eric > Subject: [patch] MdeModulePkg: Refine the UI code > > Remove

Re: [edk2] [patch] IntelFrameworkModulePkg/LegacyBootMaintUiLib: Refine the code

2016-03-14 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan > Bi > Sent: Monday, March 14, 2016 3:24 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric; Gao, Liming

Re: [edk2] [PATCH v6] MdePkg: Add UEFI2.6 HII Image Ex and Image Decoder protocol definition.

2016-03-08 Thread Dong, Eric
Reviewed-by: Eric Dong Feng, Please help to check in this code. Thanks, Eric > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Cecil > Sheng > Sent: Tuesday, March 08, 2016 3:56 PM > To: edk2-devel@lists.01.org > Cc:

Re: [edk2] [patch] MdeModulePkg/DriverSampleDxe: Uninstall the ConfigAccess protocol

2016-03-15 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Tuesday, March 15, 2016 10:19 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming; Dong, Eric > Subject: [patch] MdeModulePkg/DriverSampleDxe: Uninstall the

Re: [edk2] HII incompatibility between edk2 and iPXE?

2016-03-30 Thread Dong, Eric
30, 2016 11:42 PM > To: Dong, Eric; Laszlo Ersek; Bi, Dandan > Cc: edk2-devel-01; Justen, Jordan L; Ard Biesheuvel > Subject: Re: HII incompatibility between edk2 and iPXE? > > On 30/03/16 16:09, Dong, Eric wrote: > > This error is caused by iPXE driver

Re: [edk2] HII incompatibility between edk2 and iPXE?

2016-03-30 Thread Dong, Eric
Yes, we can also enhance Hiidatabase to not assert. From: Ni, Ruiyu Sent: Thursday, March 31, 2016 8:57 AM To: Dong, Eric; Laszlo Ersek; Bi, Dandan; Michael Brown Cc: Justen, Jordan L; edk2-devel-01; Ard Biesheuvel Subject: RE: HII incompatibility between edk2 and iPXE? Eric, Shall we also fix

Re: [edk2] HII incompatibility between edk2 and iPXE?

2016-04-12 Thread Dong, Eric
> On 05/04/16 03:10, Dong, Eric wrote: > >> On a separate but related note: The ConfigHdr portion of Request and > >> Response seems to contain absolutely zero information by the time it > >> reaches EFI_HII_CONFIG_ACCESS_PROTOCOL. As far as I can te

Re: [edk2] [Patch] SecurityPkg OpalPasswordDxe: Clean up debug message.

2016-04-07 Thread Dong, Eric
Yes, I checked all files. > -Original Message- > From: Tian, Feng > Sent: Friday, April 08, 2016 10:15 AM > To: Dong, Eric; edk2-devel@lists.01.org > Cc: Tian, Feng > Subject: RE: [Patch] SecurityPkg OpalPasswordDxe: Clean up debug message. > > Do you check a

Re: [edk2] [PATCH] OvmfPkg: Add RAM disk support

2016-03-21 Thread Dong, Eric
If the driver provides menus in setup, it only need to install the HII packages through HiiAddPackages and provide Config Access Protocol to let setup browser extract/route data from/to the driver. setup browser don't care any other information in the driver. RAM disk driver already provide

Re: [edk2] [Patch] NetworkPkg: Fix HII related problem in HTTP boot driver.

2016-03-23 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu > Siyuan > Sent: Wednesday, March 23, 2016 3:39 PM > To: edk2-devel@lists.01.org > Cc: Wu, Jiaxin; Dong, Eric > Subject

Re: [edk2] [PATCH 15/35] MdeModulePkg: BootMaintenanceManagerUiLib: remove set but unused variables

2016-03-24 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Thursday, March 24, 2016 6:37 PM > To: edk2-devel-01 > Cc: Ni, Ruiyu; Tian, Feng; Zeng, Star > Subject: [edk2] [PATCH 15/35]

Re: [edk2] [PATCH 16/35] MdeModulePkg: DeviceManagerUiLib: remove set but unused variables

2016-03-24 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Thursday, March 24, 2016 6:37 PM > To: edk2-devel-01 > Cc: Ni, Ruiyu; Tian, Feng; Zeng, Star > Subject: [edk2] [PATCH 16/35]

Re: [edk2] [PATCH v5] MdePkg: Add UEFI2.6 HII Image Ex and Image Decoder protocol definition.

2016-03-07 Thread Dong, Eric
Hi Cecil, The gEfiImageDecoderProtocolGuid value in the .h file is not consistent with the value in the dec file. Please correct it. Thanks, Eric > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Cecil > Sheng > Sent: Tuesday, March 08, 2016

Re: [edk2] [patch] MdeModulePkg/DisplayEngineDxe: Refine the coding style

2016-03-03 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Thursday, March 03, 2016 4:54 PM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin; Dong, Eric > Subject: [patch] MdeModulePkg/DisplayEngineDxe: Refine the coding style &g

Re: [edk2] [PATCH v2] MdePkg: Add UEFI2.6 HII Image Ex and Image Decoder protocol definition.

2016-03-06 Thread Dong, Eric
Reviewed-by: Eric Dong Hi Feng, Please help to check in the code. Thanks, Eric > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Cecil > Sheng > Sent: Wednesday, March 02, 2016 10:56 AM > To: edk2-devel@lists.01.org >

Re: [edk2] [PATCH v4] MdePkg: Add UEFI2.6 HII Image Ex and Image Decoder protocol definition.

2016-03-06 Thread Dong, Eric
> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Cecil > Sheng > Sent: Monday, March 07, 2016 2:07 PM > To: edk2-devel@lists.01.org > Cc: Cecil Sheng > Subject: [edk2] [PATCH v4] MdePkg: Add UEFI2.6 HII Image Ex and Image Decoder > protocol

Re: [edk2] [PATCH] MdePkg: Add UEFI2.6 HII Image Ex and Image Decoder protocol definition.

2016-03-06 Thread Dong, Eric
anks, Eric > -Original Message- > From: Sheng, Cecil (HPS SW) [mailto:cecil.sh...@hpe.com] > Sent: Friday, March 04, 2016 9:36 AM > To: Bi, Dandan; edk2-devel@lists.01.org > Cc: Dong, Eric; Gao, Liming; Chang, Abner (HPS SW/FW Technologist) > Subject: RE: [edk2] [PATCH] M

Re: [edk2] HII incompatibility between edk2 and iPXE?

2016-04-04 Thread Dong, Eric
> -Original Message- > From: Michael Brown [mailto:mc...@ipxe.org] > Sent: Saturday, April 02, 2016 12:50 AM > To: Laszlo Ersek; Dong, Eric; Bi, Dandan > Cc: Justen, Jordan L; edk2-devel-01; Ard Biesheuvel > Subject: Re: [edk2] HII incompatibility between edk2 and iPXE? &

Re: [edk2] [Patch 1/8] MdePkg: Add definition for TCG Storage Core and Opal specs.

2016-03-28 Thread Dong, Eric
Got it, I will update the code before I check in the code. > -Original Message- > From: Yao, Jiewen > Sent: Tuesday, March 29, 2016 9:52 AM > To: Tian, Feng; Dong, Eric; edk2-devel@lists.01.org > Cc: Tian, Feng > Subject: RE: [Patch 1/8] MdePkg: Add definition fo

Re: [edk2] HII incompatibility between edk2 and iPXE?

2016-03-30 Thread Dong, Eric
the ASSERT raised. Detail can check UEFI spec 2.6 chapter 33.2.1.5 and 33.5. Thanks, Eric -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, March 29, 2016 11:21 PM To: Bi, Dandan; Dong, Eric; Michael Brown Cc: edk2-devel-01; Justen, Jordan L; Ard Biesheuvel

Re: [edk2] HII incompatibility between edk2 and iPXE?

2016-03-30 Thread Dong, Eric
> On 29/03/16 16:20, Laszlo Ersek wrote: > > recent edk2 commit 8a45f80edad4 ("MdeModulePkg: Make HII > configuration settings available to OS runtime") seems to trigger an issue > between edk2 and iPXE. > > Thanks for debugging this! > > Is iPXE misbehaving here? At the time that I implemented

Re: [edk2] [PATCH] * MdePkg: Add UEFI2.6 HII Font protocol definitions.

2016-03-29 Thread Dong, Eric
Hi Cecil, Two comments for this patch: 1. The patch is out of date, I can't apply this patch with latest code base. Can you help to regenerate it base on latest code base? 2. Two much useless changes in UefiInternalFormRepresentation.h (just like below changes), please update the patch to

Re: [edk2] [patch 1/2] MdeModulePkg/BootMaintManagerUiLib: Declare EFIAPI for ChooseFile handler

2016-03-23 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Tuesday, March 22, 2016 11:37 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming; Dong, Eric > Subject: [patch 1/2] MdeModulePkg/BootMaintManagerUiLib: Declare EFIAPI f

Re: [edk2] HII incompatibility between edk2 and iPXE?

2016-03-31 Thread Dong, Eric
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, March 31, 2016 6:14 PM > To: Michael Brown; Dong, Eric; Bi, Dandan > Cc: edk2-devel-01; Justen, Jordan L; Ard Biesheuvel > Subject: Re: HII incompatibility between edk2 and iPXE? >

Re: [edk2] [Patch 0/2] Save the Boot mode info for later use.

2016-05-18 Thread Dong, Eric
Please help to check in the code. > -Original Message- > From: Gao, Liming > Sent: Thursday, May 19, 2016 9:25 AM > To: Dong, Eric; edk2-devel@lists.01.org > Subject: RE: [edk2] [Patch 0/2] Save the Boot mode info for later use. > > Reviewed-by: Liming Gao

Re: [edk2] [Patch 0/2] Change code for easy customization.

2016-05-12 Thread Dong, Eric
Extra Notes for this change: It will do some small changes for the current front page and BootMaintenanceManager(BMM) page menus. Detail see below pic. Left is the current UI and right is the new UI. [cid:image014.jpg@01D1AC5A.DA2643F0][cid:image016.jpg@01D1AC5A.DA2643F0]

Re: [edk2] [PATCH 0/2] Fix GCC build failures introduced with a85be3ae48a8

2016-05-15 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, May 13, 2016 5:51 PM > To: edk2-devel-01 > Cc: Ard Biesheuvel; Dong, Eric; Gerd Hoffmann; Gao, Liming > Subject: [PATCH 0/2] Fix GCC b

Re: [edk2] [patch] MdeModulePkg/SetupBrowser: Should free ConfigResp when it no longer be used

2016-05-12 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Wednesday, May 11, 2016 3:17 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: [patch] MdeModulePkg/SetupBrowser: Should free ConfigResp when it no > long

Re: [edk2] [patch] MdeModulePkg/HiiDatabaseDxe: Fix the VS2010/VS2012 build fail

2016-04-20 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Thursday, April 21, 2016 10:07 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming; Dong, Eric > Subject: [patch] MdeModulePkg/HiiDatabaseDxe: Fix the VS2010/VS2012 build

Re: [edk2] [Patch v2] SecurityPkg OpalPasswordDxe: Error handling enhance when input password.

2016-05-09 Thread Dong, Eric
Clarify V2 patch include below changes: "unkown" -> "unknown" "continue boot?." -> "continue boot?" "Press Esc" -> "Press ESC" L"Confirm: Not unlock device and continue boot?.", -> L"Confirm: keep lock status and continue boot?", Also refine the patch comments. Thanks, Eric >

Re: [edk2] [PATCH v2] Security/OpalPasswordDxe: Enhance the logic in RouteConfig/ExtractConfig

2016-05-09 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan > Bi > Sent: Tuesday, May 10, 2016 10:52 AM > To: edk2-devel@lists.01.org > Cc: Dong, Eric > Subject:

Re: [edk2] [PATCH v2] MdeModulePkg/DisplayEngine: Fix memory leak issues in DisplayEngine

2016-05-25 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Friday, May 20, 2016 10:12 AM > To: edk2-devel@lists.01.org > Cc: Cecil Sheng; Qiu, Shumin; Dong, Eric > Subject: [PATCH v2] MdeModulePkg/DisplayEngine: Fix memory leak is

Re: [edk2] [PATCH 1/2] PcAtChipsetPkg/PcRtc: Fix a stack corruption issue

2016-07-26 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Ni, Ruiyu > Sent: Tuesday, July 26, 2016 9:12 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: [PATCH 1/2] PcAtChipsetPkg/PcRtc: Fix a stack corruption issue > > In 32b

Re: [edk2] [PATCH] ShellPkg: Unregister hotkey callback when exiting Shell

2016-07-27 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu > Ni > Sent: Thursday, July 28, 2016 12:47 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: [edk2] [

Re: [edk2] [patch] BaseTool/VfrCompile: Remove reset button opcode in CheckQuestionOpCode

2016-08-11 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Wednesday, August 10, 2016 4:54 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming; Dong, Eric > Subject: [patch] BaseTool/VfrCompile: Remove reset button opcode i

Re: [edk2] [patch] MdeModulePkg: Refine codes of iSCSI driver

2016-08-11 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Zhang, Lubo > Sent: Thursday, August 11, 2016 3:19 PM > To: Dong, Eric > Cc: Ye, Ting; Fu, Siyuan; edk2-devel@lists.01.org > Subject: RE: [edk2] [patch] MdeModulePkg: Refine codes of i

Re: [edk2] SetUnicodeMem in DisplayEngineDxe seems unsafe

2017-01-24 Thread Dong, Eric
Xiaofeng, Thanks, we will follow up to fix it. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of wang > xiaofeng > Sent: Wednesday, January 25, 2017 10:49 AM > To: Dong, Eric > Cc: edk2-devel@lists.01.org; Gao, Liming &g

Re: [edk2] SetUnicodeMem in DisplayEngineDxe seems unsafe

2017-01-24 Thread Dong, Eric
t; >>-Original Message- > >>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > >>wang xiaofeng > >>Sent: Tuesday, January 24, 2017 3:56 PM > >>To: edk2-devel@lists.01.org; Dong, Eric <eric.d...@intel.com> >

Re: [edk2] [patch] MdeMoudlePkg/DisplayEngine: Fix incorrect index used in array "InputText"

2017-02-20 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan > Bi > Sent: Friday, February 10, 2017 10:26 AM > To: edk2-devel@lists.01.org > Cc: Wang Cloud; Dong, Eric; Gao,

Re: [edk2] [patch] MdeModulePkg/BMMUiLib: Remove old useless data before new save action

2017-02-20 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan > Bi > Sent: Monday, February 20, 2017 1:06 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric; Gao, Liming

Re: [edk2] [patch] MdeModulePkg/HiiDatabase: clean the value before setting default string

2017-02-20 Thread Dong, Eric
Dandan, You need to also add check to avoid string size exceed the width. Thanks, Eric > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan > Bi > Sent: Monday, February 20, 2017 1:06 PM > To: edk2-devel@lists.01.org > C

Re: [edk2] [PATCH v2] MdeModulePkg/HiiDatabase: clean the value before setting default string

2017-02-21 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Tuesday, February 21, 2017 10:26 AM > To: edk2-devel@lists.01.org > Cc: Dong, Eric; Gao, Liming > Subject: [PATCH v2] MdeModulePkg/HiiDatabase: clean the value before s

Re: [edk2] [patch 3/3] MdeModulePkg/FileExplorer: Enable functionality of creating new file/folder

2017-01-17 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Bi, Dandan Sent: Monday, January 16, 2017 1:57 PM To: edk2-devel@lists.01.org Cc: Dong, Eric <eric.d...@intel.com>; Gao, Liming <liming@intel.com>; Yao, Jiewen <jiewen@intel.com

Re: [edk2] [patch 1/3] MdeModulePkg/FileExplorer: Remove the codes of searching load file protocol

2017-01-17 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Bi, Dandan Sent: Monday, January 16, 2017 1:57 PM To: edk2-devel@lists.01.org Cc: Dong, Eric <eric.d...@intel.com>; Gao, Liming <liming@intel.com>; Yao, Jiewen <jiewen@intel.com

Re: [edk2] [patch 2/3] MdeModulePkg/FileExplorer: Update QuesrionId when Updating FileExplore form

2017-01-17 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Bi, Dandan Sent: Monday, January 16, 2017 1:57 PM To: edk2-devel@lists.01.org Cc: Dong, Eric <eric.d...@intel.com>; Gao, Liming <liming@intel.com>; Yao, Jiewen <jiewen@intel.com

Re: [edk2] [patch] MdeModulePkg/BMMUiLib: Replace same logic with API in UefiBootManagerLib

2017-02-28 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Ni, Ruiyu Sent: Monday, February 27, 2017 3:19 PM To: Bi, Dandan; edk2-devel@lists.01.org Cc: Dong, Eric; Zeng, Star Subject: RE: [patch] MdeModulePkg/BMMUiLib: Replace same logic with API in UefiBootMana

Re: [edk2] [patch] Nt32Pkg: Fix VS2010/VS2012 build failure

2016-09-05 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Tuesday, September 06, 2016 1:30 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: [patch] Nt32Pkg: Fix VS2010/VS2012 build failure > > Initialize the va

Re: [edk2] [patch] MdeModulePkg/UiApp: Fix incorrect question id

2016-09-08 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Thursday, September 08, 2016 5:10 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming; Dong, Eric > Subject: [patch] MdeModulePkg/UiApp: Fix incorrect question id > >

Re: [edk2] [patch] MdeModulePkg/HiiDB: Handle the "" tag in correctly

2016-09-08 Thread Dong, Eric
Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan > Bi > Sent: Thursday, September 08, 2016 5:10 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric; Gao, Liming

  1   2   3   4   >