Re: [edk2] [PATCH v3] IntelFsp2WrapperPkg: Add a PCD to control if signaling PciEnumerationComplete.

2016-10-25 Thread Dong, Guo
Hi Jiewen, Thank you catch this issue. I have sent an updated patch for it. Could you help check it in if there is no other comments? Since I don't have write access. Thanks, Guo -Original Message- From: Yao, Jiewen Sent: Tuesday, October 25, 2016 4:32 PM To: Dong, Guo <gu

Re: [edk2] [PATCH v2] IntelFsp2WrapperPkg: Add a PCD to control if signaling PciEnumerationComplete.

2016-10-25 Thread Dong, Guo
Thanks Jiewen and Giri! The patch has been updated by all the comments. Thanks, Guo From: Yao, Jiewen Sent: Monday, October 24, 2016 9:55 PM To: Mudusuru, Giri P <giri.p.mudus...@intel.com>; Dong, Guo <guo.d...@intel.com>; edk2-devel@lists.01.org Cc: Ma, Maurice <maurice...@int

Re: [edk2] [PATCH] IntelFsp2WrapperPkg: Add a PCD to control if signaling first event.

2016-10-21 Thread Dong, Guo
I am OK with bit mask PCD. Now only 3 APIs in this driver. Do we really need UINT64? Thanks, Guo From: Yao, Jiewen Sent: Friday, October 21, 2016 4:23 PM To: Dong, Guo <guo.d...@intel.com>; Mudusuru, Giri P <giri.p.mudus...@intel.com>; edk2-devel@lists.01.org Cc: Ma, Maur

Re: [edk2] [PATCH] IntelFsp2WrapperPkg: Add a PCD to control if signaling first event.

2016-10-24 Thread Dong, Guo
Thanks all for these comments. I have sent an updated patch, please help review. Thanks, Guo From: Mudusuru, Giri P Sent: Sunday, October 23, 2016 6:53 AM To: Yao, Jiewen <jiewen@intel.com>; Dong, Guo <guo.d...@intel.com>; edk2-devel@lists.01.org Cc: Ma, Maurice <mauri

Re: [edk2] [PATCH] CorebootModulePkgPkg: Expose FindCbTag API from CbParseLib

2016-10-27 Thread Dong, Guo
Hi Maurice, Thank you for the comments. I have updated patch to add EFIAPI to all the APIs in CbParseLib. Thanks, Guo -Original Message- From: Ma, Maurice Sent: Wednesday, October 26, 2016 8:02 PM To: Dong, Guo <guo.d...@intel.com> Cc: Agyeman, Prince <prince.agye...@intel.c

Re: [edk2] [PATCH v2] CorebootModulePkgPkg: Expose FindCbTag API from CbParseLib

2016-10-27 Thread Dong, Guo
Hi Maurice, Thank you capture this typo. Updated patch has been sent. Thanks, Guo -Original Message- From: Ma, Maurice Sent: Thursday, October 27, 2016 9:38 AM To: Dong, Guo <guo.d...@intel.com> Cc: edk2-devel@lists.01.org; Agyeman, Prince <prince.agye...@intel.com> Subjec

Re: [edk2] [PATCH] UefiPayloadPkg: Enhance UEFI payload for coreboot and Slim Bootloader

2019-03-29 Thread Dong, Guo
Hi Ray, Yes, the new UefiPayload will not require legacy 8254 timer. And we could remove Coreboot packages after UefiPayloadPkg check in. Thanks, Guo > -Original Message- > From: Ni, Ray > Sent: Thursday, March 28, 2019 10:15 PM > To: Dong, Guo ; edk2-devel@lists.01.org;