Re: [edk2] [PATCH v2 2/2] OvmfPkg: Add HttpBoot support

2015-08-19 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan siyuan...@intel.com -Original Message- From: Gary Ching-Pang Lin [mailto:g...@suse.com] Sent: Monday, August 17, 2015 4:21 PM To: edk2-devel@lists.01.org Cc: Laszlo Ersek; Justen, Jordan L; Fu, Siyuan Subject: [PATCH v2 2/2] OvmfPkg: Add HttpBoot support

Re: [edk2] [PATCH v2 1/2] NetworkPkg: Remove the hostname from the http request url

2015-08-19 Thread Fu, Siyuan
HTTP/1.1 Siyuan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gary Ching-Pang Lin Sent: Monday, August 17, 2015 4:21 PM To: edk2-devel@lists.01.org Cc: Justen, Jordan L; Fu, Siyuan; Laszlo Ersek Subject: [edk2] [PATCH v2 1/2] NetworkPkg: Remove

Re: [edk2] [PATCH v3 1/2] NetworkPkg: Remove the hostname from the http request URL

2015-08-19 Thread Fu, Siyuan
The patch is good, do you have access authority of edk2? Or I can help to commit this patch. Reviewed-by: Fu Siyuan siyuan...@intel.com -Original Message- From: Gary Ching-Pang Lin [mailto:g...@suse.com] Sent: Thursday, August 20, 2015 11:49 AM To: edk2-devel@lists.01.org Cc: Laszlo

Re: [edk2] [patch] MdeModulePkg: Fix the issue cannot boot to UEFI Network

2015-07-28 Thread Fu, Siyuan
Patch is good, please remember to update the copyright year when commit it. Reviewed-by: Fu Siyuan siyuan...@intel.com -Original Message- From: Zhang, Lubo Sent: Tuesday, July 28, 2015 4:47 PM To: edk2-devel@lists.01.org Cc: Fu, Siyuan; Ye, Ting; Wu, Jiaxin Subject: [patch

Re: [edk2] [Patch] ShellPkg: Fix issue about ping fail with IPv4

2015-08-05 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan siyuan...@intel.com -Original Message- From: Wu, Jiaxin Sent: Thursday, August 06, 2015 12:08 PM To: edk2-devel@lists.01.org Cc: Fu, Siyuan; Ye, Ting Subject: [Patch] ShellPkg: Fix issue about ping fail with IPv4 Fix issue about ping fail with IPv4, which

Re: [edk2] [patch] NetworkPkg:Fix the issue that cannot parse ipv6 address correctly.

2015-11-08 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan <siyuan...@intel.com> -Original Message- From: Zhang, Lubo Sent: Monday, November 9, 2015 1:26 PM To: edk2-devel@lists.01.org Cc: Fu, Siyuan <siyuan...@intel.com>; Ye, Ting <ting...@intel.com>; Wu, Jiaxin <jiaxin...@intel.com>; Gary Ching

Re: [edk2] [patch] NetworkPkg: Report Http Errors to screen when http layer occurs an error

2015-11-09 Thread Fu, Siyuan
4:23 PM To: edk2-devel@lists.01.org Cc: Ye, Ting <ting...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; Wu, Jiaxin <jiaxin...@intel.com> Subject: [edk2] [patch] NetworkPkg: Report Http Errors to screen when http layer occurs an error Http server will return error status in htt

Re: [edk2] [patch] NetworkPkg: Report Http Errors to screen when http layer occurs an error

2015-11-09 Thread Fu, Siyuan
Looks much better now. Reviewed-by: Fu Siyuan <siyuan...@intel.com> -Original Message- From: Zhang, Lubo Sent: Monday, November 9, 2015 5:57 PM To: edk2-devel@lists.01.org Cc: Ye, Ting <ting...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; Wu, Jiaxin <jiaxin...@int

Re: [edk2] [PATCH v2] NetworkPkg:Enable Http Boot over Ipv6 stack

2015-11-04 Thread Fu, Siyuan
sage- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gary Ching-Pang Lin Sent: Wednesday, November 4, 2015 6:40 PM To: Zhang, Lubo <lubo.zh...@intel.com> Cc: Ye, Ting <ting...@intel.com>; edk2-devel@lists.01.org; Wu, Jiaxin <jiaxin...@intel.com>; Fu, Si

Re: [edk2] [patch] MdeModulePkg:Fix a bug that HttpLib can not parse Ipv6 address correctly.

2015-11-05 Thread Fu, Siyuan
Hi, Lubo The patch pass "IsBracket" by value so it will always be FALSE, please check it. Siyuan -Original Message- From: Zhang, Lubo Sent: Friday, November 6, 2015 9:31 AM To: edk2-devel@lists.01.org Cc: Fu, Siyuan <siyuan...@intel.com>; Ye, Ting <ting...@int

Re: [edk2] [PATCH] NetworkPkg/HttpDxe: Missing CloseEvent() in HttpResponseWorker

2015-11-06 Thread Fu, Siyuan
Hegde, The patch is good. Reviewed-by: Fu Siyuan <siyuan...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Nagaraj Hegde Sent: Tuesday, November 3, 2015 5:11 PM To: edk2-devel@lists.01.org Cc: Ye, Ting <ting...@intel

Re: [edk2] [Patch 2/2] MdeModulePkg: reset DHCP child when leaving PXE LoadFile.

2015-10-15 Thread Fu, Siyuan
Thanks Ting, I will update the words when commit the patch. -Original Message- From: Ye, Ting Sent: Thursday, October 15, 2015 2:27 PM To: Fu, Siyuan <siyuan...@intel.com>; edk2-devel@lists.01.org Cc: srira...@hpe.com Subject: RE: [Patch 2/2] MdeModulePkg: reset DHCP child when l

[edk2] [Patch] NetworkPkg: remove unnecessary timeout event when setting IPv6 address.

2015-10-14 Thread Fu Siyuan
off-by: Fu Siyuan <siyuan...@intel.com> --- NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c | 97 +++- 1 file changed, 50 insertions(+), 47 deletions(-) diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c index 35bdc57..6ad5f

[edk2] [Patch 2/2] MdeModulePkg: reset DHCP child when leaving PXE LoadFile.

2015-10-15 Thread Fu Siyuan
-by: Fu Siyuan <siyuan...@intel.com> --- MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcImpl.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcImpl.c b/MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcImpl.c index 7

[edk2] [Patch 1/2] NetworkPkg: reset DHCP child when leaving PXE LoadFile.

2015-10-15 Thread Fu Siyuan
-by: Fu Siyuan <siyuan...@intel.com> --- NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c b/NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c index 367a135..12e5566 100644 --- a/NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c

Re: [edk2] [Patch] NetworkPkg: Add Dns and HttpUtilities driver UNI files

2015-08-27 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan siyuan...@intel.com From: Wu, Jiaxin Sent: Thursday, August 27, 2015 11:49 AM To: Fu, Siyuan siyuan...@intel.com; edk2-devel@lists.01.org Cc: Ye, Ting ting...@intel.com Subject: RE: [edk2] [Patch] NetworkPkg: Add Dns and HttpUtilities driver UNI files Thanks, I

Re: [edk2] [Patch] ShellPkg: Get media status in ifconfig command

2015-08-28 Thread Fu, Siyuan
Hi, Jiaxin The Snp-Getstatus may not support media present report, please use NetLib interface NetLibDetectMedia() instead. -Original Message- From: Wu, Jiaxin Sent: Friday, August 28, 2015 4:55 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ting...@intel.com; Fu, Siyuan siyuan

Re: [edk2] [PATCH v2] ShellPkg: Get media status in ifconfig command

2015-08-30 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan siyuan...@intel.com -Original Message- From: Wu, Jiaxin Sent: Monday, August 31, 2015 9:29 AM To: edk2-devel@lists.01.org Cc: Ye, Ting ting...@intel.com; Fu, Siyuan siyuan...@intel.com; Carsey, Jaben jaben.car...@intel.com Subject: [PATCH v2] ShellPkg: Get media

Re: [edk2] [patch] NetworkPkg: Fix the HttpCloseConnection fail issue

2015-09-02 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan <siyuan...@intel.com> -Original Message- From: Zhang, Lubo Sent: Wednesday, September 2, 2015 3:55 PM To: edk2-devel@lists.01.org Cc: Fu, Siyuan <siyuan...@intel.com>; Ye, Ting <ting...@intel.com>; Wu, Jiaxin <jiaxin...@intel.com> Subject:

Re: [edk2] [Patch] NetworkPkg: Fix suspicious dereference of pointer 'FieldCount'

2015-09-07 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan <siyuan...@intel.com> -Original Message- From: Wu, Jiaxin Sent: Tuesday, September 8, 2015 9:41 AM To: edk2-devel@lists.01.org Cc: Ye, Ting <ting...@intel.com>; Fu, Siyuan <siyuan...@intel.com> Subject: [Patch] NetworkPkg: Fix suspicious dere

Re: [edk2] [patch] MdeModulePkg: PXE Driver's LoadFile protocol should check FilePath

2015-09-09 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan <siyuan...@intel.com> -Original Message- From: Zhang, Lubo Sent: Wednesday, September 9, 2015 5:09 PM To: edk2-devel@lists.01.org Cc: Fu, Siyuan <siyuan...@intel.com>; Ye, Ting <ting...@intel.com> Subject: [patch] MdeModulePkg: PXE Driver's

[edk2] [Patch] MdeModulePkg: Change the algorithm in SNP to use the first found BAR index.

2015-09-13 Thread Fu Siyuan
of the last one. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan <siyuan...@intel.com> CC: Feng Tian <feng.t...@intel.com> --- MdeModulePkg/Universal/Network/SnpDxe/Snp.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-)

[edk2] [Patch] NetworkPkg: Enhance the NULL pointer check before dereference it.

2015-09-16 Thread Fu Siyuan
This patch enhances the NULL pointer check of the HttpInstance->RemoteHost pointer before dereference it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan <siyuan...@intel.com> --- NetworkPkg/HttpDxe/HttpImpl.c | 3 ++- 1 file changed, 2 insertions(+), 1

[edk2] [Patch] NetworkPkg: TrafficDirection not saved in IPsecConfig.

2015-09-14 Thread Fu Siyuan
Fix a bug that the TrafficDirection field is not saved in IPsecConfig.SetData. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan <siyuan...@intel.com> --- NetworkPkg/IpSecDxe/IpSecConfigImpl.c | 14 -- NetworkPkg/IpSecDxe/IpSecImpl.h |

Re: [edk2] [PATCH] MdePkg: Http.h - Add HttpMethodMax to EFI_HTTP_METHOD

2015-09-16 Thread Fu, Siyuan
Hi, Samer This enum is from UEFI spec and the I think we'd better align with spec's definition. Siyuan -Original Message- From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hpe.com] Sent: Thursday, September 17, 2015 12:29 AM To: edk2-devel@lists.01.org Cc: Fu, Siyuan <siy

Re: [edk2] [PATCH 1/1] MdeModulePkg: Add SMBIOS 3.0 support in NetLibGetSystemGuid

2015-09-17 Thread Fu, Siyuan
Hi, Samer Should below if condition + if (!(EFI_ERROR (Status) || Smbios30Table == NULL)) { to be if (!(EFI_ERROR (Status) && Smbios30Table != NULL)) Siyuan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Samer El-Haj-Mahmoud

Re: [edk2] [Patch] NetworkPkg: Fix the potential NULL pointer dereferenced issue

2015-12-09 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan <siyuan...@intel.com> -Original Message- From: Wu, Jiaxin Sent: Wednesday, December 9, 2015 11:18 AM To: edk2-devel@lists.01.org Cc: Fu, Siyuan <siyuan...@intel.com>; Zhang, Lubo <lubo.zh...@intel.com> Subject: [Patch] NetworkPkg: Fix the pote

[edk2] [Patch 2/2] MdeModulePkg: Update MNP driver to recycle TX buffer asynchronously.

2015-12-14 Thread Fu Siyuan
This patch updates the MNP driver to recycle TX buffer asynchronously, instead of using a while loop wait after each transmit command. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan <siyuan...@intel.com> --- MdeModulePkg/Universal/Network/MnpDxe/MnpCo

[edk2] [Patch 0/2] Recycle TX buffer asynchronously in MNP driver.

2015-12-14 Thread Fu Siyuan
This patch updates the MNP driver to recycle TX buffer asynchronously, instead of using a while loop wait after each transmit command. And a bug fix in SNP GetStatus is needed for this change. Fu Siyuan (2): MdeModulePkg: update SNP.GetStatus to handle multiple recycled TX buffer

[edk2] [Patch] NetworkPkg: Remove a CopyMem to speed up the HTTP boot download.

2015-12-10 Thread Fu Siyuan
This patch updates the HTTP boot driver to use the caller provided buffer directly in identity transfer-coding mode, this could save one time CopyMem operation to benefit the download performance. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan <siy

[edk2] [Patch] NetworkPkg: Enlarge the TCP send/receive buffer in HTTP driver.

2015-12-10 Thread Fu Siyuan
This patch enlarges the TCP send/receive buffer to 2M in HttpDxe driver to speed up the download speed. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan <siyuan...@intel.com> --- NetworkPkg/HttpDxe/HttpProto.c | 22 -- NetworkPkg/H

Re: [edk2] [patch] MdeModulePkg:Fix a bug HttpLib can't parse last chunked data well

2015-12-16 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan <siyuan...@intel.com> -Original Message- From: Zhang, Lubo Sent: Wednesday, December 16, 2015 3:26 PM To: edk2-devel@lists.01.org Cc: Fu, Siyuan <siyuan...@intel.com>; Ye, Ting <ting...@intel.com>; Wu, Jiaxin <jiaxin...@intel

Re: [edk2] [PATCH 7/8] NetworkPkg IScsiDxe: Fix typos in function descriptions

2016-01-03 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan <siyuan...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu Sent: Monday, January 4, 2016 8:39 AM To: edk2-devel@lists.01.org; Fu, Siyuan <siyuan...@intel.com> Cc: Wu, Hao A <hao.a...@int

Re: [edk2] [PATCH 6/8] NetworkPkg IpSecDxe: Fix a typo in function description

2016-01-03 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan <siyuan...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu Sent: Monday, January 4, 2016 8:39 AM To: edk2-devel@lists.01.org; Fu, Siyuan <siyuan...@intel.com> Cc: Wu, Hao A <hao.a...@int

[edk2] [PATCH v2] MdeModulePkg: Update MNP driver to recycle TX buffer asynchronously.

2016-01-04 Thread Fu Siyuan
command, while SNP.GetStatus could only return one pointer each time, the rest of them are lost. This patch fixes this issue by store these recycled pointer in a temporary buffer in SNP driver. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan <siyuan...@intel.

Re: [edk2] [Patch] NetworkPkg: Removing or adding some ASSERT statement

2016-01-04 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan <siyuan...@intel.com> -Original Message- From: Wu, Jiaxin Sent: Tuesday, January 5, 2016 9:47 AM To: edk2-devel@lists.01.org Cc: Ye, Ting <ting...@intel.com>; Fu, Siyuan <siyuan...@intel.com> Subject: [Patch] NetworkPkg: Removing or adding som

Re: [edk2] [PATCH v2] MdeModulePkg: Update MNP driver to recycle TX buffer asynchronously.

2016-01-04 Thread Fu, Siyuan
Thank Jiaxin, I will update the content when commit the patch. Siyuan -Original Message- From: Wu, Jiaxin Sent: Tuesday, January 5, 2016 3:34 PM To: Fu, Siyuan <siyuan...@intel.com>; edk2-devel@lists.01.org Cc: Ye, Ting <ting...@intel.com> Subject: RE: [edk2] [PATCH v2]

Re: [edk2] [PATCH 1/2] OvmfPkg: inherit Image Verification Policy defaults from SecurityPkg

2016-01-06 Thread Fu, Siyuan
Hi, Laszlo Thanks for the detail explanation of the whole story, the change is good to me. Reviewed-by: Fu Siyuan <siyuan...@intel.com> -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, January 7, 2016 5:19 AM To: edk2-de...@ml01.01.org Cc: Justen,

Re: [edk2] [PATCH] NetworkPkg: DnsDxe: fix return type of DnsFillinQNameForQueryIp()

2016-01-05 Thread Fu, Siyuan
The patch is good to me. Reviewed-by: Fu Siyuan <siyuan...@intel.com> -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, January 6, 2016 4:30 AM To: edk2-de...@ml01.01.org Cc: Subramanian Sriram <srira...@hpe.com>; El-Haj-Mahmoud Samer &

Re: [edk2] [PATCH v3] MdeModulePkg: Add HTTP 1.1 industry standard definitions

2015-12-21 Thread Fu, Siyuan
Hi, Samer The patch is good, I will commit it later. Reviewed-by: Fu Siyuan <siyuan...@intel.com> -Original Message- From: Samer El-Haj-Mahmoud [mailto:samer.el-haj-mahm...@hpe.com] Sent: Thursday, December 17, 2015 5:13 AM To: edk2-devel@lists.01.org Cc: Fu, Siyuan &

Re: [edk2] [Patch] NetworkPkg: Remove unused EFI_HTTP_PROTOCOL definition

2015-12-21 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan <siyuan...@intel.com> -Original Message- From: Wu, Jiaxin Sent: Tuesday, December 22, 2015 11:56 AM To: edk2-devel@lists.01.org Cc: Ye, Ting <ting...@intel.com>; Fu, Siyuan <siyuan...@intel.com> Subject: [Patch] NetworkPkg: Remove unused

Re: [edk2] [patch] NetworkPkg:Fix a bug the 2nd httpboot fail issue.

2015-12-17 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan <siyuan...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang Lubo Sent: Friday, December 18, 2015 10:32 AM To: edk2-devel@lists.01.org Cc: Ye, Ting <ting...@intel.com>; Fu, Siyuan <siyuan...

Re: [edk2] [patch] NetworkPkg:Fix a bug the 2nd httpboot fail issue.

2015-12-17 Thread Fu, Siyuan
-Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang Lubo Sent: Friday, December 18, 2015 10:32 AM To: edk2-devel@lists.01.org Cc: Ye, Ting <ting...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; Wu, Jiaxin <jiaxin...@intel.com&

Re: [edk2] [PATCH v2] NetworkPkg:Fix NULL pointer dereference issues.

2015-11-25 Thread Fu, Siyuan
) || HttpHeaders == NULL) { goto Error; } Reviewed-by: Fu Siyuan <siyuan...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang Lubo Sent: Thursday, November 26, 2015 10:01 AM To: edk2-devel@lists.01.org Cc: Ye, Ting

Re: [edk2] [PATCH] MdeModulePkg/Pxe: Fix bug of checking input FilePath

2015-11-20 Thread Fu, Siyuan
Hi, Guo It's not a bug, for EfiPxeLoadFile function the input FilePath should always be an end device path node. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi Guo Sent: Friday, November 20, 2015 4:23 PM To: edk2-devel@lists.01.org Cc:

Re: [edk2] [Patch 2/2] NetworkPkg: Remove DNS QType and QClass definition

2016-01-12 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan <siyuan...@intel.com> -Original Message- From: Wu, Jiaxin Sent: Tuesday, January 12, 2016 9:37 PM To: edk2-devel@lists.01.org Cc: Hegde Nagaraj P <nagaraj-p.he...@hpe.com>; Ye, Ting <ting...@intel.com>; Fu, Siyuan <siyuan...@intel.com

Re: [edk2] [Patch] MdeModulePkg: Fix incorrect status check for SockProcessRcvToken

2016-05-24 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan <siyuan...@intel.com> > -Original Message- > From: Wu, Jiaxin > Sent: Wednesday, May 25, 2016 11:57 AM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan <siyuan...@intel.com>; Ye, Ting <ting...@intel.com> > Subject: [Patch] MdeM

[edk2] [Patch 2/2] NetworkPkg: Stop the timer before clean IP service.

2016-05-25 Thread Fu Siyuan
Jiaxin <jiaxin...@intel.com> Cc: Ye Ting <ting...@intel.com> Cc: Subramanian Sriram <srira...@hpe.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan <siyuan...@intel.com> --- NetworkPkg/Ip6Dxe/Ip6Driver.c | 31 ---

[edk2] [Patch 0/2] Stop-the-timer-before-clean-IP-service

2016-05-25 Thread Fu Siyuan
Fu Siyuan (2): MdeModulePkg: Stop the timer before clean IP service. NetworkPkg: Stop the timer before clean IP service. MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Driver.c | 18 ++--- NetworkPkg/Ip6Dxe/Ip6Driver.c | 31 --- 2 files changed, 25

[edk2] [Patch 1/2] MdeModulePkg: Stop the timer before clean IP service.

2016-05-25 Thread Fu Siyuan
Jiaxin <jiaxin...@intel.com> Cc: Ye Ting <ting...@intel.com> Cc: Subramanian Sriram <srira...@hpe.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan <siyuan...@intel.com> --- MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Driver.c | 18 +

Re: [edk2] [Patch] NetworkPkg/TcpDxe: Fix GCC build failure

2016-06-14 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan <siyuan...@intel.com> > -Original Message- > From: Wu, Jiaxin > Sent: Tuesday, June 14, 2016 10:44 AM > To: edk2-devel@lists.01.org > Cc: Ye, Ting <ting...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; Zhang, > Lubo <

Re: [edk2] TCP4: Failure to Acknowledge due to DPC Dispatch Nesting

2016-05-25 Thread Fu, Siyuan
otherwise there is a deadlock. Best Regards Siyuan From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Cohen, Eugene Sent: Wednesday, May 25, 2016 1:16 AM To: Fu, Siyuan <siyuan...@intel.com>; Ye, Ting <ting...@intel.com>; edk2-devel@lists.01.org; Wu, Jiaxin <jiaxin..

Re: [edk2] [Patch 1/2] MdePkg: Correct EFI_HTTP_CONFIGURE return status value

2016-05-25 Thread Fu, Siyuan
Serials Reviewed-by: Fu Siyuan <siyuan...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jiaxin Wu > Sent: Wednesday, May 25, 2016 4:28 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting <ting...@intel

Re: [edk2] [PATCH 3/8] NetworkPkg: Replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr

2016-06-16 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan <siyuan...@intel.com> > -Original Message- > From: Zeng, Star > Sent: Wednesday, June 15, 2016 4:44 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen....@intel.com>; Fu, Siyuan <siyuan...@intel.com>; > Wu, Jiaxin <jia

Re: [edk2] [PATCH v1 1/1] MdePkg: MTftp6: Correct #define value in Mtfp6.h

2016-06-16 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan <siyuan...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > hegdenag > Sent: Thursday, June 16, 2016 12:51 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting <ting...@int

Re: [edk2] [Patch] NetworkPkg: Fix unspecified address use case in IpsecConfig

2016-06-16 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan <siyuan...@intel.com> > -Original Message- > From: Wu, Jiaxin > Sent: Wednesday, June 15, 2016 4:26 PM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan <siyuan...@intel.com>; Ye, Ting <ting...@intel.com>; Zeng, > Star <

Re: [edk2] [Patch] MdeModulePkg: Fix the wrong IpSb->State update

2016-06-22 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan <siyuan...@intel.com> > -Original Message- > From: Wu, Jiaxin > Sent: Wednesday, June 22, 2016 7:14 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting <ting...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; Ryan > Harkin <ry

Re: [edk2] [patch 1/3] NetworkPkg: Refine codes related to Dhcpv4 and Dhcpv6 configuration.

2016-06-16 Thread Fu, Siyuan
Series Reviewed-by: Fu Siyuan <siyuan...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Zhang Lubo > Sent: Friday, June 17, 2016 11:08 AM > To: edk2-devel@lists.01.org > Cc: Ye, Ting <ting...@int

Re: [edk2] [PATCH] SecurityPkg: SecureBootConfigDxe: Change KEY_TRANS_SECURE_BOOT_MODE value

2016-01-13 Thread Fu, Siyuan
It's good to me. Reviewed-by: Fu Siyuan <siyuan...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang, Chao B Sent: Thursday, January 14, 2016 9:01 AM To: edk2-de...@ml01.01.org Cc: Fu, Siyuan <siyuan...@intel.com>; Z

Re: [edk2] [Patch 0/2] Fix IpSec SPD and SAD mapping issue when SPD updated

2016-01-17 Thread Fu, Siyuan
The patch is good to me. Reviewed-by: Fu Siyuan <siyuan...@intel.com> -Original Message- From: Wu, Jiaxin Sent: Monday, January 11, 2016 4:44 PM To: edk2-devel@lists.01.org Cc: Ye, Ting <ting...@intel.com>; Fu, Siyuan <siyuan...@intel.com> Subject: [Patch 0/2] Fix

Re: [edk2] [PATCH] SecurityPkg: SecureBootConfigDxe: Fix string typo

2016-01-14 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan <siyuan...@intel.com> -Original Message- From: Zhang, Chao B Sent: Friday, January 15, 2016 9:39 AM To: edk2-de...@ml01.01.org Cc: Long, Qin <qin.l...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; Zhang, Chao B <chao.b.zh...@intel

Re: [edk2] [PATCH V2] SecurityPkg: SecureBootConfigDxe: Move Secure Boot string update location

2016-01-14 Thread Fu, Siyuan
The patch is good. Please also update the copy right year to 2016. Reviewed-by: Fu Siyuan <siyuan...@intel.com> -Original Message- From: Zhang, Chao B Sent: Thursday, January 14, 2016 4:43 PM To: edk2-de...@ml01.01.org Cc: Dong, Eric <eric.d...@intel.com>; Fu, Si

Re: [edk2] [Patch] edk2: Update the maintainer list.

2016-01-18 Thread Fu, Siyuan
Jiaxin, It's ok with me. Reviewed-by: Siyuan Fu <siyuan...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiaxin Wu Sent: Tuesday, January 19, 2016 9:40 AM To: edk2-devel@lists.01.org Cc: Fu, Siyuan <siyuan...@intel.com>

[edk2] [Patch] NetworkPkg: Stop the HTTP Boot service after the boot image download complete.

2016-06-28 Thread Fu Siyuan
lt;jiaxin...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan <siyuan...@intel.com> --- NetworkPkg/HttpBootDxe/HttpBootImpl.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/NetworkPkg/HttpBootDxe/HttpBootImpl.c b/Netw

Re: [edk2] [patch 3/3] MdePkg: Refine codes related to Dhcpv4 and Dhcpv6 configuration.

2016-06-17 Thread Fu, Siyuan
o:edk2-devel-boun...@lists.01.org] On Behalf Of > Subramanian, Sriram (EG Servers Platform SW) > Sent: Friday, June 17, 2016 3:29 PM > To: Zhang, Lubo <lubo.zh...@intel.com>; edk2-devel@lists.01.org > Cc: Ye, Ting <ting...@intel.com>; Fu, Siyuan <siyuan...@intel.com>

[edk2] [Patch 2/2] MdeModulePkg: SNP should check Cdb.StatCode with PXE_STATCODE_SUCCESS.

2016-02-04 Thread Fu Siyuan
This patch fixes a bug in SNP driver that the Cdb.StatCode should be check with PXE_STATCODE_SUCCESS instead of EFI_SUCCESS. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan <siyuan...@intel.com> CC: Ye Ting <ting...@intel.com> CC: Subramanian S

[edk2] [Patch 1/2] MdeModulePkg: Make the DEBUG info consistent in SNP driver.

2016-02-04 Thread Fu Siyuan
-by: Fu Siyuan <siyuan...@intel.com> CC: Ye Ting <ting...@intel.com> CC: Subramanian Sriram <srira...@hpe.com> CC: Wu Jiaxin <jiaxin...@intel.com> --- MdeModulePkg/Universal/Network/SnpDxe/Get_status.c | 2 +- MdeModulePkg/Universal/Network/SnpDxe/Stop.c | 6 ++

[edk2] [Patch 0/2] Minor fixes in SnpDxe

2016-02-04 Thread Fu Siyuan
Fu Siyuan (2): MdeModulePkg: Make the DEBUG info consistent in SNP driver. MdeModulePkg: SNP should check Cdb.StatCode with PXE_STATCODE_SUCCESS. MdeModulePkg/Universal/Network/SnpDxe/Get_status.c | 4 ++-- MdeModulePkg/Universal/Network/SnpDxe/Receive_filters.c | 8

Re: [edk2] [PATCH 1/2] MdeModulePkg: Add BS+RT+AT variable attribute definition

2016-01-28 Thread Fu, Siyuan
Reviewed-by: Siyuan Fu <siyuan...@intel.com> -Original Message- From: Zhang, Chao B Sent: Friday, January 29, 2016 2:18 PM To: edk2-de...@ml01.01.org Cc: Zeng, Star <star.z...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; Zhang, Chao B <chao.b.zh...@intel.com

Re: [edk2] [PATCH 2/2] SecurityPkg: AuthVariableLib: Add new cert database for volatile time based Auth variable

2016-01-28 Thread Fu, Siyuan
All right, the patch is good to me. Reviewed-by: Siyuan Fu <siyuan...@intel.com> -Original Message- From: Zhang, Chao B Sent: Friday, January 29, 2016 3:10 PM To: Fu, Siyuan <siyuan...@intel.com>; edk2-de...@ml01.01.org Cc: Zeng, Star <star.z...@intel.com> Subje

Re: [edk2] [PATCH 2/2] SecurityPkg: AuthVariableLib: Add new cert database for volatile time based Auth variable

2016-01-28 Thread Fu, Siyuan
Hi, Chao The changes for CleanCertsFromDb() function seems unnecessary, Certdbv is a volatile variable so it doesn't need clean up logic on system crash. Other parts are good for me. Reviewed-by: Siyuan Fu <siyuan...@intel.com> -Original Message- From: Zhang, Chao B Sent:

Re: [edk2] [Patch 1/2] MdePkg: Correct inconsistent function descriptions in DNS

2016-01-28 Thread Fu, Siyuan
Reviewed-by: Siyuan Fu <siyuan...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiaxin Wu Sent: Friday, January 29, 2016 8:52 AM To: edk2-devel@lists.01.org Cc: Ye, Ting <ting...@intel.com>; Fu, Siyuan <siyuan...@int

Re: [edk2] [Patch] Maintainers.txt: Update maintainers for NetworkPkg

2016-01-28 Thread Fu, Siyuan
Reviewed-by: Siyuan Fu <siyuan...@intel.com> -Original Message- From: Wu, Jiaxin Sent: Friday, January 29, 2016 9:13 AM To: edk2-devel@lists.01.org Cc: Fu, Siyuan <siyuan...@intel.com>; Ye, Ting <ting...@intel.com> Subject: [Patch] Maintainers.txt: Update maintainers

Re: [edk2] [Patch 2/2] NetworkPkg: Correct inconsistent function descriptions in DNS

2016-01-28 Thread Fu, Siyuan
Reviewed-by: Siyuan Fu <siyuan...@intel.com> -Original Message- From: Wu, Jiaxin Sent: Friday, January 29, 2016 8:52 AM To: edk2-devel@lists.01.org Cc: Fu, Siyuan <siyuan...@intel.com>; Ye, Ting <ting...@intel.com> Subject: [Patch 2/2] NetworkPkg: Correct inc

Re: [edk2] [Patch] MdePkg: Remove magic number

2016-01-28 Thread Fu, Siyuan
Reviewed-by: Siyuan Fu <siyuan...@intel.com> -Original Message- From: Wu, Jiaxin Sent: Thursday, January 28, 2016 3:47 PM To: edk2-devel@lists.01.org Cc: Fu, Siyuan <siyuan...@intel.com>; Ye, Ting <ting...@intel.com> Subject: [Patch] MdePkg: Remove magic number

[edk2] [Patch 0/3] Fix several issues related to TX buffer recycle

2016-01-31 Thread Fu Siyuan
1. MdeModulePkg-Update-the-default-size-of-MNP-TX-buffer. 2. Update DBsize in SNP GetStatus command 3. Correct one return status code in SNP Transmit function. Fu Siyuan (3): MdeModulePkg: Update the default size of MNP TX buffer pool. MdeModulePkg: Update DBsize in SNP GetStatus command

[edk2] [Patch 2/3] MdeModulePkg: Update DBsize in SNP GetStatus command.

2016-01-31 Thread Fu Siyuan
Update the DBsize in GetStatus command to let UNDI return an array of recycled buffers. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan <siyuan...@intel.com> CC: Ye Ting <ting...@intel.com> CC: Wu Jiaxin <jiaxin...@intel.com> --- MdeModulePkg

[edk2] [Patch 3/3] MdeModulePkg: Correct one return status code in SNP Transmit function.

2016-01-31 Thread Fu Siyuan
ontributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan <siyuan...@intel.com> CC: Ye Ting <ting...@intel.com> CC: Wu Jiaxin <jiaxin...@intel.com> --- MdeModulePkg/Universal/Network/SnpDxe/Transmit.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-

[edk2] [Patch 1/3] MdeModulePkg: Update the default size of MNP TX buffer pool.

2016-01-31 Thread Fu Siyuan
This patch update the default MNP TX buffer increasement to 32, so the default TX pool length is same as the maximum recycled buffer numbers in one UNDI GetStatus command. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan <siyuan...@intel.com> CC: Ye Ting

Re: [edk2] [PATCH v4] NetworkPkg:Add a new error status code EFI_HTTP_ERROR

2016-02-01 Thread Fu, Siyuan
Reviewed-by: Siyuan Fu <siyuan...@intel.com> -Original Message- From: Zhang, Lubo Sent: Tuesday, February 2, 2016 2:52 PM To: edk2-devel@lists.01.org Cc: Fu, Siyuan <siyuan...@intel.com>; Ye, Ting <ting...@intel.com>; Wu, Jiaxin <jiaxin...@intel.com> Subject: [

Re: [edk2] [Patch 1/3] MdeModulePkg: Update the default size of MNP TX buffer pool.

2016-02-02 Thread Fu, Siyuan
To: Fu, Siyuan <siyuan...@intel.com>; Subramanian Sriram <srira...@hpe.com> Cc: edk2-de...@ml01.01.org; Ye, Ting <ting...@intel.com>; Wu, Jiaxin <jiaxin...@intel.com>; El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; Li, Ruth <ruth...@intel.com>; Hsiung, Harry

Re: [edk2] [patch] NetworkPkg: Fix suspicious dereference of pointer 'Mode.Ia'

2016-02-01 Thread Fu, Siyuan
Reviewed-by: Siyuan Fu <siyuan...@intel.com> -Original Message- From: Zhang, Lubo Sent: Tuesday, February 2, 2016 2:51 PM To: edk2-devel@lists.01.org Cc: Fu, Siyuan <siyuan...@intel.com>; Ye, Ting <ting...@intel.com>; Wu, Jiaxin <jiaxin...@intel.com> Subject:

[edk2] [Patch v2 3/3] MdeModulePkg: Correct one return status code in SNP Transmit function.

2016-02-02 Thread Fu Siyuan
ontributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan <siyuan...@intel.com> CC: Ye Ting <ting...@intel.com> CC: Wu Jiaxin <jiaxin...@intel.com> --- MdeModulePkg/Universal/Network/SnpDxe/Transmit.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-

[edk2] [Patch v2 1/3] MdeModulePkg: Update the default size of MNP TX buffer pool.

2016-02-02 Thread Fu Siyuan
drivers which may not return the correct statuses for the SNP and MNP to correctly retry/call GetStatus to clear the buffers. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan <siyuan...@intel.com> CC: Ye Ting <ting...@intel.com> CC: Wu Jiaxin <jiax

[edk2] [Patch v2 0/3] Fix several issues related to TX buffer recycle

2016-02-02 Thread Fu Siyuan
1. MdeModulePkg-Update-the-default-size-of-MNP-TX-buffer. 2. Update DBsize in SNP GetStatus command 3. Correct one return status code in SNP Transmit function. Fu Siyuan (3): MdeModulePkg: Update the default size of MNP TX buffer pool. MdeModulePkg: Update DBsize in SNP GetStatus command

[edk2] [Patch v2 2/3] MdeModulePkg: Update DBsize in SNP GetStatus command.

2016-02-02 Thread Fu Siyuan
. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan <siyuan...@intel.com> CC: Ye Ting <ting...@intel.com> CC: Wu Jiaxin <jiaxin...@intel.com> --- MdeModulePkg/Universal/Network/SnpDxe/Get_status.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

Re: [edk2] [Patch 1/3] MdeModulePkg: Update the default size of MNP TX buffer pool.

2016-02-02 Thread Fu, Siyuan
ira...@hpe.com>; Fu, Siyuan <siyuan...@intel.com> Cc: edk2-de...@ml01.01.org; Ye, Ting <ting...@intel.com>; Wu, Jiaxin <jiaxin...@intel.com>; El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; Li, Ruth <ruth...@intel.com>; Hsiung, Harry L <harry.l.hsi...@in

Re: [edk2] [PATCH v2] MdePkg:Add a new error status code EFI_HTTP_ERROR.

2016-01-28 Thread Fu, Siyuan
Reviewed-by: Siyuan Fu <siyuan...@intel.com> -Original Message- From: Zhang, Lubo Sent: Friday, January 29, 2016 11:45 AM To: edk2-devel@lists.01.org Cc: Ye, Ting <ting...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; Gao, Liming <liming@intel.com> Subjec

Re: [edk2] [Patch 3/4] MdeModulePkg/Bds: Support short-form URI boot.

2016-02-24 Thread Fu, Siyuan
Hi, Ray You'd better to set the FileBuffer pointer to NULL after free it, otherwise the function will return a freed pointer if the second LoadFile() is falied. Other part is good to me. +if (FileBuffer != NULL) { + FreePool (FileBuffer); +} Reviewed-by: Fu Siyuan <siy

Re: [edk2] [PATCH] MdeModulePkg: Add HttpUtilLib

2016-02-23 Thread Fu, Siyuan
a new patch for that? Thanks Siyuan > -Original Message- > From: Samer El-Haj-Mahmoud [mailto:samer.el-haj-mahm...@hpe.com] > Sent: Friday, February 19, 2016 8:49 AM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan <siyuan...@intel.com>; Samer El-Haj-Mahmoud mahm...@h

[edk2] [Patch] MdePkg: Add definition for new warning code EFI_WARN_FILE_SYSTEM.

2016-02-23 Thread Fu Siyuan
Add the definition for the new return status code defined in UEFI 2.6. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan <siyuan...@intel.com> Cc: Liming Gao <liming@intel.com> Cc: Ye Ting <ting...@intel.com> --- MdePkg/Include/Base.

[edk2] [Patch] MdeModulePkg: Add new API HttpUrlGetPath() to HttpLib.h

2016-02-28 Thread Fu Siyuan
This patch is to add a new interface to get the "Path" component according to the URI parse result, it would be helpful for the library user to extract the file path value in a URI. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan <siyuan...@inte

Re: [edk2] [Patch] NetworkPkg: Add URI configuration form to HTTP boot driver.

2016-02-29 Thread Fu, Siyuan
You are right, I will update it. From: Wu, Jiaxin Sent: Monday, February 29, 2016 3:40 PM To: Fu, Siyuan <siyuan...@intel.com>; edk2-devel@lists.01.org Cc: Ye, Ting <ting...@intel.com> Subject: RE: [Patch] NetworkPkg: Add URI configuration form to HTTP boot driver. Siyuan, Seems

Re: [edk2] [PATCH v2] MdeModulePkg:Fix a robustness issue of Mnp Driver

2016-02-24 Thread Fu, Siyuan
Thursday, February 25, 2016 11:18 AM > To: edk2-devel@lists.01.org > Cc: Ye, Ting <ting...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; Wu, > Jiaxin <jiaxin...@intel.com> > Subject: [edk2] [PATCH v2] MdeModulePkg:Fix a robustness issue of Mnp > Driver > > v2: >

Re: [edk2] [Patch 4/6] NetworkPkg: TlsDxe driver implementation over OpenSSL

2016-02-24 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan <siyuan...@intel.com> > -Original Message- > From: Wu, Jiaxin > Sent: Wednesday, February 24, 2016 4:15 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting <ting...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; Long, > Qin <qi

Re: [edk2] [patch] MdeModulePkg:Fix a robustness issue of Mnp Driver

2016-02-22 Thread Fu, Siyuan
Hi, Lubo The VLAN 4095 is a "reserved" tag number, not invalid. I think we can directly delete the duplicate items in the variable data. Siyuan > -Original Message- > From: Zhang, Lubo > Sent: Tuesday, February 23, 2016 10:48 AM > To: edk2-devel@lists.01.org &g

Re: [edk2] [patch] NetworkPkg:Fix Network memory leak when calling GetModeData interface

2016-01-21 Thread Fu, Siyuan
: Zhang, Lubo Sent: Thursday, January 21, 2016 10:07 AM To: edk2-devel@lists.01.org Cc: Fu, Siyuan <siyuan...@intel.com>; Ye, Ting <ting...@intel.com>; Wu, Jiaxin <jiaxin...@intel.com> Subject: [patch] NetworkPkg:Fix Network memory leak when calling GetModeData interface

Re: [edk2] Help: NetworkStack requirement to generate DUID-LL(T) per own MAC address

2016-01-21 Thread Fu, Siyuan
Thanks Michael, maybe use UUID is a good way to solve this issue. But I still curious why the server has such requirement which is apparent violate the RFC requirement. Could you provide more details? Best Regards Siyuan -Original Message- From: edk2-devel

Re: [edk2] [patch] MdeModulePkg:Fix Network memory leak when calling GetModeData interface

2016-01-21 Thread Fu, Siyuan
Patch is good to me. Please also update the copyright year when commit it. Reviewed-by: Siyuan Fu <siyuan...@intel.com> -Original Message- From: Zhang, Lubo Sent: Thursday, January 21, 2016 10:11 AM To: edk2-devel@lists.01.org Cc: Fu, Siyuan <siyuan...@intel.com>; Ye

Re: [edk2] [patch] MdeModulePkg:Fix Network memory leak when calling GetModeData interface

2016-01-21 Thread Fu, Siyuan
Hi, Lubo Pls ignore my previous mail. I just checked UEFI spec, it didn't mentioned the GroupTable, RouteTable and IcmpTypeList should be freed by caller. So I think we shouldn't make this change. Siyuan -Original Message- From: Fu, Siyuan Sent: Friday, January 22, 2016 9:26 AM

  1   2   3   4   5   6   >