Re: [edk2] [PATCH] ArmPkg/CpuDxe: Disable interrupt before restoring context

2015-08-12 Thread Heyi Guo
On 08/13/2015 11:10 AM, Heyi Guo wrote: Interrupt must be disabled before we storing ELR and other system registers, or else ELR will be overridden by interrupt reentrance. This bug is critical as we may get occasional exception or dead loop when interrupt reentrance occurs: After

[edk2] [PATCH] ArmPkg/CpuDxe: Disable interrupt before restoring context

2015-08-12 Thread Heyi Guo
Or After restoring ELR The 1st circumstance could also be resolved by optimizing SP operation (Pop out registers before adding SP back), but the 2nd could not be resolved by disabling interrupt. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo heyi@linaro.org Cc

[edk2] [PATCH] ArmPkg: Bug fix for UncachedMemoryAllocationLib

2015-08-13 Thread Heyi Guo
NewNode is the node we found, while Node is the last node in the list. Also update mFreedBufferSize. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo heyi@linaro.org Cc: Leif Lindholm leif.lindh...@linaro.org Cc: Ard Biesheuvel ard.biesheu...@linaro.org

Re: [edk2] [PATCH] ArmPkg/CpuDxe: Disable interrupt before restoring context

2015-08-23 Thread Heyi Guo
On 08/17/2015 05:52 PM, Ard Biesheuvel wrote: On 13 August 2015 at 05:10, Heyi Guoheyi@linaro.org wrote: Interrupt must be disabled before we storing ELR and other system registers, or else ELR will be overridden by interrupt reentrance. This bug is critical as we may get occasional

[edk2] PXE failes with two DHCP servers in subnet

2015-10-26 Thread Heyi Guo
Hi, I'm using PXE BC protocol in MdeModulePkg (and other network protocols in the same package), and we found PXE might fail when there are two DHCP servers in the subnet, one for dedicated PXE boot and one general DHCP server. How can I resolve such issue? Thanks.

[edk2] [PATCH V2] MdePkg/ACPI: Update SPCR table definition

2015-11-09 Thread Heyi Guo
Update SPCR table definition per SPCR specification v1.03. Document link: http://msdn.microsoft.com/en-us/library/windows/hardware/dn639132(v=vs.85).aspx Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo <heyi@linaro.org> Reviewed-by: Jiewen Yao &

Re: [edk2] [PATCH] MdePkg/ACPI: Update SPCR table definition

2015-11-09 Thread Heyi Guo
[mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi Guo Sent: Monday, November 09, 2015 5:30 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D; Heyi Guo; Gao, Liming Subject: [edk2] [PATCH] MdePkg/ACPI: Update SPCR table definition Update SPCR table definition per SPCR specification v1.03

Re: [edk2] [RFC] Adaptively set serial terminal input polling interval

2015-11-09 Thread Heyi Guo
te before the rest of the information to compute a timeout is known. Are you observing an issue? Mike -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi Guo Sent: Monday, November 09, 2015 1:48 AM To: edk2-devel@lists.01.org Cc: Tian, Feng Subject: [e

Re: [edk2] [RFC] Adaptively set serial terminal input polling interval

2015-11-10 Thread Heyi Guo
this as your agreement on calculating polling rate in terminal driver? After all, really appreciate your detailed answer on this issue. Heyi Best regards, Mike -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi Guo Sent: Monday, November 09, 2015

Re: [edk2] [RFC] Adaptively set serial terminal input polling interval

2015-11-10 Thread Heyi Guo
: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi Guo Sent: Tuesday, November 10, 2015 5:27 PM To: Kinney, Michael D; edk2-devel@lists.01.org Cc: Tian, Feng Subject: Re: [edk2] [RFC] Adaptively set serial terminal input polling interval On 11/11/2015 04:34 AM, Kinney, Michael

Re: [edk2] [PATCH] MdePkg/ACPI: Update SPCR table definition

2015-11-09 Thread Heyi Guo
I also searched in edk2 code tree and didn't find any code using this structure, so no related changes are needed for this definition change. On 11/09/2015 05:29 PM, Heyi Guo wrote: Update SPCR table definition per SPCR specification v1.03. Document link: http://msdn.microsoft.com/en-us

[edk2] [PATCH] MdePkg/ACPI: Update SPCR table definition

2015-11-09 Thread Heyi Guo
Update SPCR table definition per SPCR specification v1.03. Document link: http://msdn.microsoft.com/en-us/library/windows/hardware/dn639132(v=vs.85).aspx Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo <heyi@linaro.org> Cc: Michael D Kinney <mich

[edk2] AARCH64 MMU TCR configuration questions

2015-11-09 Thread Heyi Guo
Hi All, In AARCH64 MMU configuration code, sharable attribute will be set to inner sharable when memory attribute is write back. However, I have 2 questions about this code: 1. Why is it set to inner sharable only when memory attribute is write back? Either write through or uncached will use

[edk2] [RFC] Adaptively set serial terminal input polling interval

2015-11-09 Thread Heyi Guo
Hi All, In MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf, the polling interval is fixed by macro: #define KEYBOARD_TIMER_INTERVAL 20 // 0.02s However, this may cause fast input to be truncated on some platform. For example, we have a serial console with below

Re: [edk2] [PATCH] ArmPkg: Bug fix for UncachedMemoryAllocationLib

2015-08-28 Thread Heyi Guo
Hi Ard, Would you help to commit the patch? Sorry I didn't see it upstreamed. Thanks. On 08/17/2015 06:25 PM, Ard Biesheuvel wrote: On 13 August 2015 at 16:37, Heyi Guo heyi@linaro.org wrote: NewNode is the node we found, while Node is the last node in the list. Also update

Re: [edk2] [PATCH] ArmPkg/CpuDxe: Disable interrupt before restoring context

2015-08-28 Thread Heyi Guo
, isn't it? Also, I took a look at the code of Linux kernel for ARM64 interrupt handler; it also disables IRQ before restoring context. And, thanks for your comments; I'll send another version of the patch. Heyi Guo On 08/24/2015 07:05 PM, Ard Biesheuvel wrote: On 23 August 2015 at 17:59

Re: [edk2] [PATCH 4/4] ArmPkg/Mmu: Increase PageLevel when table found at the targeted level

2015-09-07 Thread Heyi Guo
On 09/06/2015 09:42 PM, Ard Biesheuvel wrote: On 6 September 2015 at 10:15, Heyi Guo <heyi@linaro.org> wrote: Below code has bug since *BlockEntrySize and *TableLevel are not updated accordingly: if (IndexLevel == PageLevel) { // And get the appropriate BlockEntry at the next

Re: [edk2] [PATCH 1/4] ArmPkg/Mmu: Fix bug of aligning new allocated page table

2015-09-08 Thread Heyi Guo
On 09/07/2015 06:17 PM, Ard Biesheuvel wrote: On 7 September 2015 at 10:41, Heyi Guo <heyi@linaro.org> wrote: On 09/06/2015 07:43 PM, Ard Biesheuvel wrote: On 6 September 2015 at 10:15, Heyi Guo <heyi@linaro.org> wrote: The code has a simple bug on calculating aligne

[edk2] [PATCH 3/4] ArmPkg/Mmu: Fix literal number left shift bug

2015-09-06 Thread Heyi Guo
eplayed on QEMU AARCH64; by adding some debug print, we can see lots of level 1 tables created (for block of 1GB) even when the region is large enough to use 512GB block size. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo <heyi@linaro.org> Cc: Leif Lindholm

[edk2] [PATCH 2/4] ArmPkg/Mmu: Fix page level calculation bug

2015-09-06 Thread Heyi Guo
Signed-off-by: Heyi Guo <heyi@linaro.org> Cc: Leif Lindholm <leif.lindh...@linaro.org> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPkg/Library/ArmLib/AArch64/AArch64Mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ArmPkg/Library/ArmLib/AArch

[edk2] [PATCH 4/4] ArmPkg/Mmu: Increase PageLevel when table found at the targeted level

2015-09-06 Thread Heyi Guo
. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo <heyi@linaro.org> Cc: Leif Lindholm <leif.lindh...@linaro.org> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPkg/Library/ArmLib/AArch64/AArch64Mmu.c | 45 ++ 1 file chan

[edk2] [PATCH 1/4] ArmPkg/Mmu: Fix bug of aligning new allocated page table

2015-09-06 Thread Heyi Guo
The code has a simple bug on calculating aligned page table address. We need to add alignment - 1 to allocated address first and then mask the unaligned bits. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo <heyi@linaro.org> Cc: Leif Lindholm <l

[edk2] [PATCH v2 2/5] ArmPkg/Mmu: Fix page level calculation bug

2015-09-09 Thread Heyi Guo
Signed-off-by: Heyi Guo <heyi@linaro.org> Cc: Leif Lindholm <leif.lindh...@linaro.org> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPkg/Library/ArmLib/AArch64/AArch64Mmu.c | 2 +- 1 file changed, 1 insertion

[edk2] [PATCH v2 5/5] ArmPkg/Mmu: Fix potential page table memory leak

2015-09-09 Thread Heyi Guo
into the table by the same logic. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo <heyi@linaro.org> Cc: Leif Lindholm <leif.lindh...@linaro.org> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPkg/Library/ArmLib/AArch64/AArch64Mmu.c

[edk2] [PATCH v2 1/5] ArmPkg/Mmu: Fix bug of aligning new allocated page table

2015-09-09 Thread Heyi Guo
The code has a simple bug on calculating aligned page table address. We can just use AllocateAlignedPages in MemoryAllocationLib instead. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo <heyi@linaro.org> Cc: Leif Lindholm <leif.lindh...@linaro.org

[edk2] Build shell error for AARCH64

2015-09-18 Thread Heyi Guo
Hello, I got error when building shell for AARCH64: GenFw: ERROR 3000: Invalid WriteSections64(): /home/gary/git/edk2/Build/ArmVirtQemu-AARCH64/DEBUG_GCC49/AARCH64/ShellPkg/Application/Shell/Shell/DEBUG/Shell.dll AARCH64 small code model requires 4 KB section alignment. I tried removing

[edk2] BaseTools build warnings

2015-09-18 Thread Heyi Guo
Hi folks, I got below warnings when building BaseTools on Debian X86_64 with gcc (Debian 5.2.1-17) 5.2.1 20150911), can we fix it in BaseTools source code? Thanks. 1. gcc -o ../bin/VolInfo VolInfo.o -L../libs -lCommon VolInfo.o: In function `ParseSection':

Re: [edk2] BaseTools build warnings

2015-09-24 Thread Heyi Guo
Hi Yonghong or Liming, Could you help to take a look at below issue? Thanks a lot. Heyi Guo On 09/18/2015 05:13 PM, Heyi Guo wrote: Hi folks, I got below warnings when building BaseTools on Debian X86_64 with gcc (Debian 5.2.1-17) 5.2.1 20150911), can we fix it in BaseTools source code

Re: [edk2] BaseTools build warnings

2015-09-25 Thread Heyi Guo
On 09/25/2015 09:54 AM, Andrew Fish wrote: On Sep 25, 2015, at 9:37 AM, Heyi Guo <heyi@linaro.org> wrote: Hi Liming, Below is my gcc information: Are you getting warnings, but no failures? I seem to remember the C++ throws off errors for some compilers, but does not fail the

Re: [edk2] BaseTools build warnings

2015-09-25 Thread Heyi Guo
don’t reproduce it in my local. We will fix the second one first. Thanks Liming *From:*Heyi Guo [mailto:heyi@linaro.org] *Sent:* Friday, September 25, 2015 3:42 AM *To:* edk2-devel@lists.01.org; Zhu, Yonghong; Gao, Liming *Subject:* Re: [edk2] BaseTools build warnings Hi Yonghong or Liming

Re: [edk2] [PATCH] ArmPkg/CpuDxe: Disable interrupt before restoring context

2015-09-18 Thread Heyi Guo
let me know your comments. Thanks Heyi On 08/24/2015 07:05 PM, Ard Biesheuvel wrote: On 23 August 2015 at 17:59, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: On 23 August 2015 at 15:39, Heyi Guo <heyi@linaro.org> wrote: On 08/17/2015 05:52 PM, Ard Biesheuvel wrote:

[edk2] [PATCH] ArmPlatformPkg: Fix stack switch bug after commit 7945b29

2015-12-10 Thread Heyi Guo
. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo <heyi@linaro.org> Cc: Leif Lindholm <leif.lindh...@linaro.org> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPlatformPkg/PrePeiCore/PrePeiCore.c | 11 +++ 1 file changed,

Re: [edk2] [PATCH v3 2/4] ArmVirtPkg/ArmVirtPlatformLib: do not map executable NOR region as device

2015-11-18 Thread Heyi Guo
On 11/18/2015 04:25 PM, Ard Biesheuvel wrote: The ARM architecture version 7 and later mandates that device mappings have the XN (non-executable) bit set, to prevent speculative instruction fetches from read-sensitive regions. This implies that we should not map regions as device if we want to

Re: [edk2] [PATCH v3 2/4] ArmVirtPkg/ArmVirtPlatformLib: do not map executable NOR region as device

2015-11-19 Thread Heyi Guo
On 11/19/2015 01:54 PM, Ard Biesheuvel wrote: On 19 November 2015 at 00:55, Heyi Guo <heyi@linaro.org> wrote: On 11/18/2015 04:25 PM, Ard Biesheuvel wrote: The ARM architecture version 7 and later mandates that device mappings have the XN (non-executable) bit set, to prevent specu

Re: [edk2] [PATCH] ArmPkg: Flush cache after allocating UC memory

2015-11-20 Thread Heyi Guo
Hi Ard, Do we have special reason of not cleaning the allocated pages? If not having, I think it is safer to use "clean and invalidate". Thanks. Heyi On 11/20/2015 02:25 PM, Ard Biesheuvel wrote: On 20 November 2015 at 06:32, Heyi Guo <heyi@linaro.org> wrote

Re: [edk2] [PATCH] MdeModulePkg/Pxe: Fix bug of checking input FilePath

2015-11-20 Thread Heyi Guo
, for EfiPxeLoadFile function the input FilePath should always be an end device path node. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi Guo Sent: Friday, November 20, 2015 4:23 PM To: edk2-devel@lists.01.org Cc: Zhang, Lubo <lubo

[edk2] [PATCH] ArmPkg: Flush cache after allocating UC memory

2015-11-19 Thread Heyi Guo
It is implied that the memory returned from UncachedMemoryAllocationLib should have cache cleaned. So we clean and invalidate memory range after changing memory attribute to uncached. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo <heyi@linaro.org> Cc

[edk2] [PATCH] MdeModulePkg/Pxe: Fix bug of checking input FilePath

2015-11-20 Thread Heyi Guo
-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo <heyi@linaro.org> Cc: Feng Tian <feng.t...@intel.com> Cc: Zhang Lubo <lubo.zh...@intel.com> --- MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcImpl.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[edk2] [PATCH V2] ArmPkg: Invalidate cache after allocating UC memory

2015-11-22 Thread Heyi Guo
It is implied that the memory returned from UncachedMemoryAllocationLib should have cache invalidated. So we invalidate memory range after changing memory attribute to uncached. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo <heyi@linaro.org> Cc: Leif Li

Re: [edk2] [PATCH] MdeModulePkg/Pxe: Fix bug of checking input FilePath

2015-11-22 Thread Heyi Guo
- From: Heyi Guo [mailto:heyi@linaro.org] Sent: Friday, November 20, 2015 5:10 PM To: Fu, Siyuan <siyuan...@intel.com>; edk2-devel@lists.01.org Cc: Zhang, Lubo <lubo.zh...@intel.com>; Tian, Feng <feng.t...@intel.com> Subject: Re: [edk2] [PATCH] MdeModulePkg/Pxe: Fix bug of check

[edk2] [PATCH] ArmPkg/BdsLib: Send RemainingDevicePath to PXE Load File protocol

2015-11-23 Thread Heyi Guo
Load File protocol requires remaining device path rather than whole device path. For PXE, it actually requires end node device path only, or else invalid parameter will be returned directly. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo <heyi@linaro.org&

Re: [edk2] [PATCH v2] ArmPkg/ArmLib: avoid cache maintenance in PEIMs when executing in place

2016-06-14 Thread Heyi Guo
Tested-by: Heyi Guo <heyi@linaro.org> On 06/13/2016 11:26 PM, Ard Biesheuvel wrote: On some platforms, performing cache maintenance on regions that are backed by NOR flash result in SErrors. Since cache maintenance is unnecessary in that case, create a PEIM specific version tha

Re: [edk2] [PATCH v2] ArmPkg/ArmLib: avoid cache maintenance in PEIMs when executing in place

2016-06-14 Thread Heyi Guo
Hi Mark, The reason of SERR by flushing flash address is as below: 1. Flash controller and other devices except DRAM are all behind bus agents called DISP; 2. The DISPs only accept certain types of request, not including CMO; 3. When the DISPs receive requests of unsupported types, like CMO,

[edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FIFO depth with PCD

2016-03-19 Thread Heyi Guo
Set UART receive FIFO depth with PCD instead of fixed number "1". The default value of PCD is also 1, so it makes no difference for platforms which do not explicitly set this PCD. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo <heyi@linaro.org&g

[edk2] [PATCH v2 0/3] Adaptively set serial terminal polling rate

2016-03-19 Thread Heyi Guo
are to set serial terminal polling rate adaptively. Heyi Guo (3): MdePkg: Add PCD for UART default receive FIFO depth MdeModulePkg/SerialDxe: Set FIFO depth with PCD MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode .../Universal/Console/TerminalDxe/Terminal.c | 5

[edk2] [RFC 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-16 Thread Heyi Guo
delayed by other code of higher TPL, we use below equation to make polling rate fast enough: FifoDepth * DataBits * 10,000,000 * 2 / (BaudRate * 3) Signed-off-by: Heyi Guo <heyi@linaro.org> Cc: Feng Tian <feng.t...@intel.com> Cc: Star Zeng <star.z...@intel.com> --- ...

[edk2] [RFC 2/3] MdeModulePkg/SerialDxe: Set FIFO depth with PCD

2016-03-16 Thread Heyi Guo
Set UART receive FIFO depth with PCD instead of fixed number "1". The default value of PCD is also 1, so it makes no difference for platforms which do not explicitly set this PCD. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo <heyi@linaro.org&g

[edk2] [RFC 1/3] MdePkg: Add PCD for UART default receive FIFO depth

2016-03-16 Thread Heyi Guo
PcdUartDefaultReceiveFifoDepth is added to indicate UART default receive FIFO depth. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo <heyi@linaro.org> Cc: Michael D Kinney <michael.d.kin...@intel.com> Cc: Liming Gao <liming@intel.com> ---

Re: [edk2] [PATCH] EmbeddedPkg: Add GICD table init macro for ACPI 6.0

2016-04-11 Thread Heyi Guo
Hello, Any comments on this patch? Regards. Heyi On 04/07/2016 09:32 AM, Heyi Guo wrote: Add macro to help initialize GICD structure in MADT table according to ACPI 6.0. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo <heyi@linaro.org> Cc: Leif Li

Re: [edk2] [PATCH v2 1/9] MmcDxe: wait OCR busy bit free

2016-04-05 Thread Heyi Guo
On 03/22/2016 08:48 PM, Haojian Zhuang wrote: According to eMMC spec, OCR.PowerUp bit is also busy bit. If the busy bit is '0', CMD1 should be sent and OCR should be fetched again. And add a timeout counter on the repeated steps. Contributed-under: TianoCore Contribution Agreement 1.0

Re: [edk2] [RFC 1/3] MdePkg: Add PCD for UART default receive FIFO depth

2016-03-19 Thread Heyi Guo
the EFI_SERIAL_IO_MODE.ReceiveFifoDepth is of UINT32 type. But in real world, I believe UINT16 should be enough. Could you please change the PCD type to UINT16? Regards, Ray -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi Guo Sent: Wednesday

Re: [edk2] [RFC 1/3] MdePkg: Add PCD for UART default receive FIFO depth

2016-03-19 Thread Heyi Guo
the EFI_SERIAL_IO_MODE.ReceiveFifoDepth is of UINT32 type. But in real world, I believe UINT16 should be enough. Could you please change the PCD type to UINT16? Regards, Ray -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi Guo Sent: Wednesday

[edk2] [PATCH v2 1/3] MdePkg: Add PCD for UART default receive FIFO depth

2016-03-19 Thread Heyi Guo
PcdUartDefaultReceiveFifoDepth is added to indicate UART default receive FIFO depth. Type of UINT16 is enough for FIFO depth. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo <heyi@linaro.org> Cc: Michael D Kinney <michael.d.kin...@intel.com> Cc

[edk2] Is there any exiting way in edk2 to format a partition with FAT file system?

2016-03-19 Thread Heyi Guo
Hi experts, Is there any exiting way in edk2 to format a partition with FAT file system? If not, shall we implement an interface to do that? It is useful when we are using a ramdisk in UEFI, or a raw hard disk not relying on OS utilities. Thanks. Heyi

[edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-20 Thread Heyi Guo
delayed by other code of higher TPL, we use below equation to make polling rate fast enough: FifoDepth * DataBits * 10,000,000 * 2 / (BaudRate * 3) Signed-off-by: Heyi Guo <heyi@linaro.org> Cc: Feng Tian <feng.t...@intel.com> Cc: Star Zeng <star.z...@intel.com> --- ...

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FIFO depth with PCD

2016-03-23 Thread Heyi Guo
don't. So it looks like the old FIFO setting problem we discussed a few weeks ago. Thanks Laszlo Regards, Ray -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi Guo Sent: Thursday, March 17, 2016 10:37 PM To: edk2-devel@lists.

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-24 Thread Heyi Guo
for other comments below: Regards, Ray >-Original Message- >From: Heyi Guo [mailto:heyi@linaro.org] >Sent: Wednesday, March 23, 2016 5:44 PM >To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org >Cc: Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z..

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-23 Thread Heyi Guo
-devel-boun...@lists.01.org] On Behalf Of Heyi Guo Sent: Thursday, March 17, 2016 10:37 PM To: edk2-devel@lists.01.org Cc: Heyi Guo <heyi@linaro.org>; Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FIFO depth with PCD

2016-03-24 Thread Heyi Guo
On 03/24/2016 10:47 AM, Ni, Ruiyu wrote: Regards, Ray -Original Message- From: Heyi Guo [mailto:heyi@linaro.org] Sent: Thursday, March 24, 2016 9:09 AM To: Ryan Harkin <ryan.har...@linaro.org>; Laszlo Ersek <ler...@redhat.com> Cc: Ni, Ruiyu <ruiyu...@intel.c

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-28 Thread Heyi Guo
depth change in timer call back to update the interval. Regards, Ray From: Heyi Guo [mailto:heyi@linaro.org] Sent: Thursday, March 24, 2016 10:59 PM To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.co

[edk2] [PATCH] MdeModulePkg/PXE: Avoid using overloaded BootFileName or ServerName

2016-04-22 Thread Heyi Guo
BootFileName or ServerName in DHCP offer may be overloaded and cannot be used, so we manually set the strings to be null to avoid misusing. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: chenzhihui <chenzhih...@huawei.com> Signed-off-by: Heyi Guo <heyi@linar

Re: [edk2] [PATCH] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-04-28 Thread Heyi Guo
all() if it is not present. 2) I agree. Ignore time to first notification. Measure time between 2nd and 3rd notification. 3,4) I agree that setting TriggerTime to 0 makes the most sense. Mike -Original Message- From: Heyi Guo [mailto:heyi@linaro.org] Sent: Wednesday, April 27, 2016 8:21

Re: [edk2] [PATCH] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-04-28 Thread Heyi Guo
On 04/28/2016 11:17 AM, Andrew Fish wrote: On Apr 27, 2016, at 8:10 PM, Ni, Ruiyu <ruiyu...@intel.com> wrote: -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi Guo Sent: Saturday, April 23, 2016 4:54 PM To: edk2-devel@lists.01.

Re: [edk2] [PATCH] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-04-28 Thread Heyi Guo
On 04/28/2016 11:10 AM, Ni, Ruiyu wrote: -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi Guo Sent: Saturday, April 23, 2016 4:54 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Heyi Guo

Re: [edk2] [PATCH] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-04-26 Thread Heyi Guo
Hi Michael, It seems we are making the implementation more and more complicated. How about just creating a PCD for polling rate which can be set freely by platforms? Regards. Heyi On 04/24/2016 12:11 AM, Kinney, Michael D wrote: Heyi Guo, The TerminalDxe driver is intended to be a UEFI

Re: [edk2] [PATCH] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-04-27 Thread Heyi Guo
t returns the current system tick rate using UEFI services to detect it. This way, A UEFI driver can be kept simple and we move the complexity into a single new lib function. Best regards, Mike -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of H

[edk2] [PATCH] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-04-23 Thread Heyi Guo
3ms 2ms 3ms 3ms 2ms... In such case we will adjust the polling interval to be 2ms. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo <heyi@linaro.org> Cc: Feng Tian <feng.t...@intel.com> Cc: Star Zeng <star.z...@intel.com> Cc: Michael D Kin

Re: [edk2] [PATCH] MdeModulePkg/PXE: Avoid using overloaded BootFileName or ServerName

2016-04-23 Thread Heyi Guo
Sorry, it is not good to modify the original data of the packets. Please ignore this patch and I'll send out a new one. Regards. Heyi On 04/22/2016 04:32 PM, Heyi Guo wrote: BootFileName or ServerName in DHCP offer may be overloaded and cannot be used, so we manually set the strings

[edk2] [PATCH] MdeModulePkg/PXE: Ignore BootFileName if it is overloaded

2016-04-23 Thread Heyi Guo
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: chenzhihui <chenzhih...@huawei.com> Signed-off-by: Heyi Guo <heyi@linaro.org> Cc: Feng Tian <feng.t...@intel.com> Cc: Star Zeng <star.z...@intel.com> Cc: Siyuan Fu <siyuan...@intel.com> Cc:

[edk2] [PATCH] ArmPkg: Fix XN attribute for device memory

2016-04-14 Thread Heyi Guo
*XN_MASK instead. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo <heyi@linaro.org> Cc: Leif Lindholm <leif.lindh...@linaro.org> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPkg/Library/ArmLib/AArch64/AArch64Mmu.c | 4 ++-- 1 file changed,

Re: [edk2] Why is USB_BOOT_IO_BLOCKS set to 128?

2017-01-17 Thread Heyi Guo
orge.net/svnroot/edk2/trunk/edk2@4038 6f19259b-4bc3-4df7-8a09-765794883524 Thanks and regards, Heyi 在 10/19/2016 10:10 AM, Tian, Feng 写道: It's just an experience value and has been here about 10 years... Which usb brand/model name do you have problem on? Thanks Feng -Original Message

Re: [edk2] Why is USB_BOOT_IO_BLOCKS set to 128?

2017-01-18 Thread Heyi Guo
, please tell me the device model/serial no, then we can modify this value accordingly. Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi Guo Sent: Wednesday, January 18, 2017 2:41 PM To: Tian, Feng <feng.t...@intel.com>; edk2

Re: [edk2] Why is USB_BOOT_IO_BLOCKS set to 128?

2016-10-19 Thread Heyi Guo
It is a BMC virtual USB channel for BMC KVM. 在 10/19/2016 10:10 AM, Tian, Feng 写道: It's just an experience value and has been here about 10 years... Which usb brand/model name do you have problem on? Thanks Feng -Original Message- From: Heyi Guo [mailto:heyi@linaro.org] Sent

[edk2] Why is USB_BOOT_IO_BLOCKS set to 128?

2016-10-18 Thread Heyi Guo
Dear experts, Could anyone help to explain why USB_BOOT_IO_BLOCKS in MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.h is set to 128? We found on some platforms this value may cause USB boot failure and *64* blocks will make them work. Though we have not got the final root cause, it will

[edk2] Which revision of PXE spec does EDK2 code conform to?

2016-11-29 Thread Heyi Guo
Hi folks, Which revision of PXE spec does EDK2 code conform to? Is it PXE v2.1? Do PXE implementations in MdeModulePkg and NetworkPkg comform to the same revision? Thanks and regards, Heyi ___ edk2-devel mailing list edk2-devel@lists.01.org

Re: [edk2] [PATCH 0/4] Fix GCC build warnings for BaseTools

2016-12-15 Thread Heyi Guo
will look it. ../support/set/set.c:557:2: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘size_t’ [-Wformat=] Thanks Liming -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi Guo Sent: Thursday, December 15, 2016 2:50

Re: [edk2] Which revision of PXE spec does EDK2 code conform to?

2016-12-13 Thread Heyi Guo
E 2.1 specification wire protocol clarifications" of the UEFI 2.6 specification. For IPV6 PXE-style TFTP boot the wire protocol is found wholly in the UEFI 2.6 specification. Vincent -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi Guo Sen

[edk2] [PATCH 4/4] BaseTools: fix unused-result build warnings

2016-12-14 Thread Heyi Guo
bution Agreement 1.0 Signed-off-by: Heyi Guo <heyi@linaro.org> Cc: Yonghong Zhu <yonghong@intel.com> Cc: Liming Gao <liming@intel.com> --- BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/BaseTools/So

[edk2] [PATCH 1/4] BaseTools: fix format-security build warnings

2016-12-14 Thread Heyi Guo
Fix build warnings of "format not a string literal and no format arguments [-Wformat-security]" for BaseTools, while using "gcc version 4.8.4 (Ubuntu 4.8.4-2ubuntu1~14.04.3)". Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo <heyi@linar

[edk2] [PATCH 2/4] BaseTools: fix format type build warnings

2016-12-14 Thread Heyi Guo
Fix build warnings of "format ‘%d’ expects argument of type ‘int’, but argument 5 has type ‘long unsigned int’ [-Wformat=]" for BaseTools, while using "gcc version 4.8.4 (Ubuntu 4.8.4-2ubuntu1~14.04.3)". Contributed-under: TianoCore Contribution Agreement 1.0 Signed-of

[edk2] [PATCH 0/4] Fix GCC build warnings for BaseTools

2016-12-14 Thread Heyi Guo
c:557:2: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘size_t’ [-Wformat=] Heyi Guo (4): BaseTools: fix format-security build warnings BaseTools: fix format type build warnings BaseTools: fix write-strings build warnings BaseTools: fix unused-result build warni

Re: [edk2] [PATCH 0/6] Refine code logics to prevent possible mis-reports by static code checkers

2016-12-17 Thread Heyi Guo
Hi Hao, May I ask which static code checkers you are using? We are using Coverity and Fortify checkers, and there are hundreds of warnings reported. Do you have a plan to analyze and fix (some may be not real errors) the warnings from these two checkers? Thanks and regards, Heyi 在

Re: [edk2] MdeModulePkg/SerialDxe: Inconsistent timeout processing in SerialRead

2017-08-04 Thread Heyi Guo
No problem at all and thanks a lot for fixing the issue :) Gary (Heyi Guo) 在 8/4/2017 4:05 PM, Zeng, Star 写道: Oh, sorry, I forgot it because of busying on other things. I will post it soon. Thanks for your reminder. Star -Original Message- From: Heyi Guo [mailto:heyi@linaro.org

Re: [edk2] MdeModulePkg/SerialDxe: Inconsistent timeout processing in SerialRead

2017-08-04 Thread Heyi Guo
Hi Star, The patch works well on our platform. Would you merge it to EDK2 main stream or do you like me to post it to the mailing-list? Thanks and regards, Gary (Heyi Guo) 在 7/18/2017 6:59 PM, Heyi Guo 写道: Hi Star, I think your proposed patch is fine. Thanks. Gary (Heyi Guo) 在 7/18

Re: [edk2] MdeModulePkg/SerialDxe: Inconsistent timeout processing in SerialRead

2017-07-18 Thread Heyi Guo
+cc maintainers :) 在 7/17/2017 12:23 PM, Heyi Guo 写道: Hi Folks, In SerialRead function in MdeModulePkg/Universal/SerialDxe/SerialIo.c, it seems the timeout processing in SerialRead is not consistent. Since SerialPortPoll only checks the status of serial port and returns immediately

Re: [edk2] MdeModulePkg/SerialDxe: Inconsistent timeout processing in SerialRead

2017-07-18 Thread Heyi Guo
Hi Star, I think your proposed patch is fine. Thanks. Gary (Heyi Guo) 在 7/18/2017 4:39 PM, Zeng, Star 写道: Gary, SerialDxe is a wrapper of SerialPortLib to produce serial io protocol. If let SerialDxe to handle the TimeOut, seemingly it can only check SerialPortPoll() and read data

[edk2] MdeModulePkg/SerialDxe: Inconsistent timeout processing in SerialRead

2017-07-16 Thread Heyi Guo
input is coming and timeout will not really occur. As SerialPortLib is a simple library implementation, I think it is better to improve SerialIoDxe driver instead of SerialPortLib. Please let me know your comments about this. Thanks and regards, Gary (Heyi Guo) EFI_STATUS EFIAPI SerialRead

Re: [edk2] How can we identify an ISO file is an EFI bootable ISO image?

2017-06-20 Thread Heyi Guo
Thank you so much. I will try that :) Regards, Gary (Heyi Guo) 在 6/21/2017 12:47 AM, Laszlo Ersek 写道: On 06/20/17 14:34, Heyi Guo wrote: Is there any simple tool to parse ISO images (El Torito partition) and identify whether it is EFI bootable? $ dumpet --iso Fedora-Server-dvd-aarch64-25

[edk2] How can we identify an ISO file is an EFI bootable ISO image?

2017-06-20 Thread Heyi Guo
that? And is there any guide to create an EFI bootable El Torito ISO image? Thanks and regards, Gary (Heyi Guo) ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH edk2-platforms v3 11/11] Hisilicon D03/D05: Enlarge iATU for RP with ARI capable device.

2017-09-21 Thread Heyi Guo
From: Ming Huang 1. Because Hi161x chip doesn't support "ARI Forwarding Enable" function, BIOS will enumerate 32 same devices (Device Number 0~31) when attach a Non-ARI capable device in the RP. Hi161x chip will not fix it, need BIOS patch. 2. Just enlarge iatu for

[edk2] [PATCH edk2-platforms v3 10/11] D05/ACPI: Modify I2C device

2017-09-21 Thread Heyi Guo
From: Ming Huang 1. Disable I2C0 device avoiding access conflict in OS; 2. Modify _HID of I2C2 for matching the string in OS driver; Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang ---

[edk2] [PATCH edk2-platforms v3 04/11] Hisilicon D03/D05: get firmware version from FIRMWARE_VER

2017-09-21 Thread Heyi Guo
From: Ming Huang Value of the environment variable FIRMWARE_VER is GIT SHA by default, and you can add the environment variable FIRMWARE_VER to EXTRA_OPTIONS at build time to specify something else, eg. "16.12-". Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH edk2-platforms v3 08/11] Hisilicon/D03: Disable the function of PerfTuning

2017-09-21 Thread Heyi Guo
From: Chenhui Sun The PerTuning function is not stable, it will cause the 3008/3108 crash, disable this function first. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chenhui Sun --- Platform/Hisilicon/D03/D03.dsc | 2 +-

[edk2] [PATCH edk2-non-osi v3 6/7] Hisilicon/D05: Update binary file

2017-09-21 Thread Heyi Guo
Fix bug 3061: D05(before EC) boot hangs at "Need Reset"; Update binary file for edk2 upgrade. 1. Replace UncachedMemoryAllocationLib with DmaLib; 2. Remove ArmCpuLib dependenc; 3. Remove ConvertToPhysicalAddress; Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming

[edk2] [PATCH edk2-platforms v3 09/11] D05/ACPI: Disable D05 SAS0 and SAS2

2017-09-21 Thread Heyi Guo
From: Ming Huang There are no interface from SAS0 and SAS2 controller on D05, so SAS0 and SAS2 can't be use. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Sas.asl

[edk2] [PATCH edk2-non-osi v3 7/7] Hisilicon: Fix the drivers use the same GUID issue

2017-09-21 Thread Heyi Guo
The drivers build from separate sources, their GUID should be different. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Heyi Guo <heyi@linaro.org> Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> --- Platform/Hisilicon/D02/Drivers/Net/SnpPV600Dxe/Snp

[edk2] [PATCH edk2-platforms v3 06/11] Hisilicon/D05/Pcie: fix bug of size definition

2017-09-21 Thread Heyi Guo
From: huangming Fix bug of PcieRegion size definition and IO size definition. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D05/D05.dsc | 64 ++-- 1 file changed, 32

[edk2] [PATCH edk2-platforms v3 03/11] Hisilicon: Fix the drivers use the same GUID issue

2017-09-21 Thread Heyi Guo
The drivers build from separate sources, their GUID should be different. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Heyi Guo <heyi@linaro.org> Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> --- Platform/Hisilicon/D02/EarlyConfigPeim/EarlyCo

[edk2] [PATCH edk2-platforms v3 07/11] D05/PCIe: Modify PcieRegionBase of secondary chip

2017-09-21 Thread Heyi Guo
From: huangming On D05 PCIe now, 2p NA PCIe2 and 2p NB PCIe0's pci domain addresses are 0x2000 and 0x3000 based. These addresses overlap with the DDR memory range 0-1G. In this situation, on the inbound direction, our pcie will drop the DDR address access that are

[edk2] [PATCH edk2-platforms v3 02/11] Hisilicon/D03: Modify dsc and fdf file

2017-09-21 Thread Heyi Guo
1. Add Drivers/SasPlatform; 2. Add Drivers/Net/SnpPlatform; Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D03/D03.dsc | 5 - Platform/Hisilicon/D03/D03.fdf | 5 - 2 files changed, 4 insertions(+), 6

  1   2   3   4   >