Re: [edk2] Library refinement: OptionRomPkg/BltLib

2015-08-13 Thread Jordan Justen
Did you get a chance to review the commit message on caebd915 / r11520? On 2015-08-09 20:09:54, Ni, Ruiyu wrote: Jordan and Laszlo, I reviewed the OptionRomPkg/BltLib again and would like to discuss with you about the potential API refinement. I attached two versions of the

Re: [edk2] [Patch 6/8] OptionRomPkg/OvmfPkg: Remove BltLib::BltConfigure API

2015-08-17 Thread Jordan Justen
some other questions: http://article.gmane.org/gmane.comp.bios.edk2.devel/1209 -Jordan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni ruiyu...@intel.com Cc: Laszlo Ersek ler...@redhat.com Cc: Jordan Justen jordan.l.jus...@intel.com --- .../Application

Re: [edk2] [PATCH v2 00/16] unify GCC command line options

2015-08-17 Thread Jordan Justen
On 2015-08-17 07:24:57, Ard Biesheuvel wrote: This got a bit out of hand after I noticed the ELFGCC and UNIXGCC toolchains that needed some tlc as well. Anyway, this series aims to refactor the toolchains definitions for UNIXGCC, GCC44, GCC45, GCC46, GCC47, GCC48, GCC49, CLANG35, ELFGCC,

Re: [edk2] [Patch 6/8] OptionRomPkg/OvmfPkg: Remove BltLib::BltConfigure API

2015-08-23 Thread Jordan Justen
-by: Ruiyu Ni ruiyu...@intel.com Cc: Laszlo Ersek ler...@redhat.com Cc: Jordan Justen jordan.l.jus...@intel.com ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 00/16] unify GCC command line options

2015-08-18 Thread Jordan Justen
On 2015-08-18 03:57:51, Ard Biesheuvel wrote: On 17 August 2015 at 20:53, Jordan Justen jordan.l.jus...@intel.com wrote: On 2015-08-17 11:25:56, Ard Biesheuvel wrote: MinGW generates PE/COFF not ELF, so much of the linker command line is different, and it really deserves a toolchain of its

Re: [edk2] [PATCH v2 00/16] unify GCC command line options

2015-08-18 Thread Jordan Justen
On 2015-08-18 04:01:36, Ard Biesheuvel wrote: On 17 August 2015 at 21:16, David Woodhouse dw...@infradead.org wrote: On 2015-08-17 11:25:41, David Woodhouse wrote: On Mon, 2015-08-17 at 11:22 -0700, Jordan Justen wrote: Can't you use an elf-based GCC4.9 with the GCC49 toolchain instead

Re: [edk2] [PATCH v2 00/16] unify GCC command line options

2015-08-17 Thread Jordan Justen
On 2015-08-17 11:10:57, Bill Paul wrote: Of all the gin joints in all the towns in all the world, David Woodhouse had to walk into mine at 11:00:23 on Monday 17 August 2015 and say: On Mon, 2015-08-17 at 10:53 -0700, Jordan Justen wrote: UNIXGCC and CYGGCC are GCC 4.3 mingw based. Did

Re: [edk2] [PATCH v2 00/16] unify GCC command line options

2015-08-17 Thread Jordan Justen
On 2015-08-17 11:25:56, Ard Biesheuvel wrote: On 17 August 2015 at 20:22, Jordan Justen jordan.l.jus...@intel.com wrote: Can't you use an elf-based GCC4.9 with the GCC49 toolchain instead? I'm not sure it makes sense to 'upgrade' the UNIXGCC toolchain to be based on GCC 4.9 rather than

Re: [edk2] [PATCH v2 00/16] unify GCC command line options

2015-08-17 Thread Jordan Justen
On 2015-08-17 11:25:41, David Woodhouse wrote: On Mon, 2015-08-17 at 11:22 -0700, Jordan Justen wrote: Can't you use an elf-based GCC4.9 with the GCC49 toolchain instead? Not for testing LLP64, no. How/who is this helping? I'm not sure it makes sense to 'upgrade' the UNIXGCC toolchain

Re: [edk2] [Patch 6/8] OptionRomPkg/OvmfPkg: Remove BltLib::BltConfigure API

2015-08-23 Thread Jordan Justen
to the GOP protocol and call the protocol Blt function. EFI_STATUS EFIAPI BltFreeConfiguration ( IN EFI_HANDLE Configuration ); On 2015/8/24 6:28, Jordan Justen wrote: Previously you said to Laszlo in regard to keeping the BltLibVideoFill function: The reason I wanted to use the four

Re: [edk2] [PATCH] EmbeddedPkg: Added Marvell Yukon Ethernet support

2015-07-29 Thread Jordan Justen
On 2015-07-28 10:51:38, Leif Lindholm wrote: Hi Jordan, Sorry, (metaphorically) snowed under for a few days. On Fri, Jul 17, 2015 at 02:44:10PM -0700, Jordan Justen wrote: Does this depend on ArmPkg / EmbeddedPkg, or is this just a generic PCI based driver? It could be nice

Re: [edk2] [PATCH v3 09/12] ArmPlatformPkg/ArmVExpressPkg: move to unified GCC linker script

2015-07-29 Thread Jordan Justen
On 2015-07-29 08:11:59, Ard Biesheuvel wrote: Move to the parametrised generic GCC linker script and set 64 KB alignment, instead of using the AARCH64 specific incremental linker script for 64 KB alignment which is about to be removed. Contributed-under: TianoCore Contribution Agreement 1.0

Re: [edk2] [PATCH v3 12/12] BaseTools/X86|IA32: move to unified GCC linker script

2015-07-29 Thread Jordan Justen
-script and gcc4.9-ld-script. With that change, the series is Reviewed-by: Jordan Justen jordan.l.jus...@intel.com although, I would like someone to test the changes on a '4k' aligned image build. Liming, do you know who might be able to do that? -Jordan On 2015-07-29 08:12:02, Ard Biesheuvel

Re: [edk2] posting to the new list without subscription?

2015-07-29 Thread Jordan Justen
On 2015-07-28 12:59:46, Laszlo Ersek wrote: Hi Jordan, what are the rules for posting to the new list without being subscribed? On the old list, I think we dropped all such emails. Currently we are rejecting them on the new list. Paolo posted a few absolutely great comments recently, and

Re: [edk2] efi acpidump port

2015-07-29 Thread Jordan Justen
On 2015-07-29 16:27:38, Andrew Fish wrote: On Jul 29, 2015, at 4:11 PM, Jordan Justen jordan.l.jus...@intel.com wrote: On 2015-07-29 13:43:43, Smith, Jonathan D wrote: Attaching a zip of the files -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org

Re: [edk2] efi acpidump port

2015-07-29 Thread Jordan Justen
On 2015-07-29 13:43:43, Smith, Jonathan D wrote: Attaching a zip of the files -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Smith, Jonathan D Sent: Wednesday, July 29, 2015 1:37 PM To: 'Andrew Fish'; 'edk2-devel@lists.01.org' Subject:

Re: [edk2] BaseTools features: multiple workspaces

2015-08-03 Thread Jordan Justen
On 2015-08-03 14:32:15, Andrew Fish wrote: On Aug 3, 2015, at 2:04 PM, Jordan Justen jordan.l.jus...@intel.com wrote: On 2015-08-03 12:58:28, Kinney, Michael D wrote: Jordan, If we make a slight change to the requirements, we can provide clear priority rules. WORKSPACE

Re: [edk2] [PATCH] EmbeddedPkg: Added Marvell Yukon Ethernet support

2015-07-30 Thread Jordan Justen
Marvell Yukon Ethernet support Hi Jordan, On Wed, Jul 29, 2015 at 02:59:04PM -0700, Jordan Justen wrote: But, the name 'open platform' also sounds strange, assuming this a plain PCI bus driver. Couldn't it live in a 'pci drivers' package? Personally, I think we should rename

Re: [edk2] [PATCH] EmbeddedPkg: Added Marvell Yukon Ethernet support

2015-07-30 Thread Jordan Justen
.org] On Behalf Of Jordan Justen Sent: Friday, July 31, 2015 6:17 AM To: Kinney, Michael D; Leif Lindholm; Kinney, Michael D Cc: edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH] EmbeddedPkg: Added Marvell Yukon Ethernet support On 2015-07-30 11:51:56, Kinney, Michael D wrote: Jordan

Re: [edk2] [PATCH 17/58] OvmfPkg: import PiSmmCpuDxeSmm from Quark_EDKII_v1.1.0/IA32FamilyCpuBasePkg

2015-07-28 Thread Jordan Justen
Note: Cc: edk2-devel Mike, Can you *please* help out with this?? We've been discussing this since April... 1. Why should we import all this code under the OVMF platform? 2. Why should we have a different license from the rest of EDK II if this is all Intel code? Last time we talked about

Re: [edk2] [PATCH v2 1/7] BaseTools: add unified GCC linker script for all archs and versions

2015-07-28 Thread Jordan Justen
On 2015-07-24 05:08:34, Ard Biesheuvel wrote: This unifies all GCC linker scripts into a single parametrised GCC linker script that can be used for all GCC versions and architectures. The two parameters that can be set on the linker command line are: - PECOFF_HEADER_SIZE, this is a build

Re: [edk2] [PATCH v2 7/7] BaseTools/X86|IA32: move to unified GCC linker script

2015-07-28 Thread Jordan Justen
On 2015-07-24 05:08:40, Ard Biesheuvel wrote: Drop the GCC 4.4/X86 and 4.9/X86 specific linker scripts and use the new unified one instead. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ard.biesheu...@linaro.org --- BaseTools/Conf/tools_def.template

Re: [edk2] BaseTools features: multiple workspaces

2015-08-05 Thread Jordan Justen
workspaces On 08/03/15 19:35, Jordan Justen wrote: On 2015-08-03 02:08:14, Gao, Liming wrote: Paolo: I think that keep the exiting syntax for WORKSPACE to be a single path can minimize the impacts to exiting tools that assume a single workspace. I know you originally

Re: [edk2] BaseTools features: multiple workspaces

2015-08-05 Thread Jordan Justen
On 2015-08-05 12:19:47, Andrew Fish wrote: On Aug 5, 2015, at 12:09 PM, Jordan Justen jordan.l.jus...@intel.com wrote: On 2015-08-05 07:06:46, Gao, Liming wrote: Thanks for your all comments. Most people prefers to keep WOSKAPCE as single directory, and introduce new env

Re: [edk2] BaseTools features: multiple workspaces

2015-08-05 Thread Jordan Justen
On 2015-08-05 13:21:37, Andrew Fish wrote: On Aug 5, 2015, at 12:16 PM, Jordan Justen jordan.l.jus...@intel.com wrote: On 2015-08-05 07:06:46, Gao, Liming wrote: Tim gave another idea to define multiple source locations in Platform DSC file. It doesn't conflict with this proposal. We

Re: [edk2] BaseTools features: multiple workspaces

2015-08-03 Thread Jordan Justen
directories, or we add WORKSPACE_MULTIPLE, it will not make a big difference to these tools. -Jordan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jordan Justen Sent: Monday, August 03, 2015 10:36 AM To: Gao, Liming liming@intel.com

Re: [edk2] BaseTools features: multiple workspaces

2015-08-03 Thread Jordan Justen
On 2015-08-03 02:08:14, Gao, Liming wrote: Paolo: I think that keep the exiting syntax for WORKSPACE to be a single path can minimize the impacts to exiting tools that assume a single workspace. I know you originally suggested to use WORKSPACE, but got some feedback that it might be

Re: [edk2] more code sharing joy between OvmfPkg and ArmVirtPkg, re SMBIOS

2015-07-30 Thread Jordan Justen
On 2015-07-30 10:09:34, Laszlo Ersek wrote: (Sigh, I left off the list address. This should be discussed publicly. Resending.) Clearly, the SMBIOS patches I posted and got committed last time are not good enough. That's because the SMBIOS 3.0 entry point is structurally different from the

Re: [edk2] [PATCH v2 1/7] BaseTools: add unified GCC linker script for all archs and versions

2015-07-28 Thread Jordan Justen
On 2015-07-28 12:37:31, Ard Biesheuvel wrote: On 28 July 2015 at 20:48, Jordan Justen jordan.l.jus...@intel.com wrote: On 2015-07-24 05:08:34, Ard Biesheuvel wrote: This unifies all GCC linker scripts into a single parametrised GCC linker script that can be used for all GCC versions

Re: [edk2] [PATCH] OvmfPkg: PlatformDebugLibIoPort: fix AsciiSPrint() format string

2015-08-06 Thread Jordan Justen
Reviewed-by: Jordan Justen jordan.l.jus...@intel.com On 2015-08-05 09:32:17, Laszlo Ersek wrote: The LineNumber parameter of the DebugAssert() function has type UINTN. DebugAssert() passes it to AsciiSPrint() with the %d conversion specifier at the moment, but %d would require an INT32

Re: [edk2] [PATCH v3 7/7] BaseTools: add support for CLANG compiler to GCC family

2015-08-07 Thread Jordan Justen
I think the subject should say 'Add CLANG toolchain with AARCH64 support' to highlight that a new toolchain name is being defined. Should we consider adding the version to the toolchain name, like CLANG37? Then we can change parameters between major releases. At least for GCC it has proved

Re: [edk2] [PATCH v3 7/7] BaseTools: add support for CLANG compiler to GCC family

2015-08-07 Thread Jordan Justen
On 2015-08-07 07:59:24, Ard Biesheuvel wrote: On 7 August 2015 at 16:51, Jordan Justen jordan.l.jus...@intel.com wrote: I think the subject should say 'Add CLANG toolchain with AARCH64 support' to highlight that a new toolchain name is being defined. OK. I can fix that up before applying

Re: [edk2] [PATCH 0/9] OvmfPkg, ArmVirtPkg: SMBIOS 3.0, round 2

2015-08-05 Thread Jordan Justen
Series Reviewed-by: Jordan Justen jordan.l.jus...@intel.com On 2015-07-31 11:40:52, Laszlo Ersek wrote: The SMBIOS 3.x entry point is structurally different from the 2.x variant, therefore the current code used by OvmfPkg and ArmVirtPkg doesn't recognize an SMBIOS 3.0 entry point structure

Re: [edk2] [PATCH v2] MdeModulePkg:Add ESC key support in setup browser pop-up message box

2015-07-27 Thread Jordan Justen
On 2015-07-26 23:57:27, Bi, Dandan wrote: .../Universal/DisplayEngineDxe/FormDisplay.c| 3 ++- .../Universal/DisplayEngineDxe/FormDisplayStr.uni | Bin 17032 - 17056 bytes What about making 2 patches? The first patch can convert FormDisplayStr.uni to UTF-8 without changing

Re: [edk2] [PATCH 0/7] Add missing PCD usage information in UNI and DEC files.

2015-07-27 Thread Jordan Justen
On 2015-07-21 05:50:25, Qiu Shumin wrote: When PCD defined in DEC file, PCD Help/Prompt information must be provided. PCD Help and Prompt string is required in Package DEC and Package UNI file. PCD Valid Range is optional. If specified, its format should be valid. Qiu Shumin (7): MdePkg:

Re: [edk2] [PATCH] OvmfPkg: fix conversion specifiers in DEBUG format strings

2015-07-27 Thread Jordan Justen
On 2015-07-27 20:18:18, Scott Duplichan wrote: Laszlo Ersek [mailto:ler...@redhat.com] wrote: ]Sent: Monday, July 27, 2015 05:50 PM ]To: edk2-de...@ml01.01.org ]Cc: Jordan Justen jordan.l.jus...@intel.com; Scott Duplichan sc...@notabs.org ]Subject: [edk2] [PATCH] OvmfPkg: fix conversion

Re: [edk2] [PATCH 1/6] BaseTools: add unified GCC linker script for all archs and versions

2015-07-22 Thread Jordan Justen
On 2015-07-22 06:56:45, Ard Biesheuvel wrote: After two recent changes have been applied to the ELF conversion routines in GenFw, i.e., PE/COFF section alignment based on ELF section alignment (54b1b57a59b5 BaseTools: Update GenFw to support 4K alignment), and removal of the debug section

Re: [edk2] TianoCore Subversion down?

2015-07-22 Thread Jordan Justen
On 2015-07-22 12:57:13, Laszlo Ersek wrote: On 07/22/15 21:44, Bruce Cran wrote: On 7/22/2015 4:18 AM, Laszlo Ersek wrote: How about someone creates a temporary branch off the github master branch, and applies all new patches from the list that have been reviewed thus far? Then once SVN

Re: [edk2] Is source repositories svn address changed?

2015-07-24 Thread Jordan Justen
On 2015-07-23 23:14:17, winddy wrote: Dear Experts, Rcently, I find udk open source SVN cannot be accessed. (https://svn.code.sf.net/p/edk2/code/trunk/edk2) The reason for this is that sourceforge svn servers have been offline for over a week now.

Re: [edk2] Temporary git repo - Re: TianoCore Subversion down?

2015-07-26 Thread Jordan Justen
On 2015-07-24 05:00:58, Laszlo Ersek wrote: On 07/24/15 11:37, Zeng, Star wrote: I just pulled the edk2-svn-offline code and took a look. And I found Jordan had a commit for the attached patch which has been committed in SVN at 18031 and I also have git-svn r18031 in local. Is it still

Re: [edk2] TianoCore Subversion down?

2015-07-26 Thread Jordan Justen
On 2015-07-25 19:59:10, Bruce Cran wrote: On 7/24/15 5:40 PM, Jordan Justen wrote: Unfortunately, it looks like they are going to manage to get svn back up and running. ;) It looks like it's back: http://sourceforge.net/blog/sourceforge-subversion-svn-service-online/ SourceForge

[edk2] Fwd: edk2[18072] Fixed OS software shutdown when reporting actual processor temperature

2015-07-27 Thread Jordan Justen
Should this be included on master too? (Not just the UDK branch) For future patches: Could it be posted to edk2-devel for code review? How about including the package name in the first line of the commit message? https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format

Re: [edk2] [PATCH v2] MdeModulePkg:Add ESC key support in setup browser pop-up message box

2015-07-27 Thread Jordan Justen
On 2015-07-26 22:19:04, Dandan Bi wrote: When load default value or save changes will pop up message box to let user confirm,Y means confirm and N means ignore,now add Esc key with the same function of N key.And change the context of pop up message in .uni file, now will display Press 'Y' to

Re: [edk2] [PATCH 2/6] OvmfPkg: SmbiosPlatformDxe: restrict current Xen code to IA32/X64

2015-07-21 Thread Jordan Justen
On 2015-07-21 02:40:33, Laszlo Ersek wrote: On 07/21/15 06:18, Jordan Justen wrote: On 2015-07-17 04:11:46, Laszlo Ersek wrote: Guys, let's wrap this up. Just tell me what you want to see. I don't care any longer about the specifics. It's incredible that I can't submit a trivial code

Re: [edk2] [PATCH v2 1/6] OvmfPkg: SmbiosPlatformDxe: move IsEntryPointStructureValid() to Xen.c

2015-07-21 Thread Jordan Justen
1-3 Reviewed-by: Jordan Justen jordan.l.jus...@intel.com On 2015-07-21 04:10:10, Laszlo Ersek wrote: This function is only called from Xen.c, so it should be defined in Xen.c and have internal linkage (ie. STATIC). Cc: Jordan Justen jordan.l.jus...@intel.com Cc: Wei Liu wei.l...@citrix.com

Re: [edk2] TianoCore Subversion down?

2015-07-24 Thread Jordan Justen
On 2015-07-19 09:56:11, Jordan Justen wrote: On 2015-07-19 04:08:50, Laszlo Ersek wrote: On 07/19/15 12:01, Ard Biesheuvel wrote: I'd suggest that we just promote the GitHub repository to primary repository, and deprecate the public SVN right away. I don't think this would

Re: [edk2] [Patch] MdeModulePkg: Make boot option description unique

2015-07-24 Thread Jordan Justen
On 2015-07-24 09:37:49, Laszlo Ersek wrote: Jordan, On 07/24/15 06:37, Dong, Eric wrote: Reviewed-by: Eric Dong eric.d...@intel.com -Original Message- From: Ni, Ruiyu Sent: Thursday, July 23, 2015 5:15 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Dong, Eric Subject:

Re: [edk2] [PATCH] IntelFrameworkModulePkg: GenericBdsLib: set Status before use

2015-07-24 Thread Jordan Justen
On 2015-07-24 09:39:34, Laszlo Ersek wrote: Jordan, On 07/24/15 14:41, Fan, Jeff wrote: Reviewed-by: Jeff Fan jeff@intel.com -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, July 24, 2015 7:36 AM To: edk2-de...@ml01.01.org Cc: Yao,

Re: [edk2] Temporary git repo - Re: TianoCore Subversion down?

2015-07-23 Thread Jordan Justen
On 2015-07-23 10:04:26, Laszlo Ersek wrote: On 07/23/15 02:06, Jordan Justen wrote: Okay. Based on Laszlo's request, I setup a temporary git repo to collect up the changes that should have been committed to svn the past week. https://github.com/tianocore/edk2-svn-offline So far, I

Re: [edk2] Temporary git repo - Re: TianoCore Subversion down?

2015-07-23 Thread Jordan Justen
I queued up the patches you collected: https://github.com/tianocore/edk2-svn-offline/commits/master Thanks again for collecting them up! -Jordan On 2015-07-23 10:50:14, Laszlo Ersek wrote: On 07/23/15 19:31, Jordan Justen wrote: On 2015-07-23 10:04:26, Laszlo Ersek wrote: On 07/23/15 02

Re: [edk2] Enable optimization for gcc x64 builds

2015-07-23 Thread Jordan Justen
(I changed the Cc to the 01.org list.) On 2015-07-23 02:46:15, David Woodhouse wrote: On Tue, 2014-11-04 at 14:32 -0800, Jordan Justen wrote: On Tue, Nov 4, 2014 at 9:28 AM, Andrew Fish af...@apple.com wrote: Problems with the mixed calling convention: 1) All assembly routines must

[edk2] [PATCH] Maintainers.txt: Add Daryl's new email address

2015-07-23 Thread Jordan Justen
Cc: Daryl McDaniel edk2-li...@mc2research.org Cc: Jaben Carsey jaben.car...@intel.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- Maintainers.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Maintainers.txt b

Re: [edk2] [PATCH] StdLib: Do not define memcpy for AARCH64 builds

2015-07-24 Thread Jordan Justen
On 2015-07-24 16:15:57, Daryl McDaniel wrote: Reviewed by: Daryl McDaniel edk2-li...@mc2research.org I added Daryl's Reviewed-by and added the patch to the svn-offline branch: https://github.com/tianocore/edk2-svn-offline master -Jordan -Original Message- From: edk2-devel

Re: [edk2] [PATCH]: CorebootPayloadPkg: Remove data alignment restriction to support GCC49

2015-07-17 Thread Jordan Justen
to IMAGE_ERROR_INVALID_SECTION_ALIGNMENT and returns an error. This change removes the restriction. Testing with __attribute__((aligned ())) passes for data alignments of up to 256 bytes. I think I prefer Ray's commit message in r17902. Nevertheless, Reviewed-by: Jordan Justen jordan.l.jus...@intel.com Contributed-under

Re: [edk2] [PATCH] EmbeddedPkg: Added Marvell Yukon Ethernet support

2015-07-17 Thread Jordan Justen
On 2015-07-17 07:43:09, Leif Lindholm wrote: On Thu, Jul 16, 2015 at 10:22:02AM -0700, Jordan Justen wrote: On 2015-07-16 09:11:38, Olivier Martin wrote: This change adds support for the PCI Marvell Yukon Ethernet controller. This ethernet controller can be found on the ARM Juno

Re: [edk2] Boot fail with gcc 4.9

2015-07-17 Thread Jordan Justen
There are recent related BaseTools commits: edd7249/r18016 BaseTools: Fixed incorrect alignment bug. 0c5645e/r17728 BaseTools: Update GenFw to support 4K alignment. f384efd/r17727 BaseTools: Updated tool_def to support 4K alignment. These were make for 4k alignment support, but maybe they could

Re: [edk2] [PATCH 2/6] OvmfPkg: SmbiosPlatformDxe: restrict current Xen code to IA32/X64

2015-07-20 Thread Jordan Justen
On 2015-07-17 03:42:21, Ard Biesheuvel wrote: On 17 July 2015 at 12:10, Laszlo Ersek ler...@redhat.com wrote: On 07/17/15 08:45, Ard Biesheuvel wrote: [...] There is a distinction, though. The reason we could not rely on the HOB for the XenHypercall code on the ARM side was that those

Re: [edk2] [PATCH 2/6] OvmfPkg: SmbiosPlatformDxe: restrict current Xen code to IA32/X64

2015-07-20 Thread Jordan Justen
On 2015-07-17 04:11:46, Laszlo Ersek wrote: On 07/17/15 12:42, Ard Biesheuvel wrote: On 17 July 2015 at 12:10, Laszlo Ersek ler...@redhat.com wrote: On 07/17/15 08:45, Ard Biesheuvel wrote: [...] There is a distinction, though. The reason we could not rely on the HOB for the

Re: [edk2] [PATCH v3 50/52] OvmfPkg: pull in SMM-based variable driver stack

2015-10-26 Thread Jordan Justen
47-50 Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com> But, I think only 49/52: "OvmfPkg: consolidate variable driver stack in DSC and FDF files" should be committed now. I think the others should wait for the rest of the SMM pieces to fall in place. (Maybe... I gues

Re: [edk2] [PATCH v3 27/52] OvmfPkg: use relaxed AP SMM synchronization mode

2015-10-26 Thread Jordan Justen
On 2015-10-25 19:53:23, Paolo Bonzini wrote: > On 23/10/2015 17:29, Laszlo Ersek wrote: > > I plan to drop this patch, dependent on testing, and on how a new QEMU > > patch I've written will be received on qemu-devel. > > I'm not sure why it can't be fixed within the firmware. Your patch > to

Re: [edk2] [PATCH 6/6] OvmfPkg/PlatformPei: Set PcdCpuMaxLogicalProcessorNumber using QEMU fw_cfg

2015-10-29 Thread Jordan Justen
On 2015-10-29 04:45:37, Laszlo Ersek wrote: > On 10/29/15 02:32, Jordan Justen wrote: > > +ASSERT (MaxProcessors > 0); > > +PcdSet32 (PcdCpuMaxLogicalProcessorNumber, MaxProcessors); > > I think that when this branch is active, then > PcdCpuApInitTimeOutInMicroS

Re: [edk2] [PATCH v3 46/52] OvmfPkg: QemuFlashFvbServicesRuntimeDxe: clean up includes and libraries

2015-10-26 Thread Jordan Justen
On 2015-10-14 15:26:42, Laszlo Ersek wrote: > Before introducing the SMM driver interface, clean up #include directives > and [LibraryClasses] by: > - removing what's not directly used, I noticed HobLib is removed. Do you think you could mention that here? 39-46 Reviewed-by: Jord

Re: [edk2] [Patch 2/2] UefiCpuPkg/CpuDxe: Fix one dead lock issue in ProcessorToIdleState()

2015-10-28 Thread Jordan Justen
ntributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jeff Fan <jeff@intel.com> > Cc: Michael Kinney <michael.d.kin...@intel.com> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > Cc: Chen Fan <chen.fan.f.

[edk2] [PATCH 2/6] UefiCpuPkg/CpuDxe: Ignore extra APs in the system

2015-10-28 Thread Jordan Justen
-by: Jordan Justen <jordan.l.jus...@intel.com> Cc: Jeff Fan <jeff@intel.com> Cc: Laszlo Ersek <ler...@redhat.com> --- UefiCpuPkg/CpuDxe/CpuMp.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/UefiCpuPkg/CpuDxe/CpuMp.c b/UefiCpuPkg/CpuDxe/Cpu

[edk2] [PATCH 6/6] OvmfPkg/PlatformPei: Set PcdCpuMaxLogicalProcessorNumber using QEMU fw_cfg

2015-10-28 Thread Jordan Justen
By setting this PCD, we allow the CpuDxe driver to proceed earlier after all of the processors have started. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> Cc: Jeff Fan <jeff@intel.com> Cc: Laszlo Ersek <le

[edk2] [PATCH 5/6] UefiCpuPkg: Allow PcdCpuMaxLogicalProcessorNumber to be dynamic

2015-10-28 Thread Jordan Justen
multiprocessor initialization to know that all of the application processors have started. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> Cc: Jeff Fan <jeff@intel.com> Cc: Laszlo Ersek <ler...@redhat.com&g

[edk2] [PATCH 0/6] UefiCpuPkg/CpuDxe MP Startup Fixes / Optimizations

2015-10-28 Thread Jordan Justen
started. Patches 5 & 6 allow OVMF to dynamically set the PcdCpuMaxLogicalProcessorNumber so CpuDxe's MP initialization can complete as soon as all processors have started. Jordan Justen (6): UefiCpuPkg/CpuDxe: Don't use gBS->Stall UefiCpuPkg/CpuDxe: Ignore extra APs in the system Ue

[edk2] [PATCH 1/6] UefiCpuPkg/CpuDxe: Don't use gBS->Stall

2015-10-28 Thread Jordan Justen
The CpuDxe driver may run before the gEfiMetronomeArchProtocolGuid protocol is installed. gBS->Stall does not work until this arch protocol is installed. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> Cc: Jeff

[edk2] [PATCH 4/6] UefiCpuPkg/CpuDxe: Allow BSP to continue once max APs are awake

2015-10-28 Thread Jordan Justen
SynchronizationLib to update this variable on the AP and to read it on the BSP. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> Cc: Jeff Fan <jeff@intel.com> Cc: Laszlo Ersek <ler...@redhat.com> --- UefiCpuPkg/C

Re: [edk2] [PATCH] OvmfPkg: increase MP services startup timeout

2015-10-21 Thread Jordan Justen
On 2015-10-21 14:19:40, Kinney, Michael D wrote: > Laszlo, > > We have the PCD that specifies the max CPUs. > > ## Specifies max supported number of Logical Processors. > # @Prompt Configure max supported number of Logical Processors > >

Re: [edk2] [Patch V2 1/5] MdeModulePkg: Add EdkiiPlatformLogo protocol definition.

2015-11-09 Thread Jordan Justen
In the subject, can you change EdkiiPlatformLogo => PlatformLogo? On 2015-11-08 21:23:40, Ruiyu Ni wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni > Cc: Feng Tian > --- >

Re: [edk2] [Patch V2 2/5] MdeModulePkg: Add ImageDecoderLib to provide image decoding service.

2015-11-09 Thread Jordan Justen
Patches 2-5 Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com> On 2015-11-08 21:23:41, Ruiyu Ni wrote: > The library itself doesn't provide any image decoding capabilities but > manages the different image decoders. > > Contributed-under: TianoCore Contribution Agreemen

Re: [edk2] [Patch V2 1/5] MdeModulePkg: Add EdkiiPlatformLogo protocol definition.

2015-11-09 Thread Jordan Justen
On 2015-11-09 19:22:58, Ni, Ruiyu wrote: > Sure I will modify the commit message to remove "Edkii". I had more comments further down on the patch. -Jordan > -Original Message- > From: Justen, Jordan L > Sent: Tuesday, November 10, 2015 11:14 AM > To: Ni, Ruiyu ;

Re: [edk2] [Patch V2 1/5] MdeModulePkg: Add EdkiiPlatformLogo protocol definition.

2015-11-09 Thread Jordan Justen
t defined > by UEFI spec but a EDKII implementation specific one. We had > EdkiiVariableLock protocol defined in > MdeModulePkg/Include/Protocol/VariableLock.h. I agree to remove > Edkii prefix from the commit message, #ifdef macro, but will keep > the prefix in the protocol name, enum n

Re: [edk2] [PATCH v4 02/41] OvmfPkg: Sec: force reinit of BaseExtractGuidedSectionLib handler table

2015-11-11 Thread Jordan Justen
code paths examined in that commit. Furthermore, a > non-malicious runtime OS will observe no change in behavior; see case (c) > in said commit. > > Cc: Michael Kinney <michael.d.kin...@intel.com> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Contributed-und

Re: [edk2] [PATCH v4 15/41] OvmfPkg: resolve ReportStatusCodeLib for DXE_SMM_DRIVER modules

2015-11-11 Thread Jordan Justen
Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com> On 2015-11-03 13:00:51, Laszlo Ersek wrote: > PiSmmCpuDxeSmm depends on this library class, and it's okay to resolve it > generally for all DXE_SMM_DRIVER modules. > > Contributed-under: TianoCore Contribution Agreemen

Re: [edk2] [PATCH v4 11/41] OvmfPkg: pull in CpuIo2Smm driver

2015-11-11 Thread Jordan Justen
Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com> On 2015-11-03 13:00:47, Laszlo Ersek wrote: > This driver provides EFI_SMM_CPU_IO2_PROTOCOL, which the SMM core depends > on in its gEfiDxeSmmReadyToLockProtocolGuid callback > (SmmReadyToLockHandler(), "MdeModu

Re: [edk2] [PATCH v4 16/41] OvmfPkg: resolve CpuExceptionHandlerLib for DXE_SMM_DRIVER modules

2015-11-11 Thread Jordan Justen
Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com> On 2015-11-03 13:00:52, Laszlo Ersek wrote: > UefiCpuPkg/PiSmmCpuDxeSmm depends on this library (the > RegisterCpuInterruptHandler() function specifically) to set up its > specialized page fault handler (SmiPFHandler() ->

Re: [edk2] [PATCH v4 10/41] OvmfPkg: pull in the SMM IPL and SMM core

2015-11-11 Thread Jordan Justen
Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com> On 2015-11-03 13:00:46, Laszlo Ersek wrote: > "MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf" (a DXE_RUNTIME_DRIVER) > implements the SMM Initial Program Loader. It produces > EFI_SMM_BASE2_PROTOCOL and EFI_SMM_COMMUN

Re: [edk2] [PATCH v4 12/41] OvmfPkg: AcpiS3SaveDxe: don't fake LockBox protocol if SMM_REQUIRE

2015-11-11 Thread Jordan Justen
Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com> On 2015-11-03 13:00:48, Laszlo Ersek wrote: > In SVN r15306 (git commit d4ba06df), "OvmfPkg: S3 Resume: fake LockBox > protocol for BootScriptExecutorDxe", we installed a fake LockBox protocol > in OVMF's AcpiS3SaveD

Re: [edk2] [PATCH v4 07/41] OvmfPkg: add PEIM for providing TSEG-as-SMRAM during PEI

2015-11-11 Thread Jordan Justen
hat produces the EFI_PEI_SMM_COMMUNICATION_PPI > >and > >>> PEI_SMM_ACCESS_PPI interfaces, enabling SmmLockBoxPeiLib to work. > >>> > >>> Said library instance can parse and access LockBox data itself (without > >>> additional LockBox drivers) if th

Re: [edk2] MdePkg: Enable Xcode build of BaseLib without

2015-11-10 Thread Jordan Justen
Liming, Andrew, Wasn't BUILDRULEORDER supposed to help with this? -Jordan On 2015-11-10 18:30:39, Gao, Liming wrote: > This patch is committed at r18766. > > Thanks > Liming > From: af...@apple.com [mailto:af...@apple.com] > Sent: Tuesday, November 10, 2015 11:31 PM > To: Gao, Liming > Cc:

Re: [edk2] MdePkg: Enable Xcode build of BaseLib without

2015-11-10 Thread Jordan Justen
On 2015-11-10 19:18:01, Andrew Fish wrote: > On Nov 10, 2015, at 7:11 PM, Jordan Justen <jordan.l.jus...@intel.com> > wrote: > Liming, Andrew, > > Wasn't BUILDRULEORDER supposed to help with this? > > I asked about that too? I was testing with XCODE5, so the BU

Re: [edk2] [PATCH 6/6] OvmfPkg/PlatformPei: Set PcdCpuMaxLogicalProcessorNumber using QEMU fw_cfg

2015-11-02 Thread Jordan Justen
On 2015-11-02 17:14:12, Laszlo Ersek wrote: > On 11/02/15 23:49, Laszlo Ersek wrote: > > On 11/02/15 23:29, Jordan Justen wrote: > >> On 2015-11-02 12:16:12, Laszlo Ersek wrote: > >>> On 11/02/15 19:53, Alex Williamson wrote: > >>>> On Mon,

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: fix ExitBootServices() callback in the presence of SMIs

2015-11-02 Thread Jordan Justen
t; > -Original Message- > > From: Justen, Jordan L > > Sent: Wednesday, October 28, 2015 6:55 AM > > To: Laszlo Ersek; edk2-devel@lists.01.org > > Cc: Chen Fan; Kinney, Michael D; Fan, Jeff > > Subject: Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: fix ExitBootServ

Re: [edk2] [PATCH 6/6] OvmfPkg/PlatformPei: Set PcdCpuMaxLogicalProcessorNumber using QEMU fw_cfg

2015-11-03 Thread Jordan Justen
On 2015-11-03 05:45:52, Paolo Bonzini wrote: > > > On 03/11/2015 14:25, Laszlo Ersek wrote: > > - Agreement between Paolo, Jordan and Mike about implementing > > broadcast SMIs. I am willing to code up whatever design is > > agreed upon. Can everyone involved please

Re: [edk2] C Coding Standards Specification disappeared

2015-11-05 Thread Jordan Justen
On 2015-11-05 08:05:03, Laszlo Ersek wrote: > On 11/05/15 16:52, Kinney, Michael D wrote: > > Laszlo, > > > > The semi-formal way is to discuss these types of change requests > > on this mailing list and get agreement. > > > > I think your suggestion to add a new horizontal spacing rule that > >

Re: [edk2] [Patch 0/4] AppPkg/Python: Port Python 2.7.10 to EDK II

2015-11-05 Thread Jordan Justen
Have you considered using git? For one, EDK II is moving to git. It would have enabled you to easily generate and send the patch files for your patch series. (I am guessing you spend considerable time generating these emails, and yet, I don't think they are usable to actually apply to a tree.)

[edk2] [PATCH] BaseTools/Scripts: Add PatchCheck.py script

2015-10-07 Thread Jordan Justen
The --oneline option works similar to git log --oneline. The --silent option enables silent operation. The script supports python 2.7 and python 3. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> Cc: Erik Bjorge <e

Re: [edk2] [PATCH v3] Pkg-Module: Integrate new RngLib into RngDxe

2015-10-07 Thread Jordan Justen
In the subject line, 'Pkg-Module' should be something like 'MdePkg:' or 'SecurityPkg/RandomNumberGenerator:'. On 2015-10-07 18:55:42, Thomas Palmer wrote: > Use the new RngLib to provide the IA32/X64 random data for RngDxe. > Remove x86 specific functions from RdRand files. > Clean up files in

Re: [edk2] [PATCH v3 44/52] OvmfPkg: QemuFlashFvbServicesRuntimeDxe: no dual addressing needed

2015-10-18 Thread Jordan Justen
I can't find a fault with your argument, but something tells me it might be good to get some input from Mike or Andrew (or others on the list) in the form of a history lesson to know why the two modes might have been supported. I've always seen it done this way, but likely this has been due to a

Re: [edk2] [PATCH 1/4] OvmfPkg: import SmmCpuFeaturesLib from UefiCpuPkg

2015-10-13 Thread Jordan Justen
On 2015-10-13 05:57:17, Paolo Bonzini wrote: > The next patches will customize the implementation, but let's > start from the common version to better show the changes. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Paolo Bonzini > --- >

Re: [edk2] [PATCH 1/3] OvmfPkg: Add SMM DebugAgentLib mapping to DSC

2015-10-13 Thread Jordan Justen
ney <michael.d.kin...@intel.com> > --- > OvmfPkg/OvmfPkgIa32.dsc| 3 +++ > OvmfPkg/OvmfPkgIa32X64.dsc | 3 +++ Why did you not update the X64 build? My process for updating the dsc involves a 3-way diff of OvmfPkg/*.dsc, and I try to keep the differences minimal. If you update the X

Re: [edk2] [PATCH] BaseTools/Scripts: Add PatchCheck.py script

2015-10-09 Thread Jordan Justen
On 2015-10-08 15:22:08, Laszlo Ersek wrote: > On 10/08/15 04:53, Jordan Justen wrote: > > This script can be used to check some expected rules for EDK II > > patches. It only works on git formatted patches. > > > > It checks both the commit message and the lines that

Re: [edk2] [PATCH] OvmfPkg: AcpiTables: serialize control methods that create named objects

2015-09-02 Thread Jordan Justen
Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com> On 2015-08-28 02:16:29, Laszlo Ersek wrote: > Bruce Cran reported the following issue: > > With iasl version 20150410-64 building OvmfX64 (using OvmfPkg/build.sh > -a X64 -t GCC49 -b RELEASE) results in a couple

Re: [edk2] [PATCH 08/58] OvmfPkg: PlatformPei: account for TSEG size with PcdSmmSmramRequire set

2015-09-06 Thread Jordan Justen
Patches 7 & 8 Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com> On 2015-07-24 16:00:14, Laszlo Ersek wrote: > PlatformPei calls GetSystemMemorySizeBelow4gb() in three locations: > > - PublishPeiMemory(): on normal boot, the permanent PEI RAM is installed > so tha

Re: [edk2] [PATCH 05/58] OvmfPkg: Sec: assert the build-time calculated end of the scratch buffer

2015-09-06 Thread Jordan Justen
ompressMemFvs() [OvmfPkg/Sec/SecMain.c]. > + > +DEFINE OUTPUT_BASE= ($(MEMFD_BASE_ADDRESS) + > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfDxeMemFvBase + 0x0010) > +DEFINE SCRATCH_BASE_UNALIGNED = ($(OUTPUT_BASE) + $(OUTPUT_SIZE)) > +DEFINE SCRATCH_BASE_ALIGNMENT = 0x000F >

Re: [edk2] [PATCH 06/58] OvmfPkg: decompress FVs on S3 resume if SMM_REQUIRE is set

2015-09-06 Thread Jordan Justen
eImageBase >) > { > + BOOLEAN S3Resume; > + >*PeiCoreImageBase = 0; > > - if (IsS3Resume ()) { > - DEBUG ((EFI_D_VERBOSE, "SEC: S3 resume\n")); > + S3Resume = IsS3Resume (); > + if (S3Resume && !FeaturePcdGet (PcdSmmSmramRequire)) { > +

Re: [edk2] [PATCH 03/58] MdePkg: BaseExtractGuidedSectionLib: allow forced reinit of handler table

2015-09-02 Thread Jordan Justen
On 2015-07-24 16:00:09, Laszlo Ersek wrote: > BaseExtractGuidedSectionLib uses a table at the static physical address > PcdGuidedExtractHandlerTableAddress, and modules that are linked against > BaseExtractGuidedSectionLib are expected to work together on that table. > Namely, some modules can

Re: [edk2] [PATCH 03/58] MdePkg: BaseExtractGuidedSectionLib: allow forced reinit of handler table

2015-09-06 Thread Jordan Justen
gt; forced reinit of handler table > > On 09/02/15 21:38, Jordan Justen wrote: > > On 2015-07-24 16:00:09, Laszlo Ersek wrote: > >> BaseExtractGuidedSectionLib uses a table at the static physical > >> address PcdGuidedExtractHandlerTableAddress, and modules tha

  1   2   3   4   5   6   >