Re: [edk2] [PATCH 0/3] unify FVP Base and Foundation model support

2015-08-18 Thread Leif Lindholm
On Tue, Aug 18, 2015 at 01:15:54PM +0200, Ard Biesheuvel wrote: On 12 August 2015 at 08:45, Ard Biesheuvel ard.biesheu...@linaro.org wrote: Instead of omitting some drivers that are known to break the Foundation model when ARM_FOUNDATION_FVP is defined, fix those drivers so that they simply

Re: [edk2] [PATCH] ShellBinPkg: Arm/AArch64 Shell binary update.

2015-08-19 Thread Leif Lindholm
On Wed, Aug 19, 2015 at 01:46:42PM +0200, Ard Biesheuvel wrote: The binaries of ShellBinPkg are generated with ShellPkg project 18222. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ard.biesheu...@linaro.org --- These are built with the tiny code

Re: [edk2] [PATCH] ArmPkg: Fix GCC5 build fail

2015-08-19 Thread Leif Lindholm
Hi Scott, Thanks for this. Apologies, I somehow missed it going past. This same fix went in as part of Ard's CLANG series (r18193). Regards, Leif On Sun, Jul 19, 2015 at 03:23:17PM -0500, Scott Duplichan wrote: Add type cast to fix new GCC5 warning for discarded-array-qualifiers. Also remove

Re: [edk2] Adding a new BoardPkg to edk2 tree: Licensing

2015-08-20 Thread Leif Lindholm
Hi Bhupesh, On Thu, Aug 20, 2015 at 11:03:07AM +, Sharma Bhupesh wrote: We are considering adding the support for a Freescale ARM64 based platform in the EDK2 tree and upstreaming the same. As much as I would like to see more open source platform code, I really want to get some structure

Re: [edk2] [PATCH 0/3] unify FVP Base and Foundation model support

2015-08-18 Thread Leif Lindholm
On Tue, Aug 18, 2015 at 02:14:53PM +0200, Ard Biesheuvel wrote: On 18 August 2015 at 14:12, Leif Lindholm leif.lindh...@linaro.org wrote: On Tue, Aug 18, 2015 at 01:15:54PM +0200, Ard Biesheuvel wrote: On 12 August 2015 at 08:45, Ard Biesheuvel ard.biesheu...@linaro.org wrote: Instead

Re: [edk2] [PATCH 1/2] ArmVirtPkg: build our DEBUG Shell using the small code model

2015-08-19 Thread Leif Lindholm
Hi Ard, Apologies for tardiness. Could we move this into ShellPkg instead, since the mcmodel=tiny is globally applied for AARCH64, and any other direct consumers would also be affected by 2/2? / Leif On Mon, Aug 10, 2015 at 12:27:26PM +0200, Ard Biesheuvel wrote: The DEBUG build of the

Re: [edk2] [PATCH 2/2] BaseTools AARCH64: use tiny code model by default

2015-08-19 Thread Leif Lindholm
be selected by individual modules by adding -mcmodel=large to the appropriate CC_FLAGS. Once ShellPkg situation resolves one way or the other: Reviewed-by: Leif Lindholm leif.lindh...@linaro.org Tested-by: Leif Lindholm leif.lindh...@linaro.org Thanks for this. / Leif Contributed-under: TianoCore

Re: [edk2] [PATCH] ArmPkg: Move FDT offset higher in RAM

2015-07-28 Thread Leif Lindholm
Apologies for top-posting, I think this conversation should drop edk2-devel and move to linaro-uefi (added to cc), until there is consensus/conclusion. Could the next person replying to this thread delete edk2-devel from the recipient list please? / Leif On Tue, Jul 28, 2015 at 10:41:29AM

Re: [edk2] [PATCH v3 08/12] BaseTools/AARCH64: move to unified GCC linker script

2015-07-30 Thread Leif Lindholm
On Wed, Jul 29, 2015 at 05:11:58PM +0200, Ard Biesheuvel wrote: Drop the GCC AARCH64 specific linker script and use the new unified one instead. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ard.biesheu...@linaro.org Reviewed-by: Leif Lindholm

Re: [edk2] [PATCH v3 11/12] BaseTools/AARCH64: remove incremental linker script for 64K alignment

2015-07-30 Thread Leif Lindholm
Biesheuvel ard.biesheu...@linaro.org Reviewed-by: Leif Lindholm leif.lindh...@linaro.org Also tested on ARM and AARCH64 hardware. Thanks for this cleanup. --- BaseTools/Scripts/gcc-aarch64-64K-align-ld-script | 4 1 file changed, 4 deletions(-) diff --git a/BaseTools/Scripts/gcc-aarch64-64K

Re: [edk2] [PATCH] EmbeddedPkg: Added Marvell Yukon Ethernet support

2015-07-30 Thread Leif Lindholm
Hi Jordan, On Wed, Jul 29, 2015 at 02:59:04PM -0700, Jordan Justen wrote: But, the name 'open platform' also sounds strange, assuming this a plain PCI bus driver. Couldn't it live in a 'pci drivers' package? Personally, I think we should rename OptionRomPkg to DriversPkg, or split

Re: [edk2] [PATCH v2 0/6] ArmPkg/ArmVirtPkg: GIC revision detection

2015-07-28 Thread Leif Lindholm
Hi Ard, Sorry for delay. On Sun, Jul 26, 2015 at 02:50:24PM +0200, Ard Biesheuvel wrote: On 26 July 2015 at 13:46, Leif Lindholm leif.lindh...@linaro.org wrote: On Sun, Jul 26, 2015 at 01:08:20PM +0200, Ard Biesheuvel wrote: So ... had a look through, looks sane, have a couple of minor

Re: [edk2] [PATCH] EmbeddedPkg: Added Marvell Yukon Ethernet support

2015-07-28 Thread Leif Lindholm
Hi Jordan, Sorry, (metaphorically) snowed under for a few days. On Fri, Jul 17, 2015 at 02:44:10PM -0700, Jordan Justen wrote: Does this depend on ArmPkg / EmbeddedPkg, or is this just a generic PCI based driver? It could be nice to have a generic place for such drivers, but I think

Re: [edk2] [PATCH v2 0/7] small model and clang support for AARCH64

2015-08-07 Thread Leif Lindholm
Lindholm leif.lindh...@linaro.org Tested-by: Leif Lindholm leif.lindh...@linaro.org I guess you need further nods for at least 7/7? / Leif On Mon, Aug 03, 2015 at 12:14:38PM +0200, Ard Biesheuvel wrote: This is another followup to the series 'small C model and LLVM/clang support

Re: [edk2] [PATCH 0/2] ArmPlatformPkg: reduce .data contents of XIP modules

2015-08-07 Thread Leif Lindholm
ArmPlatformPkg/PlatformPeim: constify EFI_PEI_PPI_DESCRIPTOR globals ArmPlatformPkg/PlatformPei/PlatformPeim.c | 4 ++-- ArmPlatformPkg/PrePeiCore/PrePeiCore.c| 10 +- 2 files changed, 7 insertions(+), 7 deletions(-) Looks good to me. Reviewed-by: Leif Lindholm leif.lindh...@linaro.org

Re: [edk2] [PATCH 3/5] ArmPlatformPkg: remove mention of ARMGCC and ARMLINUXGCC

2015-08-10 Thread Leif Lindholm
On Mon, Aug 10, 2015 at 03:07:41PM +0200, Ard Biesheuvel wrote: Remove the ARMGCC and ARMLINUXGCC from comments in the respective Makefiles of ArmPlatformPkg and ArmJunoPkg and from the [ancient] Versatile Express instructions. Contributed-under: TianoCore Contribution Agreement 1.0

Re: [edk2] [PATCH] ArmPlatformPkg: remove obsolete ARM and AARCH64 platforms

2015-07-27 Thread Leif Lindholm
On Mon, Jul 27, 2015 at 10:35:39PM +0200, Ard Biesheuvel wrote: On 27 July 2015 at 22:28, Leif Lindholm leif.lindh...@linaro.org wrote: On Mon, Jul 27, 2015 at 04:59:31PM +0200, Ard Biesheuvel wrote: Remove obsolete ARM and AARCH64 platforms so the maintainers can focus on the ones

Re: [edk2] [PATCH] ArmPlatformPkg: remove obsolete ARM and AARCH64 platforms

2015-07-27 Thread Leif Lindholm
On Mon, Jul 27, 2015 at 04:59:31PM +0200, Ard Biesheuvel wrote: Remove obsolete ARM and AARCH64 platforms so the maintainers can focus on the ones that are still supported: - TC2 (ArmVExpress-CTA15-A7.dsc) - Foundation model and Fast model emulators (ArmVExpress-FVP-AArch64.dsc) - Juno

Re: [edk2] [PATCH v2 0/6] ArmPkg/ArmVirtPkg: GIC revision detection

2015-07-26 Thread Leif Lindholm
On Sun, Jul 26, 2015 at 11:50:53AM +0200, Ard Biesheuvel wrote: On 26 July 2015 at 11:50, Laszlo Ersek ler...@redhat.com wrote: On 07/26/15 11:40, Ard Biesheuvel wrote: The current GIC revision detection code infers the GIC revision from the AA64PFR0_EL1.GIC feature bit that tells us

Re: [edk2] [PATCH v2 2/6] ArmPkg: split off ArmGicArchLib from ArmGicLib

2015-07-26 Thread Leif Lindholm
On Sun, Jul 26, 2015 at 11:40:11AM +0200, Ard Biesheuvel wrote: ... diff --git a/ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf b/ArmPkg/Library/ArmGicArchLib/ArmGicArchLib.inf similarity index 64% copy from ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf copy to

Re: [edk2] [PATCH] EmbeddedPkg: Added Marvell Yukon Ethernet support

2015-07-17 Thread Leif Lindholm
On Thu, Jul 16, 2015 at 10:22:02AM -0700, Jordan Justen wrote: On 2015-07-16 09:11:38, Olivier Martin wrote: This change adds support for the PCI Marvell Yukon Ethernet controller. This ethernet controller can be found on the ARM Juno development platform. The UEFI driver has been

[edk2] [PATCH] Maintainers.txt: ARM packages maintainer update

2015-07-17 Thread Leif Lindholm
Retire Olivier Martin as maintainer, and add in Ard Biesheuvel as a co-maintainer for the ARM packages. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leif Lindholm leif.lindh...@linaro.org --- Maintainers.txt | 10 +- 1 file changed, 5 insertions(+), 5 deletions

Re: [edk2] style question/Omap3530Gpio

2015-10-22 Thread Leif Lindholm
On Wed, Oct 21, 2015 at 09:03:15AM -0700, Andrew Fish wrote: > > (Sorry about butting in.) > > > > If the "PL061Gpio.h" file comes from a device data sheet, then it > > should go under "ArmPlatformPkg/Include/IndustryStandard". (Or > > maybe "ArmPkg/Include/IndustryStandard".) A few such

Re: [edk2] [PATCH] MdePkg/BaseSynchronizationLib: fix return value

2015-10-27 Thread Leif Lindholm
On Tue, Oct 27, 2015 at 06:15:07PM +0900, Ard Biesheuvel wrote: > Hi Haojian, > > On 27 October 2015 at 16:15, Haojian Zhuang wrote: > > Fix the wrong return value of both InternalSyncIncrement() > > and InternalSyncDecrement(). The return value shouldn't > > be the

Re: [edk2] [Patch] MdeModulePkg: Fix a PciBusDxe hot plug bug

2015-10-29 Thread Leif Lindholm
egards, Leif > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Leif > Lindholm > Sent: Wednesday, October 28, 2015 22:51 > To: Tian, Feng > Cc: Ni, Ruiyu; edk2-devel@lists.01.org; Fan, Jeff > Subject: Re: [edk2] [Patch] Md

Re: [edk2] [Patch] MdeModulePkg: Fix a PciBusDxe hot plug bug

2015-10-28 Thread Leif Lindholm
Feng, Any update on the below? The hard crash bug is still in SVN r18690. Regards, Leif On Mon, Oct 26, 2015 at 03:35:15PM +, Leif Lindholm wrote: > Hi Ray, > > On Mon, Oct 26, 2015 at 03:17:22PM +, Ni, Ruiyu wrote: > > Can you add a null pointer check to

Re: [edk2] [Patch] MdeModulePkg: Fix a PciBusDxe hot plug bug

2015-10-26 Thread Leif Lindholm
mmit history ;) Regards, Leif > > 在 2015年10月26日,21:13,Leif Lindholm <leif.lindh...@linaro.org> 写道: > > > > Hi Ruiyu, Feng, > > > > I am currently tracking down an issue on (at least) one of my > > platforms - that happens with this (now committed) patch,

Re: [edk2] [PATCH 00/10] ARM cache maintenance cleanup

2015-11-09 Thread Leif Lindholm
nce operations > ArmVirtPkg/PrePi: do not invalidate the entire data cache at startup > ArmPlatformPkg: do not invalidate the entire data cache at startup With the above addressed, for the series: Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> > Mark Rutland (1):

Re: [edk2] [PATCH] ArmPkg/BdsLib: Increase fallback tftp buffer size

2015-11-09 Thread Leif Lindholm
Hi Michael, On Fri, Nov 06, 2015 at 05:24:02PM +, Kinney, Michael D wrote: > Hi, > > There are macros in MdePkg/Include/Base.h that help align values and pointers > to the next boundary. > This patch could use the following: > > TftpBufferSize = ALIGN_VALUE (TftpBufferSize,

Re: [edk2] [PATCH] ArmPlatformPkg: bring DS-5 scripts in line with linker script changes

2015-11-10 Thread Leif Lindholm
On 10 November 2015 at 18:10, Ard Biesheuvel wrote: > On 6 November 2015 at 08:25, Ard Biesheuvel wrote: >> The ARM and AARCH64 linker scripts have recently been updated so that >> the memory layouts of the ELF and PE/COFF versions of each

Re: [edk2] ShellPkg: Network commands (ifconfig/ping) broken

2015-11-09 Thread Leif Lindholm
On Mon, Nov 09, 2015 at 09:30:03PM +0100, Laszlo Ersek wrote: > > after switching from UDK2014 to UDK2015, I noticed that the network > > commands (ifconfig / ping) don't work anymore. ifconfig just exits > > with no feedback and ping says "Config no mapping" (logical, as it is > > not possible to

Re: [edk2] ShellPkg: Network commands (ifconfig/ping) broken

2015-11-10 Thread Leif Lindholm
OL is not available? Regards, Leif > Thanks > Laszlo > > > > > Greetings > > Johannes > > > > -Ursprüngliche Nachricht- > > Von: Laszlo Ersek [mailto:ler...@redhat.com] > > Gesendet: Dienstag, 10. November 2015 11:06 > > An: Conen

Re: [edk2] [PATCH] ArmPkg/ArmLib: mark all cached mappings as (inner) shareable

2015-11-12 Thread Leif Lindholm
nice code cleanup. I ran into an issue while testing this, which is why I haven't responded to this, but I've bisected it down to r18503/3a05b13, and am looking into what causes an issue with Linux booting. Regardless - this patch wasn't the cause of my issue, and it looks fine. Reviewed-by: Leif

Re: [edk2] [PATCH] ArmPkg/ArmV7Mmu: introduce feature PCD to map normal memory non-shareable

2015-11-16 Thread Leif Lindholm
On Mon, Nov 16, 2015 at 05:29:42PM +0100, Ard Biesheuvel wrote: > Even though mapping normal memory (inner) shareable is usually the > correct choice on coherent systems, it may be desirable in some cases > to use non-shareable mappings for normal memory, e.g., when hardware > managed coherency is

Re: [edk2] [PATCH v2] ArmPkg/ArmV7Mmu: introduce feature PCD to map normal memory non-shareable

2015-11-16 Thread Leif Lindholm
tching on memory types I minded :) Anyway: Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> > ArmPkg/ArmPkg.dec | 6 ++ > ArmPkg/Library/ArmLib/ArmV7/ArmV7Lib.inf | 3 +++ > ArmPkg/Library/ArmLib/ArmV7/ArmV7LibPrePi.inf | 3 +++ > ArmPkg/Li

Re: [edk2] [PATCH] ArmPkg/ArmLib: mark all cached mappings as (inner) shareable

2015-11-16 Thread Leif Lindholm
On Sat, Nov 14, 2015 at 08:04:19PM +0100, Ard Biesheuvel wrote: > On 14 November 2015 at 15:23, Ard Biesheuvel > wrote: > >> I have an issue with this commit too on my ARMv7 device. > >> It causes the whole system to get extremely slow. > > > > OK, thanks for the

Re: [edk2] [PATCH v3 1/3] ArmPkg/ArmV7Mmu: fix write-through translation table accesses

2015-11-17 Thread Leif Lindholm
ition equals the definition of TTBR_WRITE_BACK_ALLOC > > So instead, rename it to TTBR_WRITE_THROUGH and update the definition > to reflect the name. This is an improvement on existing code, so: Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> ...but I would have been just as hap

Re: [edk2] [PATCH v3 2/3] ArmPkg/ArmV7Mmu: make cached translation table accesses shareable

2015-11-17 Thread Leif Lindholm
Ard Biesheuvel <ard.biesheu...@linaro.org> Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> > --- > ArmPkg/Include/Chipset/ArmV7Mmu.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/ArmPkg/Include/Chipset/ArmV7Mmu.h > b/ArmPkg/In

Re: [edk2] [PATCH V2 00/12] Upstream SerialDxe from EmbeddedPkg to MdeModulePkg

2015-11-17 Thread Leif Lindholm
Hi Star, First of all - thank you for posting On Tue, Nov 17, 2015 at 07:07:16PM +0800, Star Zeng wrote: > Generally, this patch series are to upstream SerialDxe from EmbeddedPkg to > MdeModulePkg, > relatively, they are also to upstream SerialPortExtLib.h from EmbeddedPkg to >

Re: [edk2] AARCH64 MMU TCR configuration questions

2015-11-09 Thread Leif Lindholm
On Mon, Nov 09, 2015 at 04:00:51PM +0800, Heyi Guo wrote: > Hi All, > > In AARCH64 MMU configuration code, sharable attribute will be set to > inner sharable when memory attribute is write back. However, I have > 2 questions about this code: > 1. Why is it set to inner sharable only when memory

Re: [edk2] [PATCH] ArmPkg/ArmLib: remove pointless sync barriers after each cache op

2015-11-02 Thread Leif Lindholm
On Mon, Nov 02, 2015 at 02:24:18PM +0100, Ard Biesheuvel wrote: > There is no need to issue a full data synchronization barrier and an > instruction synchronization barrier after each and every set/way or > MVA cache maintenance operation. So remove them. You don't need all of these, but it is

Re: [edk2] [Patch] MdeModulePkg: Fix a PciBusDxe hot plug bug

2015-11-03 Thread Leif Lindholm
Hi guys, I never saw a response to this feedback I sent on the revised patch set, but I see it has now been committed. Could you let me know why my feedback was ignored? Regards, Leif On 30 October 2015 at 18:02, Leif Lindholm <leif.lindh...@linaro.org> wrote: > Hi Ray, > &

Re: [edk2] [PATCH 03/10] ArmPkg/ArmLib: remove unused ARM9 support

2015-11-03 Thread Leif Lindholm
On Tue, Nov 03, 2015 at 11:16:28AM +0100, Ard Biesheuvel wrote: > The ARM9 ArmLib implementation is not referenced anywhere in the > tree, and unlikely to be useful going forward, considering that > ARM9 outdates even ARMv6. So remove it. While I agree in principle, I don't think we can safely

Re: [edk2] [PATCH] Increase tftp buffer size

2015-11-05 Thread Leif Lindholm
On Thu, Nov 05, 2015 at 11:37:43AM +, Ashutosh Singh wrote: > Default tftp buffer size (8MB) is too small for standard > ARM kernel images, which results in multiple aborted tftp fetches. > This fix increase the buffer size to 16MB. So, I'm not a fan of hard-coded buffer sizes, or how this

Re: [edk2] [Patch] MdeModulePkg: Fix a PciBusDxe hot plug bug

2015-11-04 Thread Leif Lindholm
o your questions firstly. Thanks. Regards, Leif > Regards, > Ray > > -----Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Tuesday, November 3, 2015 6:45 PM > To: Ni, Ruiyu <ruiyu...@intel.com> > Cc: Tian, Feng <feng.t...@int

Re: [edk2] [PATCH] Increase tftp buffer size

2015-11-06 Thread Leif Lindholm
hich does not support rfc2349 transfer size option (such as netkit-tftpd), the existing code falls back to allocating an 8MB buffer. Since this is insufficient for an uncompressed AArch64 Linux kernel image, double the size to 16MB. --- Are you happy with that message? / Leif > -O

Re: [edk2] [PATCH] Increase tftp buffer size

2015-11-06 Thread Leif Lindholm
2638 > >> > >>> will also > >>> be able to use the tftp boot for ARM platforms. > >> > >> Since this patch intends to modify the ARM BDS, I don't really have a > >> horse in the race, but please be aware that this is just a band-aid. >

Re: [edk2] [PATCH] ArmPlatformPkg/ArmJunoPkg: Create SMBIOS/DMI data for Juno

2015-11-06 Thread Leif Lindholm
On Fri, Nov 06, 2015 at 04:21:47PM +0100, Ard Biesheuvel wrote: > On 6 November 2015 at 16:11, Jeremy Linton wrote: > > On 11/06/2015 01:31 AM, Ard Biesheuvel wrote: > >> > >> On 5 November 2015 at 22:51, Jeremy Linton wrote: > >>> > >>> > >>>

Re: [edk2] [PATCH v2 05/10] ArmPkg/ArmLib: retrieve cache line length from CTR not CCSIDR

2015-11-06 Thread Leif Lindholm
On Fri, Nov 06, 2015 at 03:03:53PM +0100, Ard Biesheuvel wrote: > The stride used by the cache maintenance by MVA instructions should > be retrieved from CTR_EL0.DminLine and CTR_EL0.IminLine, whose values > reflect the actual geometry of the caches. Using CCSIDR for this purpose > violates the

Re: [edk2] [PATCH v2 05/10] ArmPkg/ArmLib: retrieve cache line length from CTR not CCSIDR

2015-11-06 Thread Leif Lindholm
On Fri, Nov 06, 2015 at 05:13:44PM +0100, Ard Biesheuvel wrote: > On 6 November 2015 at 17:02, Leif Lindholm <leif.lindh...@linaro.org> wrote: > > On Fri, Nov 06, 2015 at 03:03:53PM +0100, Ard Biesheuvel wrote: > >> The stride used by the cache maintenance by

[edk2] [PATCH] ArmPkg: Purge unused/unneeded CPU-specific header files

2015-11-06 Thread Leif Lindholm
and then includes ArmV7.h. Delete these include files, and update their sole users to function without them. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leif Lindholm <leif.lindh...@linaro.org> --- .../ArmCpuLib/ArmCortexA15Lib/ArmCortexA1

Re: [edk2] [Patch] MdeModulePkg: Fix a PciBusDxe hot plug bug

2015-10-30 Thread Leif Lindholm
able. I also agree we should give community more time to review > those big patch before getting committed in. > > Ray, who is the module owner, will follow up your suggestions. > > Thanks > Feng > > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@

Re: [edk2] [PATCH 05/10] ArmPkg/ArmLib: remove CCSIDR based cache info routines

2015-11-03 Thread Leif Lindholm
On Tue, Nov 03, 2015 at 11:16:30AM +0100, Ard Biesheuvel wrote: > The ARM architecture does not allow the actual geometries of the caches > to be inferred from the CCSIDR cache info system register, since the > geometry it reports is intended for performing cache maintenance by > set/way and

Re: [edk2] [Patch 1/2] BaseTools VfrCompiler: In order to keep consistent, add an optional "; " for condition op-code.

2015-10-14 Thread Leif Lindholm
On Wed, Oct 14, 2015 at 04:29:27PM +0800, Eric Dong wrote: > In current implementation, the "endif" opcode for suppressif has an end ";" > for the statement opcode, but not for the option opcode. This is not a user > friendly grammar. So this patch fixed this issue. Add an optional ";" end for

Re: [edk2] [PATCH] ShellPkg: Use safe string functions to refine Tftp.c code.

2015-10-14 Thread Leif Lindholm
On Wed, Oct 14, 2015 at 01:00:15PM +0800, Qiu Shumin wrote: > Cc: Jaben Carsey > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Qiu Shumin Could we have a commit message, please? Does this resolve an observed problem, or

Re: [edk2] [Patch 2/2] MdeModulePkg DriverSampleDxe: Add optional "; " to keep consistent with existed vfr op-code.

2015-10-14 Thread Leif Lindholm
On Wed, Oct 14, 2015 at 04:29:28PM +0800, Eric Dong wrote: > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Eric Dong Hi Eric, There appears to be no commit message here. I guess the addition of this optional

Re: [edk2] [PATCH] Update the ACPI device information for ARM Juno.

2015-10-19 Thread Leif Lindholm
On Mon, Oct 19, 2015 at 09:36:00AM -0500, Jeremy Linton wrote: > These patches correct a number of problems with the JUNO ACPI tables. > > First, put CCA attributes on the devices which can do DMA. This is > because the linux kernel now requires ARM64 devices specify a coherency > model. Without

Re: [edk2] [PATCH v2 1/8] ArmPlatformPkg: NorFlashDxe: mellow DEBUG messages about flash reinit

2015-10-14 Thread Leif Lindholm
_bug.cgi?id=1270279 > - http://thread.gmane.org/gmane.comp.bios.edk2.devel/2772/focus=2869 > > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Cc: Drew Jones <drjo...@redhat.com> > Cc: Yehuda Yitschak &l

Re: [edk2] [PATCH] ArmPlatformPkg/ARMJunoPkg: Change Interrupt for PCI Routing table

2015-10-07 Thread Leif Lindholm
+, Supreeth Venkatesh wrote: > Will do. > > Thanks, > Supreeth > > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Tuesday, October 06, 2015 10:47 AM > To: Supreeth Venkatesh > Cc: edk2-de...@ml01.01.org > Subject: Re:

Re: [edk2] Cross compiling EDK2 for Aarch64

2015-10-08 Thread Leif Lindholm
Hi Yehuda, On Thu, Oct 08, 2015 at 08:24:07AM +, Yehuda Yitschak wrote: > I am new to the EDK2 projects and for starters I am trying to cross > compile the project for aarch64 on an x86_64 host > > I looked around in Linaro website and Tiano-core website but > couldn't find any instruction

Re: [edk2] Cross compiling EDK2 for Aarch64

2015-10-08 Thread Leif Lindholm
On Thu, Oct 08, 2015 at 10:04:24AM +, Yehuda Yitschak wrote: > > > but when I try to compile using the "build" command the build script > > > uses the x86 compiler and naturally it fails > > > > Any particular reason why you skipped past the first half of the page to > > follow the

Re: [edk2] [PATCH v3 3/5] ArmPkg/ArmLib MMU: add functions to set/clear RO and XN bits on regions

2015-10-08 Thread Leif Lindholm
BaseAddress, > + IN UINT64Length > + ) > +{ > + return RETURN_UNSUPPORTED; > +} > + > +RETURN_STATUS > +ArmSetMemoryRegionReadOnly ( > + IN EFI_PHYSICAL_ADDRESS BaseAddress, > + IN UINT64Length > + ) > +{ > + return RETURN_UNSUPPORTED; > +} > + > +RETURN_STATUS > +ArmClearMemoryRegionReadOnly ( > + IN EFI_PHYSICAL_ADDRESS BaseAddress, > + IN UINT64Length > + ) > +{ > + return RETURN_UNSUPPORTED; > +} > -- > 1.9.1 Provided you sort out the ArmSetMemoryRegionAttribute to SetMemoryRegionAttribute renaming before committing: Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] [PATCH] ArmVirtPkg: include BaseStackCheckLib also for AARCH64

2015-10-16 Thread Leif Lindholm
com> > > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > > Cc: Laszlo Ersek <ler...@redhat.com> > > Cc: Leif Lindholm <leif.lindh...@linaro.org> > > --- > > ArmVirtPkg/ArmVirt.dsc.inc | 8 ++-- > > 1 file changed, 2 insertions(+), 6 deleti

Re: [edk2] [PATCH] Update the ACPI device information for ARM Juno.

2015-10-16 Thread Leif Lindholm
Hi Jeremy, Thanks for this. On Wed, Oct 14, 2015 at 10:10:06AM -0500, Jeremy Linton wrote: > These patches correct a number of problems with the JUNO ACPI tables. > > First, put CCA attributes on the devices which can do DMA. This is > because the linux kernel now requires ARM64 devices specify

Re: [edk2] Porting UEFI to a ARM platform

2015-10-21 Thread Leif Lindholm
Hi Yehuda, On Wed, Oct 21, 2015 at 02:44:19AM +, Yehuda Yitschak wrote: > i started reading and experimenting with UEFI a month ago and i'm > now considering to start porting it to one of Marvell's Aarch64 SOCs > > as a first stage i only want to get a basic shell running and start > adding

Re: [edk2] [PATCH] BaseTools/Scripts: Add PatchCheck.py script

2015-10-10 Thread Leif Lindholm
On Sat, Oct 10, 2015 at 08:45:19AM -0700, Jordan Justen wrote: > On 2015-10-10 04:07:22, Leif Lindholm wrote: > > On Wed, Oct 07, 2015 at 07:53:18PM -0700, Jordan Justen wrote: > > > This script can be used to check some expected rules for EDK II > > > patches. It

Re: [edk2] Cross compiling EDK2 for Aarch64

2015-10-12 Thread Leif Lindholm
On Mon, Oct 12, 2015 at 08:50:53AM +, Yehuda Yitschak wrote: > Thanks. It worked fine. > I assumed the linaro-edk2 GIT should be more up to date with ARM > fixes but I think this is not the case here. No, that will never be the case - we work upstream, so fixes only go into linaro-edk2 after

Re: [edk2] [PATCH 1/3] ArmPlatformPkg: NorFlashDxe: mellow DEBUG messages about flash reinit

2015-10-13 Thread Leif Lindholm
into separate > > DEBUG statements? > > I'll break them up. I don't like overlong lines. :) Sure. > I assume you'd like to see the two sentences on separate lines in the > log output as well (so that noone is tempted to search for the full line > in

Re: [edk2] [PATCH 1/3] ArmPlatformPkg: NorFlashDxe: mellow DEBUG messages about flash reinit

2015-10-13 Thread Leif Lindholm
_bug.cgi?id=1270279 > - http://thread.gmane.org/gmane.comp.bios.edk2.devel/2772/focus=2869 This all looks very sensible. One comment inline. > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Cc: Drew Jones <drjo...@redhat.co

Re: [edk2] [PATCH] ArmPkg/ArmV7Mmu: handle memory regions over 4 GB correctly

2015-11-18 Thread Leif Lindholm
> >ASSERT(MemoryRegion->Length > 0); And shouldn't this ASSERT remain at the very start of the function? Adjust on check-in if you agree. Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> > > -- > 1.9.1 > ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] ShellPkg: Fix the ASSERT issue in drvcfg command.

2015-08-26 Thread Leif Lindholm
Hi, On Wed, Aug 26, 2015 at 10:45:35AM +0800, Qiu Shumin wrote: Initialize the local pointer to avoid to free a dangling pointer. Cc: Jaben Carsey jaben.car...@intel.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin shumin@intel.com ---

Re: [edk2] [PATCH v3 1/5] ArmPlatformPkg/PlatformIntelBdsLib: remove ARM BDS dependency

2015-09-01 Thread Leif Lindholm
On Tue, Sep 01, 2015 at 07:12:33PM +0200, Ard Biesheuvel wrote: > On 1 September 2015 at 18:59, Leif Lindholm <leif.lindh...@linaro.org> wrote: > > On Tue, Sep 01, 2015 at 11:58:20AM +0200, Ard Biesheuvel wrote: > >> The Intel BDS platform library still depends on the ARM

Re: [edk2] [PATCH v3 1/5] ArmPlatformPkg/PlatformIntelBdsLib: remove ARM BDS dependency

2015-09-01 Thread Leif Lindholm
gLib >DevicePathLib >MemoryAllocationLib > -- > 1.9.1 So, it's not a big deal, and I think this series is useful enough to go in anyway, but with this patch and ArmBds, I end up with two preconfigured boot menu entries for Shell: --- [1] EFI Misc Device [2] EFI Misc Device 1 [

Re: [edk2] [PATCH] ArmPlatformPkg/HdLcd: add missing LcdIdentify()

2015-09-04 Thread Leif Lindholm
ler >MmioWrite32 (HDLCD_REG_COMMAND, HDLCD_DISABLE); > } > + > +EFI_STATUS > +LcdIdentify ( > + VOID > + ) > +{ > + return EFI_SUCCESS; > +} > -- > 1.9.1 Thanks! Verified this fixes TC2 build. Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> ___

Re: [edk2] [PATCH] ArmPkg: Bug fix for UncachedMemoryAllocationLib

2015-09-02 Thread Leif Lindholm
TianoCore Contribution Agreement 1.0 >>> Signed-off-by: Heyi Guo <heyi@linaro.org> >>> Cc: Leif Lindholm <leif.lindh...@linaro.org> >>> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> >>> --- >>> .../UncachedMemoryAllocation

Re: [edk2] [PATCH] ArmPlatformPkg: signal EndOfDxe event in PlatformBsdInit

2015-09-03 Thread Leif Lindholm
On Tue, Sep 01, 2015 at 04:26:07PM +0200, Ard Biesheuvel wrote: > Like the ArmVirtPkg platforms up until SVN r17713, the ArmPlatformPkg > platforms built with the Intel BDS fail to signal the end-of-DXE event > 'gEfiEndOfDxeEventGroupGuid' when entering the BDS phase, which results > in some loss

Re: [edk2] [PATCH] ArmPlatformPkg/ArmJunoPkg/Madt.aslc: Fix MADT header version

2015-09-08 Thread Leif Lindholm
with incorrect entries in the header for Juno. > > This patch fixes these EFI_ACPI_*_0_MULTIPLE_APIC_DESCRIPTION_TABLE > > macros by using appropriate v5.0 versions. > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Sudeep Holla <s

Re: [edk2] [PATCH v3 3/5] ArmPlatformPkg/PlatformIntelBdsLib: add splash screen support

2015-09-01 Thread Leif Lindholm
MdePkgTokenSpaceGuid.PcdPlatformBootTimeOut > + gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdLogoFile > > [Protocols] >gEfiDevicePathFromTextProtocolGuid > -- > 1.9.1 Sweet - I get the Tianocore logo on my FVP CLCD :) Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> Tested-by: Leif Lindholm

Re: [edk2] [PATCH v3 5/5] ArmPlatformPkg/ArmVExpress-FVP: enable UEFI Secure Boot

2015-09-01 Thread Leif Lindholm
|{ 0x83, 0xA5, 0x04, > 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 } > !endif > > +!if $(SECURE_BOOT_ENABLE) == TRUE > + # override the default values from SecurityPkg to ensure images from all > sources are verified in secure boot > + gEfiSecuri

Re: [edk2] [PATCH v3 4/5] ArmPlatformPkg/ArmVExpress-FVP: add support for the Intel BDS

2015-09-01 Thread Leif Lindholm
iMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE > + gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, > 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 } > +!endif > + > [Components.common] >MdeModuleP

Re: [edk2] [PATCH v3 2/5] ArmPlatformPkg/PlatformIntelBdsLib: fix error handling

2015-09-01 Thread Leif Lindholm
message. Instead, use a NULL check on the LocateProtocol () output argument. Also clean up coding style on the error path. --- and you can have a Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> / Leif ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 3/4] ArmPkg/Mmu: Fix literal number left shift bug

2015-09-06 Thread Leif Lindholm
can be replayed on QEMU AARCH64; by adding some debug print, >> we can see lots of level 1 tables created (for block of 1GB) even >> when the region is large enough to use 512GB block size. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: He

Re: [edk2] [PATCH 3/4] ArmPkg/Mmu: Fix literal number left shift bug

2015-09-06 Thread Leif Lindholm
On 6 September 2015 at 13:05, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > On 6 September 2015 at 14:04, Leif Lindholm <leif.lindh...@linaro.org> wrote: >> On 6 September 2015 at 12:52, Ard Biesheuvel <ard.biesheu...@linaro.org> >> wrote: >>> On

Re: [edk2] [PATCH 1/3] ArmPlatformPkg/MemoryInitPeim: handle memory above 4 GB on 32-bit ARM

2015-09-09 Thread Leif Lindholm
(PcdFdSize); > > -- > 1.9.1 So, this is mainly an OCD thing on my end, but is there any real benefit to _not_ converting SystemMemoryBase to 64-bit? Doing so would get rid of the other UINTN cast. Either way: Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> / Leif

Re: [edk2] [PATCH 1/3] ArmPlatformPkg/MemoryInitPeim: handle memory above 4 GB on 32-bit ARM

2015-09-09 Thread Leif Lindholm
On Wed, Sep 09, 2015 at 05:11:33PM +0200, Ard Biesheuvel wrote: > On 9 September 2015 at 16:53, Leif Lindholm <leif.lindh...@linaro.org> wrote: > > On Wed, Sep 09, 2015 at 04:38:08PM +0200, Ard Biesheuvel wrote: > >> On 9 September 2015 at 16:31, Leif Lindholm &

Re: [edk2] [PATCH 1/3] ArmPlatformPkg/MemoryInitPeim: handle memory above 4 GB on 32-bit ARM

2015-09-09 Thread Leif Lindholm
On Wed, Sep 09, 2015 at 04:38:08PM +0200, Ard Biesheuvel wrote: > On 9 September 2015 at 16:31, Leif Lindholm <leif.lindh...@linaro.org> wrote: > > On Tue, Sep 08, 2015 at 07:35:40PM +0200, Ard Biesheuvel wrote: > >> Make sure that the PEI memory region is carved out of me

Re: [edk2] [PATCH v4 1/2] BaseTools/ARM: move to unified GCC linker script

2015-10-01 Thread Leif Lindholm
On Thu, Oct 01, 2015 at 03:10:20PM +0200, Ard Biesheuvel wrote: > On 1 October 2015 at 14:52, Leif Lindholm <leif.lindh...@linaro.org> wrote: > > On Thu, Oct 01, 2015 at 02:30:56PM +0200, Ard Biesheuvel wrote: > >> On 25 September 2015 at 03:08, Ard Biesheuvel &l

Re: [edk2] [PATCH v5 3/3] ArmVExpressPkg: use 4 KB section alignment for ARM DXE_RUNTIME_DRIVER modules

2015-10-01 Thread Leif Lindholm
000 > > [LibraryClasses.common] > -- > 1.9.1 > Thanks, Ard! Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] BaseTools/AARCH64: use large code model for GCC <= 4.8

2015-10-02 Thread Leif Lindholm
GS) > +DEFINE GCC49_AARCH64_CC_FLAGS= $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) > DEF(GCC44_ALL_CC_FLAGS) -mcmodel=tiny DEF(GCC_AARCH64_CC_FLAGS) > DEFINE GCC49_ARM_DLINK_FLAGS = DEF(GCC48_ARM_DLINK_FLAGS) > DEFINE GCC49_ARM_DLINK2_FLAG

Re: [edk2] [PATCH] ArmPkg/Mmu: do not configure block translations at level 0

2015-10-02 Thread Leif Lindholm
er than the current block size then we > need to go to the page below. >// The PageLevel was calculated on the Base Address alignment but did not > take in account the alignment > -- > 1.9.1 Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> Thanks. / Leif ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 0/2] BaseTools GenFw: remove ARM special case for incorrect alignment

2015-09-24 Thread Leif Lindholm
ementation of >> the special case from the 32-bit ELF code. >> >> Anyone with access to RVCT able to test this? I would highly appreciate it. >> > > OK, I managed to get access to RVCT myself, and gave this a spin. > > As I had hoped, just removing the workaround

Re: [edk2] ARM64 EFI_STUB and passing a initramfs to the kernel

2015-09-18 Thread Leif Lindholm
Hi Bhupesh, On Fri, Sep 18, 2015 at 02:03:10PM +, Sharma Bhupesh wrote: > I have been trying my hands-on on replacing the current Legacy BDS > loader with the EFI_STUB on a Freescale ARM64 SoC to load Linux and > utilize the features of the EFI_STUB. > > I am taking a reference from ARM juno

Re: [edk2] [PATCH v2 3/4] MdeModulePkg/DxeIplPeim: implement non-exec stack for ARM/AARCH64

2015-10-06 Thread Leif Lindholm
ceGuid.PcdUse1GPageTable ## > SOMETIMES_CONSUMES > + > +[Pcd.IA32,Pcd.X64,Pcd.ARM,Pcd.AARCH64] > gEfiMdeModulePkgTokenSpaceGuid.PcdSetNxForStack ## > SOMETIMES_CONSUMES > > [Depex] > -- > 1.9.1 Fine from an ARM perspective, but I guess it needs a nod from Feng Tian as well. Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> / Leif ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 1/2] BaseTools/PeCoffLoader: fix handling of ARM MOVW/MOVT instruction relocs

2015-10-06 Thread Leif Lindholm
+ sizeof(UINT64); > } > break; > > -- > 1.9.1 Well spotted. Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] ArmPlatformPkg/ArmJunoPkg/Madt.aslc: Fix MADT header version

2015-10-06 Thread Leif Lindholm
On Mon, Sep 28, 2015 at 12:03:42PM +0100, Sudeep Holla wrote: > Hi, > > On 07/09/15 17:07, Sudeep Holla wrote: > >Currently the MADT signature and revision is mapped to v1.0 macros > >which results in MADT with incorrect entries in the header for Juno. > >This patch fixes these

Re: [edk2] [PATCH v2 2/4] ArmPkg/ArmSoftFloatLib: add support for RVCT

2015-11-27 Thread Leif Lindholm
is actually used by the library when built in SOFTFLOAT_FOR_GCC mode, > so we can just drop all of them. Looks plausible. If you can confirm you've tested it as well: Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> > Contributed-under: TianoCore Contribution Agreement 1.0 > Si

Re: [edk2] [PATCH] ArmPkg/BdsLib: Send RemainingDevicePath to PXE Load File protocol

2015-12-07 Thread Leif Lindholm
parameter will be returned directly. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Heyi Guo <heyi....@linaro.org> > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > --- > ArmPkg

Re: [edk2] [PATCH] ArmPkg/PrePeiCore: adhere to architectural stack alignment requirement

2015-12-07 Thread Leif Lindholm
r as soon as > we switch to the PEI stack. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> > --- > > This issue was masked

Re: [edk2] [PATCH] ArmPkg/ArmV7Mmu: prefer non shareable memory on non-coherent hardware

2015-12-08 Thread Leif Lindholm
On Tue, Dec 08, 2015 at 03:03:05PM +0100, Ard Biesheuvel wrote: > Commit SVN r18778 made all mappings of normal memory (inner) shareable, > even on hardware that implements shareability as uncached accesses. > The original concerns that prompted the change, regarding coherent DMA > and virt guests

Re: [edk2] [PATCH] ArmPlatformPkg/ArmVExpress-CTA15-A7: remove stale ArmPlatformGlobalVariable PCD

2015-12-08 Thread Leif Lindholm
ned-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> > --- > ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA15-A7.dsc | 10 -- > 1 file changed, 10 deletions(-) > > diff --git a/ArmPlatformPkg/ArmVExpressPkg/Ar

  1   2   3   4   5   6   7   8   9   10   >