Re: [edk2] [PATCH] CryptoPkg: remove global variable 'timeval' from OpenSslSupport.h

2015-12-06 Thread Ard Biesheuvel
On 4 December 2015 at 19:09, Long, Qin wrote: > Sorry, I missed this patch. Yes, this looks good. > > Reviewed-by: Qin Long > Thanks Qin, Committed as SVN r19135 >> -Original Message- >> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >>

Re: [edk2] [PATCH] CryptoPkg: remove global variable 'timeval' from OpenSslSupport.h

2015-12-04 Thread Ard Biesheuvel
On 3 December 2015 at 10:32, Ard Biesheuvel wrote: > The header file OpenSslSupport.h not only defines a type 'struct timeval' > but also defines a global variable 'timeval' of that type. The RVCT > compiler does not merge this definition into a common symbol, resulting

Re: [edk2] [PATCH] CryptoPkg: remove global variable 'timeval' from OpenSslSupport.h

2015-12-04 Thread Long, Qin
Sorry, I missed this patch. Yes, this looks good. Reviewed-by: Qin Long Best Regards & Thanks, LONG, Qin > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Saturday, December 5, 2015 12:45 AM > To: edk2-devel@lists.01.org; Long,

[edk2] [PATCH] CryptoPkg: remove global variable 'timeval' from OpenSslSupport.h

2015-12-03 Thread Ard Biesheuvel
The header file OpenSslSupport.h not only defines a type 'struct timeval' but also defines a global variable 'timeval' of that type. The RVCT compiler does not merge this definition into a common symbol, resulting in duplicate definition errors in the final link. So remove the variable definition.