Jiansong:
The patch is good. Reviewed-by: Liming Gao
Besides, this patch is from MS Mu, please keep original patch author. Don't
need to send the patch again.
Thanks
LIming
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Jiansong Xu
> Sent: Monday, January 7, 2019 12:09 PM
> To: edk2-devel@lists.01.org
> Cc: Xu, JiansongX
> Subject: [edk2] [PATCH] MdePkg/UefiLib: Add a new API GetVariable3
>
> From: jiansonx
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1396
> Add a new API GetVariable3, which can return the attributes of a variable
> during reading it.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jiansong Xu
> Cc: Liming Gao ---
> MdePkg/Include/Library/UefiLib.h | 33
> MdePkg/Library/UefiLib/UefiLib.c | 81
>
> 2 files changed, 114 insertions(+)
>
> diff --git a/MdePkg/Include/Library/UefiLib.h
> b/MdePkg/Include/Library/UefiLib.h
> index 468bffc3cb..929ee8afb7 100644
> --- a/MdePkg/Include/Library/UefiLib.h
> +++ b/MdePkg/Include/Library/UefiLib.h
> @@ -777,6 +777,39 @@ GetEfiGlobalVariable2 (
>OUT UINTN *Size OPTIONAL
>);
>
> +/** Return the attributes of the variable.
> +
> + Returns the status whether get the variable success. The function retrieves
> + variable through the UEFI Runtime Service GetVariable(). The
> + returned buffer is allocated using AllocatePool(). The caller is
> responsible
> + for freeing this buffer with FreePool(). The attributes are returned if
> + the caller provides a valid Attribute parameter.
> +
> + If Name is NULL, then ASSERT().
> + If Guid is NULL, then ASSERT().
> + If Value is NULL, then ASSERT().
> +
> + @param[in] Name The pointer to a Null-terminated Unicode string.
> + @param[in] Guid The pointer to an EFI_GUID structure
> + @param[out] Value The buffer point saved the variable info.
> + @param[out] Size The buffer size of the variable.
> + @param[out] Attr The pointer to the variable attributes as found in var
> store
> +
> + @retval EFI_OUT_OF_RESOURCES Allocate buffer failed.
> + @retval EFI_SUCCESS Find the specified variable.
> + @retval Others Errors Return errors from call to
> gRT->GetVariable.
> +
> +**/
> +EFI_STATUS
> +EFIAPI
> +GetVariable3(
> + IN CONST CHAR16 *Name,
> + IN CONST EFI_GUID *Guid,
> + OUT VOID **Value,
> + OUT UINTN *Size OPTIONAL,
> + OUT UINT32 *Attr OPTIONAL
> + );
> +
> /**
>Returns a pointer to an allocated buffer that contains the best matching
> language
>from a set of supported languages.
> diff --git a/MdePkg/Library/UefiLib/UefiLib.c
> b/MdePkg/Library/UefiLib/UefiLib.c
> index 39d0ce2b21..475017690c 100644
> --- a/MdePkg/Library/UefiLib/UefiLib.c
> +++ b/MdePkg/Library/UefiLib/UefiLib.c
> @@ -1439,6 +1439,87 @@ GetVariable2 (
>return Status;
> }
>
> +/** Return the attributes of the variable.
> +
> + Returns the status whether get the variable success. The function retrieves
> + variable through the UEFI Runtime Service GetVariable(). The
> + returned buffer is allocated using AllocatePool(). The caller is
> responsible
> + for freeing this buffer with FreePool(). The attributes are returned if
> + the caller provides a valid Attribute parameter.
> +
> + If Name is NULL, then ASSERT().
> + If Guid is NULL, then ASSERT().
> + If Value is NULL, then ASSERT().
> +
> + @param[in] Name The pointer to a Null-terminated Unicode string.
> + @param[in] Guid The pointer to an EFI_GUID structure
> + @param[out] Value The buffer point saved the variable info.
> + @param[out] Size The buffer size of the variable.
> + @param[out] Attr The pointer to the variable attributes as found in var
> store
> +
> + @retval EFI_OUT_OF_RESOURCES Allocate buffer failed.
> + @retval EFI_SUCCESS Find the specified variable.
> + @retval Others Errors Return errors from call to
> gRT->GetVariable.
> +
> +**/
> +EFI_STATUS
> +EFIAPI
> +GetVariable3(
> + IN CONST CHAR16 *Name,
> + IN CONST EFI_GUID *Guid,
> + OUT VOID **Value,
> + OUT UINTN *Size OPTIONAL,
> + OUT UINT32 *Attr OPTIONAL
> + )
> +{
> + EFI_STATUS Status;
> + UINTN BufferSize;
> +
> + ASSERT(Name != NULL && Guid != NULL && Value != NULL);
> +
> + //
> + // Try to get the variable size.
> + //
> + BufferSize = 0;
> + *Value = NULL;
> + if (
