Reviewed-by: Hao Wu
Best Regards,
Hao Wu
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star
> Zeng
> Sent: Thursday, February 08, 2018 4:52 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu; Wu, Hao A; Zeng, Star
> Subject: [edk2] [PATCH] SourceLevelDebugPkg DebugUsb3: Fix GCC build
> failures
>
> Fix GCC build failures below.
> variable 'EvtTrb' set but not used [-Werror=unused-but-set-variable]
> variable 'Index' set but not used [-Werror=unused-but-set-variable]
>
> The build failure could only be caught with -D SOURCE_DEBUG_USE_USB3
> build flag.
>
> Cc: Ruiyu Ni
> Cc: Hao Wu
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng
> ---
> .../DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Common.c
> | 2 --
> .../DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Transfer.c |
> 4 +---
> 2 files changed, 1 insertion(+), 5 deletions(-)
>
> diff --git
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Common.c
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Common.c
> index 87fb0265489b..c577df7dea97 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Common.c
> +++
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Common.c
> @@ -906,7 +906,6 @@ DebugPortWriteBuffer (
>USB3_DEBUG_PORT_HANDLE*UsbDebugPortHandle;
>UINTN Sent;
>UINTN Total;
> - UINTN Index;
>
>if (NumberOfBytes == 0 || Buffer == NULL) {
> return 0;
> @@ -934,7 +933,6 @@ DebugPortWriteBuffer (
>//
>DebugPortPollBuffer (UsbDebugPortHandle);
>
> - Index = 0;
>while ((Total < NumberOfBytes)) {
> if (NumberOfBytes - Total >
> USB3_DEBUG_PORT_WRITE_MAX_PACKET_SIZE) {
>Sent = USB3_DEBUG_PORT_WRITE_MAX_PACKET_SIZE;
> diff --git
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Transfer.c
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Transfer.c
> index dbff49362407..1b6645bd1c6d 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Transfer.c
> +++
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Transfer.c
> @@ -1,7 +1,7 @@
> /** @file
>Debug Port Library implementation based on usb3 debug port.
>
> - Copyright (c) 2014 - 2015, Intel Corporation. All rights reserved.
> + Copyright (c) 2014 - 2018, Intel Corporation. All rights reserved.
>This program and the accompanying materials
>are licensed and made available under the terms and conditions of the BSD
> License
>which accompanies this distribution. The full text of the license may be
> found
> at
> @@ -145,11 +145,9 @@ XhcCheckNewEvent (
>)
> {
>EFI_STATUS Status;
> - TRB_TEMPLATE*EvtTrb;
>
>ASSERT (EvtRing != NULL);
>
> - EvtTrb = (TRB_TEMPLATE *)(UINTN) EvtRing->EventRingDequeue;
>*NewEvtTrb = (TRB_TEMPLATE *)(UINTN) EvtRing->EventRingDequeue;
>
>if (EvtRing->EventRingDequeue == EvtRing->EventRingEnqueue) {
> --
> 2.7.0.windows.1
>
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
